From nobody Wed Dec 17 09:16:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD4AEE49A8 for ; Tue, 22 Aug 2023 07:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233143AbjHVHFH (ORCPT ); Tue, 22 Aug 2023 03:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233048AbjHVHFD (ORCPT ); Tue, 22 Aug 2023 03:05:03 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D970130; Tue, 22 Aug 2023 00:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1692687901; x=1724223901; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mbSEUKxzfd+NdbCyXSlyZygqZr+zo6Ad1ijqItVCU3c=; b=dOS7gX/8JgxcK1Wv/yuQChxxSEVKJbnPHvzWLNkX3lilgkj4zvz1tR1q m1kfZJFAHW4Cg/Yf1WfjC3GFa5c2NmloQCukeprYM20IZQIc/BYyoqlv3 pOhTtq1uRjmtaWIULuqJdkXBT/WGV2daTH298C2Rm3NISjaehI6Q8EtM+ XofkDcUcHRR07WlN9cDec0T5AanYvqbsN58A5BJZrdtMo5huLExJfbho/ kMv9siqw6hbEjpMrF7BQmgH7V602pSI0Kaq19Kyt1Ird9sb9hpKw8oRu6 Wla8M8AcccFu6ve01pENjl99ggSNzUrSWSqF6ZFBKA+28Aa7jcdgsS0g9 Q==; X-IronPort-AV: E=Sophos;i="6.01,192,1684825200"; d="scan'208";a="608536" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Aug 2023 00:04:58 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 22 Aug 2023 00:04:54 -0700 Received: from che-lt-i63539.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Tue, 22 Aug 2023 00:04:50 -0700 From: Hari Prasath Gujulan Elango To: , , , , CC: , , , Hari Prasath Gujulan Elango Subject: [PATCH] pwm: atmel: add missing clk_disable_unprepare() Date: Tue, 22 Aug 2023 12:34:41 +0530 Message-ID: <20230822070441.22170-1-Hari.PrasathGE@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the below smatch warning: drivers/pwm/pwm-atmel-hlcdc.c:167 atmel_hlcdc_pwm_apply() warn: 'new_clk' f= rom clk_prepare_enable() not released on lines: 112,137,142,149. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/pwm/pwm-atmel-hlcdc.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c index 96a709a9d49a..ce46f6c74a14 100644 --- a/drivers/pwm/pwm-atmel-hlcdc.c +++ b/drivers/pwm/pwm-atmel-hlcdc.c @@ -108,8 +108,10 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, s= truct pwm_device *pwm, ATMEL_HLCDC_CFG(0), ATMEL_HLCDC_CLKPWMSEL, gencfg); - if (ret) + if (ret) { + clk_disable_unprepare(new_clk); return ret; + } } =20 do_div(pwmcval, state->period); @@ -133,20 +135,27 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, = struct pwm_device *pwm, ATMEL_HLCDC_PWMPS_MASK | ATMEL_HLCDC_PWMPOL, pwmcfg); - if (ret) + if (ret) { + clk_disable_unprepare(new_clk); return ret; + } =20 ret =3D regmap_write(hlcdc->regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_PWM); - if (ret) + if (ret) { + clk_disable_unprepare(new_clk); return ret; + } =20 ret =3D regmap_read_poll_timeout(hlcdc->regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_PWM, 10, 0); - if (ret) + if (ret) { + clk_disable_unprepare(new_clk); return ret; + } + } else { ret =3D regmap_write(hlcdc->regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_PWM); --=20 2.34.1