From nobody Wed Dec 17 12:46:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E29EE49AF for ; Mon, 21 Aug 2023 23:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231768AbjHUXbh (ORCPT ); Mon, 21 Aug 2023 19:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbjHUXbd (ORCPT ); Mon, 21 Aug 2023 19:31:33 -0400 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2084.outbound.protection.outlook.com [40.107.100.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12400CFC; Mon, 21 Aug 2023 16:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9tWIxgLEKU5f4phwDN6rzVWrmFPPF5eguJADS4yKqZ0JOXWPo7vRPGmnagSMBGqGH58ybW80SZ2frKjWUVduOr3kLchgvnsegtkyQCjecA0sAtYaniIvqY34V4NzRz/N/opCiQY2jb1LQqVWWF6H6JLfMdIKGbKbqbdbgGF660r0ssiMzHga742nhqo7azN+OcCh3G4AtWnz4RoGcnDE60CYAtIzjsPPefQwyteSQIPy942zJu36FZnUCeDDV2Ag0nlSqUC36jltJ06d2PnsCZx4t9t3yAiHZiyrCY9mwm9HyLr4e0oM40slesZb1/sCL7jFmNaKJURrsc1aC4iHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMUFck+2VMtQIu0eZZmniECKgvvM1ZTyI1KmUy6yZGs=; b=aF+uWFt8hu2HTc+3C9qCJBEGdS6INdmmXgHIzCSFe96JjZPC9XSb0IsS10johT7mNpCuNXCnP2G12ZUUfexnihld/0p8aH//+Tq7IyCAmcZmNUSSqFlJbnNgoHONT7wCpifJOUy1geYuQIJDmaY0wjLj3ckj4Dj5fUcEUSKNnM1U5m/qFa04p+/BJ7L91iCMX+qhVDqu6La0CuaOVnBSYjLF8WJedDUWVIpyt3Zq/+2PwKwcS4pFJGAB4G9DbElopnu6AIio4br3k3oB+yjL3pwqfIbyIhmT0+h2VLzuKBzCxgH/PpwvZs4ksHNKkA7kssA9m5WH0e9Za8A9DtjOwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lwn.net smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WMUFck+2VMtQIu0eZZmniECKgvvM1ZTyI1KmUy6yZGs=; b=udRQNhbUoIUAo2oc58rKV7SHeOnK6f2KK6sAHc3lfnNEft20De7EqX8md/em8zFek0bSPzGwOmgpCZH2/fQlbL2QUj39BWB4/3Ahes2nwcZe0lftD8+K19SOX7XOdhT+HiJBnpLSioX6n3XLINTn+Xi0ZRULlXWu7PZxAD3xGgU= Received: from SJ0PR13CA0051.namprd13.prod.outlook.com (2603:10b6:a03:2c2::26) by CH2PR12MB4134.namprd12.prod.outlook.com (2603:10b6:610:a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 23:31:09 +0000 Received: from MWH0EPF000971E6.namprd02.prod.outlook.com (2603:10b6:a03:2c2:cafe::85) by SJ0PR13CA0051.outlook.office365.com (2603:10b6:a03:2c2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.14 via Frontend Transport; Mon, 21 Aug 2023 23:31:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000971E6.mail.protection.outlook.com (10.167.243.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6699.14 via Frontend Transport; Mon, 21 Aug 2023 23:31:08 +0000 Received: from bmoger-ubuntu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 18:31:03 -0500 From: Babu Moger To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v8 1/8] x86/resctrl: Add multiple tasks to the resctrl group at once Date: Mon, 21 Aug 2023 18:30:41 -0500 Message-ID: <20230821233048.434531-2-babu.moger@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230821233048.434531-1-babu.moger@amd.com> References: <20230821233048.434531-1-babu.moger@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E6:EE_|CH2PR12MB4134:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a7c6580-a420-4437-0a91-08dba29eb299 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dWHlFevBdQVeZud0HYCV6Cf4k54qASDL2uPtUqwUufKK/iLvgw6y6jbitrQK0XiKl8X2fqYelXwkVtAMG0o0VFdwrrBrkR+R3LJHDv2ZdxTZHCOZw+JZxqYlNPb0esoy4VD3V0sa6wtWtesQEEhztvkJ/AnnL115W6ZnKxfzAVn+WZRhFMuDEYs6vocso8Xsq5CaoT2+YPsaSH9dX28zfmDzo+LrO6maCVIDebf9DNYD7euHKzQ2dwrsnDpSKJ+J2sL+ToTWlB1s9aQERzuqsLK0jaXn0sRCeii4XispaF7N1QyxYZ5nStPHBFO7zhWd8TM2YGpQhcd4cgCD3o7w32CPkIorJBSVp+lo8hfsyEdmxhaIFU1oEQK3Qlyo7ST7KQ3TP8MZR94efK15QvjKeUWbPyXrjiDBT9EN4kY4A0z0JKiQubmhdJevwLU7Bc7pC27ilTQvm6njGsV3TfBVhMf5emWddTf0u7YkKRBMjRSNomaaZyWxC9S7MuQYubGCFRHNlONMnie+HMfA6UbUgPMNOv5HamkXBF6+o9AlyK3xvhbGo3QzMGuT9f9N8toU4iTAOgh+UHmcEHA47jkPXbEY+ENpvFh7JsAOIcHniml/fFZbJnlBZNEvS+8Yrb0oL2i3qNNV3CxXOd9Ig3l13eXKbExX6bAKhAwwuKJQ8uhr/DLCVeL5BEZ0B2vQVgc0E65o+8Fv+yEDkAVuEbtc8LiPEF38t6aso859LrCx7gAKmTagi2+jEP4zIYYGtnEwPFGIyY4J5AokPcq+j48hHQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(396003)(376002)(136003)(346002)(39860400002)(186009)(1800799009)(82310400011)(451199024)(36840700001)(40470700004)(46966006)(54906003)(70586007)(70206006)(316002)(66899024)(110136005)(8676002)(8936002)(2616005)(4326008)(1076003)(36756003)(41300700001)(40460700003)(356005)(82740400003)(81166007)(478600001)(6666004)(40480700001)(83380400001)(2906002)(7406005)(7416002)(86362001)(7696005)(47076005)(36860700001)(336012)(44832011)(426003)(5660300002)(16526019)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 23:31:08.6557 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a7c6580-a420-4437-0a91-08dba29eb299 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4134 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The resctrl task assignment for monitor or control group needs to be done one at a time. For example: $mount -t resctrl resctrl /sys/fs/resctrl/ $mkdir /sys/fs/resctrl/ctrl_grp1 $echo 123 > /sys/fs/resctrl/ctrl_grp1/tasks $echo 456 > /sys/fs/resctrl/ctrl_grp1/tasks $echo 789 > /sys/fs/resctrl/ctrl_grp1/tasks This is not user-friendly when dealing with hundreds of tasks. Support multiple task assignment in one command with tasks ids separated by commas. For example: $echo 123,456,789 > /sys/fs/resctrl/ctrl_grp1/tasks Reviewed-by: Tan Shaopeng Tested-by: Tan Shaopeng Signed-off-by: Babu Moger Reviewed-by: Reinette Chatre --- Documentation/arch/x86/resctrl.rst | 8 +++++++- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 25 ++++++++++++++++++++++--- 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/re= sctrl.rst index cb05d90111b4..af234681756e 100644 --- a/Documentation/arch/x86/resctrl.rst +++ b/Documentation/arch/x86/resctrl.rst @@ -299,7 +299,13 @@ All groups contain the following files: "tasks": Reading this file shows the list of all tasks that belong to this group. Writing a task id to the file will add a task to the - group. If the group is a CTRL_MON group the task is removed from + group. Multiple tasks can be added by separating the task ids + with commas. Tasks will be assigned sequentially. Multiple + failures are not supported. A single failure encountered while + attempting to assign a task will cause the operation to abort. + Failures will be logged to /sys/fs/resctrl/info/last_cmd_status. + + If the group is a CTRL_MON group the task is removed from whichever previous CTRL_MON group owned the task and also from any MON group that owned the task. If the group is a MON group, then the task must already belong to the CTRL_MON parent of this diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/r= esctrl/rdtgroup.c index 725344048f85..8c91c333f9b3 100644 --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c @@ -696,11 +696,10 @@ static ssize_t rdtgroup_tasks_write(struct kernfs_ope= n_file *of, char *buf, size_t nbytes, loff_t off) { struct rdtgroup *rdtgrp; + char *pid_str; int ret =3D 0; pid_t pid; =20 - if (kstrtoint(strstrip(buf), 0, &pid) || pid < 0) - return -EINVAL; rdtgrp =3D rdtgroup_kn_lock_live(of->kn); if (!rdtgrp) { rdtgroup_kn_unlock(of->kn); @@ -715,7 +714,27 @@ static ssize_t rdtgroup_tasks_write(struct kernfs_open= _file *of, goto unlock; } =20 - ret =3D rdtgroup_move_task(pid, rdtgrp, of); + while (buf && buf[0] !=3D '\0' && buf[0] !=3D '\n') { + pid_str =3D strim(strsep(&buf, ",")); + + if (kstrtoint(pid_str, 0, &pid)) { + rdt_last_cmd_puts("Task list parsing error\n"); + ret =3D -EINVAL; + break; + } + + if (pid < 0) { + rdt_last_cmd_printf("Invalid pid %d\n", pid); + ret =3D -EINVAL; + break; + } + + ret =3D rdtgroup_move_task(pid, rdtgrp, of); + if (ret) { + rdt_last_cmd_printf("Error while processing task %d\n", pid); + break; + } + } =20 unlock: rdtgroup_kn_unlock(of->kn); --=20 2.34.1