From nobody Wed Dec 17 12:45:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD47EE49B3 for ; Mon, 21 Aug 2023 06:21:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233399AbjHUGVM (ORCPT ); Mon, 21 Aug 2023 02:21:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233378AbjHUGVJ (ORCPT ); Mon, 21 Aug 2023 02:21:09 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5B19B7 for ; Sun, 20 Aug 2023 23:21:04 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4fe21e7f3d1so4425853e87.3 for ; Sun, 20 Aug 2023 23:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1692598863; x=1693203663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VIjrnEwaKeqGTU5grAtJfqf2YP8aALmcmlloCUUh95k=; b=glceY5R7NLTH1At17OhMFATBfpYlKbRgzThJz1rQhvSb+8bW+pKrL5bXzdlzW8toOO QD80zDtwRI9PPMaxtPWwVFyN8yDcd9bGdtsB9uPVA8iWoEfaxKOSDLb9+6pIb5L17Eto 55UVFcX/sY837HwMdRuFr6xsqxB5mjkJCX+kqU+vJukdToA+58+Oe94eS6BpXkGokE4A YxBiKVpkEeu81V0M+nJ8DGu63VPUEvmYu9sjrCjVOW/lEcbA11y4W7IqQQo88CHShlVN YnOnN1sAfpqG83WTcXx6YCMddSryG/yKBhCDnTL7xZ2sR6hN0rGPXuMSrYPgV4IwJjXj V49Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692598863; x=1693203663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIjrnEwaKeqGTU5grAtJfqf2YP8aALmcmlloCUUh95k=; b=mE0FPkc9G/dtiFFk7piK4mNc3o7uUY/kZBRkUhCdZFSkwTJoRdQr4hXne3ru8WUj3c v8+jHEn0i6OW2zQqkbQmy77tVHNMxLEet/Bp5KVn/xaU3gTJMHOmm9AFjVSmcEtqTu+u XHsZ1kDLl0aABprOli6Vx5Fe+2AEROYw661mOfarGV343GE6lpiuyI+RT4AP4VMaPTS/ GPhil4xdFt8a/kwIKMmdKz9ukvDA4etBBMdW/qAq+oEFELJ7vAxthJfiISjh0ZGEdJDm SWiursF47OUUA58p8sO9ld0Ytt+LjdoEcqlAj+JUxEpGyP9QBH+UY8Qzxr/yyEbAH9qJ hoZw== X-Gm-Message-State: AOJu0YxG8YTRxFWEgPvwIdrKjJpbRuMmotB9OjgtczyNfyOPX/SFKIzD uAhZEQWtranbzOA/4HeYgrIzkw== X-Google-Smtp-Source: AGHT+IFIQbWRDBMaVNqei5iytuBBv71VukpPeFNpEVR6BikwZiVmxNwYheSJXndTuCqbtUQv0/bSrg== X-Received: by 2002:ac2:4c82:0:b0:4ff:87f6:6ee5 with SMTP id d2-20020ac24c82000000b004ff87f66ee5mr3107820lfl.10.1692598863092; Sun, 20 Aug 2023 23:21:03 -0700 (PDT) Received: from fedora.. (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id c4-20020aa7df04000000b00523b1335618sm5455003edy.97.2023.08.20.23.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 23:21:02 -0700 (PDT) From: Patrick Rudolph To: Peter Rosin , Laurent Pinchart Cc: naresh.solanki@9elements.com, Patrick Rudolph , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v16 1/4] dt-bindings: i2c: pca954x: Correct interrupt support Date: Mon, 21 Aug 2023 08:20:21 +0200 Message-ID: <20230821062027.2631725-2-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230821062027.2631725-1-patrick.rudolph@9elements.com> References: <20230821062027.2631725-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Only some of the PCA954x compatible ICs have interrupt capability, but the binding advertises it on all ICs. Sync the dt-binding with the driver and only advertise it on: - nxp,pca9542 - nxp,pca9543 - nxp,pca9544 - nxp,pca9545 Signed-off-by: Patrick Rudolph Reviewed-by: Krzysztof Kozlowski Acked-by: Peter Rosin --- .../bindings/i2c/i2c-mux-pca954x.yaml | 23 +++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/D= ocumentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml index 9f1726d0356b..e5c1070903ef 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml @@ -12,9 +12,6 @@ maintainers: description: The binding supports NXP PCA954x and PCA984x I2C mux/switch devices. =20 -allOf: - - $ref: /schemas/i2c/i2c-mux.yaml# - properties: compatible: oneOf: @@ -63,6 +60,24 @@ required: - compatible - reg =20 +allOf: + - $ref: /schemas/i2c/i2c-mux.yaml# + - if: + not: + properties: + compatible: + contains: + enum: + - nxp,pca9542 + - nxp,pca9543 + - nxp,pca9544 + - nxp,pca9545 + then: + properties: + interrupts: false + "#interrupt-cells": false + interrupt-controller: false + unevaluatedProperties: false =20 examples: @@ -74,7 +89,7 @@ examples: #size-cells =3D <0>; =20 i2c-mux@74 { - compatible =3D "nxp,pca9548"; + compatible =3D "nxp,pca9545"; #address-cells =3D <1>; #size-cells =3D <0>; reg =3D <0x74>; --=20 2.41.0 From nobody Wed Dec 17 12:45:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB2DEE49A0 for ; Mon, 21 Aug 2023 06:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233406AbjHUGVO (ORCPT ); Mon, 21 Aug 2023 02:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233387AbjHUGVL (ORCPT ); Mon, 21 Aug 2023 02:21:11 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0FE4C0 for ; Sun, 20 Aug 2023 23:21:05 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-528913c261bso3380072a12.1 for ; Sun, 20 Aug 2023 23:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1692598864; x=1693203664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b90IMLBWM6zQGsk777iCjnjr53BKkJdrEo5WNQ1ldaY=; b=Q+SzAlC91XHDsIyrPa4QB0FT7/Qip3dp1cdy1vffxHH1YfDpqjsQyxgO3AnAeO0z1Q IvcbBCpS7qdq183J8cQTO5mRjlZipCJwOdYisGm8roNtD62WJNSnzq4CeJeB8lkwJrZk itAEJSTKbA2tByN6JBYmp36EGZVmfL2p6S8cNurlERMSPAyF94fqTroQNu0RDIF/GlrY kH909ZJlRL6alQCY/eYg1o7zIqOJ1CmOo8NRAFJOSH5RTZ1ZRMpD1YrmAZHQw9EUJNBu 84tdKzSL4K9vWTmrOjYmdHQvBi3cATXy3CF4e5iEmzfv1rB2LLBeTIikaOeTpWdTj6// 7vIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692598864; x=1693203664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b90IMLBWM6zQGsk777iCjnjr53BKkJdrEo5WNQ1ldaY=; b=hh/fvh1QI3QNGDON/BIdppIHMmtiEGr90+1URZbkaUZHC5qJGuNC0sOzSjubWefOX0 qciX0mmLNoa+2xZ5cOFnrvGYxakLhhHwzfujcOLOykvtCgcC/1xJYXGSQ0KUi9vi6iAf IPYIuCVHpohuk+6i0GD8SInTpzTQgxrsKjbCcSAhgQ2oiCTbpZibmurfGQrQSMBcY7y2 TdUgYusuA+EMG+AyYaBikojPxvDTMt9Zs30RAPTGDqv31EnWAps9S+2D7tw8sN4S9gVP T+pyTAb0tqLs+zLvcblNmxr+6tK9vemIo66wSGiKyPkL6wK0+zY6+I9bMLxys86m471U lFYQ== X-Gm-Message-State: AOJu0YyFqesiWcv1OFAbW2a0LqpnTS5A7/brWx3I4zZBZ++0tgu+Gkwb nW8xbyodJ9KV1EOdyan2zIMDIg== X-Google-Smtp-Source: AGHT+IGqdAx68HaV3YTA0e4cdv+GHibtHR1RLOkS6C2Hl5ScDhgRTdFtCLipQcXNuMlBTQHX2zEkxg== X-Received: by 2002:a50:e712:0:b0:528:90d7:a19 with SMTP id a18-20020a50e712000000b0052890d70a19mr4613989edn.11.1692598864385; Sun, 20 Aug 2023 23:21:04 -0700 (PDT) Received: from fedora.. (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id c4-20020aa7df04000000b00523b1335618sm5455003edy.97.2023.08.20.23.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 23:21:04 -0700 (PDT) From: Patrick Rudolph To: Peter Rosin , Laurent Pinchart Cc: naresh.solanki@9elements.com, Patrick Rudolph , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v16 2/4] dt-bindings: i2c: Add Maxim MAX735x/MAX736x variants Date: Mon, 21 Aug 2023 08:20:22 +0200 Message-ID: <20230821062027.2631725-3-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230821062027.2631725-1-patrick.rudolph@9elements.com> References: <20230821062027.2631725-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Update the pca954x bindings to add support for the Maxim MAX735x/MAX736x chips. The functionality will be provided by the existing pca954x driver. For chips that are powered off by default add a regulator called vdd-supply. Signed-off-by: Patrick Rudolph Reviewed-by: Krzysztof Kozlowski Acked-by: Peter Rosin --- .../bindings/i2c/i2c-mux-pca954x.yaml | 23 +++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/D= ocumentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml index e5c1070903ef..2d7bb998b0e9 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml @@ -4,18 +4,29 @@ $id: http://devicetree.org/schemas/i2c/i2c-mux-pca954x.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: NXP PCA954x I2C bus switch +title: NXP PCA954x I2C and compatible bus switches =20 maintainers: - Laurent Pinchart =20 description: - The binding supports NXP PCA954x and PCA984x I2C mux/switch devices. + The NXP PCA954x and compatible devices are I2C bus + multiplexer/switches that share the same functionality + and register layout. + The devices usually have 4 or 8 child buses, which are + attached to the parent bus by using the SMBus "Send Byte" + command. =20 properties: compatible: oneOf: - enum: + - maxim,max7356 + - maxim,max7357 + - maxim,max7358 + - maxim,max7367 + - maxim,max7368 + - maxim,max7369 - nxp,pca9540 - nxp,pca9542 - nxp,pca9543 @@ -56,6 +67,10 @@ properties: description: if present, overrides i2c-mux-idle-disconnect $ref: /schemas/mux/mux-controller.yaml#/properties/idle-state =20 + vdd-supply: + description: A voltage regulator supplying power to the chip. On PCA98= 46 + the regulator supplies power to VDD2 (core logic) and optionally to = VDD1. + required: - compatible - reg @@ -68,6 +83,8 @@ allOf: compatible: contains: enum: + - maxim,max7367 + - maxim,max7369 - nxp,pca9542 - nxp,pca9543 - nxp,pca9544 @@ -94,6 +111,8 @@ examples: #size-cells =3D <0>; reg =3D <0x74>; =20 + vdd-supply =3D <&p3v3>; + interrupt-parent =3D <&ipic>; interrupts =3D <17 IRQ_TYPE_LEVEL_LOW>; interrupt-controller; --=20 2.41.0 From nobody Wed Dec 17 12:45:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27369EE49A5 for ; Mon, 21 Aug 2023 06:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233397AbjHUGVR (ORCPT ); Mon, 21 Aug 2023 02:21:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233393AbjHUGVL (ORCPT ); Mon, 21 Aug 2023 02:21:11 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6A25AB for ; Sun, 20 Aug 2023 23:21:07 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52a0856b4fdso929344a12.1 for ; Sun, 20 Aug 2023 23:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1692598866; x=1693203666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4T63oHx4mCgWjkztpRdYRdNA8hHPbwN5F4C8d65My+U=; b=EpvS0Z2JGi25cb665fjMWh4qXkxgUd2oQpigrrJDlJ6oeb6XnpMy2ewqe0nskvt+7x PT2Fm2birbAjZZcDHjSEvPMVmyjfhLpJ5n7ve1w8r6JpW80FB3AqIfKh1dYKYE+wUVWx Ou/ls1c0vrS1nu+zYUf7Mtg0uTjMlCU7dU+M14FLar83OXYe2S3eUwcC+tWxYZyZam7X weOgtlVvI3SAnsX5PgPPu5zW1J594qofH+rpTQpbPs7n17LV5VblpDCtqCMMQ3Tb9Er9 KrgKqyX1PQEIOY6H40vU4aPWUlL69mK4TFMs6aXHCFl9d6R3kNUGwemR9oFxBFVFfZi0 ky1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692598866; x=1693203666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4T63oHx4mCgWjkztpRdYRdNA8hHPbwN5F4C8d65My+U=; b=APMAMkYws6hi4LisoKG9bnHUSTF3w3af0DTZw8meSenD2ImIcNpX1LXHw2BUqW3RSC vwjecww101+tijNOXnCIr7W7rWkaczzqwgseubbUj0+zoej9Px+k78zr+HnZAFm+ZNsy vfFUl7GPd1qQWABucptZwoMhmy1vn/Tl+HTDUquqI0o/be1vf7H9AsUJfnOyqaBBnG5j hwe4uIgncTz5VoapC0Cu/u1C4LcOkdhGslVKEzvqfeRQ/ooIitvS5l8j02NR5EyyTzFU LZ11w+y5BPmqI5vFDEWW7KB8Qz+VzKtu5x9i4Irtq9/Jk2IjoRv7/nAii+JBWgVq2nWJ CNOQ== X-Gm-Message-State: AOJu0YxkRkTXaS9iIUe6qMFH/OQya73DTWvHPPF7UKDBiN3wIgd8zFmZ Vc3VqaqJsdtBncSJDful5FIf+g== X-Google-Smtp-Source: AGHT+IEYK4lqOqTB3cxbW6Ofi9kIkXd+VFVksT9JATNvaiW9da0BU9I1I8WWSvn/Gfhl2Y90L7s+ng== X-Received: by 2002:aa7:d058:0:b0:522:4c7a:d5a9 with SMTP id n24-20020aa7d058000000b005224c7ad5a9mr4519275edo.3.1692598865619; Sun, 20 Aug 2023 23:21:05 -0700 (PDT) Received: from fedora.. (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id c4-20020aa7df04000000b00523b1335618sm5455003edy.97.2023.08.20.23.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 23:21:05 -0700 (PDT) From: Patrick Rudolph To: Peter Rosin Cc: naresh.solanki@9elements.com, Patrick Rudolph , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v16 3/4] i2c: muxes: pca954x: Add MAX735x/MAX736x support Date: Mon, 21 Aug 2023 08:20:23 +0200 Message-ID: <20230821062027.2631725-4-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230821062027.2631725-1-patrick.rudolph@9elements.com> References: <20230821062027.2631725-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for the following Maxim chips using the existing PCA954x driver: - MAX7356 - MAX7357 - MAX7358 - MAX7367 - MAX7368 - MAX7369 All added Maxim chips behave like the PCA954x, where a single SMBUS byte write selects up to 8 channels to be bridged to the primary bus. While the MAX7357/MAX7358 have interrupt support, they don't act as interrupt controller like the PCA9545 does. Thus don't enable IRQ support and handle them like the PCA9548. Tested using the MAX7357. Signed-off-by: Patrick Rudolph Acked-by: Peter Rosin Reviewed-by: Andi Shyti =20 --- drivers/i2c/muxes/Kconfig | 6 +-- drivers/i2c/muxes/i2c-mux-pca954x.c | 67 ++++++++++++++++++++++++++++- 2 files changed, 69 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index ea838dbae32e..db1b9057612a 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -65,11 +65,11 @@ config I2C_MUX_PCA9541 will be called i2c-mux-pca9541. =20 config I2C_MUX_PCA954x - tristate "NXP PCA954x and PCA984x I2C Mux/switches" + tristate "NXP PCA954x/PCA984x and Maxim MAX735x/MAX736x I2C Mux/switches" depends on GPIOLIB || COMPILE_TEST help - If you say yes here you get support for the NXP PCA954x - and PCA984x I2C mux/switch devices. + If you say yes here you get support for NXP PCA954x/PCA984x + and Maxim MAX735x/MAX736x I2C mux/switch devices. =20 This driver can also be built as a module. If so, the module will be called i2c-mux-pca954x. diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mu= x-pca954x.c index 0ccee2ae5720..32873df56e33 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c @@ -11,6 +11,12 @@ * PCA9540, PCA9542, PCA9543, PCA9544, PCA9545, PCA9546, PCA9547, * PCA9548, PCA9846, PCA9847, PCA9848 and PCA9849. * + * It's also compatible to Maxims MAX735x I2C switch chips, which are cont= rolled + * as the NXP PCA9548 and the MAX736x chips that act like the PCA9544. + * + * This includes the: + * MAX7356, MAX7357, MAX7358, MAX7367, MAX7368 and MAX7369 + * * These chips are all controlled via the I2C bus itself, and all have a * single 8-bit register. The upstream "parent" bus fans out to two, * four, or eight downstream busses or channels; which of these @@ -51,6 +57,12 @@ #define PCA954X_IRQ_OFFSET 4 =20 enum pca_type { + max_7356, + max_7357, + max_7358, + max_7367, + max_7368, + max_7369, pca_9540, pca_9542, pca_9543, @@ -90,8 +102,49 @@ struct pca954x { raw_spinlock_t lock; }; =20 -/* Provide specs for the PCA954x types we know about */ +/* Provide specs for the MAX735x, PCA954x and PCA984x types we know about = */ static const struct chip_desc chips[] =3D { + [max_7356] =3D { + .nchans =3D 8, + .muxtype =3D pca954x_isswi, + .id =3D { .manufacturer_id =3D I2C_DEVICE_ID_NONE }, + }, + [max_7357] =3D { + .nchans =3D 8, + .muxtype =3D pca954x_isswi, + .id =3D { .manufacturer_id =3D I2C_DEVICE_ID_NONE }, + /* + * No interrupt controller support. The interrupt + * provides information about stuck channels. + */ + }, + [max_7358] =3D { + .nchans =3D 8, + .muxtype =3D pca954x_isswi, + .id =3D { .manufacturer_id =3D I2C_DEVICE_ID_NONE }, + /* + * No interrupt controller support. The interrupt + * provides information about stuck channels. + */ + }, + [max_7367] =3D { + .nchans =3D 4, + .muxtype =3D pca954x_isswi, + .has_irq =3D 1, + .id =3D { .manufacturer_id =3D I2C_DEVICE_ID_NONE }, + }, + [max_7368] =3D { + .nchans =3D 4, + .muxtype =3D pca954x_isswi, + .id =3D { .manufacturer_id =3D I2C_DEVICE_ID_NONE }, + }, + [max_7369] =3D { + .nchans =3D 4, + .enable =3D 0x4, + .muxtype =3D pca954x_ismux, + .has_irq =3D 1, + .id =3D { .manufacturer_id =3D I2C_DEVICE_ID_NONE }, + }, [pca_9540] =3D { .nchans =3D 2, .enable =3D 0x4, @@ -177,6 +230,12 @@ static const struct chip_desc chips[] =3D { }; =20 static const struct i2c_device_id pca954x_id[] =3D { + { "max7356", max_7356 }, + { "max7357", max_7357 }, + { "max7358", max_7358 }, + { "max7367", max_7367 }, + { "max7368", max_7368 }, + { "max7369", max_7369 }, { "pca9540", pca_9540 }, { "pca9542", pca_9542 }, { "pca9543", pca_9543 }, @@ -194,6 +253,12 @@ static const struct i2c_device_id pca954x_id[] =3D { MODULE_DEVICE_TABLE(i2c, pca954x_id); =20 static const struct of_device_id pca954x_of_match[] =3D { + { .compatible =3D "maxim,max7356", .data =3D &chips[max_7356] }, + { .compatible =3D "maxim,max7357", .data =3D &chips[max_7357] }, + { .compatible =3D "maxim,max7358", .data =3D &chips[max_7358] }, + { .compatible =3D "maxim,max7367", .data =3D &chips[max_7367] }, + { .compatible =3D "maxim,max7368", .data =3D &chips[max_7368] }, + { .compatible =3D "maxim,max7369", .data =3D &chips[max_7369] }, { .compatible =3D "nxp,pca9540", .data =3D &chips[pca_9540] }, { .compatible =3D "nxp,pca9542", .data =3D &chips[pca_9542] }, { .compatible =3D "nxp,pca9543", .data =3D &chips[pca_9543] }, --=20 2.41.0 From nobody Wed Dec 17 12:45:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D57EE49A0 for ; Mon, 21 Aug 2023 06:21:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233413AbjHUGVS (ORCPT ); Mon, 21 Aug 2023 02:21:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbjHUGVL (ORCPT ); Mon, 21 Aug 2023 02:21:11 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B0BAC for ; Sun, 20 Aug 2023 23:21:08 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so3536909a12.2 for ; Sun, 20 Aug 2023 23:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1692598867; x=1693203667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mhOUt2tzecxNC3yGDp4EJrCLbLTReEQeCvGgn9oNECQ=; b=EKo9ZH6gHObgt1HYVj8JaP2oiJ1d1oAzRgoGN7NeqvIeYixhvpoII7LbNQQTuL5kH1 IgUfpFsULPFPOjJKzf9/qtfyngPPpkivB6s5hZlTq8DR7aWgzwJsvMQSq4cPGkf2pNmE ti2GsIujiM8m/y28T815DQyPQfHQ95sCF6a9oXxBz2GVw7+v+3aI2ptDGjm1xdp4sA+B WxVh1ow2VMfBoiVhKA9tZYhAPW+zuJ6zUs+kyj/ulRC8/sF1Zb4xosMs4doQ28dgX+Ry zCilvwh3RhIaUuVIyKMVPS3FtOXdnXQyqBt58BhEu3PV6iAktsYwlkxDSGpZV1W4J+iF ZT2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692598867; x=1693203667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mhOUt2tzecxNC3yGDp4EJrCLbLTReEQeCvGgn9oNECQ=; b=iSm6PS3ZIQ35AxROtlFhb6dFNdJm6TxJ9gqdedMF6PRRzcTGrago6eOs950b2/CZ3O QPtvUcNxkCVl0Bkdn/E9/yN2MraCKMzEx8XmbAvDXCvM62zigGfmod4/CCSJfIsdQDB2 lffHPPgW9mQvCYzvSxEo1znHmS46WAMKEJuI0I1qXCd6iiS48IUeTmjLUp3WtRvSX3nV hoXcBEv+42zFOmfRyAYF83Oql9ekLBz08v2xD+2ZupQ835ctkU1GTeBwikXZ/dYtkbNq gaWEsL62xX5/Jii39JDm5UASzDjlvpigEwe9XXaVtjkiqJzd7zG6G1n3a6rOejJb6sdJ Nfsg== X-Gm-Message-State: AOJu0Yx35vmsjSguZqstnDQucUsaLV2YBx6GQAaii47W2Q+a1EPCUtSq c/hkxbjrdXBpj4U1JuMZlvNYBQ== X-Google-Smtp-Source: AGHT+IEZ1WGJCViXYgku7ZS537iNI1j7BtgGYKhrahmtuPd9m/nuY+r0npj3vob2/C6pkRBxjSVxWA== X-Received: by 2002:a05:6402:60f:b0:51d:fa7c:c330 with SMTP id n15-20020a056402060f00b0051dfa7cc330mr3787050edv.26.1692598866798; Sun, 20 Aug 2023 23:21:06 -0700 (PDT) Received: from fedora.. (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id c4-20020aa7df04000000b00523b1335618sm5455003edy.97.2023.08.20.23.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 23:21:06 -0700 (PDT) From: Patrick Rudolph To: Peter Rosin Cc: naresh.solanki@9elements.com, Patrick Rudolph , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v16 4/4] i2c: muxes: pca954x: Add regulator support Date: Mon, 21 Aug 2023 08:20:24 +0200 Message-ID: <20230821062027.2631725-5-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230821062027.2631725-1-patrick.rudolph@9elements.com> References: <20230821062027.2631725-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a vdd regulator and enable it for boards that have the mux powered off by default. Signed-off-by: Patrick Rudolph Reviewed-by: Andi Shyti --- drivers/i2c/muxes/i2c-mux-pca954x.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mu= x-pca954x.c index 32873df56e33..f36a26acb0d2 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c @@ -48,6 +48,7 @@ #include #include #include +#include #include #include #include @@ -100,6 +101,7 @@ struct pca954x { struct irq_domain *irq; unsigned int irq_mask; raw_spinlock_t lock; + struct regulator *supply; }; =20 /* Provide specs for the MAX735x, PCA954x and PCA984x types we know about = */ @@ -447,6 +449,8 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc) struct pca954x *data =3D i2c_mux_priv(muxc); int c, irq; =20 + regulator_disable(data->supply); + if (data->irq) { for (c =3D 0; c < data->chip->nchans; c++) { irq =3D irq_find_mapping(data->irq, c); @@ -499,10 +503,22 @@ static int pca954x_probe(struct i2c_client *client) i2c_set_clientdata(client, muxc); data->client =3D client; =20 + data->supply =3D devm_regulator_get(dev, "vdd"); + if (IS_ERR(data->supply)) + return dev_err_probe(dev, PTR_ERR(data->supply), + "Failed to request regulator\n"); + + ret =3D regulator_enable(data->supply); + if (ret) + return dev_err_probe(dev, ret, + "Failed to enable vdd supply\n"); + /* Reset the mux if a reset GPIO is specified. */ gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(gpio)) - return PTR_ERR(gpio); + if (IS_ERR(gpio)) { + ret =3D PTR_ERR(gpio); + goto fail_cleanup; + } if (gpio) { udelay(1); gpiod_set_value_cansleep(gpio, 0); @@ -519,7 +535,7 @@ static int pca954x_probe(struct i2c_client *client) =20 ret =3D i2c_get_device_id(client, &id); if (ret && ret !=3D -EOPNOTSUPP) - return ret; + goto fail_cleanup; =20 if (!ret && (id.manufacturer_id !=3D data->chip->id.manufacturer_id || @@ -527,7 +543,8 @@ static int pca954x_probe(struct i2c_client *client) dev_warn(dev, "unexpected device id %03x-%03x-%x\n", id.manufacturer_id, id.part_id, id.die_revision); - return -ENODEV; + ret =3D -ENODEV; + goto fail_cleanup; } } =20 @@ -546,7 +563,8 @@ static int pca954x_probe(struct i2c_client *client) ret =3D pca954x_init(client, data); if (ret < 0) { dev_warn(dev, "probe failed\n"); - return -ENODEV; + ret =3D -ENODEV; + goto fail_cleanup; } =20 ret =3D pca954x_irq_setup(muxc); --=20 2.41.0