From nobody Wed Dec 17 12:34:25 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A70A8EE4996 for ; Mon, 21 Aug 2023 03:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232646AbjHUDef (ORCPT ); Sun, 20 Aug 2023 23:34:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbjHUDed (ORCPT ); Sun, 20 Aug 2023 23:34:33 -0400 Received: from out-53.mta0.migadu.com (out-53.mta0.migadu.com [IPv6:2001:41d0:1004:224b::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2AE9A1 for ; Sun, 20 Aug 2023 20:34:31 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692588867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8VMbBoJ73OofW8qjWYu7YkN64TyZ3Qgi4fe/POONZLg=; b=TULM3Kgfrajd6uesJBMCK3cJrSmDQjTNvfKSUkivpRsY8+rCYerctq6HT0FpP0wWDQYIVm jHTHozdJ5Btmo+yeNAaNLg1Kk9vS+hb1JflF7WXbUlu5nQRupxfa+I42aWkcqtzgnvE/dD cDWtlAY6lutzMe05l8bRGRVmaUR/3R4= From: Gang Li To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, Gang Li Subject: [PATCH RESEND ethtool] netlink: Allow nl_sset return -EOPNOTSUPP to fallback to do_sset Date: Mon, 21 Aug 2023 11:34:19 +0800 Message-Id: <20230821033419.59095-1-gang.li@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, nl_sset treats any negative value returned by nl_parser (including -EOPNOTSUPP) as `1`. Consequently, netlink_run_handler directly calls exit without returning to main and invoking do_sset through ioctl_init. To fallback to do_sset, this commit allows nl_sset return -EOPNOTSUPP. Fixes: 392b12e ("netlink: add netlink handler for sset (-s)") Signed-off-by: Gang Li --- netlink/settings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/netlink/settings.c b/netlink/settings.c index dda4ac9..2af933d 100644 --- a/netlink/settings.c +++ b/netlink/settings.c @@ -1244,6 +1244,9 @@ int nl_sset(struct cmd_context *ctx) nlctx->devname =3D ctx->devname; =20 ret =3D nl_parser(nlctx, sset_params, NULL, PARSER_GROUP_MSG, msgbuffs); + if (ret =3D=3D -EOPNOTSUPP) + return ret; + if (ret < 0) { ret =3D 1; goto out_free; --=20 2.20.1