From nobody Wed Dec 17 15:55:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC22DC001DE for ; Fri, 18 Aug 2023 09:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359034AbjHRJU4 (ORCPT ); Fri, 18 Aug 2023 05:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359080AbjHRJUh (ORCPT ); Fri, 18 Aug 2023 05:20:37 -0400 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE6C23AA6; Fri, 18 Aug 2023 02:20:33 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=mengferry@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Vq26Rhg_1692350423; Received: from j66c13357.sqa.eu95.tbsite.net(mailfrom:mengferry@linux.alibaba.com fp:SMTPD_---0Vq26Rhg_1692350423) by smtp.aliyun-inc.com; Fri, 18 Aug 2023 17:20:30 +0800 From: Ferry Meng To: Ryusuke Konishi , linux-nilfs@vger.kernel.org Cc: LKML , Ferry Meng Subject: [PATCH] nilfs2: fix dereferencing freed memory Date: Fri, 18 Aug 2023 17:20:22 +0800 Message-Id: <20230818092022.111054-1-mengferry@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix smatch warning: fs/nilfs2/gcinode.c:103 nilfs_gccache_submit_read_data() error: dereferencing freed memory 'bh' Signed-off-by: Ferry Meng diff --git a/fs/nilfs2/gcinode.c b/fs/nilfs2/gcinode.c index 48fe71d309cb..6319e825f317 100644 --- a/fs/nilfs2/gcinode.c +++ b/fs/nilfs2/gcinode.c @@ -73,10 +73,8 @@ int nilfs_gccache_submit_read_data(struct inode *inode, = sector_t blkoff, struct the_nilfs *nilfs =3D inode->i_sb->s_fs_info; =20 err =3D nilfs_dat_translate(nilfs->ns_dat, vbn, &pbn); - if (unlikely(err)) { /* -EIO, -ENOMEM, -ENOENT */ - brelse(bh); + if (unlikely(err)) /* -EIO, -ENOMEM, -ENOENT */ goto failed; - } } =20 lock_buffer(bh); @@ -102,6 +100,8 @@ int nilfs_gccache_submit_read_data(struct inode *inode,= sector_t blkoff, failed: unlock_page(bh->b_page); put_page(bh->b_page); + if (err) + brelse(bh); return err; } =20 --=20 2.19.1.6.gb485710b