From nobody Wed Dec 17 17:59:38 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE669C7115A for ; Fri, 18 Aug 2023 07:52:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358376AbjHRHwa (ORCPT ); Fri, 18 Aug 2023 03:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358384AbjHRHvr (ORCPT ); Fri, 18 Aug 2023 03:51:47 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D59C3AAB for ; Fri, 18 Aug 2023 00:51:46 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-565e395e7a6so457786a12.0 for ; Fri, 18 Aug 2023 00:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692345105; x=1692949905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UibU+Wd31ET9DKxhDYToQOnKhMNxhV0MyhlXlmFI9GI=; b=bXn58IfKTl/OaFFD27WzupSML+yBkWWDTVyyndG1TuOouYNe0+9VhpxLw98Bw2TyLS gYrPcuPCxrSt3gjp3OnQ7rynaNyMhp7FxhyHlr9fawAKdkaMTe3wwsNJIDnVJra/rc5o 1CpxQd7Lnad41+hEnBehNpIcuPWEoSKrTt8HE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692345105; x=1692949905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UibU+Wd31ET9DKxhDYToQOnKhMNxhV0MyhlXlmFI9GI=; b=CmEbv0kJRH62n8Yi3ipspuKE5l4XPSZpVimfo2tfdIpfuUFrskF32Mt+Hx1rMJwVsC VhTgNr8RDG/EZJhZCnT52OFNgQgMbhmviPDADP4AnYCg4mM5vyJqRoiWziuiEmW610fh ZBwvG82s77nBB5/uXYGFjdl8DWq/Py12cu6Kn++3gxl4PjRACMBVXP8ysJNwtlqFquy2 wCkPY5xG3Lcdz8HDzmViJ4eQTwep2d3dh7pHxcKdhBxJTRVESce4m7K+SGMdkf1Ppe7d jihAz0zHf8uvF7Z6MHtPhrYCLaR/9HXG7EMrESoSk3H5naSvRxgn7Zzbiz3T1+/iVim9 HHjw== X-Gm-Message-State: AOJu0YwUkElIUqS/o1SXeLF2uKKBKMy6dGN8RrM2LjBszkABBU/2vmWM /1LQF7Hozk95kMttH9x08X1xCQ== X-Google-Smtp-Source: AGHT+IHTyUqshW8qDF1IGLnlwGboFoBoKGIZNB3RG7BziXH7GhgaqoD7dfGm6FUc+P73o+HSewuohg== X-Received: by 2002:a05:6a20:459:b0:140:2ec5:2b4c with SMTP id b25-20020a056a20045900b001402ec52b4cmr1909389pzb.49.1692345105777; Fri, 18 Aug 2023 00:51:45 -0700 (PDT) Received: from datalore.c.googlers.com.com (148.175.199.104.bc.googleusercontent.com. [104.199.175.148]) by smtp.gmail.com with ESMTPSA id jj19-20020a170903049300b001ba066c589dsm1051834plb.137.2023.08.18.00.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 00:51:45 -0700 (PDT) From: Brandon Pollack To: marius.vlad@collabora.com, jshargo@chromium.org Cc: corbet@lwn.net, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mairacanal@riseup.net, melissa.srw@gmail.com, mripard@kernel.org, rodrigosiqueiramelo@gmail.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mduggan@chromium.org, hirono@chromium.org, Brandon Pollack Subject: [PATCH v3 6/7] drm/vkms: Add a module param to enable/disable the default device Date: Fri, 18 Aug 2023 07:43:11 +0000 Message-ID: <20230818075057.3426088-7-brpol@chromium.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230818075057.3426088-1-brpol@chromium.org> References: <20230818075057.3426088-1-brpol@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jim Shargo In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the only one that exists. The param, enable_default, is defaulted to true to maintain backwards compatibility. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c | 45 ++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_dr= v.c index 6e7f20681890..293bebf8e8ce 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -42,17 +42,26 @@ #define DRIVER_MAJOR 1 #define DRIVER_MINOR 0 =20 +static bool enable_default_device =3D true; +module_param_named(enable_default_device, enable_default_device, bool, 044= 4); +MODULE_PARM_DESC(enable_default_device, + "Enable/Disable creating the default device"); + static bool enable_cursor =3D true; module_param_named(enable_cursor, enable_cursor, bool, 0444); -MODULE_PARM_DESC(enable_cursor, "Enable/Disable cursor support"); +MODULE_PARM_DESC(enable_cursor, + "Enable/Disable cursor support for the default device"); =20 static bool enable_writeback =3D true; module_param_named(enable_writeback, enable_writeback, bool, 0444); -MODULE_PARM_DESC(enable_writeback, "Enable/Disable writeback connector sup= port"); +MODULE_PARM_DESC( + enable_writeback, + "Enable/Disable writeback connector support for the default device"); =20 static bool enable_overlay; module_param_named(enable_overlay, enable_overlay, bool, 0444); -MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay support"); +MODULE_PARM_DESC(enable_overlay, + "Enable/Disable overlay support for the default device"); =20 DEFINE_DRM_GEM_FOPS(vkms_driver_fops); =20 @@ -99,6 +108,7 @@ static int vkms_config_show(struct seq_file *m, void *da= ta) struct drm_device *dev =3D entry->dev; struct vkms_device *vkmsdev =3D drm_device_to_vkms_device(dev); =20 + seq_printf(m, "default_device=3D%d\n", enable_default_device); seq_printf(m, "writeback=3D%d\n", vkmsdev->config.writeback); seq_printf(m, "cursor=3D%d\n", vkmsdev->config.cursor); seq_printf(m, "overlay=3D%d\n", vkmsdev->config.overlay); @@ -297,10 +307,7 @@ void vkms_remove_device(struct vkms_device *vkms_devic= e) static int __init vkms_init(void) { int ret; - struct platform_device *pdev; - struct vkms_device_setup vkms_device_setup =3D { - .configfs =3D NULL, - }; + struct platform_device *default_pdev =3D NULL; =20 ret =3D platform_driver_register(&vkms_platform_driver); if (ret) { @@ -308,19 +315,27 @@ static int __init vkms_init(void) return ret; } =20 - pdev =3D platform_device_register_data(NULL, DRIVER_NAME, 0, - &vkms_device_setup, - sizeof(vkms_device_setup)); - if (IS_ERR(pdev)) { - DRM_ERROR("Unable to register default vkms device\n"); - platform_driver_unregister(&vkms_platform_driver); - return PTR_ERR(pdev); + if (enable_default_device) { + struct vkms_device_setup vkms_device_setup =3D { + .configfs =3D NULL, + }; + + default_pdev =3D platform_device_register_data( + NULL, DRIVER_NAME, 0, &vkms_device_setup, + sizeof(vkms_device_setup)); + if (IS_ERR(default_pdev)) { + DRM_ERROR("Unable to register default vkms device\n"); + platform_driver_unregister(&vkms_platform_driver); + return PTR_ERR(default_pdev); + } } =20 ret =3D vkms_init_configfs(); if (ret) { DRM_ERROR("Unable to initialize configfs\n"); - platform_device_unregister(pdev); + if (default_pdev) + platform_device_unregister(default_pdev); + platform_driver_unregister(&vkms_platform_driver); } =20 --=20 2.42.0.rc1.204.g551eb34607-goog