From nobody Sun Feb 8 11:44:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA91C71131 for ; Thu, 17 Aug 2023 23:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356277AbjHQXog (ORCPT ); Thu, 17 Aug 2023 19:44:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356095AbjHQXoN (ORCPT ); Thu, 17 Aug 2023 19:44:13 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C8EC2D64; Thu, 17 Aug 2023 16:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692315852; x=1723851852; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GZRkou5+WvkDInF2JwAq3cQtZp+dFMEyNGBCi2pJTPk=; b=f174WOgvPW07R8NnxYa9A4m7eUZuMeatVr4gJoZKPKcfQhpGROpa3bO0 lKoGynHtqh3Mx9bsLj9KODKDMtpmiA4gv2L5IYRq5F8pzpuBkCgeLB8HB xmHjF3G0mQaQTl3k9TmLlQsJGn98r2TRi/eveOLyof5Qac0rpPMuze5m2 GBDXKZh8PrYNFhlwBvLnh4mpCqtXlO0J9eMJ2VUQ1xoGxpxhY+DNxOkUO FO3t6JWXV5k60NAULv9YiZISSRBFKr0NSGWuILRxV+CKIkA/b8z+DlOx+ riAHo6LQNdiTNg0aF6svdrVv9pWn+S/T8PBbTHUdsYTqFpDQvOgp3idXz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="352552127" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208";a="352552127" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2023 16:44:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="849051969" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208";a="849051969" Received: from allen-box.sh.intel.com ([10.239.159.127]) by fmsmga002.fm.intel.com with ESMTP; 17 Aug 2023 16:44:06 -0700 From: Lu Baolu To: Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen Cc: Yi Liu , Jacob Pan , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Baolu , Jason Gunthorpe Subject: [PATCH v3 10/11] iommu: Add debugging on domain lifetime for iopf Date: Fri, 18 Aug 2023 07:40:46 +0800 Message-Id: <20230817234047.195194-11-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230817234047.195194-1-baolu.lu@linux.intel.com> References: <20230817234047.195194-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The iopf handling framework in the core requires the domain's lifetime should cover all possible iopfs. This has been documented in the comments for iommu_queue_iopf() which is the entry of the framework. Add some debugging to enforce this. Suggested-by: Jason Gunthorpe Signed-off-by: Lu Baolu --- drivers/iommu/io-pgfault.c | 3 +++ drivers/iommu/iommu.c | 24 ++++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/drivers/iommu/io-pgfault.c b/drivers/iommu/io-pgfault.c index a61c2aabd1b8..bf667ed39b01 100644 --- a/drivers/iommu/io-pgfault.c +++ b/drivers/iommu/io-pgfault.c @@ -129,6 +129,9 @@ int iommu_queue_iopf(struct iommu_fault *fault, struct = device *dev) domain =3D iommu_get_domain_for_dev(dev); =20 if (!domain || !domain->iopf_handler) { + dev_warn_ratelimited(dev, + "iopf from pasid %d received without handler installed\n", + fault->prm.pasid); ret =3D -ENODEV; goto cleanup_partial; } diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 9b622088c741..c170bcd3f05e 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -2032,6 +2032,28 @@ int iommu_deferred_attach(struct device *dev, struct= iommu_domain *domain) return 0; } =20 +static void assert_no_pending_iopf(struct device *dev, ioasid_t pasid) +{ + struct iommu_fault_param *iopf_param =3D dev->iommu->fault_param; + struct iommu_fault_event *evt; + struct iopf_fault *iopf; + + if (!iopf_param) + return; + + mutex_lock(&iopf_param->lock); + list_for_each_entry(iopf, &iopf_param->partial, list) { + if (WARN_ON(iopf->fault.prm.pasid =3D=3D pasid)) + break; + } + + list_for_each_entry(evt, &iopf_param->faults, list) { + if (WARN_ON(evt->fault.prm.pasid =3D=3D pasid)) + break; + } + mutex_unlock(&iopf_param->lock); +} + void iommu_detach_device(struct iommu_domain *domain, struct device *dev) { /* Caller must be a probed driver on dev */ @@ -2040,6 +2062,7 @@ void iommu_detach_device(struct iommu_domain *domain,= struct device *dev) if (!group) return; =20 + assert_no_pending_iopf(dev, IOMMU_NO_PASID); mutex_lock(&group->mutex); if (WARN_ON(domain !=3D group->domain) || WARN_ON(list_count_nodes(&group->devices) !=3D 1)) @@ -3340,6 +3363,7 @@ void iommu_detach_device_pasid(struct iommu_domain *d= omain, struct device *dev, /* Caller must be a probed driver on dev */ struct iommu_group *group =3D dev->iommu_group; =20 + assert_no_pending_iopf(dev, pasid); mutex_lock(&group->mutex); __iommu_remove_group_pasid(group, pasid); WARN_ON(xa_erase(&group->pasid_array, pasid) !=3D domain); --=20 2.34.1