From nobody Wed Dec 17 20:55:19 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28928C04E69 for ; Wed, 16 Aug 2023 11:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244626AbjHPLe0 (ORCPT ); Wed, 16 Aug 2023 07:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244683AbjHPLeL (ORCPT ); Wed, 16 Aug 2023 07:34:11 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA7826A8 for ; Wed, 16 Aug 2023 04:33:36 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5d0c:f209:12a7:4ce5]) by xavier.telenet-ops.be with bizsmtp id aBZT2A00445ualL01BZTFl; Wed, 16 Aug 2023 13:33:28 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qWEm8-000p1Y-GO; Wed, 16 Aug 2023 13:33:26 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qWEmE-006A0c-RE; Wed, 16 Aug 2023 13:33:26 +0200 From: Geert Uytterhoeven To: Alessandro Zummo , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Valentin Caron Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() Date: Wed, 16 Aug 2023 13:33:26 +0200 Message-Id: <20230816113326.1468435-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_PM_SLEEP=3Dn (e.g. m68k/allmodconfig): drivers/rtc/rtc-stm32.c:904:12: error: =E2=80=98stm32_rtc_resume=E2=80= =99 defined but not used [-Werror=3Dunused-function] 904 | static int stm32_rtc_resume(struct device *dev) | ^~~~~~~~~~~~~~~~ drivers/rtc/rtc-stm32.c:894:12: error: =E2=80=98stm32_rtc_suspend=E2=80= =99 defined but not used [-Werror=3Dunused-function] 894 | static int stm32_rtc_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ Indeed, the previous change mixed up the semantics between SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and NOIRQ_SYSTEM_SLEEP_PM_OPS(). Fix this by using the modern NOIRQ_SYSTEM_SLEEP_PM_OPS() instead. Reported-by: noreply@ellerman.id.au Fixes: a69c610e13e2b2de ("rtc: stm32: remove incorrect #ifdef check") Signed-off-by: Geert Uytterhoeven Reviewed-by: Arnd Bergmann --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 3ce4b3d08155b48d..76753c71d92eef3e 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -923,7 +923,7 @@ static int stm32_rtc_resume(struct device *dev) } =20 static const struct dev_pm_ops stm32_rtc_pm_ops =3D { - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) + NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) }; =20 static struct platform_driver stm32_rtc_driver =3D { --=20 2.34.1