From nobody Thu Dec 18 18:31:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5722FC04E69 for ; Mon, 14 Aug 2023 07:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234276AbjHNHra (ORCPT ); Mon, 14 Aug 2023 03:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234384AbjHNHrT (ORCPT ); Mon, 14 Aug 2023 03:47:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B62CE75 for ; Mon, 14 Aug 2023 00:47:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D56C36172B for ; Mon, 14 Aug 2023 07:47:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07E69C433C9; Mon, 14 Aug 2023 07:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691999238; bh=nKgrnCU7kI3wR/FQzbZP+F8vXg3oOXU0D3MYKHvXP28=; h=From:To:Cc:Subject:Date:From; b=PZF5xdDQSRmwEHZUVYWUZife4sXMwTWHGmoIsKx/KaSf1a06Fp+ipg2agrQLdIA5u BIZ9jnB+KwuIBkyNnT4NtCCoBsOXguWokAkjvC5hHu+5AciTuUXpghg961en0sZFqQ AUTvmyZIJ6XBCkxK4GXj2I9CqcjvENfPdhLoCUA2XiAg4Ay9HngHwvCE+R0U5Bv1na zDjoTiF9SHPAIpP8jWPkuf13GB80NZO55aTRZs3WAeZ3xlQvyBWzHXRjjvy82k5Sc3 PucmcS+80lVumd9/fFkIrnQmMZTd7PgtVEXA9qYITI6UkLvp4NfWWz01G7zjPmFCJ8 z1ipfXhOuVmxA== From: Arnd Bergmann To: Pierre-Louis Bossart , Mark Brown Cc: Arnd Bergmann , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Rander Wang , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: SOF: Intel: fix hda_sdw_check_wakeen_irq() Date: Mon, 14 Aug 2023 09:46:29 +0200 Message-Id: <20230814074711.1068093-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann This function cannot work, as the 'chip' variable is never initialized: sound/soc/sof/intel/hda.c:423:6: error: variable 'chip' is uninitialized wh= en used here [-Werror,-Wuninitialized] if (chip && chip->check_sdw_wakeen_irq) ^~~~ Set it the same way that other functions in this file do. Fixes: 9362ab78f175d ("ASoC: SOF: Intel: add abstraction for SoundWire wake= -ups") Signed-off-by: Arnd Bergmann --- There hasn't been a new linux-next in a few days, so there is a good chance someone else already fixed this in the meantime. Sending out my fix in case that hasn't happened yet. --- sound/soc/sof/intel/hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c index 04c748a72b137..6c9c7b390cf53 100644 --- a/sound/soc/sof/intel/hda.c +++ b/sound/soc/sof/intel/hda.c @@ -415,7 +415,7 @@ bool hda_sdw_check_wakeen_irq_common(struct snd_sof_dev= *sdev) static bool hda_sdw_check_wakeen_irq(struct snd_sof_dev *sdev) { u32 interface_mask =3D hda_get_interface_mask(sdev); - const struct sof_intel_dsp_desc *chip; + const struct sof_intel_dsp_desc *chip =3D get_chip_info(sdev->pdata); =20 if (!(interface_mask & BIT(SOF_DAI_INTEL_ALH))) return false; --=20 2.39.2