From nobody Fri Dec 19 04:51:09 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5ACC001DB for ; Sat, 12 Aug 2023 20:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231208AbjHLUGf (ORCPT ); Sat, 12 Aug 2023 16:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjHLUG3 (ORCPT ); Sat, 12 Aug 2023 16:06:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC1911BD5 for ; Sat, 12 Aug 2023 13:06:02 -0700 (PDT) Message-ID: <20230812195728.939405357@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691870354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; b=KoZ1ybHnOOGe2zWwq2N/AO8QzTIPNoxSiE04VegirbMVBzppota03EXRPs+zlqOfC+Y4iV mQ5tzz6bOoSTyJMsos6t9XinrRtWes/iOMQ78XsvyUqvXowU8iB9eJSM4Dv2nULqKOOMtT zNXoOetuSz2pq2NSUrsrtw0X2mMqmaQT9eveACdtT8gLqn2LycxbE82y1/Y9wQYVEAWGW3 JYf39p5C+yGSQRZXaJEu9Xqn0xHwoNVWbKTFosp0IVv4/GkbsgH8aro9qp0P+a/irOqeDj ViUJb8aRClX2WeEqoEI+a90k0tGIPaF9Xdi1UMLHw/329kh8gortRCNF20DaBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691870354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; b=4ZhZweDjvFpyoC8DV+cd8XYhXs8IDmR6TVjaAgLPr4uZPP7HKldEsPyxif8cPYO00rwb9q ++u2PpZFUiNUafBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Borislav Petkov , Ashok Raj , Arjan van de Ven , Nikolay Borisov Subject: [patch V2 24/37] x86/microcode: Clean up mc_cpu_down_prep() References: <20230812194003.682298127@linutronix.de> MIME-Version: 1.0 Date: Sat, 12 Aug 2023 21:59:13 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner --- V2: New patch --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -569,16 +569,10 @@ static int mc_cpu_online(unsigned int cp =20 static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev =3D get_cpu_device(cpu); + struct device *dev =3D get_cpu_device(cpu); =20 microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }