From nobody Fri Sep 12 07:29:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85042C04FE0 for ; Thu, 10 Aug 2023 16:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235207AbjHJQY4 (ORCPT ); Thu, 10 Aug 2023 12:24:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234983AbjHJQYv (ORCPT ); Thu, 10 Aug 2023 12:24:51 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2223103 for ; Thu, 10 Aug 2023 09:24:50 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-68783004143so844048b3a.2 for ; Thu, 10 Aug 2023 09:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691684690; x=1692289490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nt6CR9HHeK7zgBz6fcScWFIY0NBszh7vNKMQXcDtos0=; b=XFsFzQqdaTaPQRn6vyEKmgGKISYvFL/a6YMDa77xCoXUJFV6954HgACo6As6lTmO69 ZKjDlc1V8S38EIFNwQ0yt7lx8Z747kn6RUFY4Q5T9mQSdTsnHof2DwQo90tMjIUhcmhF 1NhyZ+FgbibFcbOArCPbbApw3NYcJ4Vrut4/yslOdF0A4ayO1+QkunBxsDzw0LkGKSKx mQ+LFHEM/UbfAFr4g/ODj6M2NkfxFAisnT6/viOipN9H1YfSFKNeqk2mG0glgsX+ERvC b7qSUha5wggKGIAq/HTrx7uiVRJD5SS5OTzVVL1sKQOUZEaeG1gNeiU/HMRGYAp8JkJg fLBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691684690; x=1692289490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nt6CR9HHeK7zgBz6fcScWFIY0NBszh7vNKMQXcDtos0=; b=JJ6Xsg5IecJC11THrWqZaCIufMHrdW0WaQv7iaVwGxdEM1LSEKa/22uI9cbgHP44tM qAU1p2IfWJSblQ6cMXDLOeykDwoJav/nLCwq+vkJPqDHgxn381U2hetX4ozTq0Jakv5V tptLWmQqBz6Iu/wo19k8zQER4yscSsZoW2dWdm7cC4z2PO+SLITnUO6TAwsfuWuOx1zD XK08vuvZBW/hCXkD7r6VJXqu1NLBPsxzdnRhvx36BGENnA4sIxWVt4hsgYa6/7F1Zgx7 zIs404DxE7t48RQrAj0s0UX5Q9jBp+S4TfwtottTm1AIqGttCXV2yf0PET+rjO0kWuOl Lf9Q== X-Gm-Message-State: AOJu0YwpwaB2kxDv6hLVMlbl9kS1W4nvQoa8dkTgGFpiQsVeRwdzDe68 zEsTlTUW5M5Bkscriy+yitBfrtXZ814= X-Google-Smtp-Source: AGHT+IF+HSKdTxdkxlmBxL9la1pCFwMfvcL9kLyLQbU13M/krB/0NdbxKsUiSjtnGTzzM/pJoXXx/A== X-Received: by 2002:a05:6a21:3e0a:b0:13a:fa9e:787b with SMTP id bk10-20020a056a213e0a00b0013afa9e787bmr2366502pzc.12.1691684689654; Thu, 10 Aug 2023 09:24:49 -0700 (PDT) Received: from localhost ([216.228.127.129]) by smtp.gmail.com with ESMTPSA id l6-20020a62be06000000b0066f37665a63sm1724928pff.73.2023.08.10.09.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 09:24:49 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yury Norov , Ingo Molnar , Peter Zijlstra , Andrew Morton , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Jacob Keller , Jakub Kicinski , Juri Lelli , Mel Gorman , Peter Lafreniere , Steven Rostedt , Tariq Toukan , Valentin Schneider , Vincent Guittot , shiju.jose@huawei.com, jonathan.cameron@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com, yangyicong@hisilicon.com, Andy Shevchenko , Rasmus Villemoes Subject: [PATCH 1/4] numa: generalize numa_map_to_online_node() Date: Thu, 10 Aug 2023 09:24:39 -0700 Message-Id: <20230810162442.9863-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810162442.9863-1-yury.norov@gmail.com> References: <20230810162442.9863-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function is in fact searches for the nearest node for a given one, based on a N_ONLINE state. This is a common pattern to search for a nearest node. This patch converts numa_map_to_online_node(node) to numa_nearest_node(node, state), so that others won't need opencode the logic. The following patches apply it where applicable. Signed-off-by: Yury Norov --- include/linux/numa.h | 7 +++++-- mm/mempolicy.c | 18 +++++++++++------- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/include/linux/numa.h b/include/linux/numa.h index 59df211d051f..fb30a42f0700 100644 --- a/include/linux/numa.h +++ b/include/linux/numa.h @@ -25,7 +25,7 @@ #include =20 /* Generic implementation available */ -int numa_map_to_online_node(int node); +int numa_nearest_node(int node, unsigned int state); =20 #ifndef memory_add_physaddr_to_nid static inline int memory_add_physaddr_to_nid(u64 start) @@ -44,10 +44,11 @@ static inline int phys_to_target_node(u64 start) } #endif #else /* !CONFIG_NUMA */ -static inline int numa_map_to_online_node(int node) +static inline int numa_nearest_node(int node, unsigned int state) { return NUMA_NO_NODE; } + static inline int memory_add_physaddr_to_nid(u64 start) { return 0; @@ -58,6 +59,8 @@ static inline int phys_to_target_node(u64 start) } #endif =20 +#define numa_map_to_online_node(node) numa_nearest_node(node, N_ONLINE) + #ifdef CONFIG_HAVE_ARCH_NODE_DEV_GROUP extern const struct attribute_group arch_node_dev_group; #endif diff --git a/mm/mempolicy.c b/mm/mempolicy.c index c53f8beeb507..db74dd957d2c 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -131,22 +131,26 @@ static struct mempolicy default_policy =3D { static struct mempolicy preferred_node_policy[MAX_NUMNODES]; =20 /** - * numa_map_to_online_node - Find closest online node + * numa_nearest_node - Find nearest node by state * @node: Node id to start the search + * @state: State to filter the search * - * Lookup the next closest node by distance if @nid is not online. + * Lookup the closest node by distance if @nid is not in state. * - * Return: this @node if it is online, otherwise the closest node by dista= nce + * Return: this @node if it is in state, otherwise the closest node by dis= tance */ -int numa_map_to_online_node(int node) +int numa_nearest_node(int node, unsigned int state) { int min_dist =3D INT_MAX, dist, n, min_node; =20 - if (node =3D=3D NUMA_NO_NODE || node_online(node)) + if (state >=3D NR_NODE_STATES) + return -EINVAL; + + if (node =3D=3D NUMA_NO_NODE || node_state(node, state)) return node; =20 min_node =3D node; - for_each_online_node(n) { + for_each_node_state(n, state) { dist =3D node_distance(node, n); if (dist < min_dist) { min_dist =3D dist; @@ -156,7 +160,7 @@ int numa_map_to_online_node(int node) =20 return min_node; } -EXPORT_SYMBOL_GPL(numa_map_to_online_node); +EXPORT_SYMBOL_GPL(numa_nearest_node); =20 struct mempolicy *get_task_policy(struct task_struct *p) { --=20 2.39.2 From nobody Fri Sep 12 07:29:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5ADC04A6A for ; Thu, 10 Aug 2023 16:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236273AbjHJQY6 (ORCPT ); Thu, 10 Aug 2023 12:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235494AbjHJQYy (ORCPT ); Thu, 10 Aug 2023 12:24:54 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B6CE2698 for ; Thu, 10 Aug 2023 09:24:54 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6873a30d02eso807792b3a.3 for ; Thu, 10 Aug 2023 09:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691684693; x=1692289493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=97Np0Dq1sjh/AlJqPoAcdype5uG/AKghnCitY+NNEhM=; b=A28IsFYWvTZlltxjPz79uMSyOph+88G9Ft3TaE6hmpdwtTjAbpLjj36Y8D1rDP5tsx gqNrKYT1WaVWHMwBgHXzOMScx0r58umABHAX7X4pOuPQYd591n7NqkzmlhOTkIYVBQ3E MUZPgcWKB0YzfP6uKnviDTG4+uKLPED3865QUmLUUL7UFawQ2V0wm4gVkkAZcpfi5rZH cwyvQA7rOIFLZu455sw2Oy9pbys4jHsxVhgUieAUKjUp7qbRHT83k5UbKOy1ArvX0tRy d7aMj1rbYp4sZIB56MqBWrF+cJL6gbbrA1ROBmN+zF9kgt+n7OS35AsGnir2YZyx7kAE cl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691684693; x=1692289493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=97Np0Dq1sjh/AlJqPoAcdype5uG/AKghnCitY+NNEhM=; b=FM922jVPdeUL4kiZNOfQYnI1kCq3AJSUviTohxZ09ftK2NCbCkq8sCbhWCuyKE6Nzs R5b5mwK3eHQFRJoO+2z3f2UMLgLP2jkTYn+l0KkNw5ABdmTMY6vWPzle7tQP4Yn0iiWe MFc2rHF8vpqPIct3imxv0eC6vtCTNUegcRkk1l1LbbT1CmZ+Hg04K0P46xFQ6XtsyA4+ WliFjCrMKwrgySjvFlUH/qYJYKt6+DZ6iJikKKRFtOAPB8K+67kdXx1uvYcHGkoGnkS+ CN7fB9R3b7vCJKBh539sJi45WUBuEiddhhO0oTkBVm4QwcqfA88mfbXFGttZFEsiSUBQ dSFg== X-Gm-Message-State: AOJu0YzHRMlGSMSeFBEzILWTMzvefPQij+GjRsbbeoS/EGtGHRGSrFny UI7zMpnDkbyLZHXxJ9E8ljaTDIJl8J0= X-Google-Smtp-Source: AGHT+IHsk0h5rwGZHG4cMG39kTlHSH3djuCACl1aU9H9G7Tq9XIknzH67+DdDoStnlXXCDW22OILnQ== X-Received: by 2002:a05:6a20:325a:b0:134:a8a1:3bf with SMTP id hm26-20020a056a20325a00b00134a8a103bfmr2389040pzc.30.1691684693125; Thu, 10 Aug 2023 09:24:53 -0700 (PDT) Received: from localhost ([216.228.127.129]) by smtp.gmail.com with ESMTPSA id f15-20020aa782cf000000b00686a80f431dsm1711885pfn.126.2023.08.10.09.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 09:24:52 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yury Norov , Ingo Molnar , Peter Zijlstra , Andrew Morton , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Jacob Keller , Jakub Kicinski , Juri Lelli , Mel Gorman , Peter Lafreniere , Steven Rostedt , Tariq Toukan , Valentin Schneider , Vincent Guittot , shiju.jose@huawei.com, jonathan.cameron@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com, yangyicong@hisilicon.com, Andy Shevchenko , Rasmus Villemoes Subject: [PATCH 2/4] sched/fair: fix opencoded numa_nearest_node() Date: Thu, 10 Aug 2023 09:24:40 -0700 Message-Id: <20230810162442.9863-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810162442.9863-1-yury.norov@gmail.com> References: <20230810162442.9863-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" task_numa_placement() searches for a nearest node by calling for_each_node_state(). Now that we have numa_nearest_node(), switch to using it. Signed-off-by: Yury Norov --- kernel/sched/fair.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b3e25be58e2b..e7b7cf87937b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2645,19 +2645,7 @@ static void task_numa_placement(struct task_struct *= p) } =20 /* Cannot migrate task to CPU-less node */ - if (max_nid !=3D NUMA_NO_NODE && !node_state(max_nid, N_CPU)) { - int near_nid =3D max_nid; - int distance, near_distance =3D INT_MAX; - - for_each_node_state(nid, N_CPU) { - distance =3D node_distance(max_nid, nid); - if (distance < near_distance) { - near_nid =3D nid; - near_distance =3D distance; - } - } - max_nid =3D near_nid; - } + max_nid =3D numa_nearest_node(max_nid, N_CPU); =20 if (ng) { numa_group_count_active_nodes(ng); --=20 2.39.2 From nobody Fri Sep 12 07:29:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0108EC04FE1 for ; Thu, 10 Aug 2023 16:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236322AbjHJQZH (ORCPT ); Thu, 10 Aug 2023 12:25:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235458AbjHJQY6 (ORCPT ); Thu, 10 Aug 2023 12:24:58 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D6426B9 for ; Thu, 10 Aug 2023 09:24:57 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bc73a2b0easo8793645ad.0 for ; Thu, 10 Aug 2023 09:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691684696; x=1692289496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZQk4oJI+dzYiJ4RogHTgjWRfeAMe6bXV6Pd7fbAJYxU=; b=M6sZ2J4RqvlOD26FWyHUZkJEL4FbixgRpcY7K5Qx7CRSteyzAk5jEZZ3/nSPOURWur xcSHtBDVDtXtT9UMg52UVtPwO0QW8YKpfYXUalKV+OjXLuAXZDRiFksuPQTN9TUxg8+i acSXvrkexfeLi8DqZ7kHNO98YwAfh6HJSsX5un/0hBI/J1NfQ08+TGhJeXlRZKeSUtlJ ysKOCebZZJiOVVIulL83NG/0ZacXvYct0AyBjluLQVjG6Ny72+8lqqCgScSAnHTYF3/A pdJGSITa/qbFccDnMfseTM3MqRfO8Kq/mwaqrFxvSlmYyBl+Cmymt3+FrfbDP0NHrBZn H49g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691684696; x=1692289496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZQk4oJI+dzYiJ4RogHTgjWRfeAMe6bXV6Pd7fbAJYxU=; b=O1TmntaEt6TY7RGjbuyluOHlH3fT+JVcaxx9cIG6/L5Saynofr/IHjyQx4zN/myQwS 71nbyQHwDPvsvUlu2r4sd2Tf0wAT0rwuoNpn/mX/W0HhwTiFz1N6k2ZaIS5MT7MQsF1K l7GN8yKlI9GA8Wc+smLmnFgLlrYqT3Iin8LQz4mYJOG7yB8sQs/hZm2TYh8GOkkdoLfM Na21kP/+PKFSq1ba3bqPhQvvyYWxqNvLV/iQ3OKNxxSV7/wuFeIpFOzEPaRQ+/mBMI7r 4+iz8NE5JHoPfGdut4EeCCR/u78PkJj44UljvLcFj64yp2bnIqdpftUKj6Bp7ZgBvO+j Z44A== X-Gm-Message-State: AOJu0YwW70+Q2DZ8Ry4hHP+fvJahM27LA+xknIRok1yHOOYGfGpPg1Lk akhsRbV74I1Uu28dOBHYbhB1nXkxj2w= X-Google-Smtp-Source: AGHT+IGpw06hn3MFB4Nmd0fxqwgYy6O+F1jeSuXuJNEsYw+C2EQLFpRj4Hz94ivhfKYOnMQUVqg2+Q== X-Received: by 2002:a17:902:d483:b0:1b5:1787:d23f with SMTP id c3-20020a170902d48300b001b51787d23fmr2773609plg.5.1691684696416; Thu, 10 Aug 2023 09:24:56 -0700 (PDT) Received: from localhost ([216.228.127.129]) by smtp.gmail.com with ESMTPSA id r10-20020a170902be0a00b001bbab888ba0sm1967879pls.138.2023.08.10.09.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 09:24:56 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yury Norov , Ingo Molnar , Peter Zijlstra , Andrew Morton , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Jacob Keller , Jakub Kicinski , Juri Lelli , Mel Gorman , Peter Lafreniere , Steven Rostedt , Tariq Toukan , Valentin Schneider , Vincent Guittot , shiju.jose@huawei.com, jonathan.cameron@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com, yangyicong@hisilicon.com, Andy Shevchenko , Rasmus Villemoes , Guenter Roeck Subject: [PATCH 3/4] sched: fix sched_numa_find_nth_cpu() in CPU-less case Date: Thu, 10 Aug 2023 09:24:41 -0700 Message-Id: <20230810162442.9863-4-yury.norov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810162442.9863-1-yury.norov@gmail.com> References: <20230810162442.9863-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When the node provided by user is CPU-less, corresponding record in sched_domains_numa_masks is not set. Trying to dereference it in the following code leads to kernel crash. To avoid it, start searching from the nearest node with CPUs. Fixes: cd7f55359c90 ("sched: add sched_numa_find_nth_cpu()") Reported-by: Yicong Yang Closes: https://lore.kernel.org/lkml/CAAH8bW8C5humYnfpW3y5ypwx0E-09A3QxFE1J= FzR66v+mO4XfA@mail.gmail.com/T/ Reported-by: Guenter Roeck Closes: https://lore.kernel.org/lkml/ZMHSNQfv39HN068m@yury-ThinkPad/T/#mf64= 31cb0b7f6f05193c41adeee444bc95bf2b1c4 Signed-off-by: Yury Norov Reviewed-by: Yicong Yang --- This has been discovered and fixed by Yicong Yang: https://lore.kernel.org/lkml/CAAH8bW8C5humYnfpW3y5ypwx0E-09A3QxFE1JFzR66v+m= O4XfA@mail.gmail.com/T/ When discovering Guenter's failure report for sparc64, I found it's due to the same problem. And while fixing, I found an opportunity to generalize nearest NUMA node search and avoid code duplication. Yicong, if you like this approach, please feel free to add your co-develope= d-by or any appropriate tags. kernel/sched/topology.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index d3a3b2646ec4..66b387172b6f 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2113,10 +2113,14 @@ static int hop_cmp(const void *a, const void *b) */ int sched_numa_find_nth_cpu(const struct cpumask *cpus, int cpu, int node) { - struct __cmp_key k =3D { .cpus =3D cpus, .node =3D node, .cpu =3D cpu }; + struct __cmp_key k =3D { .cpus =3D cpus, .cpu =3D cpu }; struct cpumask ***hop_masks; int hop, ret =3D nr_cpu_ids; =20 + /* CPU-less node entries are uninitialized in sched_domains_numa_masks */ + node =3D numa_nearest_node(node, N_CPU); + k.node =3D node; + rcu_read_lock(); =20 k.masks =3D rcu_dereference(sched_domains_numa_masks); --=20 2.39.2 From nobody Fri Sep 12 07:29:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D841EC04A6A for ; Thu, 10 Aug 2023 16:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236781AbjHJQZK (ORCPT ); Thu, 10 Aug 2023 12:25:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236731AbjHJQZF (ORCPT ); Thu, 10 Aug 2023 12:25:05 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37AF3271E for ; Thu, 10 Aug 2023 09:25:01 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-55b0e7efb1cso748396a12.1 for ; Thu, 10 Aug 2023 09:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691684700; x=1692289500; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SmmjHmVn6ls0sfUQEL2MtTTuL3JIkk0EADWsp1ssJ1I=; b=Bfx08UPqSGUA5kMzlG6c1gKFPujJymFxHHEcbncpgTNXWfilym9jS0kJbo5BDAWSAt D9mUQJQct3QouTQHkHkPrBDMCKnWAqpbreP6nPj61t/mOCWJMUiU9SBgEkrua+TY2WvN RQ5wEy+PuxBPt8ZoFj5D2HGw+0EHyLI1z4DoNLoS5QRQ61C+28JBYhQSRil/n4cmq226 +7wHPiq3FSMBXOYZHozHHb530CuwJI/i1j1XgNJxE8OzuAkHE9j+84kXPMYw7IqXs9K/ EXbvqacZmwYzBoSTAuKgMu8XWHjH7xGtl86RqyboalPaLOIF5AyV51Wm78Vn2A7DNWzT lIsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691684700; x=1692289500; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SmmjHmVn6ls0sfUQEL2MtTTuL3JIkk0EADWsp1ssJ1I=; b=N/W3aJ0xf21clczBs2B5V0PPmERg2NcMzvsqk0OX27k5ygRkqbCPjQKlBC+vEw/4wN 21oZOEZhZWs4eQpw55ZyFiPrA2GX3dqUC9l5/eV1q73JnHbAAkopsyMLJ7YoW9KbkLQC rkzq3e8rj94BNuJV1duArmQ89pa1YszSgZUJGKEzZH6C332Zmnu/ykoY1/OjkqQuCDoa U2IU0FWjIPMX0MZpj8Sj3b/ds82VD2QFpqJ7OcCv/aaUclLcPZH1EVAvRxomJFvVYwDr is/fTNbPvDpX+chMVDr8q/Xdvh6wH4IJtTJfZWyPBBhlOrQ/s5o6m0Iq+iJU6U214QCC +R7Q== X-Gm-Message-State: AOJu0YwRtw7ttvcZaTzfLvXeOhXkqtu1n66XL+MSjqh1LhAi7A7NkpoM KHSv1+SmcK3XDl2HoNL6GcdvOfs/l+M= X-Google-Smtp-Source: AGHT+IH4taXK3kC2OJr25PCWrlpW+eWTUdvnoQR0cwNL04PBbBOADtjdA//KwLTk44jREORqIyxPQQ== X-Received: by 2002:a17:90b:4f8a:b0:267:f8a2:300a with SMTP id qe10-20020a17090b4f8a00b00267f8a2300amr2362896pjb.7.1691684700106; Thu, 10 Aug 2023 09:25:00 -0700 (PDT) Received: from localhost ([216.228.127.129]) by smtp.gmail.com with ESMTPSA id l9-20020a17090a070900b00267b38f5e13sm1811075pjl.2.2023.08.10.09.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 09:24:59 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yury Norov , Ingo Molnar , Peter Zijlstra , Andrew Morton , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Jacob Keller , Jakub Kicinski , Juri Lelli , Mel Gorman , Peter Lafreniere , Steven Rostedt , Tariq Toukan , Valentin Schneider , Vincent Guittot , shiju.jose@huawei.com, jonathan.cameron@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com, yangyicong@hisilicon.com, Andy Shevchenko , Rasmus Villemoes Subject: [PATCH 4/4] sched: fix sched_numa_find_nth_cpu() in non-NUMA case Date: Thu, 10 Aug 2023 09:24:42 -0700 Message-Id: <20230810162442.9863-5-yury.norov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810162442.9863-1-yury.norov@gmail.com> References: <20230810162442.9863-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When CONFIG_NUMA is enabled, sched_numa_find_nth_cpu() searches for a CPU in sched_domains_numa_masks. The masks includes only online CPUs, so effectively offline CPUs are skipped. When CONFIG_NUMA is disabled, the fallback function should be consistent. Fixes: cd7f55359c90 ("sched: add sched_numa_find_nth_cpu()") Signed-off-by: Yury Norov --- include/linux/topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/topology.h b/include/linux/topology.h index fea32377f7c7..52f5850730b3 100644 --- a/include/linux/topology.h +++ b/include/linux/topology.h @@ -251,7 +251,7 @@ extern const struct cpumask *sched_numa_hop_mask(unsign= ed int node, unsigned int #else static __always_inline int sched_numa_find_nth_cpu(const struct cpumask *c= pus, int cpu, int node) { - return cpumask_nth(cpu, cpus); + return cpumask_nth_and(cpu, cpus, cpu_online_mask); } =20 static inline const struct cpumask * --=20 2.39.2