From nobody Fri Sep 12 07:44:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E2AC04A6A for ; Thu, 10 Aug 2023 06:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232882AbjHJGG2 (ORCPT ); Thu, 10 Aug 2023 02:06:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231437AbjHJGG1 (ORCPT ); Thu, 10 Aug 2023 02:06:27 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B177B171D for ; Wed, 9 Aug 2023 23:06:26 -0700 (PDT) Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37A5r8hL017531; Thu, 10 Aug 2023 06:05:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=FJZYLStsj55jSIlYlDgwpbg7S5EBCrJAiAQRw3GAopw=; b=iz33t3ikQPTz4i1tZzKFJpInlneVWuXvHDI2jpMRS6bJQGtFBgWR3yUByArnYr71b44O X3WJu/QHvCjj9y4GlFsfp95vfXP++n16ruJ/2b2WRgxBZIpD1znA8TZ4tAkZu8FoWhlD DiW9L19XCenhu8H3pnYtweCuHUgpOwWhwU39RxK3DDuTq5Wtqo9fXEti+3EPkcJrXrnt qoS5rEbKuTGWp9o0zOAeIZChf5u8dZifmuZysuz68chen/RZdW0HRQeaq6zq6bsGzoD4 1lVdmAgWl0TTsavfRmi4Fv+q4XeObJ7Ar097lkvTSYm00CI+7iTkqqA2FiHK5bQMr7GT EQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sct4wg89f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 06:05:58 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37A5jTmg000403; Thu, 10 Aug 2023 06:05:43 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3sa28kxtqd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 06:05:43 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37A65fHe17433126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Aug 2023 06:05:41 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AE26E20043; Thu, 10 Aug 2023 06:05:41 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D94720040; Thu, 10 Aug 2023 06:05:41 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 10 Aug 2023 06:05:41 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55390) id 59780E139E; Thu, 10 Aug 2023 08:05:41 +0200 (CEST) From: Sven Schnelle To: Steven Rostedt Cc: linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] tracing/synthetic: allocate one additional element for size Date: Thu, 10 Aug 2023 08:05:38 +0200 Message-Id: <20230810060538.1350348-4-svens@linux.ibm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810060538.1350348-1-svens@linux.ibm.com> References: <20230810060538.1350348-1-svens@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: u2b6sn5_mjtwERo64EW8XuO2_bdgHERB X-Proofpoint-ORIG-GUID: u2b6sn5_mjtwERo64EW8XuO2_bdgHERB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_04,2023-08-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308100051 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" While debugging another issue i noticed that the stack trace contains one invalid entry at the end: -0 [008] d..4. 26.484201: wake_lat: pid=3D0 delta=3D26299760= 84 000000009cc24024 stack=3DSTACK: =3D> __schedule+0xac6/0x1a98 =3D> schedule+0x126/0x2c0 =3D> schedule_timeout+0x150/0x2c0 =3D> kcompactd+0x9ca/0xc20 =3D> kthread+0x2f6/0x3d8 =3D> __ret_from_fork+0x8a/0xe8 =3D> 0x6b6b6b6b6b6b6b6b This is because the code failed to add the one element containing the number of entries to field_size. Fixes: 00cf3d672a9d ("tracing: Allow synthetic events to pass around stackt= races") Signed-off-by: Sven Schnelle --- kernel/trace/trace_events_synth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_= synth.c index 80a2a832f857..9897d0bfcab7 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -528,7 +528,8 @@ static notrace void trace_event_raw_event_synth(void *_= _data, str_val =3D (char *)(long)var_ref_vals[val_idx]; =20 if (event->dynamic_fields[i]->is_stack) { - len =3D *((unsigned long *)str_val); + /* reserve one extra element for size */ + len =3D *((unsigned long *)str_val) + 1; len *=3D sizeof(unsigned long); } else { len =3D fetch_store_strlen((unsigned long)str_val); --=20 2.39.2