From nobody Thu Sep 11 14:47:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2DFC00528 for ; Fri, 4 Aug 2023 12:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbjHDMXF (ORCPT ); Fri, 4 Aug 2023 08:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjHDMXE (ORCPT ); Fri, 4 Aug 2023 08:23:04 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36B58B2 for ; Fri, 4 Aug 2023 05:23:03 -0700 (PDT) Received: from kwepemi500009.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RHPwJ53vXzrS60; Fri, 4 Aug 2023 20:21:52 +0800 (CST) Received: from huawei.com (10.67.175.85) by kwepemi500009.china.huawei.com (7.221.188.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 20:22:57 +0800 From: Xia Fukun To: , , CC: , Subject: [PATCH] cxgb4: Optimize the call of memset in fill_default_mask() Date: Fri, 4 Aug 2023 20:22:05 +0800 Message-ID: <20230804122205.193331-1-xiafukun@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.85] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500009.china.huawei.com (7.221.188.199) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When using memset to assign values to fs->mask.fip, the byte length should be sizeof(fs->mask.fip), which is more reasonable than lip. Fixes: 578b46b9383c ("cxgb4: add common api support for configuring filters= ") Signed-off-by: Xia Fukun --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/ne= t/ethernet/chelsio/cxgb4/cxgb4_filter.c index 786ceae34488..caadb2283328 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c @@ -1097,7 +1097,7 @@ static void fill_default_mask(struct ch_filter_specif= ication *fs) memset(fs->mask.lip, ~0, sizeof(fs->mask.lip)); =20 if (fip && !fip_mask) - memset(fs->mask.fip, ~0, sizeof(fs->mask.lip)); + memset(fs->mask.fip, ~0, sizeof(fs->mask.fip)); =20 if (fs->val.lport && !fs->mask.lport) fs->mask.lport =3D ~0; --=20 2.17.1