From nobody Thu Sep 11 14:52:27 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E859C001DB for ; Fri, 4 Aug 2023 12:16:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbjHDMQr (ORCPT ); Fri, 4 Aug 2023 08:16:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbjHDMQq (ORCPT ); Fri, 4 Aug 2023 08:16:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7A4246B1 for ; Fri, 4 Aug 2023 05:16:43 -0700 (PDT) Received: from kwepemi500009.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RHPkM04ZTzGpnK; Fri, 4 Aug 2023 20:13:14 +0800 (CST) Received: from huawei.com (10.67.175.85) by kwepemi500009.china.huawei.com (7.221.188.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 20:16:41 +0800 From: Xia Fukun To: , , , CC: , Subject: [PATCH] serial: 8250_dw: Fix assignment error of data in dw8250_probe() Date: Fri, 4 Aug 2023 20:16:07 +0800 Message-ID: <20230804121607.191203-1-xiafukun@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.85] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500009.china.huawei.com (7.221.188.199) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the "ri-override" property is present in the device, data->msr_mask_on and UART_MSR_RI should be used for OR-assignment. Fix the errors in it. Fixes: 1bd8edba10e6 ("serial: 8250_dw: adapt to unified device property int= erface") Signed-off-by: Xia Fukun --- drivers/tty/serial/8250/8250_dw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/82= 50_dw.c index 7db51781289e..921b5f07828f 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -587,7 +587,7 @@ static int dw8250_probe(struct platform_device *pdev) =20 if (device_property_read_bool(dev, "ri-override")) { /* Always report Ring indicator as inactive */ - data->msr_mask_off |=3D UART_MSR_RI; + data->msr_mask_on |=3D UART_MSR_RI; data->msr_mask_off |=3D UART_MSR_TERI; } =20 --=20 2.17.1