From nobody Thu Sep 11 14:52:29 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CAE8C04A94 for ; Fri, 4 Aug 2023 11:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbjHDLHC (ORCPT ); Fri, 4 Aug 2023 07:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbjHDLG7 (ORCPT ); Fri, 4 Aug 2023 07:06:59 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E777AC for ; Fri, 4 Aug 2023 04:06:57 -0700 (PDT) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RHNCk74PfzVjdL; Fri, 4 Aug 2023 19:05:06 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.202) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 19:06:54 +0800 From: Zhu Wang To: , , , , CC: Subject: [PATCH -next v4] drm/i2c: tda998x: remove redundant CONFIG_OF and of_match_ptr() Date: Fri, 4 Aug 2023 19:06:25 +0800 Message-ID: <20230804110625.98520-1-wangzhu9@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.202] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500025.china.huawei.com (7.185.36.35) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF and of_match_ptr() here, we remove them all. Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text if a driver can be used both with and without it. Signed-off-by: Zhu Wang Reviewed-by: Arnd Bergmann --- Changes in v2: - Remove CONFIG_OF which includes tda998x_ids. --- Changes in v3: - Changes of_match_ptr to of_match_ptr() in the commit message. --- Changes in v4: - Remove "Reviewed-by: Andy Shevchenko". --- drivers/gpu/drm/i2c/tda998x_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998= x_drv.c index d8d7de18dd65..9666e0746240 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -2084,13 +2084,11 @@ static void tda998x_remove(struct i2c_client *clien= t) tda998x_destroy(&client->dev); } =20 -#ifdef CONFIG_OF static const struct of_device_id tda998x_dt_ids[] =3D { { .compatible =3D "nxp,tda998x", }, { } }; MODULE_DEVICE_TABLE(of, tda998x_dt_ids); -#endif =20 static const struct i2c_device_id tda998x_ids[] =3D { { "tda998x", 0 }, @@ -2103,7 +2101,7 @@ static struct i2c_driver tda998x_driver =3D { .remove =3D tda998x_remove, .driver =3D { .name =3D "tda998x", - .of_match_table =3D of_match_ptr(tda998x_dt_ids), + .of_match_table =3D tda998x_dt_ids, }, .id_table =3D tda998x_ids, }; --=20 2.17.1