From nobody Wed Sep 10 02:48:45 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E04EAC0015E for ; Tue, 1 Aug 2023 20:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbjHAUzB (ORCPT ); Tue, 1 Aug 2023 16:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbjHAUy7 (ORCPT ); Tue, 1 Aug 2023 16:54:59 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A541BFD for ; Tue, 1 Aug 2023 13:54:58 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-cf4cb742715so6109734276.2 for ; Tue, 01 Aug 2023 13:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690923298; x=1691528098; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=01D3Mc0WQ1sIli+WCBM4zperRKd1MnhhHpfIVHiLwx8=; b=1jJu6159CsEIRLvgUdpUI1Kmk2CD/pULRu35xBZarz3VKKiaxvzywe8XhiyRymuz9+ VGXNWUH2W7pvQXfMIFXjZmhpOu6k5N8HysyDDxF6SRGYVwcdOjXbrjMZSdm3nL489cDc zNM16qvLpgziUskQ7RgtgbUDHKiLINF17HGx7edKruttIUkYvdFWrvMBgblyiXcIKy2K jA062pKnujX4Aq2su7H2c7Z7HerlA36c3xy6KMqDzQfKJv5GX4lc6ucFYCKTyZD3eDPo 0JLAGEHy8Q9zCvLhjp+I25CNKfCJwrDZpC1A6PWm42ykYKs4hAwSlWvUEgc6mbjYXdhO aFJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690923298; x=1691528098; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=01D3Mc0WQ1sIli+WCBM4zperRKd1MnhhHpfIVHiLwx8=; b=fr0Wey8a2SvA1zjGP36A9o2UDyAvzGBfZ0h3sG9hjLYCJSI0NAv7ALwS+hzFTgX3FX k+hhrcbs4W78fa8KGQmRnRArKj1B5OiRjqZJRItBIVWQaquDT5Ik3Yh29EV+1zfk23w8 mccoxcUC8IOLWWADCMt6I+xJU3NfT8JPg0DalX/ODz85VFQR7n20ZPhWCLX5bTp+QAkq 0Qx6xHyQy5/yPXYNVlHT0MNYvgScSU/bKvPWo4VJL6ePRM8fsuRb1GT6gaay2v/GO4dr aryxZb2eZTvvjUhPT7GcptHRAMzN5IiLIgzYeS8djeu9cUp0+1KwW1ubBBkTEwCg3Vma bVrg== X-Gm-Message-State: ABy/qLbXao4B+fPbyjTRxq0Vb2nZ9rqPgJT5aZYFgXknwwzXYuu/ujST pMn6d6yXYcKDEEP/URSxc+R0E2pBszBv X-Google-Smtp-Source: APBJJlEq9l+NEtUD1U41TgFedR95hPQqXDoEZJG5YtLGgKxbgLgZUUEM7/8Esq5rFZhfDdXxNAOrT/Xz2wJm X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:bea9:545d:a179:25e7]) (user=irogers job=sendgmr) by 2002:a25:d613:0:b0:d12:d6e4:a08d with SMTP id n19-20020a25d613000000b00d12d6e4a08dmr85369ybg.7.1690923298054; Tue, 01 Aug 2023 13:54:58 -0700 (PDT) Date: Tue, 1 Aug 2023 13:54:52 -0700 Message-Id: <20230801205452.3380578-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog Subject: [PATCH v1] perf stat: Don't display zero tool counts From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Athira Rajeev , Claire Jensen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Cc: Ian Rogers Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Skip zero counts for tool events. Reported-by: Andi Kleen Signed-off-by: Ian Rogers Tested-by: Andi Kleen --- tools/perf/util/stat-display.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 7329b3340f88..d45d5dcb0e2b 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -931,6 +931,11 @@ static bool should_skip_zero_counter(struct perf_stat_= config *config, */ if (config->aggr_mode =3D=3D AGGR_THREAD && config->system_wide) return true; + + /* Tool events have the software PMU but are only gathered on 1. */ + if (evsel__is_tool(counter)) + return true; + /* * Skip value 0 when it's an uncore event and the given aggr id * does not belong to the PMU cpumask. --=20 2.41.0.585.gd2178a4bd4-goog