From nobody Sun Feb 8 09:27:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEDEC04A94 for ; Tue, 1 Aug 2023 02:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232086AbjHAC21 (ORCPT ); Mon, 31 Jul 2023 22:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbjHAC2Z (ORCPT ); Mon, 31 Jul 2023 22:28:25 -0400 Received: from out28-2.mail.aliyun.com (out28-2.mail.aliyun.com [115.124.28.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18181E65 for ; Mon, 31 Jul 2023 19:28:23 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.0744491|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.00483132-0.000711951-0.994457;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047192;MF=sunran001@208suo.com;NM=1;PH=DS;RN=7;RT=7;SR=0;TI=SMTPD_---.U5Fqw-3_1690856895; Received: from localhost.localdomain(mailfrom:sunran001@208suo.com fp:SMTPD_---.U5Fqw-3_1690856895) by smtp.aliyun-inc.com; Tue, 01 Aug 2023 10:28:17 +0800 From: Ran Sun To: alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ran Sun Subject: [PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.c Date: Tue, 1 Aug 2023 02:28:14 +0000 Message-Id: <20230801022814.4577-1-sunran001@208suo.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix the following errors reported by checkpatch: ERROR: spaces required around that '=3D' (ctx:WxV) ERROR: spaces required around that '&&' (ctx:VxW) ERROR: that open brace { should be on the previous line ERROR: space required before the open parenthesis '(' ERROR: space required before the open brace '{' ERROR: spaces required around that ':' (ctx:VxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/am= d/pm/swsmu/amdgpu_smu.c index ce41a8309582..a7199275ffb8 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c @@ -618,7 +618,7 @@ static int smu_set_funcs(struct amdgpu_device *adev) adev->pm.pp_feature &=3D ~PP_GFXOFF_MASK; arcturus_set_ppt_funcs(smu); /* OD is not supported on Arcturus */ - smu->od_enabled =3Dfalse; + smu->od_enabled =3D false; break; case IP_VERSION(13, 0, 2): aldebaran_set_ppt_funcs(smu); @@ -1648,7 +1648,7 @@ static int smu_hw_fini(void *handle) struct amdgpu_device *adev =3D (struct amdgpu_device *)handle; struct smu_context *smu =3D adev->powerplay.pp_handle; =20 - if (amdgpu_sriov_vf(adev)&& !amdgpu_sriov_is_pp_one_vf(adev)) + if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)) return 0; =20 smu_dpm_set_vcn_enable(smu, false); @@ -1700,7 +1700,7 @@ static int smu_suspend(void *handle) int ret; uint64_t count; =20 - if (amdgpu_sriov_vf(adev)&& !amdgpu_sriov_is_pp_one_vf(adev)) + if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)) return 0; =20 if (!smu->pm_enabled) @@ -2217,8 +2217,7 @@ const struct amd_ip_funcs smu_ip_funcs =3D { .set_powergating_state =3D smu_set_powergating_state, }; =20 -const struct amdgpu_ip_block_version smu_v11_0_ip_block =3D -{ +const struct amdgpu_ip_block_version smu_v11_0_ip_block =3D { .type =3D AMD_IP_BLOCK_TYPE_SMC, .major =3D 11, .minor =3D 0, @@ -2226,8 +2225,7 @@ const struct amdgpu_ip_block_version smu_v11_0_ip_blo= ck =3D .funcs =3D &smu_ip_funcs, }; =20 -const struct amdgpu_ip_block_version smu_v12_0_ip_block =3D -{ +const struct amdgpu_ip_block_version smu_v12_0_ip_block =3D { .type =3D AMD_IP_BLOCK_TYPE_SMC, .major =3D 12, .minor =3D 0, @@ -2235,8 +2233,7 @@ const struct amdgpu_ip_block_version smu_v12_0_ip_blo= ck =3D .funcs =3D &smu_ip_funcs, }; =20 -const struct amdgpu_ip_block_version smu_v13_0_ip_block =3D -{ +const struct amdgpu_ip_block_version smu_v13_0_ip_block =3D { .type =3D AMD_IP_BLOCK_TYPE_SMC, .major =3D 13, .minor =3D 0, @@ -2337,7 +2334,7 @@ int smu_get_power_limit(void *handle, if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) return -EOPNOTSUPP; =20 - switch(pp_power_type) { + switch (pp_power_type) { case PP_PWR_TYPE_SUSTAINED: limit_type =3D SMU_DEFAULT_PPT_LIMIT; break; @@ -2349,7 +2346,7 @@ int smu_get_power_limit(void *handle, break; } =20 - switch(pp_limit_level){ + switch (pp_limit_level) { case PP_PWR_LIMIT_CURRENT: limit_level =3D SMU_PPT_LIMIT_CURRENT; break; @@ -2595,7 +2592,7 @@ static int smu_read_sensor(void *handle, *size =3D 4; break; case AMDGPU_PP_SENSOR_VCN_POWER_STATE: - *(uint32_t *)data =3D atomic_read(&smu->smu_power.power_gate.vcn_gated) = ? 0: 1; + *(uint32_t *)data =3D atomic_read(&smu->smu_power.power_gate.vcn_gated) = ? 0 : 1; *size =3D 4; break; case AMDGPU_PP_SENSOR_MIN_FAN_RPM: @@ -2868,7 +2865,7 @@ static int smu_set_xgmi_pstate(void *handle, if (smu->ppt_funcs->set_xgmi_pstate) ret =3D smu->ppt_funcs->set_xgmi_pstate(smu, pstate); =20 - if(ret) + if (ret) dev_err(smu->adev->dev, "Failed to set XGMI pstate!\n"); =20 return ret; --=20 2.17.1