From nobody Sun Feb 8 04:34:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425A5C001DC for ; Mon, 31 Jul 2023 12:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbjGaMJ6 (ORCPT ); Mon, 31 Jul 2023 08:09:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231665AbjGaMJx (ORCPT ); Mon, 31 Jul 2023 08:09:53 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062.outbound.protection.outlook.com [40.107.93.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FD3810DF for ; Mon, 31 Jul 2023 05:09:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CaTQKByOCoTQNXQKyuhQQkCHHgJkfAUgz9fCm1lDUxi5xVnQRIw52MlpIsFVWSJFXDlnk76WGbX2MuYQ/003rB6PdZproJ/WoRh13nXeRqKINTqBH1heC/bXHeTmzwZcA9cVhJ/+a4vMH38id4+d/jYNkVXRsQSN7fa4awaIbAoqyuArJRIHwQkKJvmHLU9sfI057tgcTz86Hldd8Xz8qJUmFMc8L3OUjzJ9YmmjpkTjHs+eKo43LVo+7mQ/cW/HGuKYKVpctElZGZeeunHnR8itjQ+Se1akydiCJVmZhMEHRJEcInChk9lrzXX2eGJPMTZTCUE1h6UH6VPOmZzksQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vmH86kURiAr73ayzl6xvzV7Foce/Dj8VeQupccytOfs=; b=dlpQctIoMJu+f/NXOGdP0kE70ETgB5fVzXgc9XTacxjF5nJPIfDvJd5HdtRV+eGIxDCoIAGLzI9qG+i6r/9hFgIU9AAMWp0SEtB5Lw5QCSwr0Pm4D/Wv51pglEiHEusbRypE6XuGZLeEqjHwHevWN8tnsoa0xWoJsBxChTAsH+BHiW0xJrRrTbgla2wUiQMPHeVqrGfefBotNcdZ9tEAbtXLOIbyw/kogIkUoVitMVln2mlLyq/KzQP3BC5AtAti6HATfHgIYtYq4VOTnj9ZoQHEgAHHy9AOkEnBSdSzwtzRBONYIreD/ez5Uq5ZOH1/vk2W24NeZpCDMXgoj4NfgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vmH86kURiAr73ayzl6xvzV7Foce/Dj8VeQupccytOfs=; b=HPfRjBZtpo36Kbq1xnRHjt9npem6Blmwx5Y3H8FAJ8+AqXyw7EXmDbbcvDDcFa9sk8RBD8NSHvk5Fop6Ap92IeJSyotUdW0OPVziT8ruDviwBxUeULUP196zKOF+jYSJ71wL7HGcv+SR0N0a0wMjESU2ajfmEhJS6k2vSWK5Fk4= Received: from BY3PR03CA0019.namprd03.prod.outlook.com (2603:10b6:a03:39a::24) by CH3PR12MB9430.namprd12.prod.outlook.com (2603:10b6:610:1cd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 12:09:48 +0000 Received: from CO1PEPF000042AA.namprd03.prod.outlook.com (2603:10b6:a03:39a:cafe::ec) by BY3PR03CA0019.outlook.office365.com (2603:10b6:a03:39a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Mon, 31 Jul 2023 12:09:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042AA.mail.protection.outlook.com (10.167.243.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.22 via Frontend Transport; Mon, 31 Jul 2023 12:09:47 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 07:09:46 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 05:09:45 -0700 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 07:09:43 -0500 From: Abhijit Gangurde To: , , CC: , , , , Abhijit Gangurde Subject: [PATCH v2 1/4] cdx: Introduce lock to protect controller ops and controller list Date: Mon, 31 Jul 2023 17:38:10 +0530 Message-ID: <20230731120813.123247-2-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230731120813.123247-1-abhijit.gangurde@amd.com> References: <20230731120813.123247-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AA:EE_|CH3PR12MB9430:EE_ X-MS-Office365-Filtering-Correlation-Id: 06d123fe-46d8-4961-bfeb-08db91bf0894 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Aiy8/Bs7MSXcugfgSks90kNl/IgYYItOVoE2mei3k91s4wtbNeMR+2q6rUzjK751C3qdewrpb2ey+M0J6S3g0D+x4gk1Kd1ukt+TB+miVC+KJNm6EUMn9Khdt7pbWt0jYCN60nlcPS2YaUPWDZV75A0w8NFabzKe6Z85zO2kNC3AAp6ifJtfkLcjQu7CD572DqD/VyuOVIY6slFLqiLjGSDGcRwEonE+Utd8I19kbpjbvAIMJq7wP0QrVXlxUBKeAaBY3Ersd6OJ9xvM3XplOVHm0fu8MW7ZiHupHG9ZwMpGEH3UqElRIQcpNZ3rGsqZDmaZ2gKooSw84rmikdcNDmpRQhKaWrept195JwiFwMUIsiqig1lYz+HNu1KeOBQ5qLTYIxK3MFXwo//Gf8sSgIyou5+5VcRnG9t6DZZOdgj/DYNPGIcRjdfAupn4RPSu2fU0raYqCclkK0Bq4Oxuv5H5tdwnVHAzf0sgMYf6uQhHs42DRbzbkKHofVR1ImudK9Y8E4Rse+2Wg0sRB14JGPRdTHrsApsJZ2eTu70MKV6J980mC7xXcD3C17qyA3uXOpUnlxGsuqBnZkGEq7z9zQp2yhEToL5ZB6sJVQQ608hx1fgMo24Y6VIo3ahiwt64E8ryFfZ1/CercnXgcdxa2kh/laZS4n8HWvgIJIlqI53Vbl02Z65iVe5j+18mo+9oete81WPhb/k771Kf1JNBu9Z9z78d/foZzSpcGPpIoy3yfIjNxahE9oQn5XRK5Rau371wxpqX9Cm9gAjufpMlnA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199021)(82310400008)(36840700001)(40470700004)(46966006)(5660300002)(2616005)(426003)(8936002)(1076003)(8676002)(186003)(336012)(36860700001)(26005)(44832011)(47076005)(83380400001)(316002)(478600001)(70586007)(70206006)(4326008)(54906003)(110136005)(6666004)(41300700001)(86362001)(40480700001)(40460700003)(36756003)(2906002)(356005)(82740400003)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 12:09:47.0085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06d123fe-46d8-4961-bfeb-08db91bf0894 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9430 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a mutex lock to prevent race between controller ops initiated by the bus subsystem and the controller registration/unregistration. Signed-off-by: Abhijit Gangurde --- drivers/cdx/cdx.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index d2cad4c670a0..66797c8fe400 100644 --- a/drivers/cdx/cdx.c +++ b/drivers/cdx/cdx.c @@ -72,6 +72,8 @@ =20 /* CDX controllers registered with the CDX bus */ static DEFINE_XARRAY_ALLOC(cdx_controllers); +/* Lock to protect controller ops and controller list */ +static DEFINE_MUTEX(cdx_controller_lock); =20 /** * cdx_dev_reset - Reset a CDX device @@ -393,6 +395,8 @@ static ssize_t rescan_store(const struct bus_type *bus, if (!val) return -EINVAL; =20 + mutex_lock(&cdx_controller_lock); + /* Unregister all the devices on the bus */ cdx_unregister_devices(&cdx_bus_type); =20 @@ -405,6 +409,8 @@ static ssize_t rescan_store(const struct bus_type *bus, dev_err(cdx->dev, "cdx bus scanning failed\n"); } =20 + mutex_unlock(&cdx_controller_lock); + return count; } static BUS_ATTR_WO(rescan); @@ -520,9 +526,12 @@ int cdx_register_controller(struct cdx_controller *cdx) { int ret; =20 + mutex_lock(&cdx_controller_lock); + ret =3D xa_alloc(&cdx_controllers, &cdx->id, cdx, XA_LIMIT(0, MAX_CDX_CONTROLLERS - 1), GFP_KERNEL); if (ret) { + mutex_unlock(&cdx_controller_lock); dev_err(cdx->dev, "No free index available. Maximum controllers already registered\n"); cdx->id =3D (u8)MAX_CDX_CONTROLLERS; @@ -531,6 +540,7 @@ int cdx_register_controller(struct cdx_controller *cdx) =20 /* Scan all the devices */ cdx->ops->scan(cdx); + mutex_unlock(&cdx_controller_lock); =20 return 0; } @@ -541,8 +551,12 @@ void cdx_unregister_controller(struct cdx_controller *= cdx) if (cdx->id >=3D MAX_CDX_CONTROLLERS) return; =20 + mutex_lock(&cdx_controller_lock); + device_for_each_child(cdx->dev, NULL, cdx_unregister_device); xa_erase(&cdx_controllers, cdx->id); + + mutex_unlock(&cdx_controller_lock); } EXPORT_SYMBOL_GPL(cdx_unregister_controller); =20 --=20 2.25.1 From nobody Sun Feb 8 04:34:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C5AC001DC for ; Mon, 31 Jul 2023 12:10:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231919AbjGaMKd (ORCPT ); Mon, 31 Jul 2023 08:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjGaMK2 (ORCPT ); Mon, 31 Jul 2023 08:10:28 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A3C310E7 for ; Mon, 31 Jul 2023 05:10:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKXaf1WJNfgn0Vl7wgFLQdYx/tB3t1SYanofIT2MBQLMyK4Jp3EkicVHfvVaHb0ccCEYs5Jkd7T187KDuSTW790qW3uz/7Jnd+uLJ6i9Vm5qTMCfnwG3muu4LGUBO/cOFIDqeMEDsuGaJdNMMmSZKdSEZesSFmuaL7F5HO6NCINf1/OYjwsBUbm9wR1F16tNUi/ULrJ1q9na1IsQwRKHi25CiddUO2J78kh3/IKSLCuwlxPk9+DGumYEUiO3CDp734GkixI3sB7qqmQlOIQvG6FUKjVRY7wiiVAkKM2bG6vChBqIK4tBOphCtyW+8kQ7+zb40UmyfzoxDsmbnPe8Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZomFaUQz5uBPrRS5hAQrKqRXYZbvw8npwBFNglX3YnE=; b=V7zrnav9xaVPjP/cjdYZ1P2apWfpmMwajOqNgjFxMM47OfjwVbcUbXE45/fp4n/qhnOSDXmH07z3ugfiQvoY711Y0q3V48ZERA4GSQQKyaJNSK9sFZdYZysFg4usMAroTBe3GroRQdg8aPvQ+F3kNmAIZd9sN2gzEgyUKDvN3idpvNyu8+UdYefI/b9WETKTsSUiUy2mkYc1Vcs5ogqUAZ6ebuKLUNzDDpLWqkmxjQ19utAMBrSjmUr511HPIKIc+dpN203T9h3oFZatq0Z1vczKM5Nhp4RHyOH6cJl/GD5/Qbxg0skSYlOqmfjeYxCoj2yF7w2mWpEH7ZZJn/cQVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZomFaUQz5uBPrRS5hAQrKqRXYZbvw8npwBFNglX3YnE=; b=0iXxKD35vjpMSFh7rIgpYhouU7YFMrq55ig5TfFLPWpWitxizfp9J+EDwDoqrjC+rzpEB0UeeigcYcFTyP031MBEVht/Utch/qvWUu3/fy3JjZ8C5vlLT2tNzPMgq6HOrWWKr938ZLqbPU4PgCFM1Tn9eWv0FUg1d5dH4b94XFs= Received: from SJ0PR05CA0157.namprd05.prod.outlook.com (2603:10b6:a03:339::12) by CH2PR12MB4088.namprd12.prod.outlook.com (2603:10b6:610:a5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Mon, 31 Jul 2023 12:10:20 +0000 Received: from CO1PEPF000042A8.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::20) by SJ0PR05CA0157.outlook.office365.com (2603:10b6:a03:339::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.12 via Frontend Transport; Mon, 31 Jul 2023 12:10:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042A8.mail.protection.outlook.com (10.167.243.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.22 via Frontend Transport; Mon, 31 Jul 2023 12:10:20 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 07:10:19 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 05:10:19 -0700 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 07:10:11 -0500 From: Abhijit Gangurde To: , , CC: , , , , Abhijit Gangurde , "Nipun Gupta" , Pieter Jansen van Vuuren Subject: [PATCH v2 2/4] cdx: add support for bus enable and disable Date: Mon, 31 Jul 2023 17:38:11 +0530 Message-ID: <20230731120813.123247-3-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230731120813.123247-1-abhijit.gangurde@amd.com> References: <20230731120813.123247-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A8:EE_|CH2PR12MB4088:EE_ X-MS-Office365-Filtering-Correlation-Id: eea0278a-f035-4720-f8e5-08db91bf1c71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WLutJzCrgZnIPP4fuzyo6nNPGA4+f0RU21//BpWlxxZRyyB9dzLznWOOKuk45P2ufPhjuBu+slnp7+Wdtiye/n2A9w4Ah0lgfl3YkvBpgLISgLqTFRmn2zUFVJrCTpSL4tApmfclOD5yFB+STsTw1rGomP5YmPmM8XE70hDG0cLY+HyckVYtJTTP2UKSEf9konltrHtlgHMU0IL8+qmqRigzktE398ZWi5hk4u0dzuxDaPGgz1uQyBVOzoI6mYTBO4fYR4xvRtYtRtJ1kMqaM0Bgj7O1KNtSf4yMz4RbiWvt2lmETtP4SsSvGWzPBi66btQeD/x1/DQn5rydgoB1X2/YoSds1O5AM+qppDkKGq9toflSZMcqOIsh1DOyFE1HDooOc63tJVxNnlQSMb7PwdhpYxYjTLaJefF1QnazbxWOddOcuaLctdpeJaoorcyRgJuuytAzmLDVrAMb7vZvxoLMv8Xk+THhTSwbaiGSo1ELaa7d6L8OcwiTAnGHyAkAAwdYL6Jv4GmtqnfCBzy6NgrxuRrDjXQAS1kpKixQ1ui1nD0gBilfgbl6slrC1KKNStI9AXd9F58FstCoVHFcpSrQwg8lhpolaYXFFRg2/JWbrOe0qmwdnmqJLul4yokAm65W78ZObnQc0CNt4MCR0NtFAcRfKg/AxD0T4NZpa+UcO2AtK6ALyrxr9B4MBgT9VmxLmuLq3JnPeNKEyJefY77gNv28mXJyt8DKBkVsWqOS8P+zGJSt+2BENLI5EzHmLfXktiejL+BW8H/js5/k5g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(136003)(346002)(451199021)(82310400008)(36840700001)(46966006)(40470700004)(40460700003)(86362001)(40480700001)(36860700001)(47076005)(186003)(36756003)(2616005)(336012)(83380400001)(426003)(1076003)(26005)(81166007)(82740400003)(356005)(5660300002)(8676002)(41300700001)(8936002)(70206006)(70586007)(2906002)(30864003)(316002)(478600001)(110136005)(54906003)(4326008)(44832011)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 12:10:20.3507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eea0278a-f035-4720-f8e5-08db91bf1c71 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4088 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" CDX bus needs to be disabled before updating/writing devices in the FPGA. Once the devices are written, the bus shall be rescanned. This change provides sysfs entry to enable/disable the CDX bus. Co-developed-by: Nipun Gupta Signed-off-by: Nipun Gupta Signed-off-by: Abhijit Gangurde Reviewed-by: Pieter Jansen van Vuuren Tested-by: Nikhil Agarwal --- Documentation/ABI/testing/sysfs-bus-cdx | 27 ++++++++++ drivers/cdx/cdx.c | 72 +++++++++++++++++++++++++ drivers/cdx/controller/cdx_controller.c | 50 +++++++++++++++++ drivers/cdx/controller/mc_cdx_pcol.h | 54 +++++++++++++++++++ drivers/cdx/controller/mcdi_functions.c | 24 +++++++++ drivers/cdx/controller/mcdi_functions.h | 18 +++++++ include/linux/cdx/cdx_bus.h | 12 +++++ 7 files changed, 257 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/te= sting/sysfs-bus-cdx index 7af477f49998..04c8dfe7e201 100644 --- a/Documentation/ABI/testing/sysfs-bus-cdx +++ b/Documentation/ABI/testing/sysfs-bus-cdx @@ -11,6 +11,33 @@ Description: =20 # echo 1 > /sys/bus/cdx/rescan =20 +What: /sys/bus/cdx/enable +Date: July 2023 +Contact: nipun.gupta@amd.com +Description: + Writing bus number in hex to this file will attempt to enable + the CDX bus. The bus number for the cdx devices can be found + at /sys/bus/cdx/devices/cdx-BB:DD, where BB denotes the bus + number for the respective device. + + For example :: + + # echo 00 > /sys/bus/cdx/enable + +What: /sys/bus/cdx/disable +Date: July 2023 +Contact: nipun.gupta@amd.com +Description: + Writing bus number in hex to this file will attempt to disable + the CDX bus. CDX bus should be disabled before updating the + devices in FPGA. The bus number for the cdx devices can be + found at /sys/bus/cdx/devices/cdx-BB:DD, where BB denotes the + bus number for the respective device. + + For example :: + + # echo 00 > /sys/bus/cdx/disable + What: /sys/bus/cdx/devices/.../vendor Date: March 2023 Contact: nipun.gupta@amd.com diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index 66797c8fe400..28c38cc4e4f6 100644 --- a/drivers/cdx/cdx.c +++ b/drivers/cdx/cdx.c @@ -70,6 +70,10 @@ #define CDX_DEFAULT_DMA_MASK (~0ULL) #define MAX_CDX_CONTROLLERS 16 =20 +#define CONTROLLER_ID(X) \ + (((X) & CDX_CONTROLLER_ID_MASK) >> CDX_CONTROLLER_ID_SHIFT) +#define BUS_ID(X) ((X) & CDX_BUS_NUM_MASK) + /* CDX controllers registered with the CDX bus */ static DEFINE_XARRAY_ALLOC(cdx_controllers); /* Lock to protect controller ops and controller list */ @@ -382,6 +386,72 @@ static struct attribute *cdx_dev_attrs[] =3D { }; ATTRIBUTE_GROUPS(cdx_dev); =20 +static ssize_t enable_store(const struct bus_type *bus, + const char *buf, size_t count) +{ + struct cdx_controller *cdx; + unsigned long controller_id; + u8 bus_id; + int ret; + + if (kstrtou8(buf, 16, &bus_id)) + return -EINVAL; + + controller_id =3D CONTROLLER_ID(bus_id); + bus_id =3D BUS_ID(bus_id); + + mutex_lock(&cdx_controller_lock); + + cdx =3D xa_load(&cdx_controllers, controller_id); + if (!cdx) { + mutex_unlock(&cdx_controller_lock); + return -EINVAL; + } + + if (cdx->ops->bus_disable) + ret =3D cdx->ops->bus_enable(cdx, bus_id); + else + ret =3D -EOPNOTSUPP; + + mutex_unlock(&cdx_controller_lock); + + return ret < 0 ? ret : count; +} +static BUS_ATTR_WO(enable); + +static ssize_t disable_store(const struct bus_type *bus, + const char *buf, size_t count) +{ + struct cdx_controller *cdx; + unsigned long controller_id; + u8 bus_id; + int ret; + + if (kstrtou8(buf, 16, &bus_id)) + return -EINVAL; + + controller_id =3D CONTROLLER_ID(bus_id); + bus_id =3D BUS_ID(bus_id); + + mutex_lock(&cdx_controller_lock); + + cdx =3D xa_load(&cdx_controllers, controller_id); + if (!cdx) { + mutex_unlock(&cdx_controller_lock); + return -EINVAL; + } + + if (cdx->ops->bus_disable) + ret =3D cdx->ops->bus_disable(cdx, bus_id); + else + ret =3D -EOPNOTSUPP; + + mutex_unlock(&cdx_controller_lock); + + return ret < 0 ? ret : count; +} +static BUS_ATTR_WO(disable); + static ssize_t rescan_store(const struct bus_type *bus, const char *buf, size_t count) { @@ -416,6 +486,8 @@ static ssize_t rescan_store(const struct bus_type *bus, static BUS_ATTR_WO(rescan); =20 static struct attribute *cdx_bus_attrs[] =3D { + &bus_attr_enable.attr, + &bus_attr_disable.attr, &bus_attr_rescan.attr, NULL, }; diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controll= er/cdx_controller.c index dc52f95f8978..2e4725c872d0 100644 --- a/drivers/cdx/controller/cdx_controller.c +++ b/drivers/cdx/controller/cdx_controller.c @@ -32,6 +32,42 @@ static const struct cdx_mcdi_ops mcdi_ops =3D { .mcdi_request =3D cdx_mcdi_request, }; =20 +static int cdx_bus_enable(struct cdx_controller *cdx, u8 bus_num) +{ + int ret; + + if (test_bit(bus_num, cdx->bus_state)) + return 0; + + ret =3D cdx_mcdi_bus_enable(cdx->priv, bus_num); + if (!ret) + set_bit(bus_num, cdx->bus_state); + + return ret; +} + +static int cdx_bus_disable(struct cdx_controller *cdx, u8 bus_num) +{ + int ret; + + if (!test_bit(bus_num, cdx->bus_state)) + return 0; + + ret =3D cdx_mcdi_bus_disable(cdx->priv, bus_num); + if (!ret) + clear_bit(bus_num, cdx->bus_state); + + return ret; +} + +static void cdx_bus_disable_all(struct cdx_controller *cdx) +{ + u8 bus_num; + + for_each_set_bit(bus_num, cdx->bus_state, MAX_CDX_BUSES) + cdx_bus_disable(cdx, bus_num); +} + void cdx_rpmsg_post_probe(struct cdx_controller *cdx) { /* Register CDX controller with CDX bus driver */ @@ -42,6 +78,7 @@ void cdx_rpmsg_post_probe(struct cdx_controller *cdx) void cdx_rpmsg_pre_remove(struct cdx_controller *cdx) { cdx_unregister_controller(cdx); + cdx_bus_disable_all(cdx); cdx_mcdi_wait_for_quiescence(cdx->priv, MCDI_RPC_TIMEOUT); } =20 @@ -80,11 +117,22 @@ static int cdx_scan_devices(struct cdx_controller *cdx) for (bus_num =3D 0; bus_num < num_cdx_bus; bus_num++) { u8 num_cdx_dev; =20 + ret =3D cdx_bus_enable(cdx, bus_num); + if (ret && ret !=3D -EALREADY) { + dev_err(cdx->dev, + "CDX bus %d enable failed: %d\n", bus_num, ret); + continue; + } + /* MCDI FW Read: Fetch the number of devices present */ ret =3D cdx_mcdi_get_num_devs(cdx_mcdi, bus_num); if (ret < 0) { dev_err(cdx->dev, "Get devices on CDX bus %d failed: %d\n", bus_num, ret); + ret =3D cdx_bus_disable(cdx, bus_num); + if (ret) + dev_err(cdx->dev, + "CDX bus %d disable failed: %d\n", bus_num, ret); continue; } num_cdx_dev =3D (u8)ret; @@ -120,6 +168,8 @@ static int cdx_scan_devices(struct cdx_controller *cdx) } =20 static struct cdx_ops cdx_ops =3D { + .bus_enable =3D cdx_bus_enable, + .bus_disable =3D cdx_bus_disable, .scan =3D cdx_scan_devices, .dev_configure =3D cdx_configure_device, }; diff --git a/drivers/cdx/controller/mc_cdx_pcol.h b/drivers/cdx/controller/= mc_cdx_pcol.h index 4ccb7b52951b..2de019406b57 100644 --- a/drivers/cdx/controller/mc_cdx_pcol.h +++ b/drivers/cdx/controller/mc_cdx_pcol.h @@ -455,6 +455,60 @@ #define MC_CMD_CDX_BUS_GET_DEVICE_CONFIG_OUT_REQUESTER_ID_OFST 84 #define MC_CMD_CDX_BUS_GET_DEVICE_CONFIG_OUT_REQUESTER_ID_LEN 4 =20 +/***********************************/ +/* + * MC_CMD_CDX_BUS_DOWN + * Asserting reset on the CDX bus causes all devices on the bus to be quie= sced. + * DMA bus mastering is disabled and any pending DMA request are flushed. = Once + * the response is returned, the devices are guaranteed to no longer issue= DMA + * requests or raise MSI interrupts. Further device MMIO accesses may have + * undefined results. While the bus reset is asserted, any of the enumerat= ion + * or device configuration MCDIs will fail with EAGAIN. It is only legal to + * reload the relevant PL region containing CDX devices if the correspondi= ng CDX + * bus is in reset. Depending on the implementation, the firmware may or m= ay + * not enforce this restriction and it is up to the caller to make sure th= is + * requirement is satisfied. + */ +#define MC_CMD_CDX_BUS_DOWN 0x4 +#define MC_CMD_CDX_BUS_DOWN_MSGSET 0x4 + +/* MC_CMD_CDX_BUS_DOWN_IN msgrequest */ +#define MC_CMD_CDX_BUS_DOWN_IN_LEN 4 +/* Bus number to put in reset, in range 0 to BUS_COUNT-1 */ +#define MC_CMD_CDX_BUS_DOWN_IN_BUS_OFST 0 +#define MC_CMD_CDX_BUS_DOWN_IN_BUS_LEN 4 + +/* + * MC_CMD_CDX_BUS_DOWN_OUT msgresponse: The bus is quiesced, no further + * upstream traffic for devices on this bus. + */ +#define MC_CMD_CDX_BUS_DOWN_OUT_LEN 0 + +/***********************************/ +/* + * MC_CMD_CDX_BUS_UP + * After bus reset is de-asserted, devices are in a state which is functio= nally + * equivalent to each device having been reset with MC_CMD_CDX_DEVICE_RESE= T. In + * other words, device logic is reset in a hardware-specific way, MMIO acc= esses + * are forwarded to the device, DMA bus mastering is disabled and needs to= be + * re-enabled with MC_CMD_CDX_DEVICE_DMA_ENABLE once the driver is ready to + * start servicing DMA. If the underlying number of devices or device reso= urces + * changed (e.g. if PL was reloaded) while the bus was in reset, the bus d= river + * is expected to re-enumerate the bus. Returns EALREADY if the bus was al= ready + * up before the call. + */ +#define MC_CMD_CDX_BUS_UP 0x5 +#define MC_CMD_CDX_BUS_UP_MSGSET 0x5 + +/* MC_CMD_CDX_BUS_UP_IN msgrequest */ +#define MC_CMD_CDX_BUS_UP_IN_LEN 4 +/* Bus number to take out of reset, in range 0 to BUS_COUNT-1 */ +#define MC_CMD_CDX_BUS_UP_IN_BUS_OFST 0 +#define MC_CMD_CDX_BUS_UP_IN_BUS_LEN 4 + +/* MC_CMD_CDX_BUS_UP_OUT msgresponse: The bus can now be enumerated. */ +#define MC_CMD_CDX_BUS_UP_OUT_LEN 0 + /***********************************/ /* * MC_CMD_CDX_DEVICE_RESET diff --git a/drivers/cdx/controller/mcdi_functions.c b/drivers/cdx/controll= er/mcdi_functions.c index 0158f26533dd..0e1e35d91242 100644 --- a/drivers/cdx/controller/mcdi_functions.c +++ b/drivers/cdx/controller/mcdi_functions.c @@ -124,6 +124,30 @@ int cdx_mcdi_get_dev_config(struct cdx_mcdi *cdx, return 0; } =20 +int cdx_mcdi_bus_enable(struct cdx_mcdi *cdx, u8 bus_num) +{ + MCDI_DECLARE_BUF(inbuf, MC_CMD_CDX_BUS_UP_IN_LEN); + int ret; + + MCDI_SET_DWORD(inbuf, CDX_BUS_UP_IN_BUS, bus_num); + ret =3D cdx_mcdi_rpc(cdx, MC_CMD_CDX_BUS_UP, inbuf, sizeof(inbuf), + NULL, 0, NULL); + + return ret; +} + +int cdx_mcdi_bus_disable(struct cdx_mcdi *cdx, u8 bus_num) +{ + MCDI_DECLARE_BUF(inbuf, MC_CMD_CDX_BUS_DOWN_IN_LEN); + int ret; + + MCDI_SET_DWORD(inbuf, CDX_BUS_DOWN_IN_BUS, bus_num); + ret =3D cdx_mcdi_rpc(cdx, MC_CMD_CDX_BUS_DOWN, inbuf, sizeof(inbuf), + NULL, 0, NULL); + + return ret; +} + int cdx_mcdi_reset_device(struct cdx_mcdi *cdx, u8 bus_num, u8 dev_num) { MCDI_DECLARE_BUF(inbuf, MC_CMD_CDX_DEVICE_RESET_IN_LEN); diff --git a/drivers/cdx/controller/mcdi_functions.h b/drivers/cdx/controll= er/mcdi_functions.h index 7440ace5539a..28973d5ec3ab 100644 --- a/drivers/cdx/controller/mcdi_functions.h +++ b/drivers/cdx/controller/mcdi_functions.h @@ -47,6 +47,24 @@ int cdx_mcdi_get_dev_config(struct cdx_mcdi *cdx, u8 bus_num, u8 dev_num, struct cdx_dev_params *dev_params); =20 +/** + * cdx_mcdi_bus_enable - Enable CDX bus represented by bus_num + * @cdx: pointer to MCDI interface. + * @bus_num: Bus number. + * + * Return: 0 on success, <0 on failure + */ +int cdx_mcdi_bus_enable(struct cdx_mcdi *cdx, u8 bus_num); + +/** + * cdx_mcdi_bus_disable - Disable CDX bus represented by bus_num + * @cdx: pointer to MCDI interface. + * @bus_num: Bus number. + * + * Return: 0 on success, <0 on failure + */ +int cdx_mcdi_bus_disable(struct cdx_mcdi *cdx, u8 bus_num); + /** * cdx_mcdi_reset_device - Reset cdx device represented by bus_num:dev_num * @cdx: pointer to MCDI interface. diff --git a/include/linux/cdx/cdx_bus.h b/include/linux/cdx/cdx_bus.h index bead71b7bc73..f26b53884359 100644 --- a/include/linux/cdx/cdx_bus.h +++ b/include/linux/cdx/cdx_bus.h @@ -16,6 +16,8 @@ #define MAX_CDX_DEV_RESOURCES 4 #define CDX_CONTROLLER_ID_SHIFT 4 #define CDX_BUS_NUM_MASK 0xF +#define CDX_CONTROLLER_ID_MASK 0xF0 +#define MAX_CDX_BUSES (CDX_BUS_NUM_MASK + 1) =20 /* Forward declaration for CDX controller */ struct cdx_controller; @@ -28,6 +30,10 @@ struct cdx_device_config { u8 type; }; =20 +typedef int (*cdx_bus_enable_cb)(struct cdx_controller *cdx, u8 bus_num); + +typedef int (*cdx_bus_disable_cb)(struct cdx_controller *cdx, u8 bus_num); + typedef int (*cdx_scan_cb)(struct cdx_controller *cdx); =20 typedef int (*cdx_dev_configure_cb)(struct cdx_controller *cdx, @@ -49,11 +55,15 @@ typedef int (*cdx_dev_configure_cb)(struct cdx_controll= er *cdx, =20 /** * struct cdx_ops - Callbacks supported by CDX controller. + * @bus_enable: enable bus on the controller + * @bus_disable: disable bus on the controller * @scan: scan the devices on the controller * @dev_configure: configuration like reset, master_enable, * msi_config etc for a CDX device */ struct cdx_ops { + cdx_bus_enable_cb bus_enable; + cdx_bus_disable_cb bus_disable; cdx_scan_cb scan; cdx_dev_configure_cb dev_configure; }; @@ -63,12 +73,14 @@ struct cdx_ops { * @dev: Linux device associated with the CDX controller. * @priv: private data * @id: Controller ID + * @bus_state: state of the buses(enabled/disabled) * @ops: CDX controller ops */ struct cdx_controller { struct device *dev; void *priv; u32 id; + DECLARE_BITMAP(bus_state, MAX_CDX_BUSES); struct cdx_ops *ops; }; =20 --=20 2.25.1 From nobody Sun Feb 8 04:34:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31383C001DC for ; Mon, 31 Jul 2023 12:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231743AbjGaMLF (ORCPT ); Mon, 31 Jul 2023 08:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbjGaMKz (ORCPT ); Mon, 31 Jul 2023 08:10:55 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2BBB19AB for ; Mon, 31 Jul 2023 05:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+xQ4aVRCKoL534zpePheM47g/YM43rk7cyHnFDDgdkUs/vhoTcHJ27ASt9NwXSfKq6pAgXFAr+EOoewu/oJZ1EN+zA7S1k8ZZyRbS9vxT2IgVqHpE0CRJgjdgZhsTL7NZ7Dxa+Ha/khj9yi6+YCeNJ3PEI96ecKDS2Qhrors5LyElwiRFxWmNsoAs8KCvyTLOFM7U3EdvBXjoswdrZHlQZad36ZFvBt+KtoB4MNoV8KHqee3I0mxPyASOme1/cbhX5TEhGwwH2IMgMRLZ4aip5qJsw/va5qAvrT2cqqJF8QI3M1JGxeXN45V4ggkWwVfFZ6/gKMHJoxpge+RmPD2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6wg1hHU9slQd3wQBSez9GWzOK2LAcxrLQ+kanHbds7w=; b=MTJwTs4KQNiyodM1cTm8L8DHD7/gnno4xESkXGM+lvquAbYkpohZG8e8ATos7m0JepoCjz+16taPfYekACsYhk1bOxjyHdOAiHyDakcToAeHjTmftJ8tFWHFdphRrZBELM4EVVqSCiBVDYVyV7Pdf9MxAHiP25vVojWbkE7i4HsYq15mx+HD4cbyH+cB+1kz7YGyK/jMEZBGpkenOLqdICZEA27nS7AEHIO7/Sq/lLjM9j+ibnfYI3v3jqxqmdnUKY1cHAlDs9KDKplW0YxKEdf68+VEbwv3nK5HsicmnzQHdvV1yyEJVgZIl4u4F5VbkD8vy0Tt4twnpPMCgOuC3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wg1hHU9slQd3wQBSez9GWzOK2LAcxrLQ+kanHbds7w=; b=D1EVzXlaKvn5MU4KFaYMUvbuy4u/o4BBhbCXGitlIi1b7giK8okdsUJCu/8K1xMOHELTPZP2x6R0+/Tl7LzFRVdiRRbWaJAaAoG753IvorWY5ENesytX45XWxVel7tNnww4og6dQzpFMgauy5gzgAFavZ+bF13RM2F7gM/WJYps= Received: from MW4PR03CA0038.namprd03.prod.outlook.com (2603:10b6:303:8e::13) by PH7PR12MB8121.namprd12.prod.outlook.com (2603:10b6:510:2b5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Mon, 31 Jul 2023 12:10:43 +0000 Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:303:8e:cafe::5a) by MW4PR03CA0038.outlook.office365.com (2603:10b6:303:8e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42 via Frontend Transport; Mon, 31 Jul 2023 12:10:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.22 via Frontend Transport; Mon, 31 Jul 2023 12:10:42 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 07:10:42 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 05:10:41 -0700 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 07:10:33 -0500 From: Abhijit Gangurde To: , , CC: , , , , Abhijit Gangurde , "Puneet Gupta" , Nipun Gupta , "Pieter Jansen van Vuuren" Subject: [PATCH v2 3/4] cdx: add sysfs for bus reset Date: Mon, 31 Jul 2023 17:38:12 +0530 Message-ID: <20230731120813.123247-4-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230731120813.123247-1-abhijit.gangurde@amd.com> References: <20230731120813.123247-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|PH7PR12MB8121:EE_ X-MS-Office365-Filtering-Correlation-Id: af7075d5-ee21-4597-b4b3-08db91bf29e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uwDGoYaWS6+gLy6zASC50StTZfyBObn81Ej8rSglgKZRoXAF6NbI4rWvXMlk+8ALubM8Bj9SkT9Zls8iEmlEt5f8wbhTOus2ANQVrhGkiFdGdEozKdgvTAMPev/jllc1Ny8VcWdvGqmkefhyIFVe/Dq4q9xPgHxXLARiTFUvZPfLz0/q+6/WwJckoKCR6HtII2ro7NZectVCE6Wj3AP7g3Rz9U4NsrSi7TiVtmZyuTw3jp46PpcRWrrmPQ+/Um42k2ZpaZgmVUKv+BB99WCTl0fSPFlDXeUzM5MJz1wn5gvLr3Lrib0cRI629UYiJmidMGgKUGvZFEFoyBmsegTYxbDmHZl+mL6OQz96Xt6ZvbbiK3yk9UyhIMc4A886CKTE+Ccu3sha3WYe2e5bQsdRYjSJWStQZgKPN877GiYLbqZyaC3UTIrzYMhOflJdGrfZi67fTj0urMr579moUzesPimJFkOO86qMbsokk/VQmFjvLCW4Ijk3/s8tW3BULV8Ctazyu+vwUU2tVd1o2CB4gwCI/pfrrhWpU0wx95NZtYR/IlFvo28vcqzIgwh46cUmNTKcrpNMRiWCQqschzBwUIrH++vKLzHcnEfQ4GQtaWA9WfgfyzxD9j0qPZjee37kCoHgM47NkvKx77kguJ17w2lelppVgydOSDIRVNaTvBmE1HbcXCZNXmcjVsQmaWRjW6v6JAEVs3th8eRSvXezdUCMBdgj+IzDP25RvQk7LF7o7bWs1xCaNG2H2q8/Fwo0GAieKMN2Bf9TTWMdUgpyCg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(346002)(82310400008)(451199021)(40470700004)(46966006)(36840700001)(8936002)(8676002)(1076003)(26005)(110136005)(54906003)(41300700001)(82740400003)(316002)(4326008)(5660300002)(336012)(186003)(6666004)(70586007)(70206006)(478600001)(44832011)(86362001)(2616005)(36756003)(426003)(83380400001)(47076005)(40460700003)(36860700001)(2906002)(356005)(81166007)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 12:10:42.8061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af7075d5-ee21-4597-b4b3-08db91bf29e2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8121 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add sysfs interface reset to reset all the devices on the CDX bus. Co-developed-by: Puneet Gupta Signed-off-by: Puneet Gupta Co-developed-by: Nipun Gupta Signed-off-by: Nipun Gupta Signed-off-by: Abhijit Gangurde Reviewed-by: Pieter Jansen van Vuuren Tested-by: Nikhil Agarwal --- Documentation/ABI/testing/sysfs-bus-cdx | 15 +++++++++ drivers/cdx/cdx.c | 41 +++++++++++++++++++++++++ 2 files changed, 56 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/te= sting/sysfs-bus-cdx index 04c8dfe7e201..d25875359741 100644 --- a/Documentation/ABI/testing/sysfs-bus-cdx +++ b/Documentation/ABI/testing/sysfs-bus-cdx @@ -38,6 +38,21 @@ Description: =20 # echo 00 > /sys/bus/cdx/disable =20 +What: /sys/bus/cdx/reset +Date: July 2023 +Contact: puneet.gupta@amd.com +Description: + Writing bus number in hex to this file will attempt to reset + all the devices present on the bus. Resetting a device would + clear all existing configuration of the device and put the + device in default state. The bus number for the cdx devices can + be found at /sys/bus/cdx/devices/cdx-BB:DD, where BB denotes + the bus number for the respective device. + + For example :: + + # echo 00 > /sys/bus/cdx/reset + What: /sys/bus/cdx/devices/.../vendor Date: March 2023 Contact: nipun.gupta@amd.com diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index 28c38cc4e4f6..76219d35e321 100644 --- a/drivers/cdx/cdx.c +++ b/drivers/cdx/cdx.c @@ -112,6 +112,26 @@ int cdx_dev_reset(struct device *dev) } EXPORT_SYMBOL_GPL(cdx_dev_reset); =20 +/** + * reset_cdx_device - Reset a CDX device + * @dev: CDX device + * @data: Bus number + * If bus number matches to the device's bus then this device + * is reset else this is no op. + * + * Return: -errno on failure, 0 on success. + */ +static int reset_cdx_device(struct device *dev, void *data) +{ + struct cdx_device *cdx_dev =3D to_cdx_device(dev); + u8 bus_num =3D *((u8 *)data); + + if (cdx_dev->bus_num =3D=3D bus_num) + return cdx_dev_reset(dev); + + return 0; +} + /** * cdx_unregister_device - Unregister a CDX device * @dev: CDX device @@ -485,10 +505,31 @@ static ssize_t rescan_store(const struct bus_type *bu= s, } static BUS_ATTR_WO(rescan); =20 +static ssize_t bus_reset_store(const struct bus_type *bus, + const char *buf, size_t count) +{ + u8 bus_id; + int ret; + + if (kstrtou8(buf, 16, &bus_id)) + return -EINVAL; + + bus_id =3D BUS_ID(bus_id); + mutex_lock(&cdx_controller_lock); + /* Reset all the devices attached to cdx bus */ + ret =3D bus_for_each_dev(bus, NULL, (void *)&bus_id, reset_cdx_device); + mutex_unlock(&cdx_controller_lock); + + return ret < 0 ? ret : count; +} +static struct bus_attribute bus_attr_reset =3D __ATTR(reset, 0200, NULL, + bus_reset_store); + static struct attribute *cdx_bus_attrs[] =3D { &bus_attr_enable.attr, &bus_attr_disable.attr, &bus_attr_rescan.attr, + &bus_attr_reset.attr, NULL, }; ATTRIBUTE_GROUPS(cdx_bus); --=20 2.25.1 From nobody Sun Feb 8 04:34:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BF5C001DF for ; Mon, 31 Jul 2023 12:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231901AbjGaMLT (ORCPT ); Mon, 31 Jul 2023 08:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230480AbjGaMLQ (ORCPT ); Mon, 31 Jul 2023 08:11:16 -0400 Received: from outbound.mail.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6116110FD for ; Mon, 31 Jul 2023 05:11:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GKGqR3n/vPL1AetOXMxPgZWwVLc8+CIzAGkez6OK+DsE7k2if3hNHWsCK9AItn6QhdbKD6DPWHb7kcRUjIs+i7EAzrfF4W1bJI3os4DGLNDwE5OwIT+04RchZh6H6d/8UbvblPr5VJdZDuMxTlrv2WwW96wD23R8NGmDZ2N95slEwTDWXnSQVxHlaqFskq0czhzP7dm8roXWYTko52kcVCa7Cdjxq2g27qd7d9ME4Sb5Z0GTuzxO9xYm2Xr3vIshXdFru8gEhC/bvRZoJU929Wa1+l4I/FT+Eu5rIuuEy5X5hVvpydhgDmQsAdEFY6cjoR9VahLi2O96NqC3xnykvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=34m9eFsxdD5FjKksPu9wrcS1GjPWiGXy6bPKeTxxRfM=; b=Ud4XXsncrAklJZkmOUU1N/W5uc0R8Li9vp7rlS0Ml/haNtDYkurN9fThxiiBixsRvBI9dlf0+RIIL3kPyvb27cfK0tCmq5m6WtrFImzVFhl8Q+ln8MXNemZ+60sPckN6xA1andlZKRCr0rOXFlmNngONxOPi/jVtxKiyjo0iVimtCCwJQL4c0H0vxRbaZqrq4wnHUdnbJ6SuvssdhlWYLI9zkx4rY3OHeiA4+eh0xoBD9aR8syJJV/YXRGeHZ6RErIn/oxjeDpVZEUaKhYTqNs9hmyUKbmuO6Ol2aUn7YmAN6Tei50UdDND+M3rok+LSqyPf/79ClkAQgc51pPlxUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=34m9eFsxdD5FjKksPu9wrcS1GjPWiGXy6bPKeTxxRfM=; b=Ws8Vq94IIxSHOfQ7jRXxdCGk+Z7z4LTNTo5MXFkLdTF+vOp9meZMdCA4saDISsAcqMu9PcsWGcb3Ybe3LMRZcx2IlCH0UiYEn+pd6l3fBCqaUpxQHnkfZKGKCjePQUGQZfQeSIUjSoYBMEri/+mkDA9vhdU4DEXWFFHVRvyx9sI= Received: from BY3PR03CA0024.namprd03.prod.outlook.com (2603:10b6:a03:39a::29) by BN9PR12MB5049.namprd12.prod.outlook.com (2603:10b6:408:132::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 12:10:59 +0000 Received: from CO1PEPF000042AA.namprd03.prod.outlook.com (2603:10b6:a03:39a:cafe::14) by BY3PR03CA0024.outlook.office365.com (2603:10b6:a03:39a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Mon, 31 Jul 2023 12:10:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042AA.mail.protection.outlook.com (10.167.243.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.22 via Frontend Transport; Mon, 31 Jul 2023 12:10:58 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 07:10:57 -0500 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 07:10:49 -0500 From: Abhijit Gangurde To: , , CC: , , , , Abhijit Gangurde , "Puneet Gupta" , Nipun Gupta , "Pieter Jansen van Vuuren" Subject: [PATCH v2 4/4] cdx: add sysfs for subsystem, class and revision Date: Mon, 31 Jul 2023 17:38:13 +0530 Message-ID: <20230731120813.123247-5-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230731120813.123247-1-abhijit.gangurde@amd.com> References: <20230731120813.123247-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AA:EE_|BN9PR12MB5049:EE_ X-MS-Office365-Filtering-Correlation-Id: a3299d27-ecb8-4ed6-9eb5-08db91bf333e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YcHRoERDuLtkY++Jtb2Hh/rsxPW7ZrLaWlQAxua8MM5z195+gvGiJbt7hcYPbETOOjUUAbsO6YIrSGUfSsd4MdLgYtf1kU9By3yNhBSCBaKv5LivwaO3hl/UoimSXEmlwWijadKkGQ7UkaFr1LSr64tUPQkf4Uy+lRkMvwiKlgZDLkx5ZYX8FaijNAonkblzFcQEKG/XOjPyIixyzN8g8m7PN7A3GfpV1jBfNgT4U+MRBC7SQHB/N8foQCKNhiKYzsIzySbK4t8w92eZwzhEqpjm15PgqQotaLjrWOyOtXxRwb0daR6HoPB12Dlscx8z6naSgK0S9cT+4dId1YrY20rvAIdKtDCLQszbUD1+1JyQKao7m01dlOZdaFkz4ecIDnXII/naD74vb2sMQnOakjjDnbbyAd2zHemxkZmLBmBVwhRcZVV9ysr6GcJamgtkeyQf1yFuA+Ct46D5ULZDdsQtxCpSbzUf4JhzLt0Fu3IYb1vzQNqNYU3tu2nCVKIczG18x5yJEZjcKt8OFUUNWuOjMdbnytOjgFoRlucsi2i4hCOEjM3hmG0QpWWASRmnt+SrcJDbLKg4NN5Y2tpCmhSdPorLeD/7Y4IgPDxFqZpy5SNbcscoElSVOVCByVQG3DO7BL1KgCqdxgLxKb7h01hU0gTGFQPxd1dPdl310i+LUQo97CRlzFGMZunyyMF8XNDvZ3rv/ir+E6tqheN1c5AVRQq87sqtNLeIRW+qPiK+eF/+q5Rb9ZH+BZXsyei21YqwZsFPxbsT1wi1q4OeIw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(376002)(396003)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(47076005)(36860700001)(36756003)(40480700001)(40460700003)(2616005)(1076003)(26005)(83380400001)(186003)(336012)(426003)(44832011)(70206006)(70586007)(81166007)(356005)(54906003)(110136005)(82740400003)(86362001)(316002)(4326008)(5660300002)(8676002)(8936002)(41300700001)(2906002)(6666004)(478600001)(30864003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 12:10:58.5861 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3299d27-ecb8-4ed6-9eb5-08db91bf333e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5049 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" CDX controller provides subsystem vendor, subsystem device, class and revision info of the device along with vendor and device ID in native endian format. CDX Bus system uses this information to bind the cdx device to the cdx device driver. Co-developed-by: Puneet Gupta Signed-off-by: Puneet Gupta Co-developed-by: Nipun Gupta Signed-off-by: Nipun Gupta Signed-off-by: Abhijit Gangurde Reviewed-by: Pieter Jansen van Vuuren Tested-by: Nikhil Agarwal --- Documentation/ABI/testing/sysfs-bus-cdx | 45 +++++++++++++++++++++++++ drivers/cdx/cdx.c | 29 +++++++++++++++- drivers/cdx/cdx.h | 8 +++++ drivers/cdx/controller/mcdi_functions.c | 7 ++++ include/linux/cdx/cdx_bus.h | 27 +++++++++++++-- include/linux/mod_devicetable.h | 10 ++++++ scripts/mod/devicetable-offsets.c | 4 +++ scripts/mod/file2alias.c | 8 +++++ 8 files changed, 135 insertions(+), 3 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/te= sting/sysfs-bus-cdx index d25875359741..e71a6daccfbe 100644 --- a/Documentation/ABI/testing/sysfs-bus-cdx +++ b/Documentation/ABI/testing/sysfs-bus-cdx @@ -70,6 +70,36 @@ Description: of a device manufacturer. Combination of Vendor ID and Device ID identifies a device. =20 +What: /sys/bus/cdx/devices/.../subsystem_vendor +Date: July 2023 +Contact: puneet.gupta@amd.com +Description: + Subsystem Vendor ID for this CDX device, in hexadecimal. + Subsystem Vendor ID is 16 bit identifier specific to the + card manufacturer. + +What: /sys/bus/cdx/devices/.../subsystem_device +Date: July 2023 +Contact: puneet.gupta@amd.com +Description: + Subsystem Device ID for this CDX device, in hexadecimal + Subsystem Device ID is 16 bit identifier specific to the + card manufacturer. + +What: /sys/bus/cdx/devices/.../class +Date: July 2023 +Contact: puneet.gupta@amd.com +Description: + This file contains the class of the CDX device, in hexadecimal. + Class is 24 bit identifier specifies the functionality of the device. + +What: /sys/bus/cdx/devices/.../revision +Date: July 2023 +Contact: puneet.gupta@amd.com +Description: + This file contains the revision field of the CDX device, in hexadecimal. + Revision is 8 bit revision identifier of the device. + What: /sys/bus/cdx/devices/.../reset Date: March 2023 Contact: nipun.gupta@amd.com @@ -96,3 +126,18 @@ Description: For example:: =20 # echo 1 > /sys/bus/cdx/devices/.../remove + +What: /sys/bus/cdx/devices/.../modalias +Date: July 2023 +Contact: nipun.gupta@amd.com +Description: + This attribute indicates the CDX ID of the device. + That is in the format: + cdx:vXXXXdXXXXsvXXXXsdXXXXcXXXXXX, + where: + + - vXXXX contains the vendor ID; + - dXXXX contains the device ID; + - svXXXX contains the subsystem vendor ID; + - sdXXXX contains the subsystem device ID; + - cXXXXXX contains the device class. diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index 76219d35e321..806b2ed2af06 100644 --- a/drivers/cdx/cdx.c +++ b/drivers/cdx/cdx.c @@ -179,7 +179,10 @@ cdx_match_one_device(const struct cdx_device_id *id, { /* Use vendor ID and device ID for matching */ if ((id->vendor =3D=3D CDX_ANY_ID || id->vendor =3D=3D dev->vendor) && - (id->device =3D=3D CDX_ANY_ID || id->device =3D=3D dev->device)) + (id->device =3D=3D CDX_ANY_ID || id->device =3D=3D dev->device) && + (id->subvendor =3D=3D CDX_ANY_ID || id->subvendor =3D=3D dev->subsyst= em_vendor) && + (id->subdevice =3D=3D CDX_ANY_ID || id->subdevice =3D=3D dev->subsyst= em_device) && + !((id->class ^ dev->class) & id->class_mask)) return id; return NULL; } @@ -325,6 +328,10 @@ static DEVICE_ATTR_RO(field) =20 cdx_config_attr(vendor, "0x%04x\n"); cdx_config_attr(device, "0x%04x\n"); +cdx_config_attr(subsystem_vendor, "0x%04x\n"); +cdx_config_attr(subsystem_device, "0x%04x\n"); +cdx_config_attr(revision, "0x%02x\n"); +cdx_config_attr(class, "0x%06x\n"); =20 static ssize_t remove_store(struct device *dev, struct device_attribute *attr, @@ -370,6 +377,17 @@ static ssize_t reset_store(struct device *dev, struct = device_attribute *attr, } static DEVICE_ATTR_WO(reset); =20 +static ssize_t modalias_show(struct device *dev, struct device_attribute *= attr, + char *buf) +{ + struct cdx_device *cdx_dev =3D to_cdx_device(dev); + + return sprintf(buf, "cdx:v%04Xd%04Xsv%04Xsd%04Xc%06X\n", cdx_dev->vendor, + cdx_dev->device, cdx_dev->subsystem_vendor, cdx_dev->subsystem_device, + cdx_dev->class); +} +static DEVICE_ATTR_RO(modalias); + static ssize_t driver_override_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -401,6 +419,11 @@ static struct attribute *cdx_dev_attrs[] =3D { &dev_attr_reset.attr, &dev_attr_vendor.attr, &dev_attr_device.attr, + &dev_attr_subsystem_vendor.attr, + &dev_attr_subsystem_device.attr, + &dev_attr_class.attr, + &dev_attr_revision.attr, + &dev_attr_modalias.attr, &dev_attr_driver_override.attr, NULL, }; @@ -599,6 +622,10 @@ int cdx_device_add(struct cdx_dev_params *dev_params) cdx_dev->req_id =3D dev_params->req_id; cdx_dev->vendor =3D dev_params->vendor; cdx_dev->device =3D dev_params->device; + cdx_dev->subsystem_vendor =3D dev_params->subsys_vendor; + cdx_dev->subsystem_device =3D dev_params->subsys_device; + cdx_dev->class =3D dev_params->class; + cdx_dev->revision =3D dev_params->revision; cdx_dev->bus_num =3D dev_params->bus_num; cdx_dev->dev_num =3D dev_params->dev_num; cdx_dev->cdx =3D dev_params->cdx; diff --git a/drivers/cdx/cdx.h b/drivers/cdx/cdx.h index c436ac7ac86f..d17b5a501e8d 100644 --- a/drivers/cdx/cdx.h +++ b/drivers/cdx/cdx.h @@ -16,21 +16,29 @@ * @parent: Associated CDX controller * @vendor: Vendor ID for CDX device * @device: Device ID for CDX device + * @subsys_vendor: Sub vendor ID for CDX device + * @subsys_device: Sub device ID for CDX device * @bus_num: Bus number for this CDX device * @dev_num: Device number for this device * @res: array of MMIO region entries * @res_count: number of valid MMIO regions * @req_id: Requestor ID associated with CDX device + * @class: Class of the CDX Device + * @revision: Revision of the CDX device */ struct cdx_dev_params { struct cdx_controller *cdx; u16 vendor; u16 device; + u16 subsys_vendor; + u16 subsys_device; u8 bus_num; u8 dev_num; struct resource res[MAX_CDX_DEV_RESOURCES]; u8 res_count; u32 req_id; + u32 class; + u8 revision; }; =20 /** diff --git a/drivers/cdx/controller/mcdi_functions.c b/drivers/cdx/controll= er/mcdi_functions.c index 0e1e35d91242..65dca2aa1d3f 100644 --- a/drivers/cdx/controller/mcdi_functions.c +++ b/drivers/cdx/controller/mcdi_functions.c @@ -120,6 +120,13 @@ int cdx_mcdi_get_dev_config(struct cdx_mcdi *cdx, =20 dev_params->vendor =3D MCDI_WORD(outbuf, CDX_BUS_GET_DEVICE_CONFIG_OUT_VE= NDOR_ID); dev_params->device =3D MCDI_WORD(outbuf, CDX_BUS_GET_DEVICE_CONFIG_OUT_DE= VICE_ID); + dev_params->subsys_vendor =3D MCDI_WORD(outbuf, + CDX_BUS_GET_DEVICE_CONFIG_OUT_SUBSYS_VENDOR_ID); + dev_params->subsys_device =3D MCDI_WORD(outbuf, + CDX_BUS_GET_DEVICE_CONFIG_OUT_SUBSYS_DEVICE_ID); + dev_params->class =3D MCDI_DWORD(outbuf, + CDX_BUS_GET_DEVICE_CONFIG_OUT_DEVICE_CLASS) & 0xFFFFFF; + dev_params->revision =3D MCDI_BYTE(outbuf, CDX_BUS_GET_DEVICE_CONFIG_OUT_= DEVICE_REVISION); =20 return 0; } diff --git a/include/linux/cdx/cdx_bus.h b/include/linux/cdx/cdx_bus.h index f26b53884359..46ced2cb2291 100644 --- a/include/linux/cdx/cdx_bus.h +++ b/include/linux/cdx/cdx_bus.h @@ -40,6 +40,19 @@ typedef int (*cdx_dev_configure_cb)(struct cdx_controlle= r *cdx, u8 bus_num, u8 dev_num, struct cdx_device_config *dev_config); =20 +/** + * CDX_DEVICE - macro used to describe a specific CDX device + * @vend: the 16 bit CDX Vendor ID + * @dev: the 16 bit CDX Device ID + * + * This macro is used to create a struct cdx_device_id that matches a + * specific device. The subvendor and subdevice fields will be set to + * CDX_ANY_ID. + */ +#define CDX_DEVICE(vend, dev) \ + .vendor =3D (vend), .device =3D (dev), \ + .subvendor =3D CDX_ANY_ID, .subdevice =3D CDX_ANY_ID + /** * CDX_DEVICE_DRIVER_OVERRIDE - macro used to describe a CDX device with * override_only flags. @@ -48,10 +61,12 @@ typedef int (*cdx_dev_configure_cb)(struct cdx_controll= er *cdx, * @driver_override: the 32 bit CDX Device override_only * * This macro is used to create a struct cdx_device_id that matches only a - * driver_override device. + * driver_override device. The subvendor and subdevice fields will be set = to + * CDX_ANY_ID. */ #define CDX_DEVICE_DRIVER_OVERRIDE(vend, dev, driver_override) \ - .vendor =3D (vend), .device =3D (dev), .override_only =3D (driver_overrid= e) + .vendor =3D (vend), .device =3D (dev), .subvendor =3D CDX_ANY_ID,\ + .subdevice =3D CDX_ANY_ID, .override_only =3D (driver_override) =20 /** * struct cdx_ops - Callbacks supported by CDX controller. @@ -90,6 +105,10 @@ struct cdx_controller { * @cdx: CDX controller associated with the device * @vendor: Vendor ID for CDX device * @device: Device ID for CDX device + * @subsystem_vendor: Subsystem Vendor ID for CDX device + * @subsystem_device: Subsystem Device ID for CDX device + * @class: Class for the CDX device + * @revision: Revision of the CDX device * @bus_num: Bus number for this CDX device * @dev_num: Device number for this device * @res: array of MMIO region entries @@ -107,6 +126,10 @@ struct cdx_device { struct cdx_controller *cdx; u16 vendor; u16 device; + u16 subsystem_vendor; + u16 subsystem_device; + u32 class; + u8 revision; u8 bus_num; u8 dev_num; struct resource res[MAX_CDX_DEV_RESOURCES]; diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetabl= e.h index b0678b093cb2..aa3c28781248 100644 --- a/include/linux/mod_devicetable.h +++ b/include/linux/mod_devicetable.h @@ -935,6 +935,12 @@ enum { * struct cdx_device_id - CDX device identifier * @vendor: Vendor ID * @device: Device ID + * @subvendor: Subsystem vendor ID (or CDX_ANY_ID) + * @subdevice: Subsystem device ID (or CDX_ANY_ID) + * @class: Device class + * Most drivers do not need to specify class/class_mask + * as vendor/device is normally sufficient. + * @class_mask: Limit which sub-fields of the class field are compared. * @override_only: Match only when dev->driver_override is this driver. * * Type of entries in the "device Id" table for CDX devices supported by @@ -943,6 +949,10 @@ enum { struct cdx_device_id { __u16 vendor; __u16 device; + __u16 subvendor; + __u16 subdevice; + __u32 class; + __u32 class_mask; __u32 override_only; }; =20 diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-of= fsets.c index abe65f8968dd..7a659aa3114a 100644 --- a/scripts/mod/devicetable-offsets.c +++ b/scripts/mod/devicetable-offsets.c @@ -265,6 +265,10 @@ int main(void) DEVID(cdx_device_id); DEVID_FIELD(cdx_device_id, vendor); DEVID_FIELD(cdx_device_id, device); + DEVID_FIELD(cdx_device_id, subvendor); + DEVID_FIELD(cdx_device_id, subdevice); + DEVID_FIELD(cdx_device_id, class); + DEVID_FIELD(cdx_device_id, class_mask); DEVID_FIELD(cdx_device_id, override_only); =20 return 0; diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c index 38120f932b0d..abc4781d5db7 100644 --- a/scripts/mod/file2alias.c +++ b/scripts/mod/file2alias.c @@ -1458,6 +1458,10 @@ static int do_cdx_entry(const char *filename, void *= symval, { DEF_FIELD(symval, cdx_device_id, vendor); DEF_FIELD(symval, cdx_device_id, device); + DEF_FIELD(symval, cdx_device_id, subvendor); + DEF_FIELD(symval, cdx_device_id, subdevice); + DEF_FIELD(symval, cdx_device_id, class); + DEF_FIELD(symval, cdx_device_id, class_mask); DEF_FIELD(symval, cdx_device_id, override_only); =20 switch (override_only) { @@ -1475,6 +1479,10 @@ static int do_cdx_entry(const char *filename, void *= symval, =20 ADD(alias, "v", vendor !=3D CDX_ANY_ID, vendor); ADD(alias, "d", device !=3D CDX_ANY_ID, device); + ADD(alias, "sv", subvendor !=3D CDX_ANY_ID, subvendor); + ADD(alias, "sd", subdevice !=3D CDX_ANY_ID, subdevice); + ADD(alias, "c", class_mask =3D=3D 0xFFFFFF, class); + return 1; } =20 --=20 2.25.1