From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90454C001DC for ; Mon, 31 Jul 2023 09:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbjGaJAP (ORCPT ); Mon, 31 Jul 2023 05:00:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbjGaJAI (ORCPT ); Mon, 31 Jul 2023 05:00:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DACB6B7; Mon, 31 Jul 2023 02:00:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E75660F94; Mon, 31 Jul 2023 09:00:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAF5FC433C7; Mon, 31 Jul 2023 09:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794006; bh=Ae5cwFiKpnoFn/0C354AUzKQGPHUNIO2/eAg222GTVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hVLeMKnhpi6dglyr2Mpxhzj7fUyZI9TqiLI4iOVRhFvIjgUyOXpfVSapas+oXGyfG CPOiU2NxqAUZE03BtRmYMkk5yS2QSDDTp9PmzYs/6I1+/7glkbW0GBaE+Lm6K58tRq ommegD8nFdBbUEnHU0WxX6dTS+q4btrFydwmn0gRkCfBAK8qy5M7TNVYbfrXJWcmqf NMFUq1DXu/WBq86PBbwJVEpn5cn7t893EEcFMpKZXAxXM9cFaRo5tY74P9zLkh4zeP YY4CgYbzo3RqvRJCxkpma/p4JF6WqnoPc86nRNvEuD9J8uaYHdi7VHFOwc0jBQbEuk gxq2pJdd1LJWA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 1/7] tty: synclink_gt: convert CALC_REGADDR() macro to an inline Date: Mon, 31 Jul 2023 10:59:56 +0200 Message-ID: <20230731090002.15680-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It makes the code more readable and less error-prone as the result is returned and not stored in a variable newly defined inside the macro. Note that cast to 'unsigned long' and back to 'void *' was eliminated as info->reg_addr is 'char *' already (so the addition is per bytes already). This nicely cleans up the callers too. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/synclink_gt.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index 16e469e581ec..00efed2c139e 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -3734,47 +3734,47 @@ module_exit(slgt_exit); * register access routines */ =20 -#define CALC_REGADDR() \ - unsigned long reg_addr =3D ((unsigned long)info->reg_addr) + addr; \ - if (addr >=3D 0x80) \ - reg_addr +=3D (info->port_num) * 32; \ - else if (addr >=3D 0x40) \ - reg_addr +=3D (info->port_num) * 16; +static inline void __iomem *calc_regaddr(struct slgt_info *info, + unsigned int addr) +{ + void __iomem *reg_addr =3D info->reg_addr + addr; + + if (addr >=3D 0x80) + reg_addr +=3D info->port_num * 32; + else if (addr >=3D 0x40) + reg_addr +=3D info->port_num * 16; + + return reg_addr; +} =20 static __u8 rd_reg8(struct slgt_info *info, unsigned int addr) { - CALC_REGADDR(); - return readb((void __iomem *)reg_addr); + return readb(calc_regaddr(info, addr)); } =20 static void wr_reg8(struct slgt_info *info, unsigned int addr, __u8 value) { - CALC_REGADDR(); - writeb(value, (void __iomem *)reg_addr); + writeb(value, calc_regaddr(info, addr)); } =20 static __u16 rd_reg16(struct slgt_info *info, unsigned int addr) { - CALC_REGADDR(); - return readw((void __iomem *)reg_addr); + return readw(calc_regaddr(info, addr)); } =20 static void wr_reg16(struct slgt_info *info, unsigned int addr, __u16 valu= e) { - CALC_REGADDR(); - writew(value, (void __iomem *)reg_addr); + writew(value, calc_regaddr(info, addr)); } =20 static __u32 rd_reg32(struct slgt_info *info, unsigned int addr) { - CALC_REGADDR(); - return readl((void __iomem *)reg_addr); + return readl(calc_regaddr(info, addr)); } =20 static void wr_reg32(struct slgt_info *info, unsigned int addr, __u32 valu= e) { - CALC_REGADDR(); - writel(value, (void __iomem *)reg_addr); + writel(value, calc_regaddr(info, addr)); } =20 static void rdma_reset(struct slgt_info *info) --=20 2.41.0 From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA97C001DC for ; Mon, 31 Jul 2023 09:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjGaJAR (ORCPT ); Mon, 31 Jul 2023 05:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjGaJAK (ORCPT ); Mon, 31 Jul 2023 05:00:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E3283; Mon, 31 Jul 2023 02:00:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E97D160F2A; Mon, 31 Jul 2023 09:00:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D068C433CB; Mon, 31 Jul 2023 09:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794008; bh=HRgq8PnvNhpR3/55CfJPsOVwTF/5PMq6rz6tiVpFMTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BoZMXKWU9tJV0tkUTimjGAOnp/MFr3ph4Zf4a8PGkLvW6F0Oxnaua4udM0PgNYt7m dGIaSrax3BqYQ1bexEKE+N3UU8KRFm3ggetszu7MqISTcb1BaEEXVNaaaxGeAfIJ2F fPQJRFKLoXBcyD4LsJACB25PTHxCi+K/MqrR82ZPbeYlGsuh9/3wb35CV8ZNF2bEZT 1G7/NSK8WwG49sA3hcrjt6KSvwGGX+pH/3FP6UsRtx8N4R5CPX1Q1L9NNFJeimIOax 0cL+weqnv4CPLSxs2zR+KqomYmuGrw+o91lp/dLDNd9PPLFMoXoGa5kkH8r1wZCjfz ET+6PKS68AYNA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 2/7] tty: synclink_gt: drop global slgt_driver_name array Date: Mon, 31 Jul 2023 10:59:57 +0200 Message-ID: <20230731090002.15680-3-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It's used on one place, so put the containing string there directly. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/synclink_gt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index 00efed2c139e..c2ab7ecf0900 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -88,7 +88,6 @@ * module identification */ static char *driver_name =3D "SyncLink GT"; -static char *slgt_driver_name =3D "synclink_gt"; static char *tty_dev_prefix =3D "ttySLG"; MODULE_LICENSE("GPL"); #define MAX_DEVICES 32 @@ -3683,7 +3682,7 @@ static int __init slgt_init(void) =20 /* Initialize the tty_driver structure */ =20 - serial_driver->driver_name =3D slgt_driver_name; + serial_driver->driver_name =3D "synclink_gt"; serial_driver->name =3D tty_dev_prefix; serial_driver->major =3D ttymajor; serial_driver->minor_start =3D 64; --=20 2.41.0 From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DC9C001DC for ; Mon, 31 Jul 2023 09:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230482AbjGaJAY (ORCPT ); Mon, 31 Jul 2023 05:00:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbjGaJAL (ORCPT ); Mon, 31 Jul 2023 05:00:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024AEE9; Mon, 31 Jul 2023 02:00:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AF3760DFF; Mon, 31 Jul 2023 09:00:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C30F3C433CC; Mon, 31 Jul 2023 09:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794009; bh=Q8cO9OqlmUpHgysSy3lZuv3L9XFPNu27/Az5bHOtWnI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kEWZ7h0PajWZhY2EA136xYaMzlkL6izi0Hb/xdWCOs6b6p1hmjqsC1ntIglf7/U4s 9nOm5UCnHStSEayQLC0/Vd1I84cqyIhnNuzJNsf/m+rKLo7aIiJ6jQ1orOMdu/ZlMm TAE7zAS+FMNbt+EQarpPerH+C67YVtN/aTuxej6BDLk53wr5IdozWl3UZs/0Y8J4hZ d5haD6pG7iUxs82UpwIw0uq9ravWPDwE4fW1NiOv6erIeqK/+6V3UgT2D/1SQijDSr 4u6a9ZI7uRCIBlwAOZnpxzc5vs6zNgPH4NUTYAzrh5vFDojIhPFHAu2sxjRv3/WP2b yk06RiIIcUM3g== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 3/7] tty: synclink_gt: define global strings as const strings Date: Mon, 31 Jul 2023 10:59:58 +0200 Message-ID: <20230731090002.15680-4-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" And not non-const pointers to strings. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/synclink_gt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index c2ab7ecf0900..a8716a81ac74 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -87,8 +87,8 @@ /* * module identification */ -static char *driver_name =3D "SyncLink GT"; -static char *tty_dev_prefix =3D "ttySLG"; +static const char driver_name[] =3D "SyncLink GT"; +static const char tty_dev_prefix[] =3D "ttySLG"; MODULE_LICENSE("GPL"); #define MAX_DEVICES 32 =20 --=20 2.41.0 From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582ABC001E0 for ; Mon, 31 Jul 2023 09:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231184AbjGaJA1 (ORCPT ); Mon, 31 Jul 2023 05:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbjGaJAN (ORCPT ); Mon, 31 Jul 2023 05:00:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C7B0E0; Mon, 31 Jul 2023 02:00:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDAE860DFF; Mon, 31 Jul 2023 09:00:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EBB9C433C9; Mon, 31 Jul 2023 09:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794011; bh=koPLOXpSKm8PLNO/WcSVGaP713T9jox+3iKwaWka9XI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mOF/8lLKzsmsN3VeOBvafYS3/82sJF7zj7BOg9Dg9rwqWIk1unPCX2WwYyQpskZFJ 3x5XBLwN1FThAAt6r2RATPWfFy8f+HJts9itx+QU4lF2uxxon9kaG1fTEv+rL2vrLO pqcJGr0vhGjxDb2RniJEm3GMNbH34sHjUtICcfVlYxeHdFZ0Xhp6AOceE+aZ9mCGCp cV98SHnULawaB3+XFyyhQORoncvQqHYQj62mkz+VeZhruu/qLzxLTsO8llzvLROiPA iX0UOc+ehHAhgCqa1lOkbwn6AodHMYM7MDhkX9Bty5BF9ADoZ352xEhUl+R0YM2cS9 lNitkD0kr3ugw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 4/7] tty: synclink_gt: drop info messages from init/exit functions Date: Mon, 31 Jul 2023 10:59:59 +0200 Message-ID: <20230731090002.15680-5-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It is preferred NOT to print anything from init and exit functions of a module. (If everything goes fine.) Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/synclink_gt.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index a8716a81ac74..4a93e0e48156 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -3628,8 +3628,6 @@ static void slgt_cleanup(void) struct slgt_info *info; struct slgt_info *tmp; =20 - printk(KERN_INFO "unload %s\n", driver_name); - if (serial_driver) { for (info=3Dslgt_device_list ; info !=3D NULL ; info=3Dinfo->next_device) tty_unregister_device(serial_driver, info->line); @@ -3671,8 +3669,6 @@ static int __init slgt_init(void) { int rc; =20 - printk(KERN_INFO "%s\n", driver_name); - serial_driver =3D tty_alloc_driver(MAX_DEVICES, TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV); if (IS_ERR(serial_driver)) { @@ -3701,9 +3697,6 @@ static int __init slgt_init(void) goto error; } =20 - printk(KERN_INFO "%s, tty major#%d\n", - driver_name, serial_driver->major); - slgt_device_count =3D 0; if ((rc =3D pci_register_driver(&pci_driver)) < 0) { printk("%s pci_register_driver error=3D%d\n", driver_name, rc); @@ -3711,9 +3704,6 @@ static int __init slgt_init(void) } pci_registered =3D true; =20 - if (!slgt_device_list) - printk("%s no devices found\n",driver_name); - return 0; =20 error: --=20 2.41.0 From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8CA3C001DC for ; Mon, 31 Jul 2023 09:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbjGaJA3 (ORCPT ); Mon, 31 Jul 2023 05:00:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbjGaJAP (ORCPT ); Mon, 31 Jul 2023 05:00:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9343F4; Mon, 31 Jul 2023 02:00:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 72AF960F9B; Mon, 31 Jul 2023 09:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C84E4C433C7; Mon, 31 Jul 2023 09:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794012; bh=r05v/Z3avoaL+J176Epb/F0IBfdt+0+lEHtBxlv9Ftk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lRD8O0p0Klk8GRjsrovatlOKkNihWh//41kunvXqlkMzoIYRb68ZXcAa7L69HTeig pNrgLCCfU6seAw/gDhb7w2DvaihY62b3QPqlxaaz7dR7VLCdrS2ldI0fv1Q28SF5ma obpWNgb2DiUOr8iwVh4HmvMWRlCYDe+noWifTKxJ7K6uc2Q/SBFaNooCK5BBHRKh4v RQCYJU61M9KFgf3oXrC6MY9sMNZVAoxP3JEnbSE/DYzEEFdYagTbJFU0ZljgLe6bAz mcLHLnEGHgHfBygmTngE67uz3yrMUD0suXYk2NogU7CFP2kqEHYn6t2oYo3TPUxh7n i57BSH0Dl96+w== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 5/7] tty: synclink_gt: use PCI_VDEVICE Date: Mon, 31 Jul 2023 11:00:00 +0200 Message-ID: <20230731090002.15680-6-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It makes the device entries quite a bit readable. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/synclink_gt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index 4a93e0e48156..381b2e22fa96 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -93,11 +93,11 @@ MODULE_LICENSE("GPL"); #define MAX_DEVICES 32 =20 static const struct pci_device_id pci_table[] =3D { - {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,}, - {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT2_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,= }, - {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT4_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,= }, - {PCI_VENDOR_ID_MICROGATE, SYNCLINK_AC_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,}, - {0,}, /* terminate list */ + { PCI_VDEVICE(MICROGATE, SYNCLINK_GT_DEVICE_ID) }, + { PCI_VDEVICE(MICROGATE, SYNCLINK_GT2_DEVICE_ID) }, + { PCI_VDEVICE(MICROGATE, SYNCLINK_GT4_DEVICE_ID) }, + { PCI_VDEVICE(MICROGATE, SYNCLINK_AC_DEVICE_ID) }, + { 0 }, /* terminate list */ }; MODULE_DEVICE_TABLE(pci, pci_table); =20 --=20 2.41.0 From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A16FC001DC for ; Mon, 31 Jul 2023 09:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbjGaJAn (ORCPT ); Mon, 31 Jul 2023 05:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbjGaJAR (ORCPT ); Mon, 31 Jul 2023 05:00:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D4EE125; Mon, 31 Jul 2023 02:00:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF6B160FA0; Mon, 31 Jul 2023 09:00:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B3C3C433CB; Mon, 31 Jul 2023 09:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794014; bh=bqTVXbRunEpODgYOcmi3I5Ad7VnQnc4RQhFgP2aeJGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BP/VyGV5WZSSospGjdgCqfrdB69q2pOjibbP5kmw7UpdGI7w81E8/mtnPCOis6d5q /PSgBubVNxETXQ5EIMx0DRJ4hZld7g1+q6GGhonpo8F3/PFjpHQBi1cxtTwLzA5ehA fr0g6parwBSRuZ136O1NIElrVekImwZqZ4XOx2pG3ic1eaIwwZL6y6sAGye2wgtnj4 lX6MTPVX2EL+KUnFh8pIDFayjGWRPQznVqkzNVwlz8BvJRSY4LpjpJFn5Qp7hsKtmQ DlbKdDeQyRTwV9yGCZJnXVpgCeyG+3yCFaW16AzTHB/vYmBPbSu67Y5nObV8w5srIB +untWsPNXDXkA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 6/7] tty: synclink_gt: make default_params const Date: Mon, 31 Jul 2023 11:00:01 +0200 Message-ID: <20230731090002.15680-7-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" default_params are only read, so move them from .data to .rodata using 'const'. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/synclink_gt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index 381b2e22fa96..fe53e9c2c9b4 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -322,7 +322,7 @@ struct slgt_info { =20 }; =20 -static MGSL_PARAMS default_params =3D { +static const MGSL_PARAMS default_params =3D { .mode =3D MGSL_MODE_HDLC, .loopback =3D 0, .flags =3D HDLC_FLAG_UNDERRUN_ABORT15, --=20 2.41.0 From nobody Sun Feb 8 04:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06288C001DC for ; Mon, 31 Jul 2023 09:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbjGaJAq (ORCPT ); Mon, 31 Jul 2023 05:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230442AbjGaJAW (ORCPT ); Mon, 31 Jul 2023 05:00:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2666012A; Mon, 31 Jul 2023 02:00:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A005A60E15; Mon, 31 Jul 2023 09:00:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCF83C433BC; Mon, 31 Jul 2023 09:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690794016; bh=UKla50+Uu6d8/OdvxC4FOiwYL61SGfFkX9ZDiS9YrP8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VsDhmvWgW4QZM9grPr7Cmj5HuYUV+q6S0yZcCcletfKskOV1KilnuWr9R2f5hYlmB RpGt8f9Nj4QJD8RIuvywgYrvF/mJT9MpkJkz4UcPSnea0Ipi/huU1GvTXwdjhUOMpo h711XjUFkyGMXpaCo3G1+ZWoBy2/uBOz+V452i9gnLgZayHVFT+BQts6CB9YNz/SUv IR+isv6ZrYVCe4OFwG6xWmUEDRAF40ILue5U+rVCtWS/V5sCG7fVtX54D0YXlhbXqE +5Yn7gC40Kh8LbDPzWkIuLKM1bXwLLWzz0uLdOYP86wLCNhzueN1fo4ENb7L3zeHbn /9P9s7OCX3UzQ== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Chengfeng Ye Subject: [PATCH 7/7] tty: synclink_gt: mark as BROKEN Date: Mon, 31 Jul 2023 11:00:02 +0200 Message-ID: <20230731090002.15680-8-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org> References: <20230731090002.15680-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After walking and trying to clean up the worst in the driver, I came across the pci_driver::remove() _empty_ implementation. That would crash the system at least during hot-unplug (or write to remove in sysfs). There are many other problems: * Initialization + deinitialization apparently comes from no-hotplug support age. It needs a rewrite. * Hairy debug macros. Drop them. * Use of self-baked lists. Replace by list. * The order of the functions should be inverted and fwd decls dropped. * Coding style from the stone age. Fix. * I assume there are many bugs, but the code is unreadable at times, so hard to judge. There is one example posted [1]. I was able to find only one user back in 2016. So mark the driver as BROKEN for some time. Either someone will notice and we can bring the driver to this century. Or we will drop it completely if noone cares. [1] https://lore.kernel.org/all/20230728123901.64225-1-dg573847474@gmail.co= m/ Signed-off-by: Jiri Slaby (SUSE) Cc: Chengfeng Ye --- drivers/tty/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig index 341abaed4ce2..907a7cb1d186 100644 --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -236,6 +236,7 @@ config MOXA_SMARTIO config SYNCLINK_GT tristate "SyncLink GT/AC support" depends on SERIAL_NONSTANDARD && PCI + depends on BROKEN help Support for SyncLink GT and SyncLink AC families of synchronous and asynchronous serial adapters --=20 2.41.0