From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D10C001DC for ; Mon, 31 Jul 2023 08:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231824AbjGaIEj (ORCPT ); Mon, 31 Jul 2023 04:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbjGaIEL (ORCPT ); Mon, 31 Jul 2023 04:04:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E57A2133; Mon, 31 Jul 2023 01:02:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51A0560F73; Mon, 31 Jul 2023 08:02:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8000C433CB; Mon, 31 Jul 2023 08:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790568; bh=+zO7FyhxfQpim+6aXiX4wyEaVl0osOo9Jvm1XcJ4UJI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HWAi6/awhedagqhtUxkRfSFEcBp0m21vHP4yhbx1qdtbAYNtOaRV/42d3dD1ffs0J psw77i3kD1b6CspYgk+bxW6errj/WJ7o9HB7HHIx0uRUS+TXY4AShCup9tUxr1lXgq xQM172uelQ+mpcZU10nsf84+1nSg1miWa1fMygDxHWMAXFp1U4avA+b7WPd9NL/tUw XaCNHxvYHelZb7cnWSjY+4fJUynuU1/fgQu6+kcZc9FFWvvYycDmCeQVcFn/pMWSUZ /apXW0/CLyQ8MToM0R8AzCurEw5nH91+l0S+2YJXKuEsgQJro/XXKFwQoBqX4AGmC1 QV8leulMcBx3w== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 01/10] serial: move WARN_ON() in uart_write() to the condition Date: Mon, 31 Jul 2023 10:02:35 +0200 Message-ID: <20230731080244.2698-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" uart code currently does the following in uart_write() and uart_flush_buffer(): if (cond) { WARN_ON(1); return; } It can be rewritten to more obvious and more readable: if (WARN_ON(cond)) return; Do so. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/serial/serial_core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index 306ea1a560e6..e31c9b6bd8ab 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -593,10 +593,8 @@ static int uart_write(struct tty_struct *tty, * This means you called this function _after_ the port was * closed. No cookie for you. */ - if (!state) { - WARN_ON(1); + if (WARN_ON(!state)) return -EL3HLT; - } =20 port =3D uart_port_lock(state, flags); circ =3D &state->xmit; @@ -659,10 +657,8 @@ static void uart_flush_buffer(struct tty_struct *tty) * This means you called this function _after_ the port was * closed. No cookie for you. */ - if (!state) { - WARN_ON(1); + if (WARN_ON(!state)) return; - } =20 pr_debug("uart_flush_buffer(%d) called\n", tty->index); =20 --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD5DC001DC for ; Mon, 31 Jul 2023 08:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbjGaIFY (ORCPT ); Mon, 31 Jul 2023 04:05:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbjGaIES (ORCPT ); Mon, 31 Jul 2023 04:04:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6234E1713; Mon, 31 Jul 2023 01:02:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FC4E60E8B; Mon, 31 Jul 2023 08:02:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DE88C433C9; Mon, 31 Jul 2023 08:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790570; bh=iL+/iMkVyPpitc+31cYvs+uU/ZxRswV5+Wl1H0RRVAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kk8c18DLN8tYP5izkZrkGSFDhJrb7SeDZ2SJdORAd4uCe9aBlAuCYU4UpsXxCh1q7 nOQqzUT+G08qFcjMIIQ/pOIvdg2x0Z+65ju3cD8Z+9D7HHt45CFK7yUbIff/GI+JbK ijOILqb8o3+xF0Hiu5rwe3S86z9WyK1cqGTOMzVsiCFUu9Vm45Zg3OkfMjMOneoNtJ rZx01dTozdMNkVlKNj58/YqEESOGn3K9obS8F6L6epGPzJ9H5vi6fK1AOnbQ1PS/My AW78bF4WFORdBUyYEnCIV1MFh9lCHEl9Nif7xvBcpLJgjF4IG8zEiSJU8vAtd/YTMf 7eGVYk0787PsA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org Subject: [PATCH 02/10] Bluetooth: rfcomm: remove casts from tty->driver_data Date: Mon, 31 Jul 2023 10:02:36 +0200 Message-ID: <20230731080244.2698-3-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" tty->driver_data is 'void *', so there is no need to cast from that. Therefore remove the casts and assign the pointer directly. Signed-off-by: Jiri Slaby (SUSE) Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org --- net/bluetooth/rfcomm/tty.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c index 5697df9d4394..d73eec146529 100644 --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -771,7 +771,7 @@ static int rfcomm_tty_open(struct tty_struct *tty, stru= ct file *filp) =20 static void rfcomm_tty_close(struct tty_struct *tty, struct file *filp) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p dlc %p opened %d", tty, dev, dev->dlc, dev->port.count); @@ -781,7 +781,7 @@ static void rfcomm_tty_close(struct tty_struct *tty, st= ruct file *filp) =20 static int rfcomm_tty_write(struct tty_struct *tty, const unsigned char *b= uf, int count) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; struct rfcomm_dlc *dlc =3D dev->dlc; struct sk_buff *skb; int sent =3D 0, size; @@ -810,7 +810,7 @@ static int rfcomm_tty_write(struct tty_struct *tty, con= st unsigned char *buf, in =20 static unsigned int rfcomm_tty_write_room(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; int room =3D 0; =20 if (dev && dev->dlc) @@ -864,7 +864,7 @@ static void rfcomm_tty_set_termios(struct tty_struct *t= ty, u8 baud, data_bits, stop_bits, parity, x_on, x_off; u16 changes =3D 0; =20 - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p termios %p", tty, old); =20 @@ -996,7 +996,7 @@ static void rfcomm_tty_set_termios(struct tty_struct *t= ty, =20 static void rfcomm_tty_throttle(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p", tty, dev); =20 @@ -1005,7 +1005,7 @@ static void rfcomm_tty_throttle(struct tty_struct *tt= y) =20 static void rfcomm_tty_unthrottle(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p", tty, dev); =20 @@ -1014,7 +1014,7 @@ static void rfcomm_tty_unthrottle(struct tty_struct *= tty) =20 static unsigned int rfcomm_tty_chars_in_buffer(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p", tty, dev); =20 @@ -1029,7 +1029,7 @@ static unsigned int rfcomm_tty_chars_in_buffer(struct= tty_struct *tty) =20 static void rfcomm_tty_flush_buffer(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p", tty, dev); =20 @@ -1052,7 +1052,7 @@ static void rfcomm_tty_wait_until_sent(struct tty_str= uct *tty, int timeout) =20 static void rfcomm_tty_hangup(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p", tty, dev); =20 @@ -1061,7 +1061,7 @@ static void rfcomm_tty_hangup(struct tty_struct *tty) =20 static int rfcomm_tty_tiocmget(struct tty_struct *tty) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; =20 BT_DBG("tty %p dev %p", tty, dev); =20 @@ -1070,7 +1070,7 @@ static int rfcomm_tty_tiocmget(struct tty_struct *tty) =20 static int rfcomm_tty_tiocmset(struct tty_struct *tty, unsigned int set, u= nsigned int clear) { - struct rfcomm_dev *dev =3D (struct rfcomm_dev *) tty->driver_data; + struct rfcomm_dev *dev =3D tty->driver_data; struct rfcomm_dlc *dlc =3D dev->dlc; u8 v24_sig; =20 --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E45C001DC for ; Mon, 31 Jul 2023 08:05:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231906AbjGaIFp (ORCPT ); Mon, 31 Jul 2023 04:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231794AbjGaIEU (ORCPT ); Mon, 31 Jul 2023 04:04:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2ABD2696; Mon, 31 Jul 2023 01:02:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 312DC60F70; Mon, 31 Jul 2023 08:02:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63489C433C7; Mon, 31 Jul 2023 08:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790572; bh=CFCUO1q2jsK74UC2bwVz7miuEtn6Vz1wrsnbjpoYBoE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zxkxs5HlsQ22+uk6HxRfSnXVnkXQrgnRL0xYAU9zOhLxxVwnTltHXn3xkW5TIMaVA s2/ZkpjZZrsy8Yg47g2Yf6J1CiFdQWjIc8LClZCxbWSWsIx4BJBwYCTFv++rMjad0T bHa+WlPcEaoyuTPupPQn+KQzuiUUJlUe85LatZEg8/M7dVgtlx5YSXL2fBjUXkCtGR EeZxkxnt3IiL1s2w3nP4JNwjGIP/y34/uWg1PvxyRzGHy6wyoIRPcvYu2IFVYnJvdK Mm7KNXDq6EX4oP1juDpt5FVQYe8qiOOzMV4TeS1zxXzR4gLmFiHzfb0/A9xEBtChFX qmetPBluQldWA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 03/10] tty: hvsi: remove an extra variable from hvsi_write() Date: Mon, 31 Jul 2023 10:02:37 +0200 Message-ID: <20230731080244.2698-4-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'source' is the same as 'buf'. Rename the parameter ('buf') to 'source' and drop the local variable. Likely, the two were introduced to have a different type. But 'char' and 'unsigned char' are the same in the kernel for a long time. Signed-off-by: Jiri Slaby (SUSE) Cc: linuxppc-dev@lists.ozlabs.org --- drivers/tty/hvc/hvsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c index a200d01eceed..c1b8a4fd8b1e 100644 --- a/drivers/tty/hvc/hvsi.c +++ b/drivers/tty/hvc/hvsi.c @@ -905,10 +905,9 @@ static unsigned int hvsi_chars_in_buffer(struct tty_st= ruct *tty) } =20 static int hvsi_write(struct tty_struct *tty, - const unsigned char *buf, int count) + const unsigned char *source, int count) { struct hvsi_struct *hp =3D tty->driver_data; - const char *source =3D buf; unsigned long flags; int total =3D 0; int origcount =3D count; --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041A7C04E69 for ; Mon, 31 Jul 2023 08:05:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbjGaIFi (ORCPT ); Mon, 31 Jul 2023 04:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231789AbjGaIET (ORCPT ); Mon, 31 Jul 2023 04:04:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1CD4269D; Mon, 31 Jul 2023 01:02:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2101060F78; Mon, 31 Jul 2023 08:02:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1509FC433C9; Mon, 31 Jul 2023 08:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790574; bh=w3zM+yrYXpgkmIfhHdq6oR6kOfQGs28UkmPFxSAMjzY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mlBTAlXEYvnrKw+rnkk64Ny16BNI5CFUXkoWxTIm9o2vopncA27bmBEf3aaf4/NzG fCWedJkUbWt2tBE6EtlDgiEnm18UYa5en7G8C9j27TZOPkl1Q/bHnntBds0RMAwTUk 6k2D1EF6SeKGa6xdNJfjXZr7eIfi4Esj9SnsQVthYExQpDdGL98vrSducz/rlXlIKq 8GOM2tFaFwokemSZBrHWoJeAVCEQ4Oud77p7XN7QQ/+XOJkEPQ5dSSRkhU5nIi87hN G8vgJQ3u8T4Y3rF/1zJbjaUeiteVdY8RLuKcBgQLR4ua0+2t3lW+uDnL9K83DXg0bc Lrrcs+P6TeRgw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Dmitry Torokhov , linux-input@vger.kernel.org Subject: [PATCH 04/10] input: serport: remove casts from tty->disc_data Date: Mon, 31 Jul 2023 10:02:38 +0200 Message-ID: <20230731080244.2698-5-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" tty->disc_data is 'void *', so there is no need to cast from that. Therefore remove the casts and assign the pointer directly. Signed-off-by: Jiri Slaby (SUSE) Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Acked-by: Dmitry Torokhov --- drivers/input/serio/serport.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c index 7f7ef0e3a749..a5d8953f5904 100644 --- a/drivers/input/serio/serport.c +++ b/drivers/input/serio/serport.c @@ -103,7 +103,7 @@ static int serport_ldisc_open(struct tty_struct *tty) =20 static void serport_ldisc_close(struct tty_struct *tty) { - struct serport *serport =3D (struct serport *) tty->disc_data; + struct serport *serport =3D tty->disc_data; =20 kfree(serport); } @@ -117,7 +117,7 @@ static void serport_ldisc_close(struct tty_struct *tty) static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *cp, const char *fp, int count) { - struct serport *serport =3D (struct serport*) tty->disc_data; + struct serport *serport =3D tty->disc_data; unsigned long flags; unsigned int ch_flags =3D 0; int i; @@ -161,7 +161,7 @@ static ssize_t serport_ldisc_read(struct tty_struct * t= ty, struct file * file, unsigned char *kbuf, size_t nr, void **cookie, unsigned long offset) { - struct serport *serport =3D (struct serport*) tty->disc_data; + struct serport *serport =3D tty->disc_data; struct serio *serio; =20 if (test_and_set_bit(SERPORT_BUSY, &serport->flags)) @@ -245,7 +245,7 @@ static int serport_ldisc_compat_ioctl(struct tty_struct= *tty, =20 static void serport_ldisc_hangup(struct tty_struct *tty) { - struct serport *serport =3D (struct serport *) tty->disc_data; + struct serport *serport =3D tty->disc_data; unsigned long flags; =20 spin_lock_irqsave(&serport->lock, flags); @@ -257,7 +257,7 @@ static void serport_ldisc_hangup(struct tty_struct *tty) =20 static void serport_ldisc_write_wakeup(struct tty_struct * tty) { - struct serport *serport =3D (struct serport *) tty->disc_data; + struct serport *serport =3D tty->disc_data; unsigned long flags; =20 spin_lock_irqsave(&serport->lock, flags); --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097D1C001DC for ; Mon, 31 Jul 2023 08:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbjGaIFv (ORCPT ); Mon, 31 Jul 2023 04:05:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbjGaIEX (ORCPT ); Mon, 31 Jul 2023 04:04:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E213426A3; Mon, 31 Jul 2023 01:02:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B31260F5E; Mon, 31 Jul 2023 08:02:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECEAAC43395; Mon, 31 Jul 2023 08:02:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790577; bh=t10N72oEfrdWvctrgvxTa70mihQMypTsXP5is3fxQas=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YFMtHrIhFzDSxjMCDs1WdZHEIKSx1+VX1YOY/dFgDZvmbzMGfH3RP0d+HhZhoU19t hZlT/E0OjVoFFCdn2M8gZRsVrZNFE2xg83Ly7od1GPm5C1479rkTdgj2CLZwfW4StB Twg4NRjSSaCFE4FsvZnKpqxXBAEeeD+q1lGqu2NjPqo2pBNKFOQ5tJgchlY82DRpY/ y7G0cT1PMK0AtF+xJ/BnB89INOyuzs3Ym2JPcAl0VlkWU7chVbYhaAI4cIrdI563VT p2H/YQNsB5sSXBMzPudyFIfUmPr6nK0XXZhNJbJcf8VxCiGpnxOSlqz7nQVXFZT6aP dJpIUIMMVM3Cw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Dario Binacchi , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 05/10] can: slcan: remove casts from tty->disc_data Date: Mon, 31 Jul 2023 10:02:39 +0200 Message-ID: <20230731080244.2698-6-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" tty->disc_data is 'void *', so there is no need to cast from that. Therefore remove the casts and assign the pointer directly. Signed-off-by: Jiri Slaby (SUSE) Cc: Dario Binacchi Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-can@vger.kernel.org Cc: netdev@vger.kernel.org Acked-by: Marc Kleine-Budde --- drivers/net/can/slcan/slcan-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slc= an-core.c index f4db77007c13..371af9d17b14 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -583,7 +583,7 @@ static void slcan_transmit(struct work_struct *work) */ static void slcan_write_wakeup(struct tty_struct *tty) { - struct slcan *sl =3D (struct slcan *)tty->disc_data; + struct slcan *sl =3D tty->disc_data; =20 schedule_work(&sl->tx_work); } @@ -778,7 +778,7 @@ static void slcan_receive_buf(struct tty_struct *tty, const unsigned char *cp, const char *fp, int count) { - struct slcan *sl =3D (struct slcan *)tty->disc_data; + struct slcan *sl =3D tty->disc_data; =20 if (!netif_running(sl->dev)) return; @@ -862,7 +862,7 @@ static int slcan_open(struct tty_struct *tty) */ static void slcan_close(struct tty_struct *tty) { - struct slcan *sl =3D (struct slcan *)tty->disc_data; + struct slcan *sl =3D tty->disc_data; =20 unregister_candev(sl->dev); =20 @@ -886,7 +886,7 @@ static void slcan_close(struct tty_struct *tty) static int slcan_ioctl(struct tty_struct *tty, unsigned int cmd, unsigned long arg) { - struct slcan *sl =3D (struct slcan *)tty->disc_data; + struct slcan *sl =3D tty->disc_data; unsigned int tmp; =20 switch (cmd) { --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC62C001DF for ; Mon, 31 Jul 2023 08:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231908AbjGaIFy (ORCPT ); Mon, 31 Jul 2023 04:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231752AbjGaIE2 (ORCPT ); Mon, 31 Jul 2023 04:04:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07AE51716; Mon, 31 Jul 2023 01:03:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBC4860F7C; Mon, 31 Jul 2023 08:02:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 174A0C433C7; Mon, 31 Jul 2023 08:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790579; bh=K+H/hoatehbQhPWW2mUSJBRDUhbE9sguuS2KLp9LDIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uDrqDxWrJYHNWB0bT+ULXoW5jX5anh43k3Ky2ZjVFk8aL7n0JQTodkmshwOD33EX3 1XvYrwsVcv6rbxAF8rXRlELFtptPGLzxZtI3WwLMPZ4WJqXdhEFn6r+0EPmYSLcEkB VpuWbddDgNdjodeainAp8fEDjRmMiZJpBpOnH0DYj1HukED29A+zm1Q30P5DOnz6f3 kp9cz/vixcsJzAN5yRIHaJ5Jcr4Vac049lFnk+YeNUFax9Wds8I0gNeopvwq0Zup6/ n+FkpwWDvnPhmm0sdOlYJNIKK0kgNcGEQPq5VyWVUS+v7p1Qrhbp0jwn0Zw+1gwBJc BjHqrS1+vl3EQ== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Tobias Klauser Subject: [PATCH 06/10] serial: altera_jtaguart: switch status to u32 Date: Mon, 31 Jul 2023 10:02:40 +0200 Message-ID: <20230731080244.2698-7-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'status' is assigned a result from readl(). There is no need for the variable to be 'unsigned long'. readl() returns 32bit values. Provided, this is a Nios II driver (32-bit), there is no change in semantics. This only makes the type explicit. Signed-off-by: Jiri Slaby (SUSE) Cc: Tobias Klauser Acked-by: Tobias Klauser --- drivers/tty/serial/altera_jtaguart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/alte= ra_jtaguart.c index 6203ca1de769..5fab4c978891 100644 --- a/drivers/tty/serial/altera_jtaguart.c +++ b/drivers/tty/serial/altera_jtaguart.c @@ -110,7 +110,7 @@ static void altera_jtaguart_set_termios(struct uart_por= t *port, =20 static void altera_jtaguart_rx_chars(struct uart_port *port) { - unsigned long status; + u32 status; u8 ch; =20 while ((status =3D readl(port->membase + ALTERA_JTAGUART_DATA_REG)) & --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755B4C001DC for ; Mon, 31 Jul 2023 08:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbjGaIGH (ORCPT ); Mon, 31 Jul 2023 04:06:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231618AbjGaIE2 (ORCPT ); Mon, 31 Jul 2023 04:04:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C01331723; Mon, 31 Jul 2023 01:03:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F2D560F88; Mon, 31 Jul 2023 08:03:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC12AC433CA; Mon, 31 Jul 2023 08:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790581; bh=C858cK3IVRNBXL+ZU9kIJwJE3Aayva8V0BpdDOTGA+U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PSfKM7Y/XKWiZVda4hE1vXwfE+9O+P0VIbGOboHfp4xgihTCSrGVI4zJe5XSnwP9l tEptjpG8SKH9dHic4SLTjn/T6KHZwyf3pyTkYOJ17uvlDioTO56Y5OvTNBp5ABR+Wj g/aEJi016EWFYE/3uZmMMMpMXEEm/nMocfVkpHwow8Gc0tDMMFhAIhifHh+MyjOAx2 5MBUNM0hIEmYo1nk0kIhR3xfALs2MRtL/+NU19GOUirBuDCjEO87e+3wXSUFkZhmdF 82cJxPIGL32qt7673QP27eE+NAEfG3LDayJNdOXWNiiG2h8yhomvqIp3RdjHIw/gx8 kRCnoPP+BTAKg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , speakup@linux-speakup.org Subject: [PATCH 07/10] speakup: switch to unsigned iterator in spk_ttyio_receive_buf2() Date: Mon, 31 Jul 2023 10:02:41 +0200 Message-ID: <20230731080244.2698-8-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Now, that spk_ttyio_receive_buf2() receives an unsigned count, the iterator can/should be unsigned too. Switch to that to be explicit. Signed-off-by: Jiri Slaby (SUSE) Cc: William Hubbs Cc: Chris Brannon Cc: Kirk Reiser Cc: Samuel Thibault Cc: speakup@linux-speakup.org --- drivers/accessibility/speakup/spk_ttyio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accessibility/speakup/spk_ttyio.c b/drivers/accessibil= ity/speakup/spk_ttyio.c index 07373b3debd1..5d4bafe118ec 100644 --- a/drivers/accessibility/speakup/spk_ttyio.c +++ b/drivers/accessibility/speakup/spk_ttyio.c @@ -79,7 +79,7 @@ static int spk_ttyio_receive_buf2(struct tty_struct *tty, struct spk_synth *synth =3D ldisc_data->synth; =20 if (synth->read_buff_add) { - int i; + unsigned int i; =20 for (i =3D 0; i < count; i++) synth->read_buff_add(cp[i]); --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC826C001DC for ; Mon, 31 Jul 2023 08:06:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231860AbjGaIGO (ORCPT ); Mon, 31 Jul 2023 04:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230357AbjGaIEd (ORCPT ); Mon, 31 Jul 2023 04:04:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BEB61724; Mon, 31 Jul 2023 01:03:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02E4160F77; Mon, 31 Jul 2023 08:03:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3261DC433C9; Mon, 31 Jul 2023 08:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790583; bh=6sCzu84ZbNFeuecmBcFu3cCZGqCgnMZYTlY4wKquDdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sqIK16KsZ0ZT6eMsToQp0hx9VJoCyerLkUrrq/zljD3OZLcpyVXHWxxKBfkVHHuz1 gv/u+bm+Krjnb+eCyXAHaTpu0ukPWjDM+jissvtq3y4bgIzRbcLBadshpgfNaZDCxc UB3CLZVCMeQ4A/cxnkgxaEgOizu/uyUGwN5pCtcwxczcyYbwhrl3UsAr3tEsMI0Kyf 3aGdzyLzyPbMy3eJpW3F7vsJjMefg62ukSiF2I5/a2/zCxV1Vy4vLqCw1EwogcO2Rc GgyZtf0ZCutLbe4Lhnh669GJ54MOasDH2gpdyDNXeztYxOQq5ejehL5CRmUz68WNsV CrvDFIDjW+Hxg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Arnd Bergmann Subject: [PATCH 08/10] misc: ti-st: remove forward declarations and make st_int_recv() static Date: Mon, 31 Jul 2023 10:02:42 +0200 Message-ID: <20230731080244.2698-9-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" st_kim_recv() is already declared in linux/ti_wilink_st.h. Given that is already included in st_core.c, drop the re-declaration from there. st_int_recv() is used only in st_core.c and the forward declaration is not needed. So drop the declaration and make the function static. Signed-off-by: Jiri Slaby (SUSE) Cc: Arnd Bergmann --- drivers/misc/ti-st/st_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index 01d2257deea4..389901276ce3 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -16,8 +16,6 @@ =20 #include =20 -extern void st_kim_recv(void *, const unsigned char *, long); -void st_int_recv(void *, const unsigned char *, long); /* * function pointer pointing to either, * st_kim_recv during registration to receive fw download responses @@ -225,7 +223,7 @@ static inline void st_wakeup_ack(struct st_data_s *st_g= data, * HCI-Events, ACL, SCO, 4 types of HCI-LL PM packets * CH-8 packets from FM, CH-9 packets from GPS cores. */ -void st_int_recv(void *disc_data, +static void st_int_recv(void *disc_data, const unsigned char *data, long count) { char *ptr; --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F3FFC001DC for ; Mon, 31 Jul 2023 08:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231872AbjGaIG1 (ORCPT ); Mon, 31 Jul 2023 04:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbjGaIEd (ORCPT ); Mon, 31 Jul 2023 04:04:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 329321726; Mon, 31 Jul 2023 01:03:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7E8D60F30; Mon, 31 Jul 2023 08:03:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D742FC433C7; Mon, 31 Jul 2023 08:03:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790585; bh=T3RQZEVjTUZC7k/WLvQaJ7ITDbA5hvLXPQp0OeU6JrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CNwYGjhcyLi8C4NJpFWurdq5mW5ku7Ny666lC5umnleK884pj1POi11FdwHUEZGuD HUJa6+IIstHWyakiconglNzRx9ZcGO9fbyShhH6R3cnJIBWTWM0T6Ay70nFuC0mRK4 K7exCSnkq9/P3FqcG80Kfk/05TqPFEi+ma29tggvBoI5lE9pgflhbue5b50Y9i0GPu sMgJcn7mCbJoxmLm55bzdJPABvG/0r8PGPtzZh5oafDauSgxbLfO4MeyKLaHd51nmg M1RhAyFZldrdqvlIm9qm+EAZ0jvU5aCzZUgQaJCpx3ev49E3I5UGQ8awZZGkXeyaTa BYnLqoovmVzzg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Arnd Bergmann Subject: [PATCH 09/10] misc: ti-st: remove ptr from recv functions Date: Mon, 31 Jul 2023 10:02:43 +0200 Message-ID: <20230731080244.2698-10-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" ptr is the same as data, so use ptr directly as a parameter and drop the useless local variable. Likely, the two were introduced to have a different type. But 'char' and 'unsigned char' are the same in the kernel for a long time. Signed-off-by: Jiri Slaby (SUSE) Cc: Arnd Bergmann --- drivers/misc/ti-st/st_core.c | 4 +--- drivers/misc/ti-st/st_kim.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index 389901276ce3..e2add50b191c 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -224,9 +224,8 @@ static inline void st_wakeup_ack(struct st_data_s *st_g= data, * CH-8 packets from FM, CH-9 packets from GPS cores. */ static void st_int_recv(void *disc_data, - const unsigned char *data, long count) + const unsigned char *ptr, long count) { - char *ptr; struct st_proto_s *proto; unsigned short payload_len =3D 0; int len =3D 0; @@ -235,7 +234,6 @@ static void st_int_recv(void *disc_data, struct st_data_s *st_gdata =3D (struct st_data_s *)disc_data; unsigned long flags; =20 - ptr =3D (char *)data; /* tty_receive sent null ? */ if (unlikely(ptr =3D=3D NULL) || (st_gdata =3D=3D NULL)) { pr_err(" received null from TTY "); diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index f2f6cab97c08..8c801897ffa2 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -128,15 +128,13 @@ static inline int kim_check_data_len(struct kim_data_= s *kim_gdata, int len) * tty_receive and hence the logic */ static void kim_int_recv(struct kim_data_s *kim_gdata, - const unsigned char *data, long count) + const unsigned char *ptr, long count) { - const unsigned char *ptr; int len =3D 0; unsigned char *plen; =20 pr_debug("%s", __func__); /* Decode received bytes here */ - ptr =3D data; if (unlikely(ptr =3D=3D NULL)) { pr_err(" received null from TTY "); return; --=20 2.41.0 From nobody Mon Feb 9 05:52:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28DDC001DC for ; Mon, 31 Jul 2023 08:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbjGaIGa (ORCPT ); Mon, 31 Jul 2023 04:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231869AbjGaIEe (ORCPT ); Mon, 31 Jul 2023 04:04:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C409E1A6; Mon, 31 Jul 2023 01:03:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6170B60F33; Mon, 31 Jul 2023 08:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 882C2C433C9; Mon, 31 Jul 2023 08:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690790586; bh=+2+5Tnk3+q3dIP9/bYUXB3vDyW94Doym0JZK1jfkQpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fkoKyimKveikThTww6CG4ac9bXEwuyUSo1neOBMVcQrK84SM2A80Qhb7TEr9ptBhX CWHxlZWvIp7ntSAIW1ifiJBHuY94tsuBJ/erROBMHJd1f8le+MAAh/raO9wBH1zmai RM2BDg0tDqzaFQtKpW4YrlCBtgCH3cmtygr8nb0uuISuKevTLvGELTzZSKh+VHXGJb cNHnXHIKHwJock1jDKepc5AbC+TIqW6gACjRUBwyTWs7IZMZdzkUN9wQee0a9dIdzs gHZVixrhMnnt3YoJX8wXFrMYG/cEAillAeHkFMjbIibhOTNJbrx9BIYGWJTmMO9qfP nEAYEA8ZmalTg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Arnd Bergmann Subject: [PATCH 10/10] misc: ti-st: don't check for tty data == NULL Date: Mon, 31 Jul 2023 10:02:44 +0200 Message-ID: <20230731080244.2698-11-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230731080244.2698-1-jirislaby@kernel.org> References: <20230731080244.2698-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" tty data passed to tty_ldisc_ops::receive_buf() are never NULL. Remove this check. Signed-off-by: Jiri Slaby (SUSE) Cc: Arnd Bergmann --- drivers/misc/ti-st/st_core.c | 3 +-- drivers/misc/ti-st/st_kim.c | 5 ----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index e2add50b191c..3b2145722bd7 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -234,8 +234,7 @@ static void st_int_recv(void *disc_data, struct st_data_s *st_gdata =3D (struct st_data_s *)disc_data; unsigned long flags; =20 - /* tty_receive sent null ? */ - if (unlikely(ptr =3D=3D NULL) || (st_gdata =3D=3D NULL)) { + if (st_gdata =3D=3D NULL) { pr_err(" received null from TTY "); return; } diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index 8c801897ffa2..5431a89924aa 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -135,11 +135,6 @@ static void kim_int_recv(struct kim_data_s *kim_gdata, =20 pr_debug("%s", __func__); /* Decode received bytes here */ - if (unlikely(ptr =3D=3D NULL)) { - pr_err(" received null from TTY "); - return; - } - while (count) { if (kim_gdata->rx_count) { len =3D min_t(unsigned int, kim_gdata->rx_count, count); --=20 2.41.0