From nobody Mon Feb 9 14:31:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD07EB64DD for ; Sun, 30 Jul 2023 21:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbjG3V6R (ORCPT ); Sun, 30 Jul 2023 17:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjG3V6P (ORCPT ); Sun, 30 Jul 2023 17:58:15 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71052BB for ; Sun, 30 Jul 2023 14:58:14 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-3490a1f8ba4so6246815ab.3 for ; Sun, 30 Jul 2023 14:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754294; x=1691359094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; b=XzBrK3fiUVV+Qw4FCBmhAFwh1M0BxMpb4QGOJCxG7oDqhsffTtg/qFqxOVRqkaqopU MLw7n8YGvbNiZ6khvhNn+Jt/Z3E+WMCbucPJv2IQ4lolvyur+F5jlnJarCaSME/UkEku 9F6Ja5BmoEkjw3Wr2+chJjJaBE+ONMPflSSvi2Tl+Gqmb2+wSbGpHDqUbJUPKdMr4rdh 5qBAI6BIgkp+++m+RHQShsg9LkzNA2p44oaJDMiOGM8bkXK6SO7+lWEEo2a/ncPoyRfX XB9cWkYe2V2JmnCJ5S5jV0DVJLrbsFyJVNuO4xx2K88BM0faTo0inK4m4XzVUR4czgsv rykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754294; x=1691359094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; b=PpK3hBCYwN8l9Vb+Nc7EkBTLUklLlms8x7/HDFluPFx/WCu2nlk53SFRIjthW2mqk6 yo9M7vcVe2EV/sBW0Om3BTjfjV0KxBPQqAWNheJ10F6vXMz21pWBJ2/8K1HwfA5jJQ6z ib0qpvgPZNnBLR0+Lg4UQaEDPfw2RbKfz6ws3OfKpYYTrsKUvxlUBDqnjepkdwDWmcfV h3c44P5iN/nY2rOXJCqYoD8jIcqIlZlCXhQubrwRebq/foLrd00alMDw6oOoP/Ur3v1M odgUkG1y/DqhjO1EpTIUZxhbX3hR1GRywAg9jhXOhKikMvWNqbQV7zhnpjGyHksLCqUY 0S9w== X-Gm-Message-State: ABy/qLYz2uGqJzu3qxvxPRcy7ONcCxVjD2LZ350CFY9cn0R03tnwWgti 7cJ9RCuVW3NjL7ZAcCCV2/A= X-Google-Smtp-Source: APBJJlH6xhZtbgvn4c0B+kMVYzCY+kgywJH6WENm9VN8LteRzuOqbTqqERlfoNBE7GYEfulDvwvIaA== X-Received: by 2002:a05:6e02:931:b0:348:c57f:b016 with SMTP id o17-20020a056e02093100b00348c57fb016mr5734702ilt.3.1690754293582; Sun, 30 Jul 2023 14:58:13 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:13 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Anitha Chrisanthus , Edmund Dea Subject: [PATCH 1/5] drm_dbg: add trailing newlines to remaining callsites Date: Sun, 30 Jul 2023 15:57:50 -0600 Message-ID: <20230730215758.54010-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" All callers should uniformly include a trailing newline, the vast majority already do: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in this and next commits (split for easy acks). No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch =3D 0; vm.hsync_len =3D 28; =20 - drm_dbg(dev, "%s : %dactive height=3D %d vbp=3D%d vfp=3D%d vsync-w=3D%d h= -active=3D%d h-bp=3D%d h-fp=3D%d hsync-l=3D%d", + drm_dbg(dev, "%s : %dactive height=3D %d vbp=3D%d vfp=3D%d vsync-w=3D%d h= -active=3D%d h-bp=3D%d h-fp=3D%d hsync-l=3D%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp =3D mode->vsync_start - mode->vdisplay; =20 if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height =3D %d less than %d", + drm_dbg(dev, "height =3D %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width =3D %d less than %d", + drm_dbg(dev, "width =3D %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh =3D drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh =3D %d less than %d or greater than %d", + drm_dbg(dev, "refresh =3D %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } =20 if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp =3D %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp =3D %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } =20 diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plan= e.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *= plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format !=3D format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configurati= on"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configurati= on\n"); return -EINVAL; } for (i =3D 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *pla= ne, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width !=3D fb->width || init_disp_cfg.height !=3D fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial co= nfiguration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial co= nfiguration\n"); return -EINVAL; } can_position =3D (plane->type =3D=3D DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *p= lane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock); --=20 2.41.0 From nobody Mon Feb 9 14:31:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC29AEB64DD for ; Sun, 30 Jul 2023 21:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbjG3V60 (ORCPT ); Sun, 30 Jul 2023 17:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjG3V6Y (ORCPT ); Sun, 30 Jul 2023 17:58:24 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55839171F for ; Sun, 30 Jul 2023 14:58:20 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-34642952736so21639965ab.3 for ; Sun, 30 Jul 2023 14:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754299; x=1691359099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nOewQfiuna8cVbGW5XrkGFy/hH53YPAnw6xDAt3LB98=; b=DKqR8ijCyupw8t6lZBwoDKFigkZROGJMEnXL0h+oDYIWwrL9txDkSZwkw8qDxS3soa c3XjOLuZrGWsm9OD3KHhrpaHR8GLxe/CB5Ro1EaU9VacZqveIVmsH8CsmTBO++Xaw043 S9c6oT2auG+ybCgccn4OLLiMrn6/XVSvAF3xW6fHj3I96dLrXCCEGBqomm+i4JrtxKNP 4IzSucxKUjtCeXcpYBmuwY5QKkQKoRM3oL5rXZFv2h34c6/mpHNp06uALNOSgH9FacqC 9CA1m/gl3qLd2CeJGFNDiLv4DsucE5zaM45Bd6PL+T/8Hi3WkinQ5SEFRhcOE5+BRjef 0hQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754299; x=1691359099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nOewQfiuna8cVbGW5XrkGFy/hH53YPAnw6xDAt3LB98=; b=ebC8DQPrVK0kOy6HQkJd8D/+5FC0KdEd4zBws4sTOmUyOwpZSvw9IZteHUjSBhxyQz 6O/Xr/cDspBhpFFGXCeNQJvhJoL6kg3TqKcDbxaRZdX3TocW223vFZJNSDTJ++YCs0Mz 6GD2hDUQsW6z2Ti16IxKhGH1OQBl+qI2/6xO7Bnn7v5s9AJuFmzCzRrHSNm16GIQF9nv b5B5C/YJ2TmdMNG0qe71D6MWyF7lzycFRhPN4fle6UKyx417v4in49wR/S4hWdwuFCfd llajfgIMQyzR2SexPt483U+0FjdzvDOwMaeM5sTb4SWNZCb30ypHDMwfrwRLqYOiyC48 NI4w== X-Gm-Message-State: ABy/qLZhR/N5IQoqwnVpE2nZL/8JdhI3PENaq0w/Wa8MCvZX7TyA9D9S oCy+eCb/ucReXRZ9iLjRvM8= X-Google-Smtp-Source: APBJJlE+/l1vuBJeosdUA7YLF9Qwd6Adbkqlh0UuNChyRu2idYwLmWELfaF8uOq6UyjwQhIZGytVZw== X-Received: by 2002:a05:6e02:134e:b0:340:8cb1:aaa8 with SMTP id k14-20020a056e02134e00b003408cb1aaa8mr6815096ilr.21.1690754299458; Sun, 30 Jul 2023 14:58:19 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:19 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Imre Deak , Mika Kahola , Lucas De Marchi , Andrzej Hajda , Matthew Auld , Daniele Ceraolo Spurio , "Jason A. Donenfeld" , Rob Clark , Niranjana Vishwanathapura , Chris Wilson Subject: [PATCH 2/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:51 -0600 Message-ID: <20230730215758.54010-3-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Jim Cromie --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i91= 5/display/intel_ddi.c index 3a7b98837516..993ba9f01018 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -3808,7 +3808,7 @@ static int intel_ddi_compute_config_late(struct intel= _encoder *encoder, struct drm_connector *connector =3D conn_state->connector; u8 port_sync_transcoders =3D 0; =20 - drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]", + drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]\n", encoder->base.base.id, encoder->base.name, crtc_state->uapi.crtc->base.id, crtc_state->uapi.crtc->name); =20 diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/d= rm/i915/gem/i915_gem_execbuffer.c index 3aeede6aee4d..c7daae828792 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1428,7 +1428,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { drm_dbg(&i915->drm, "reloc with multiple write domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, @@ -1439,7 +1439,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, & ~I915_GEM_GPU_DOMAINS)) { drm_dbg(&i915->drm, "reloc with read/write non-GPU domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, --=20 2.41.0 From nobody Mon Feb 9 14:31:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20B7EB64DD for ; Sun, 30 Jul 2023 21:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229799AbjG3V6c (ORCPT ); Sun, 30 Jul 2023 17:58:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjG3V63 (ORCPT ); Sun, 30 Jul 2023 17:58:29 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39337172C; Sun, 30 Jul 2023 14:58:23 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7866189cff1so223446139f.0; Sun, 30 Jul 2023 14:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754302; x=1691359102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dzT1NtmhVPgMEzc8/Vu/DYGCtAi6F3prLfzQtzunD4A=; b=i0VV1Pxf7fG96sx0/4My6LgaDnMdoakFvgPb0GqVsaBE0OE88LPAs1C1z/LFiLzGY5 tK1P659w0nu2hKiaVoiKdy0SSV51ZlEFs7/CvGJkv6PZFbBdo/R3QRsLeXdRm7XDC7O9 wdfHH3f0+y2lP3D4FCSXCk8XG7edQ5vLizkTzo3oJESZdEuVmPQAuLS37O0S5Smj3X5w 7omb+y63UjShSSAZwWtxVTQuLG+fBkZSNtQrEhVlp8snane6OWnw89sObWaAS8FCbao2 fVuSfXU/JV8oMmCqhR0azQwVHqLzvgLTHx2O7JPpxlBqAO6ok++yOGD8Jat+Qlr4jLNA /YNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754302; x=1691359102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dzT1NtmhVPgMEzc8/Vu/DYGCtAi6F3prLfzQtzunD4A=; b=BgTqcosHqUhG45QhPwDDoX4cpLPSdeIliEirYJRxM5ID9AcXQTb1igItARl2+P6xoS OfKfGw/MRxEXmUrvc3H/Y5WAcTuNbW+Kwx4Rg1UmNg9R6v9Z/0WhmxnOqNoi7mrNhVqD i0puSXRqp8OSo/JCMojgQNPV6ngTsSphJmKuQqPDSs8ymbrPlAnTGUQn8ESBDZQ+3J70 nYxbUlbQT6hBCveKEN6WECIZvyjXmYIMhLk/F7Kqg2dRTUFpwWgjTJpyVaWnNhdMXmfS rTmsWJ+g3iPxZE6EU4l+uPs+REv+gjkTqH21UtOLotfBHyoA4WHTjIyMcCpgD4Gkp8h9 U7eg== X-Gm-Message-State: ABy/qLaxPp8ZGJ8vkCNd0amU/s5lXboP5JVy+9Rd7PFRwoBHTSj/K0f5 PIqY6crPegixFshUWepJHuw= X-Google-Smtp-Source: APBJJlH4diQF/gKGaFZFV2noWGnmxyr7j4k1TEOXzKb7Z048RyRdykHNxKRIZVn7OfF540vKITQnhg== X-Received: by 2002:a05:6e02:218d:b0:346:d51:9922 with SMTP id j13-20020a056e02218d00b003460d519922mr8975282ila.13.1690754302289; Sun, 30 Jul 2023 14:58:22 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:21 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 3/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:52 -0600 Message-ID: <20230730215758.54010-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Jim Cromie --- drivers/gpu/drm/msm/msm_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index e3f61c39df69..80166f702a0d 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, =20 for (i =3D 0; i < n; i++) { ret =3D msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); - drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", + drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n", fb->base.id, i, msm_fb->iova[i], ret); if (ret) return ret; @@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(str= uct drm_device *dev, const struct msm_format *format; int ret, i, n; =20 - drm_dbg_state(dev, "create framebuffer: mode_cmd=3D%p (%dx%d@%4.4s)", + drm_dbg_state(dev, "create framebuffer: mode_cmd=3D%p (%dx%d@%4.4s)\n", mode_cmd, mode_cmd->width, mode_cmd->height, (char *)&mode_cmd->pixel_format); =20 @@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(str= uct drm_device *dev, =20 refcount_set(&msm_fb->dirtyfb, 1); =20 - drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); + drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb); =20 return fb; =20 --=20 2.41.0 From nobody Mon Feb 9 14:31:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 543D4C001DC for ; Sun, 30 Jul 2023 21:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbjG3V6f (ORCPT ); Sun, 30 Jul 2023 17:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbjG3V6a (ORCPT ); Sun, 30 Jul 2023 17:58:30 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C18381710 for ; Sun, 30 Jul 2023 14:58:24 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-348f5193c12so11084415ab.2 for ; Sun, 30 Jul 2023 14:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754303; x=1691359103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vu0ECoPsGxDrhExN3brXHjUi2LDDzR+FiP6BVL6w+Kw=; b=h2LpsYBPFywLz1hFWTqus0/HFnW3Z94Zi07PcYMQkZiem7z0ylk17/7KsTQPPlC49J WwWEMAsnKjGxik3r9XXI45OgJR2XTvUZ+dJRbDKGMNvD2iQdJkySUFNB3SnqG1jmV4Av ZNfDadE3pOeeTc3WclrdH2Fjw9mazeO0r+rBnVebI5Rvp0r7HhgpL9n0Kg5vzpnWu7mv wtwzKAbSxAHbXfPEEFYMrnL3Ky0XmLv2ukbzDgZkUBX1MPu3CX46st9FWTMU1vn0jJRA h/YUn7AsWV81jr8SmGici+CfPXznEghYrzftC3PmSbagKM+5dbAHRH2EHLFZhWm8HcZh D2wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754303; x=1691359103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vu0ECoPsGxDrhExN3brXHjUi2LDDzR+FiP6BVL6w+Kw=; b=c+nPfNOfXy3Kxl+lZNiAatzksic7Q7rd7/0OPgNtQuDD54uzow5UQAHEO9x1z9vq3r 6zQjxQl2CgE7cbKoyUVfSI8qCtvoOovobloBXPsKuhcfFcU+i8q/IjvyMIqlREKHkSle DL7AVJVCgKbutFbkAAN1QYN5w25zxNq/oJ2YI50RZZJcJhylCwew4h3uiTMKrGSplrDa s4LSkYf0S9cbY+sgHsNm0wfr8c1QUXUChOAXZbI6P/vAx0T5qXL9ZpCQ52tDgZAsHXNO 56xPgtqN5ChKpJMCigIwaWsgS/85/zuLwONAPMzfRd7x+qBvnvhDZOIK0nSTMrjswDwS N8iw== X-Gm-Message-State: ABy/qLbGPcElSafvXdLRXKzAxNaWtjrHiaaPfbdB1tOqNpIGI5RvOQUk SX8YetkOkvUZn9JeED9cL2Q= X-Google-Smtp-Source: APBJJlGFctHBx6g16uBxY6S5P569mXmHB6D7A2XcVTPreJQ0slf/YQc2sQUGDPhGIc2DYrEGBMMm2g== X-Received: by 2002:a05:6e02:ed3:b0:348:1a1f:5542 with SMTP id i19-20020a056e020ed300b003481a1f5542mr6325346ilk.17.1690754303337; Sun, 30 Jul 2023 14:58:23 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:22 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Emma Anholt Subject: [PATCH 4/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:53 -0600 Message-ID: <20230730215758.54010-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Jim Cromie --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index bef9d45ef1df..959123759711 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -592,7 +592,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *cr= tc, struct drm_encoder *encoder =3D vc4_get_crtc_encoder(crtc, old_state); struct drm_device *dev =3D crtc->dev; =20 - drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); =20 require_hvs_enabled(dev); @@ -620,7 +620,7 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crt= c, struct vc4_encoder *vc4_encoder =3D to_vc4_encoder(encoder); int idx; =20 - drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); =20 if (!drm_dev_enter(dev, &idx)) --=20 2.41.0 From nobody Mon Feb 9 14:31:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B51AEB64DD for ; Sun, 30 Jul 2023 21:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbjG3V6h (ORCPT ); Sun, 30 Jul 2023 17:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbjG3V6c (ORCPT ); Sun, 30 Jul 2023 17:58:32 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B3301737 for ; Sun, 30 Jul 2023 14:58:25 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-3490eacf4d5so10128115ab.0 for ; Sun, 30 Jul 2023 14:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754304; x=1691359104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbdMUo5HBcvY3eA/Wfik+1Hzr5RoZnPa0wj8fbM2oVc=; b=agVaMhk3pEDzjsQ5PJyT8TavFw+ZA1YIJ4H/s3iaFPJoI8A+JU9zgKcNSrJCgxUl/r gYWsjp9fZNe4vt7RemD5oACo4VCjF07da+eVPFlVJIkfktYDXcy5Oq+0ekv9WXTj7pcm hmEnSEYYhhmntvlDW4g70h2LR2HkvQn5FqAST7z6k08AS8fAEwVkjuN8tRLiIF0a5ZIV zqZnaBhzbuwwTxWL4loRMEodWBeftbndPQeDTMmB1/vwK4WwDkrY7l5AJVSHTEYTFO29 s5w0iqu/j3yx3l/WX3aD+U1AhW9tHhIrbBDMXu+ZSBw+XLzelPALaICnC91VG1juNtbi c5/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754304; x=1691359104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zbdMUo5HBcvY3eA/Wfik+1Hzr5RoZnPa0wj8fbM2oVc=; b=XyFHcYERUmwimyalSJpJnw2s2dSnTLxBfquoLDvmlXVvuA79aDzuQpXnM2ntLwtUSd o46EtrZ/SQLs1dSBNatKgx6pUC/A1woAhPi4b70O4XDSu4P6fWOU0vlhkOKJ6Vsx2ch8 2LsTKD/woTMbZmK1tbHhF1AXtoDmX+PuACyKGoJxUc1IalxcpmH2Mbc2zuM9JiqGU2kx CoKBe2/Evrz5dLnb1Wfba4oQDy7EmvyUXtJ6N+L33la6J/nJa3eFi+XlwhhmEL1P6OBg R/FJFCej3fMkLp5YvOf70HpNw3WDAVJmXJD3hdvZHtJI+upaZlvX7COY3O8BN87GAYCR 2azw== X-Gm-Message-State: ABy/qLa/fKtmEUs4g46RR7WXJOakMn608mWTkK01DZkakxos2VYVaCgG tp5vduC3fuh24kMddXfp1+4= X-Google-Smtp-Source: APBJJlHWzXyQhdHLBN6Z9svWK4MZ1KGWPcL9B/eTSCudiAIzkRE+6jckTWaAdZVRO5La86sBKnRHQw== X-Received: by 2002:a05:6e02:1aad:b0:346:50ce:d602 with SMTP id l13-20020a056e021aad00b0034650ced602mr8965298ilv.1.1690754304330; Sun, 30 Jul 2023 14:58:24 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:23 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Subject: [PATCH 5/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:54 -0600 Message-ID: <20230730215758.54010-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connecto= r.c index 48df7a5ea503..39eab45649c8 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2868,7 +2868,9 @@ int drm_mode_getconnector(struct drm_device *dev, voi= d *data, dev->mode_config.max_width, dev->mode_config.max_height); else - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:= %s] but is not the DRM master, demoting to read-only probe", + drm_dbg_kms(dev, + "User-space requested a forced probe on [CONNECTOR:%d:%s] " + "but is not the DRM master, demoting to read-only probe\n", connector->base.id, connector->name); } =20 --=20 2.41.0