From nobody Sun Feb 8 07:07:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97311C001E0 for ; Fri, 28 Jul 2023 06:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233443AbjG1Gty (ORCPT ); Fri, 28 Jul 2023 02:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233157AbjG1Gtt (ORCPT ); Fri, 28 Jul 2023 02:49:49 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 752403A8F for ; Thu, 27 Jul 2023 23:49:45 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-583b256faf5so29870027b3.1 for ; Thu, 27 Jul 2023 23:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690526984; x=1691131784; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=C14Lkth5YhYGrilJLa3as9gLOwkujqv4yqaGCfXT1cI=; b=pTjgM814griVQd95nxRaERmRO4ta0it5y0NikLDzqte4Dxn2OcWCpUMVSOvdBGreHj PZJRS4r4rVxhf29d7VG6q96fZkFs1VfPbiGyiQrPDC6Q9vUxd2rIephumHnoDhePDv2s dZbeVLCAvL5Q+Mv4ZDP+F2ec55M3eGwo3vCBg8m30lXOcsi/8UbFGTLKyJw4IeRjmbFD kTV85zxQ5M5/yBE4/QrnJEK2Mn1TnBXO1PxDUJWAlKuX+PuB0RRx31rFWa82I+LvrfuM iww3QIxpJUoNGzIl7w8eydhXRjvGgmD818Sy6noQENKa3nyDJQixl0m0FI6X5wuwbhVr Gg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690526984; x=1691131784; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C14Lkth5YhYGrilJLa3as9gLOwkujqv4yqaGCfXT1cI=; b=TyC5zy1JSQ9M7fZR5xy4aBT1Y4I21cUKAImIA5hAvOu2WTZ6yu3xY5xC3RavYrGJjl GKsL4w1BaXgetIKtwzmHnv4xFNx+BSdvbn3aVwycKINSSN11mx7OlNZAxhGzDGPUSLou W0JuU0RgqXzsJwFyZIntaFAcklp1QSqGihdmHX2rZO1+Xv+nvun+06+xg5+NaGvj5Ezy Ti5eZWSSX+l/te3v/90zqPXmRPrVe4Mhox05QCLwOO6S/aH7+JEfytSwSxdKLGxdx5wE CvEZhKss0Xb5g7kfydYtMqolNLmGK5PB5m4jRQuSEC4elBJL7gpAm4ijwLX6PB714RRr xjig== X-Gm-Message-State: ABy/qLauvGUbPlWyO+HLvYFTG6A2KbalJc85T5qlIFjvhVpmd+e+3Kzb h4DqI3kxFeAuRmFEJ5epIXLvdexvCgg7 X-Google-Smtp-Source: APBJJlHY5OrUkocwZKG462E8XmaFPEseNqQWvhpbV4IL+1aqabtUQ0n/nVuKjAoPgqFX/ErHS1qmqEk8D1gC X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:3d03:ff18:af30:2dad]) (user=irogers job=sendgmr) by 2002:a81:c509:0:b0:583:9d8d:fb0d with SMTP id k9-20020a81c509000000b005839d8dfb0dmr10517ywi.0.1690526984540; Thu, 27 Jul 2023 23:49:44 -0700 (PDT) Date: Thu, 27 Jul 2023 23:49:12 -0700 In-Reply-To: <20230728064917.767761-1-irogers@google.com> Message-Id: <20230728064917.767761-2-irogers@google.com> Mime-Version: 1.0 References: <20230728064917.767761-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Subject: [PATCH v1 1/6] perf bpf-loader: Remove unneeded diagnostic pragma From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added during the progress to libbpf 1.0 the deprecated functions are no longer used and so the pragma can be removed. Signed-off-by: Ian Rogers Acked-by: James Clark --- tools/perf/util/bpf-loader.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c index 44cde27d6389..8f4c76f2265a 100644 --- a/tools/perf/util/bpf-loader.c +++ b/tools/perf/util/bpf-loader.c @@ -32,9 +32,6 @@ =20 #include =20 -/* temporarily disable libbpf deprecation warnings */ -#pragma GCC diagnostic ignored "-Wdeprecated-declarations" - static int libbpf_perf_print(enum libbpf_print_level level __attribute__((= unused)), const char *fmt, va_list args) { --=20 2.41.0.487.g6d72f3e995-goog From nobody Sun Feb 8 07:07:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE972EB64DD for ; Fri, 28 Jul 2023 06:49:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233616AbjG1Gt5 (ORCPT ); Fri, 28 Jul 2023 02:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232861AbjG1Gtx (ORCPT ); Fri, 28 Jul 2023 02:49:53 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 832EE3592 for ; Thu, 27 Jul 2023 23:49:47 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d052f58b7deso1759222276.2 for ; Thu, 27 Jul 2023 23:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690526987; x=1691131787; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=nhkzLjqRFF0tb62b0zCcrfbiHArZkxdbKwWW1/g/MaY=; b=4clqy47Iqnh9PeYyHrqFTBjZVVf2SsELiW1HtOdGDeARMMfpRfOc5BJg7RxKU+0K59 RuhH+JcaohEwep2coSpp1uhn625qdWNvq18kjJeU1bqh4H+4r2JgRo+B/XHKkvIFAtAd R3kQBqwvyEa+TcMvRgBKHmm8MYf8+ukvA1ioGcNVQg/Gso5Ud9gz3tk0FPXR7o0hNTZf QFZB0DzH6H5VFQTA7uYQh+vnKMQhcU6NxtStCPkF6+G4gpUIT7bLYg6AmiimM+mPPiw2 0cdqCrJgLMxv/olLDJ+/aTTgleRC2E7Z4U9KIdBIg2AKRYWN1ab8Va/7I+p7lyQfoMQd B22w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690526987; x=1691131787; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nhkzLjqRFF0tb62b0zCcrfbiHArZkxdbKwWW1/g/MaY=; b=B9oY+AOvEEftDvd6AHk5hCKWg6gTO3AUWrU/eWw/KfxoG58SOtAPEr+eASLpgDURZ0 PN6wnBzPVIMIzHh34Eu83776crdPNCzmp91JleA8KBSSer9W9fs6lz2hTigb5yIxMqFv Ys7UIzzwWD8pmoJnjw57sw8zd/4paN2jFcWdpJYqsRs1R2B96UCUqLj4+DDLOxvzTapb t1c/+xzgvErJvvVrx+slX3fRNFcppKbCtYWeSHkiHGu432ikhGihoDnZjTRgI6PL68xk 9pu2H/f3BtoYEEUiHiWsqCAaktrchgkQzJ0dRRDOvytbEUvguOJ9Wanj1Z215BTW0RQy BzQw== X-Gm-Message-State: ABy/qLZLSD2CCwVR8mgHtaNZT5ppOMr/jIZGAkwSRZwf971eFxa6kHoP IUyWBPxq78phGtczyvv9GD1x/54jPH4h X-Google-Smtp-Source: APBJJlFItFzpwaYwOmttNt6LMhW33cuF50knjW5+ecNSk4vm9Ubps/H5m9OxllkRh3cs73v48l7MUO+HQmGt X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:3d03:ff18:af30:2dad]) (user=irogers job=sendgmr) by 2002:a25:ae0c:0:b0:d05:38ba:b616 with SMTP id a12-20020a25ae0c000000b00d0538bab616mr4562ybj.6.1690526986818; Thu, 27 Jul 2023 23:49:46 -0700 (PDT) Date: Thu, 27 Jul 2023 23:49:13 -0700 In-Reply-To: <20230728064917.767761-1-irogers@google.com> Message-Id: <20230728064917.767761-3-irogers@google.com> Mime-Version: 1.0 References: <20230728064917.767761-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Subject: [PATCH v1 2/6] perf build: Don't always set -funwind-tables and -ggdb3 From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 6a40cd90f5de ("perf tools: Add libunwind dependency for DWARF CFI unwinding") added libunwind support but also -funwind-tables and -ggdb3 to the standard build. These build flags aren't necessary so remove, set -g when DEBUG is enabled for the build. Signed-off-by: Ian Rogers Acked-by: James Clark --- tools/perf/Makefile.config | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index a9cfe83638a9..14709a6bd622 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -246,6 +246,9 @@ ifeq ($(CC_NO_CLANG), 0) else CORE_CFLAGS +=3D -O6 endif +else + CORE_CFLAGS +=3D -g + CXXFLAGS +=3D -g endif =20 ifdef PARSER_DEBUG @@ -324,8 +327,6 @@ FEATURE_CHECK_LDFLAGS-disassembler-four-args =3D -lbfd = -lopcodes -ldl FEATURE_CHECK_LDFLAGS-disassembler-init-styled =3D -lbfd -lopcodes -ldl =20 CORE_CFLAGS +=3D -fno-omit-frame-pointer -CORE_CFLAGS +=3D -ggdb3 -CORE_CFLAGS +=3D -funwind-tables CORE_CFLAGS +=3D -Wall CORE_CFLAGS +=3D -Wextra CORE_CFLAGS +=3D -std=3Dgnu11 @@ -333,8 +334,6 @@ CORE_CFLAGS +=3D -std=3Dgnu11 CXXFLAGS +=3D -std=3Dgnu++14 -fno-exceptions -fno-rtti CXXFLAGS +=3D -Wall CXXFLAGS +=3D -fno-omit-frame-pointer -CXXFLAGS +=3D -ggdb3 -CXXFLAGS +=3D -funwind-tables CXXFLAGS +=3D -Wno-strict-aliasing =20 HOSTCFLAGS +=3D -Wall --=20 2.41.0.487.g6d72f3e995-goog From nobody Sun Feb 8 07:07:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA08C001E0 for ; Fri, 28 Jul 2023 06:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233600AbjG1GuM (ORCPT ); Fri, 28 Jul 2023 02:50:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233560AbjG1Gt4 (ORCPT ); Fri, 28 Jul 2023 02:49:56 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8EA035AB for ; Thu, 27 Jul 2023 23:49:49 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d052f58b7deso1759311276.2 for ; Thu, 27 Jul 2023 23:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690526989; x=1691131789; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=o+NuSN9XkT+qsQuvKgJBdNq4nk4vcI3JH0hFT1DVHgI=; b=dBWfagtHD8/GX5CfSM0USkliKrcgjg7HFq51oTJfadYnvK2v3CXXfjwoGKERNpv3cI 4AUh0LL57JfZLlBfahYZs7188BkkTzaC6XOahh1G7K6UlM+Ll8rC86zWvjSKyi7LhZP5 M7RMyGdKmtrbQ8AI3nAe18nKyqLPfckUcaMM3nVyHIue/AQSImE85rbc2i4MXRJmHCN9 TNXXK0CuMC8RLg39DqApn3XqceSzf0vyA3QhKs3XLbwDbUmTT6bLYabPOh73nfBhDH1H oH9n2bueV+aOOiThlR2LuT0Qa+Dq1E2g02ybR//9V6PXxgIS5SzcAGGaW5wpHjsLXWuT gI0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690526989; x=1691131789; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o+NuSN9XkT+qsQuvKgJBdNq4nk4vcI3JH0hFT1DVHgI=; b=QkgNFebNSzhxKNXAy8Jv/rnGY32rOLMbkgC5JHKNfJYA7xyqixuiV7l954GTDu3sBC MFPC72VNWfV1F6dz5JJ4RiDnUPCbZSpEp1lUaiUtTb9e3WFGNAhinCa3fcKmY3sA6KiE 41D8enOxh+3p3YKWEyqla+Ex0iTyWkNvYwLsux7PSiPwinPmlIiIHrROCKmBfVYYqFbs z4jlW8BsuFc0BpvcKjBsfBxZSEBWMBPUqZha0SarQltSghIU0/G8aqxePtF7igCDr8j4 DXWMwXKVwU+oCsAHf4fyrqPtgw2JSriTR4eChsHoYvi+tO0XT6OAeaPeb3R8e59946FR oQvw== X-Gm-Message-State: ABy/qLa7HbXee3MT3aVBtHpHfLTNDFMR1rscwyP2Qll0qsAVE4VFwccE u5NZx6B1IlqqNsQ7WPVjFWIyEkoGn8/V X-Google-Smtp-Source: APBJJlH1isPienb9pKw3EcA/eACCf//JnX+EHZyFmUKd3n/1Raax6Ty/uxc322vFBpfbg4KszcnotojxYicG X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:3d03:ff18:af30:2dad]) (user=irogers job=sendgmr) by 2002:a25:37d8:0:b0:c64:2bcd:a451 with SMTP id e207-20020a2537d8000000b00c642bcda451mr4280yba.7.1690526989081; Thu, 27 Jul 2023 23:49:49 -0700 (PDT) Date: Thu, 27 Jul 2023 23:49:14 -0700 In-Reply-To: <20230728064917.767761-1-irogers@google.com> Message-Id: <20230728064917.767761-4-irogers@google.com> Mime-Version: 1.0 References: <20230728064917.767761-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Subject: [PATCH v1 3/6] perf build: Add Wextra for C++ compilation From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit d58ac0bf8d1e ("perf build: Add clang and llvm compile and linking support") added -Wall and -Wno-strict-aliasing for CXXFLAGS, but not -Wextra. -Wno-strict-aliasing is no longer necessary, adding -Wextra for CXXFLAGS requires adding -Wno-unused-parameter clang.cpp and clang-test.cpp for LIBCLANGLLVM=3D1 to build. Signed-off-by: Ian Rogers Acked-by: James Clark --- tools/perf/Makefile.config | 2 +- tools/perf/util/c++/Build | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 14709a6bd622..fe7afe6d8529 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -333,8 +333,8 @@ CORE_CFLAGS +=3D -std=3Dgnu11 =20 CXXFLAGS +=3D -std=3Dgnu++14 -fno-exceptions -fno-rtti CXXFLAGS +=3D -Wall +CXXFLAGS +=3D -Wextra CXXFLAGS +=3D -fno-omit-frame-pointer -CXXFLAGS +=3D -Wno-strict-aliasing =20 HOSTCFLAGS +=3D -Wall HOSTCFLAGS +=3D -Wextra diff --git a/tools/perf/util/c++/Build b/tools/perf/util/c++/Build index 613ecfd76527..8610d032ac19 100644 --- a/tools/perf/util/c++/Build +++ b/tools/perf/util/c++/Build @@ -1,2 +1,5 @@ perf-$(CONFIG_CLANGLLVM) +=3D clang.o perf-$(CONFIG_CLANGLLVM) +=3D clang-test.o + +CXXFLAGS_clang.o +=3D -Wno-unused-parameter +CXXFLAGS_clang-test.o +=3D -Wno-unused-parameter --=20 2.41.0.487.g6d72f3e995-goog From nobody Sun Feb 8 07:07:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B5FEB64DD for ; Fri, 28 Jul 2023 06:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232986AbjG1GuQ (ORCPT ); Fri, 28 Jul 2023 02:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233618AbjG1GuA (ORCPT ); Fri, 28 Jul 2023 02:50:00 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E3453AA0 for ; Thu, 27 Jul 2023 23:49:52 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d27ac992539so366172276.3 for ; Thu, 27 Jul 2023 23:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690526991; x=1691131791; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=yvpEokk/Mu+ZE+CJyBkDreLaqziwX68WuK1LqhXECqc=; b=hVmuTBJ1Yox9HBREo2lnQL3+qmpioV9r5UsFkBpcTMWs9ujPbivpL62+ixWzmxYbld 2oj5+aaUkdI7MiXvfOBbiXL6vzkchIAT7sgf/1xEqv1qyiVTkUXz46qqAzkz8YE7IjAc a7dAw3ZtkKE0Hdi0zukSamMUV+hxfnGCH1q0cA12gs0ILJz3moGg3LylCmSfm5vhIZ0H 1nxyLuWhnWNjY6730d+R+507i6pKyHJOqb1BFoQMRvynVEhaUkfZy+JvYJdFIeA3lhV3 fjl0oWJqm5kdcfw2zmcGWXuqcb300wHWC8naQmdWY1IonPToG6OaTflMjrpM9bqM63Bd F1/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690526991; x=1691131791; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yvpEokk/Mu+ZE+CJyBkDreLaqziwX68WuK1LqhXECqc=; b=JBnibWSYFpXAjdLbffNsT70ZBRQSt1hFZWuxa0JbXiBlZILd5YP5fMfpKBKlEGskXK 9oPyVzDD6dYtiFPcTCZPGcGmi82LShWT14sKVH4fEEL2I6jfpVNrKr+pVCPDueAn+xq/ P/h7S5NQwB9EqwyMtmanvcl0ESHBOCcuDJMWNU3f0qeCGBRMxXAOuTUEKVLh2WfJZGe2 ecrKDMeI/KvJY6gFiMBix+a34e5QlrTYo14P+xSfJimy+GjtpjHes0gQwbIaWBQ+fNCd K1TVO0vqW5oWx7cCi/yZkC0pL7D2cAAR1FL+CfaDRUSNgec8IotrENEbxE40auIyep0B ohpQ== X-Gm-Message-State: ABy/qLacD8pmGlhpFS2TSEqjuEm5GeZKI2AeLnvIfUg8wNVotapnWBp4 JSY78gUBptr6sIaLUD2xwT1JhWvMK37G X-Google-Smtp-Source: APBJJlE4sPZ8c2Rq2bZAztF25wIkgTHXbSIfDU4obqALIt5bZH9JO3jXTK5qgYFJMBGfyHqayH2sgvVAeYMT X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:3d03:ff18:af30:2dad]) (user=irogers job=sendgmr) by 2002:a25:2311:0:b0:d0c:e71d:fab with SMTP id j17-20020a252311000000b00d0ce71d0fabmr5532ybj.0.1690526991697; Thu, 27 Jul 2023 23:49:51 -0700 (PDT) Date: Thu, 27 Jul 2023 23:49:15 -0700 In-Reply-To: <20230728064917.767761-1-irogers@google.com> Message-Id: <20230728064917.767761-5-irogers@google.com> Mime-Version: 1.0 References: <20230728064917.767761-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Subject: [PATCH v1 4/6] perf build: Disable fewer flex warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If flex is version 2.6.4, reduce the number of flex C warnings disabled. Earlier flex versions have all C warnings disabled. Signed-off-by: Ian Rogers --- tools/perf/util/Build | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/Build b/tools/perf/util/Build index 96f4ea1d45c5..32239c4b0393 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -279,13 +279,9 @@ $(OUTPUT)util/bpf-filter-bison.c $(OUTPUT)util/bpf-fil= ter-bison.h: util/bpf-filt $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) $(BISON= _FILE_PREFIX_MAP) \ -o $(OUTPUT)util/bpf-filter-bison.c -p perf_bpf_filter_ =20 -FLEX_GE_26 :=3D $(shell expr $(shell $(FLEX) --version | sed -e 's/flex \= ([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\=3D 26) -ifeq ($(FLEX_GE_26),1) - flex_flags :=3D -Wno-switch-enum -Wno-switch-default -Wno-unused-functio= n -Wno-redundant-decls -Wno-sign-compare -Wno-unused-parameter -Wno-missing= -prototypes -Wno-missing-declarations - CC_HASNT_MISLEADING_INDENTATION :=3D $(shell echo "int main(void) { retu= rn 0 }" | $(CC) -Werror -Wno-misleading-indentation -o /dev/null -xc - 2>&1= | grep -q -- -Wno-misleading-indentation ; echo $$?) - ifeq ($(CC_HASNT_MISLEADING_INDENTATION), 1) - flex_flags +=3D -Wno-misleading-indentation - endif +FLEX_GE_264 :=3D $(shell expr $(shell $(FLEX) --version | sed -e 's/flex = \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \>\=3D 264) +ifeq ($(FLEX_GE_264),1) + flex_flags :=3D -Wno-redundant-decls -Wno-switch-default -Wno-unused-fun= ction else flex_flags :=3D -w endif --=20 2.41.0.487.g6d72f3e995-goog From nobody Sun Feb 8 07:07:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8473C001DE for ; Fri, 28 Jul 2023 06:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233709AbjG1GuZ (ORCPT ); Fri, 28 Jul 2023 02:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233683AbjG1GuL (ORCPT ); Fri, 28 Jul 2023 02:50:11 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 459ADE64 for ; Thu, 27 Jul 2023 23:49:55 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d27ac992539so366192276.3 for ; Thu, 27 Jul 2023 23:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690526994; x=1691131794; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Kv5zMq7Gf+E/mq3KI9mmBvkyfhWn6r0mf6FnCBupmRU=; b=l4MYYbki/hukDreSiqPgSSi7kqT1I0MQAIIMZIRxKVi/gAKLP++vvsd3ohOTx5Peii fqJRbuy+r7VsxO2l6XzHudVyls1bul7gFWrwlg4Rytz7DH8HyH9gSFhKJaR9boqxH5vf tQfuU5hcGl/o9sWuVE9WVfiAGOTqTKTExEQBqUE387gTXbEcKWPa8knk8egaau1z8RJ5 vo6VhoZfucWIvZZld14uFMpRpXPex78nOuYY+HlH6yuU4IhsIMPIUUG5/GjQBsL95wLy W8JKCHqR1HtA8ERSKiqVL7z9rAR1bnYFcooC/jmcbIeA1w6HhuY7zkKABT+erQaA7juD 1jeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690526994; x=1691131794; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kv5zMq7Gf+E/mq3KI9mmBvkyfhWn6r0mf6FnCBupmRU=; b=HjmpuP/7dmEOs90Tdew5LozrBOnhcuU0ExIFyc2AcyQt+ot+gAw5BoEgrOSc12TIPV PO6gcJY+h2v8oDskH3NAcdTNbHNx5PxgqovoHdmQvXDAOwLfSIJQj/7OuLlLYNLbml9k KXAzxcol42bv+sHgDp5tb8rDs5TjZPdCXc0hEO9bztRBM2Ussh7IZFiO84kuw6xSqEOx UVIHgHGD4YZsqtQVRWoYy7dinpBwZaS814NTheNd1CB8Rba+VXKyLW4J79I/qmeswuzL spDrcPsv0NdVQper6QgbOGJ8fdKdQy9lMt8pebDIZUEbkKooEils7yBU+v9yVt9YkM0n mv4w== X-Gm-Message-State: ABy/qLY4YVRPluAWf7rbyhBD5h6jlm0XiohQuweg3mJgkW/u30XO0F8e VEPvNW3LUuZK+XDKT3AUFgW3J3nj7RfB X-Google-Smtp-Source: APBJJlHSjc/IT1qlh3DupBROZRiA34CttLjbZ/ikQplvXR7TLxlgSKa9DNC7fbAHgw/FKUsK9regMJwIlwEM X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:3d03:ff18:af30:2dad]) (user=irogers job=sendgmr) by 2002:a25:d613:0:b0:d12:d6e4:a08d with SMTP id n19-20020a25d613000000b00d12d6e4a08dmr4686ybg.7.1690526993885; Thu, 27 Jul 2023 23:49:53 -0700 (PDT) Date: Thu, 27 Jul 2023 23:49:16 -0700 In-Reply-To: <20230728064917.767761-1-irogers@google.com> Message-Id: <20230728064917.767761-6-irogers@google.com> Mime-Version: 1.0 References: <20230728064917.767761-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Subject: [PATCH v1 5/6] perf build: Disable fewer bison warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If bison is version 3.8.2, reduce the number of bison C warnings disabled. Earlier bison versions have all C warnings disabled. Avoid implicit declarations of yylex by adding the declaration in the C file. A header can't be included as a circular dependency would occur due to the lexer using the bison defined tokens. Signed-off-by: Ian Rogers --- tools/perf/util/Build | 6 +++--- tools/perf/util/bpf-filter.y | 2 ++ tools/perf/util/expr.y | 4 +++- tools/perf/util/parse-events.y | 1 + tools/perf/util/pmu.y | 3 +++ 5 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/Build b/tools/perf/util/Build index 32239c4b0393..20aa8545b127 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -291,9 +291,9 @@ CFLAGS_expr-flex.o +=3D $(flex_flags) CFLAGS_bpf-filter-flex.o +=3D $(flex_flags) =20 bison_flags :=3D -DYYENABLE_NLS=3D0 -BISON_GE_35 :=3D $(shell expr $(shell $(BISON) --version | grep bison | se= d -e 's/.\+ \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\=3D 35) -ifeq ($(BISON_GE_35),1) - bison_flags +=3D -Wno-unused-parameter -Wno-nested-externs -Wno-implicit= -function-declaration -Wno-switch-enum -Wno-unused-but-set-variable -Wno-un= known-warning-option +BISON_GE_382 :=3D $(shell expr $(shell $(BISON) --version | grep bison | s= ed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \>\=3D 382) +ifeq ($(BISON_GE_382),1) + bison_flags +=3D -Wno-switch-enum else bison_flags +=3D -w endif diff --git a/tools/perf/util/bpf-filter.y b/tools/perf/util/bpf-filter.y index 07d6c7926c13..5dfa948fc986 100644 --- a/tools/perf/util/bpf-filter.y +++ b/tools/perf/util/bpf-filter.y @@ -9,6 +9,8 @@ #include #include "bpf-filter.h" =20 +int perf_bpf_filter_lex(void); + static void perf_bpf_filter_error(struct list_head *expr __maybe_unused, char const *msg) { diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y index dd504afd8f36..65d54a6f29ad 100644 --- a/tools/perf/util/expr.y +++ b/tools/perf/util/expr.y @@ -7,6 +7,8 @@ #include "util/debug.h" #define IN_EXPR_Y 1 #include "expr.h" +#include "expr-bison.h" +int expr_lex(YYSTYPE * yylval_param , void *yyscanner); %} =20 %define api.pure full @@ -56,7 +58,7 @@ static void expr_error(double *final_val __maybe_unused, struct expr_parse_ctx *ctx __maybe_unused, bool compute_ids __maybe_unused, - void *scanner, + void *scanner __maybe_unused, const char *s) { pr_debug("%s\n", s); diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y index 454577f7aff6..251b7d2fde32 100644 --- a/tools/perf/util/parse-events.y +++ b/tools/perf/util/parse-events.y @@ -20,6 +20,7 @@ #include "parse-events.h" #include "parse-events-bison.h" =20 +int parse_events_lex(YYSTYPE * yylval_param, YYLTYPE * yylloc_param , void= *yyscanner); void parse_events_error(YYLTYPE *loc, void *parse_state, void *scanner, ch= ar const *msg); =20 #define PE_ABORT(val) \ diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y index dff4e892ac4d..3d46cca3bb94 100644 --- a/tools/perf/util/pmu.y +++ b/tools/perf/util/pmu.y @@ -11,6 +11,9 @@ #include #include #include "pmu.h" +#include "pmu-bison.h" + +int perf_pmu_lex(YYSTYPE * yylval_param , void *yyscanner); =20 #define ABORT_ON(val) \ do { \ --=20 2.41.0.487.g6d72f3e995-goog From nobody Sun Feb 8 07:07:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314F3C001DE for ; Fri, 28 Jul 2023 06:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233434AbjG1Gu2 (ORCPT ); Fri, 28 Jul 2023 02:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233712AbjG1GuM (ORCPT ); Fri, 28 Jul 2023 02:50:12 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D91F3ABC for ; Thu, 27 Jul 2023 23:49:57 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-58378ae25bfso19333877b3.0 for ; Thu, 27 Jul 2023 23:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690526996; x=1691131796; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=qCTbKLxJE0e0fl2gNVl7kq0Lz7zE9dDnQokd98Af9Ns=; b=X3zNA1RyzLTULsNbdzaguab4z5QUbvoNMUV1EWAEh8ykQMS+N/lSrXKHrjXCDjAIW0 b8fAsPrrPrZUyGp2r2JOgYtx0Iyu2JRCxWsXHm0VA9DEhKb90ArH81bKpFGytwmaegL/ ahLqi1dWB0gpwXhL71JAr4ayzjdZNvmRpaOg3DNpfus2x79fe2cK/zPF8M4yzx8dle8/ lgYRqJGe5+65cNJgMBcb6mUsE4h8lwi7sFbN5W2Ys+inxantP8VFhm0mjMLMGq0MIX+3 Q2qJAkJzldydQMadbHTKbjY/T5QuIThGF37ugL0IfZXuyIkE+c2o8kYT/YKIo3X65Ptf 4j5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690526996; x=1691131796; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qCTbKLxJE0e0fl2gNVl7kq0Lz7zE9dDnQokd98Af9Ns=; b=R8WzPSvV/QC3g8q+9ExO2p4letQnk3CBvsfoIpXhrUIxektjRvKyoD6gUEG8KKBXgw 0XcW7PNlKVGfR5tD3i4jBzN0ASA+0B+RVomRXTKTTfYwq4rVlg9CsaowxLMlLwWmp8bP 9iI0/m1Ri1vfMKxL9XCJiQg+8H5Pw9qJopqzevuMDiRHpEdv7qNZclQawsrY8R3NEkDN Hz3ZV8rzLrkT0I4x3VAgFcwOLekSsW+Z5nNPZnbJvjnYVEKA8ZitITM33wIiwGJjrd/2 WNI6Rw8WY7D7Kpz0v77srJDc3EmqZlmAI9+EbC9JWRCfqF89Hy8B4lRDfBdiaTfEQf6z z/HQ== X-Gm-Message-State: ABy/qLY99TNUwMfDYNm8W+hJjeWMYbl04F/epQCr23dpj8HqUcjCvCGW 4wzfDKafDuKhSDNmqpp0qih9jGDXAPUa X-Google-Smtp-Source: APBJJlF1VBO/nA6o0F1Sw4iDyXLL+nD10wzaY2iHSF0gHcJmj7AOkP0CJ29sQFCewflEsjHmJprWtoE0EOv5 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:3d03:ff18:af30:2dad]) (user=irogers job=sendgmr) by 2002:a25:7392:0:b0:d1e:721b:469d with SMTP id o140-20020a257392000000b00d1e721b469dmr4543ybc.7.1690526996428; Thu, 27 Jul 2023 23:49:56 -0700 (PDT) Date: Thu, 27 Jul 2023 23:49:17 -0700 In-Reply-To: <20230728064917.767761-1-irogers@google.com> Message-Id: <20230728064917.767761-7-irogers@google.com> Mime-Version: 1.0 References: <20230728064917.767761-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Subject: [PATCH v1 6/6] perf build: Remove -Wno-redundant-decls in 2 cases From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Properly fix a warning and remove the -Wno-redundant-decls C flag. Signed-off-by: Ian Rogers --- tools/perf/util/Build | 2 -- tools/perf/util/parse-events.c | 1 - 2 files changed, 3 deletions(-) diff --git a/tools/perf/util/Build b/tools/perf/util/Build index 20aa8545b127..b8f1e9ba8c6f 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -312,8 +312,6 @@ CFLAGS_find_bit.o +=3D -Wno-unused-parameter -DETC= _PERFCONFIG=3D"BUILD_STR($(ET CFLAGS_rbtree.o +=3D -Wno-unused-parameter -DETC_PERFCONFIG=3D"BUIL= D_STR($(ETC_PERFCONFIG_SQ))" CFLAGS_libstring.o +=3D -Wno-unused-parameter -DETC_PERFCONFIG=3D"BUIL= D_STR($(ETC_PERFCONFIG_SQ))" CFLAGS_hweight.o +=3D -Wno-unused-parameter -DETC_PERFCONFIG=3D"BUIL= D_STR($(ETC_PERFCONFIG_SQ))" -CFLAGS_parse-events.o +=3D -Wno-redundant-decls -CFLAGS_expr.o +=3D -Wno-redundant-decls CFLAGS_header.o +=3D -include $(OUTPUT)PERF-VERSION-FILE CFLAGS_arm-spe.o +=3D -I$(srctree)/tools/arch/arm64/include/ =20 diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 926d3ac97324..ac315e1be2bc 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -35,7 +35,6 @@ #ifdef PARSER_DEBUG extern int parse_events_debug; #endif -int parse_events_parse(void *parse_state, void *scanner); static int get_config_terms(struct list_head *head_config, struct list_head *head_terms __maybe_unused); =20 --=20 2.41.0.487.g6d72f3e995-goog