From nobody Wed Sep 10 02:48:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 322FAC001E0 for ; Fri, 28 Jul 2023 06:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233527AbjG1GTW (ORCPT ); Fri, 28 Jul 2023 02:19:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233524AbjG1GTT (ORCPT ); Fri, 28 Jul 2023 02:19:19 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0958421C for ; Thu, 27 Jul 2023 23:18:47 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id EBBAC1A8D10; Fri, 28 Jul 2023 02:18:12 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=JOkJwPjwlZO67IiYuY88Dz2P3 NwcX7o5HkWjwCQM+bw=; b=cDRh8wInbXbxsPkNT2+mgYztC8Hc6RyO7EaLmMzMp NEbAjtOMetf4kdDxmwlKN/C2yKVtqo004EHslgkwewkn9oYBe2Wcc7CA0OY1VMcQ OVY22E4yVCjq3awjw+nNVdGvbL5grRATiY6APKhrjwU4rBon5Acrh7FWvzai1jpB vU= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id E5AB11A8D0F; Fri, 28 Jul 2023 02:18:12 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=2019-09.pbsmtp; bh=XUtp31xPUR4KlS3n6K/4849ubr4dJYL/+GyX7zOXVr0=; b=bse0qP6WjvU6EmRKjIFolqBTaMUIqlEjhVzlknpWGO6h11zUSXkHcvXvMdiRcSL+01oPeVbn0zibU+jZ7/wDe8+DMLgSqKcGzVJocDfxQ5bWmWiPig0jUCWd9XCHfDyVFyZnJV9+gxHl6HR5Spxqen3hqmpw2dOfAJTrOGHstAc= Received: from basil.darkphysics (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id B72811A8D0B; Fri, 28 Jul 2023 02:18:10 -0400 (EDT) (envelope-from tdavies@darkphysics.net) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v4 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Date: Thu, 27 Jul 2023 23:19:27 -0700 Message-ID: <20230728061930.624540-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230728061930.624540-1-tdavies@darkphysics.net> References: <20230728061930.624540-1-tdavies@darkphysics.net> MIME-Version: 1.0 X-Pobox-Relay-ID: 87A3FEF0-2D0E-11EE-8671-C65BE52EC81B-45285927!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix checkpatch warning: Avoid CamelCase Signed-off-by: Tree Davies --- v4: Resending. git send-email failed to send patch #5. v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_b= a_entry v2: Sent to mailing list via git send-email, patches are the same. =20 drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 965ffa8b78c2..50362bbbc8dd 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -17,7 +17,7 @@ static void activate_ba_entry(struct ba_record *pBA, u16 = Time) mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time)); } =20 -static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record= *pBA) +static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_reco= rd *pBA) { pBA->b_valid =3D false; del_timer_sync(&pBA->timer); @@ -30,12 +30,12 @@ static u8 TxTsDeleteBA(struct rtllib_device *ieee, stru= ct tx_ts_record *pTxTs) u8 bSendDELBA =3D false; =20 if (pPendingBa->b_valid) { - DeActivateBAEntry(ieee, pPendingBa); + deactivate_ba_entry(ieee, pPendingBa); bSendDELBA =3D true; } =20 if (pAdmittedBa->b_valid) { - DeActivateBAEntry(ieee, pAdmittedBa); + deactivate_ba_entry(ieee, pAdmittedBa); bSendDELBA =3D true; } return bSendDELBA; @@ -47,7 +47,7 @@ static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct= rx_ts_record *pRxTs) u8 bSendDELBA =3D false; =20 if (pBa->b_valid) { - DeActivateBAEntry(ieee, pBa); + deactivate_ba_entry(ieee, pBa); bSendDELBA =3D true; } =20 @@ -270,7 +270,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 rtllib_FlushRxTsPendingPkts(ieee, pTS); =20 - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token =3D *pDialogToken; pBA->ba_param_set =3D *pBaParamSet; pBA->ba_timeout_value =3D *pBaTimeoutVal; @@ -363,13 +363,13 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, st= ruct sk_buff *skb) netdev_dbg(ieee->dev, "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n", __func__, *pStatusCode); - DeActivateBAEntry(ieee, pPendingBA); + deactivate_ba_entry(ieee, pPendingBA); } =20 if (*pStatusCode =3D=3D ADDBA_STATUS_SUCCESS) { if (pBaParamSet->field.ba_policy =3D=3D BA_POLICY_DELAYED) { pTS->bAddBaReqDelayed =3D true; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); ReasonCode =3D DELBA_REASON_END_BA; goto OnADDBARsp_Reject; } @@ -378,7 +378,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl =3D pPendingBA->ba_start_seq_ctrl; pAdmittedBA->ba_param_set =3D *pBaParamSet; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { pTS->bAddBaReqDelayed =3D true; @@ -469,7 +469,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_= ts_record *pTS, if (pBA->b_valid && !bOverwritePending) return; =20 - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); =20 pBA->dialog_token++; pBA->ba_param_set.field.amsdu_support =3D 0; --=20 2.41.0