From nobody Sat Feb 7 22:21:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9BFC00528 for ; Thu, 27 Jul 2023 19:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjG0TiH (ORCPT ); Thu, 27 Jul 2023 15:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231925AbjG0TiC (ORCPT ); Thu, 27 Jul 2023 15:38:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F50D273C; Thu, 27 Jul 2023 12:38:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C9AB61F20; Thu, 27 Jul 2023 19:37:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02196C433C7; Thu, 27 Jul 2023 19:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690486678; bh=rE/Kd3G9NMSVIw3ayakgITZdDQaqNiUsnvItueTbY+w=; h=From:To:Cc:Subject:Date:From; b=lA5tu1Z7RaFa+Ys40DjEvhe665WRDbIAM9b7Gx3bm4GJNDILpMmqUQr/By4OSQS7Z vXNRun/zuYbeTr9GnTfJO0sAIc+MESL7JK8eLY83qxn+8GaUbNuiBoN8jxJIMkQWWz DqVOxaa9KnOvnvB+l1Nbo6HRg5e0eFDeth3V9uar9RUoFP8uTLdsaGLIjn63NSkgiZ xJQ6UkKTEaVLlyorUxWZZb535Di6/Vsf7drbFzOJCRt/61QpG0VFanIT3yjb7U5ZE2 vWMR3S5zc7OISTYYEsN6LN1mEpCsOc53ZoKUyFHwdNiS1nz7Ksq4twktFm/6wLGWVN VVbXS0zzC8ecg== From: Dinh Nguyen To: gregkh@linuxfoundation.org Cc: dinguyen@kernel.org, linux-kernel@vger.kernel.org, Wang Ming , stable@vger.kernel.org Subject: [PATCH] firmware: Fix an NULL vs IS_ERR() bug in probe Date: Thu, 27 Jul 2023 14:37:50 -0500 Message-Id: <20230727193750.983795-1-dinguyen@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Wang Ming The devm_memremap() function returns error pointers. It never returns NULL. Fix the check. Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") Cc: stable@vger.kernel.org Signed-off-by: Wang Ming Signed-off-by: Dinh Nguyen --- drivers/firmware/stratix10-svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-= svc.c index 260695a8a9e6..c693da60e9a9 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -774,7 +774,7 @@ svc_create_memory_pool(struct platform_device *pdev, paddr =3D begin; size =3D end - begin; va =3D devm_memremap(dev, paddr, size, MEMREMAP_WC); - if (!va) { + if (IS_ERR(va)) { dev_err(dev, "fail to remap shared memory\n"); return ERR_PTR(-EINVAL); } --=20 2.25.1