From nobody Sun Feb 8 00:34:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523E0C04A94 for ; Thu, 27 Jul 2023 18:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbjG0SGu (ORCPT ); Thu, 27 Jul 2023 14:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjG0SGr (ORCPT ); Thu, 27 Jul 2023 14:06:47 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07652D5B for ; Thu, 27 Jul 2023 11:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481206; x=1722017206; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pNajP0H5SUJ9f+Q1Onyg09lY/pVe/W2pk6K32ziRX90=; b=gb9JxKALS1REZGkMaAFDjgpsW3NvfF0YzytTfFV/dkO+q2XV8cFVZcZE 1lvy/+uRP6S9AKLAM8gvQRp+MkAW7jx/6Nryy6cStYMqYoRdBpQ7DV8ke xd+N610z0p9MQsQQcX+aNWQg6sFMzMJqiXg0Zs3ZTNzg+3SUSzxsg+QZm sO51Dkq+C89cMvBErz2BrWwbDy9F8gaCPVBNDVoHedcFG7Ig2tKMeqMwe bEyalnvN97A5lwgBEdfhT7+ny3X4pghX99e//+/b2ZvcTqTyBc+B1H8FD td/dNMvd0DWWy/4r7rkd2OeaOpc29nMmyPe7YO1X/KmqL7g0057UV1gLE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760087" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760087" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523921" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:47 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] x86/smpboot: Remove a stray comment about CPU hotplug Date: Thu, 27 Jul 2023 18:05:31 +0000 Message-Id: <20230727180533.3119660-2-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta --- arch/x86/kernel/smpboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd7734b..6a09a021b534 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); =20 cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); } =20 --=20 2.34.1 From nobody Sun Feb 8 00:34:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8645DC00528 for ; Thu, 27 Jul 2023 18:06:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231572AbjG0SGx (ORCPT ); Thu, 27 Jul 2023 14:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbjG0SGt (ORCPT ); Thu, 27 Jul 2023 14:06:49 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5818D2D64 for ; Thu, 27 Jul 2023 11:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481207; x=1722017207; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mr2dxah7WXzCzQIlxM3ZK1C/zanGAvJYwpX4ZaRJNIw=; b=Z5kXAlFTeCxcI3A5C9P8JmJNk3KAFwbXDbDdFsjlnXcoubk0mbJG9+hE 30+S95MdB2Gqz9r8KkBWcyOxyzpPmj/lwHqOIV4uKWBkKC9Wxcq2jsYZL v36XflXWBEdBnNHu30YUSIqzapdbvWq9z3GAKTm9tSNqzEPdz6TFZLrqu i5/mSrA/9LAMH7/Xq+XAh6831J0SFU5WA99QjfuM9xEraVWQcPsyPcN6X c7cvxzlj6BCY2oRCBMY9r9kN6cDffrsyMjTzaRQa97GMmLdYphNXCIu2v 5gxFCXZjXe1A+EAluIS5J80vJLr5nZ64y05s+0wCN//irCoqEnI3pdM0G w==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760096" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760096" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523924" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:48 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] x86/smp: Remove a non-existent function declaration Date: Thu, 27 Jul 2023 18:05:32 +0000 Message-Id: <20230727180533.3119660-3-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" x86_idle_thread_init() does not exist anywhere. Remove its declaration from the header. Signed-off-by: Sohil Mehta --- arch/x86/include/asm/smp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index 600cf25dbfc6..094f31d3f950 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -132,7 +132,6 @@ void smp_kick_mwait_play_dead(void); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); void native_send_call_func_single_ipi(int cpu); -void x86_idle_thread_init(unsigned int cpu, struct task_struct *idle); =20 bool smp_park_other_cpus_in_init(void); =20 --=20 2.34.1 From nobody Sun Feb 8 00:34:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17675C04E69 for ; Thu, 27 Jul 2023 18:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbjG0SG5 (ORCPT ); Thu, 27 Jul 2023 14:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbjG0SGu (ORCPT ); Thu, 27 Jul 2023 14:06:50 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92A030F4 for ; Thu, 27 Jul 2023 11:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481208; x=1722017208; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ou+7XfN+1f2cTllTnn7hZn4iUyiMerEMeSBG9j8AO/g=; b=SW0M6hxc7TN5go3Ly3D+W3VhLhFLPGwznFyYOqD8aexHfkstqKKLp+9/ HcyD5o7sBDz9YZAY8YTnWoIMG+FQ0C1tpT9stjWJdlX1TcwmAbJO2Woex T6uA5YJnmN46P7+0eu5P1uU6KmrD97BKDjMXSrWpH1nDF8hPsQ1htCVdX 4S1uPTAeZs+nPG9CQ5BTp7V3F+SXGoZvAQW2Gu6bQTdnH9jc+NmiFLRGX NjdtIVvPyEesQmTN8z5FmLT/QmivjZnoqPT59SeNsUxss4p2rG5/Ff460 noATdy0FuyKhS1IWsPVqjpJTZfpu3KUREXT1Yc+bapIWAW7Srulkb13lp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760103" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760103" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523929" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:50 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] x86/smpboot: Change smp_store_boot_cpu_info() to static Date: Thu, 27 Jul 2023 18:05:33 +0000 Message-Id: <20230727180533.3119660-4-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function is only used locally. Convert it to a static one. Signed-off-by: Sohil Mehta --- arch/x86/include/asm/smp.h | 2 -- arch/x86/kernel/smpboot.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index 094f31d3f950..cf7217ad5701 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -134,8 +134,6 @@ void native_send_call_func_ipi(const struct cpumask *ma= sk); void native_send_call_func_single_ipi(int cpu); =20 bool smp_park_other_cpus_in_init(void); - -void smp_store_boot_cpu_info(void); void smp_store_cpu_info(int id); =20 asmlinkage __visible void smp_reboot_interrupt(void); diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 6a09a021b534..28c590b4b1b1 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -422,7 +422,7 @@ int topology_update_die_map(unsigned int die, unsigned = int cpu) return 0; } =20 -void __init smp_store_boot_cpu_info(void) +static void __init smp_store_boot_cpu_info(void) { int id =3D 0; /* CPU 0 */ struct cpuinfo_x86 *c =3D &cpu_data(id); --=20 2.34.1