From nobody Sat Feb 7 17:40:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331CBC0015E for ; Thu, 27 Jul 2023 17:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbjG0R6d (ORCPT ); Thu, 27 Jul 2023 13:58:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjG0R6b (ORCPT ); Thu, 27 Jul 2023 13:58:31 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2053.outbound.protection.outlook.com [40.107.94.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A86602D64; Thu, 27 Jul 2023 10:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LTJmiqk1nsJkXmDexxTkRkf7NfuJCgmdAvmL7NBEGjN2geqXM1vHMpobTOWk9dpWfXzJn1a6M377WCxIM4G66vPY51b/JgCCb4Ae3TEfAQC6WAAkNU5QzSUyMYml6euw2N6ixxkCGeTGhjgJZmFBD6uj2AXPtGq1MPBzR+euIW76UQuX3RDCHe+RyaOAEOMyO2fefA/IQLIfB7TI7WWlzyc9xIa2zKEArcKwHiH6RiDtw/ZNvwNp3gA7fDG85YzlkaCxuZTdmwKBVk/zgrnYY4r5cxtaAO24/SxdsDkR3IqCRZySGnw4yv/BHskUK4RGbXJ5E4Q+wnhS5CrZEsrcvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B0X9WamVdIhTmxfAVDjnZRe5MLzXc6VbF1Lk426V1E4=; b=JihgaJtHF6RpmQDc4Ntoh+BTFOQjF36bXrGzIMPdGMUxLqoUVC1OGSOvPdXGMN8wmdJuoCoa4/DAyGsn2X+uTl0E2jji4nVIbcMY3tc5VU1J9kv6vZu2szoOM6iQYyAahz9PCNKGtC38wUVM9NFBoP4YXwGjk3toZpKKivMsMtZQbfQEmYsT68Wav6ChGbSDSoglDtbcjkxdUMj8qYzKUzxWrUBppV6LM0oVrvpV7l7OJGYUqtjB47GTcTSPEOaTBqKNxIzE0lJ4Ras+LwGFUUPnLpFoAiagDYqCXB87cS9+OFZGoJS/FXaiWylmqvFMlPYO9DcvRexfPjyVpyCqmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B0X9WamVdIhTmxfAVDjnZRe5MLzXc6VbF1Lk426V1E4=; b=VRkxDOYyrTh2rDLKEOBzH5LJCXPm81W+Pqt+3nNiK1osguT+18UOZZbmvgI6e0dKXssbI13QOusk1yZtE9HCgOQYLGYJhn2k4qglkVUvrqCtSPSz7mzyV9i3uYn8Sqjie9kpIAM22SD/tbKZrZO1wIF01LwTFftVwPDALVspiWoDWaD0l6gArEBfSP3r1n7X1rYHmQlCqGqbVCkbr3Mp3mMKcW2RUB3ISqxMDxdCSlfR3yzsF7hWyh/xoJ8dVJC2Uzac1Kn2m87dFyU1JZsrTiIf6lID9c1IIOiZ/xnSyEf/hdUBAYCgl4pZFr769SIAyeKpI2V/YnNm1HMCGywYjg== Received: from DM6PR03CA0050.namprd03.prod.outlook.com (2603:10b6:5:100::27) by MW4PR12MB6706.namprd12.prod.outlook.com (2603:10b6:303:1e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 17:58:27 +0000 Received: from DM6NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:5:100:cafe::c6) by DM6PR03CA0050.outlook.office365.com (2603:10b6:5:100::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT047.mail.protection.outlook.com (10.13.172.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:27 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 27 Jul 2023 10:58:15 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 27 Jul 2023 10:58:14 -0700 Received: from c-237-113-220-225.mtl.labs.mlnx (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 27 Jul 2023 10:58:12 -0700 From: Dragos Tatulea To: "Michael S . Tsirkin" , Lin Ma , "Jason Wang" , Xuan Zhuo , "Parav Pandit" CC: , , Subject: [PATCH 1/4] vdpa: Add features attr to vdpa_nl_policy for nlattr length check Date: Thu, 27 Jul 2023 20:57:48 +0300 Message-ID: <20230727175757.73988-3-dtatulea@nvidia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230727175757.73988-1-dtatulea@nvidia.com> References: <20230727175757.73988-1-dtatulea@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT047:EE_|MW4PR12MB6706:EE_ X-MS-Office365-Filtering-Correlation-Id: c16c23f6-8353-4d50-363f-08db8ecb1456 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a+LH2QriJ49GfF5yQIU/hIp+nqZ24XGOD2OJfeq6pB5y9nKfju6dIuUY2u+gvKDHnIlKqtzPpQgJfk5bjFlv++BD/g6bateRkStjQKip0Q/W4MeQdwtn49QFfdUDJYQk5v2K78bsGp8PFahKJBOLTfn0WkytYzx9dexbJ6kH1S46ieVwn9ATI5ul4bvwjqk5L4ViUgjv1UcxGdVBRq49IJ4UVQ0wpgJzdJIYMTq7Pwc/Mjvxqi0PXXaNvu5AVYPtYGGvCp4zAEa/ygHEsxWhbW/wTLNcbnLZ50FP+oy1WcYwyRfSOOh5YlMX5M+7Ve+gKBNeGAtwvsDELJlMHGet4fzH2SdRKXbAbEGtIu+1pQVSZ19/fuNIapGMgYsUA2A0qQ8rvoHr18NysujDHSk3HeUkAYijq+S8bvs1lOrbrs5KVfWawE/SOJrGbXGLwXCPygFiqjvvR81DXEasQSD0hPoyDR3ZY2YRxEnV12Z4oN5DwfzJ3KKTIg9TOWUMy6arhJnFE5GPvkwS4DJ4JS24jAa5m4Zg+Lc0DHLiLj8E+L8WXrVDnN6zBzk2z4kzTtQz8GOpDOSrC1YjVWwDJQo/Z6b65gn9mDsz6sj8QZFEFr/tg6Ikbe9p1faoOJByqgyg39YFa6gwA+izl3U3GesEefFhYU5/m1qbd6aFENPMAPg0M560X3v3BGzz+r8JAXWQlqFAcC0KUNUZ/19OVJ88b0mIUOmS88KKCNZzXkysRU7wLdPLqRyrY7G3jLQxNKUB X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(86362001)(41300700001)(2906002)(316002)(5660300002)(8936002)(8676002)(36756003)(40480700001)(40460700003)(1076003)(26005)(478600001)(7636003)(82740400003)(356005)(6666004)(47076005)(83380400001)(36860700001)(186003)(336012)(426003)(2616005)(4326008)(6636002)(70206006)(54906003)(110136005)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 17:58:27.2350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c16c23f6-8353-4d50-363f-08db8ecb1456 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6706 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Lin Ma The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in vdpa_nl_policy may lead to illegal nlattr after parsing, which could lead to OOB read just like CVE-2023-3773. This patch adds the missing nla_policy for vdpa features attr to avoid such bugs. Fixes: 90fea5a800c3 ("vdpa: device feature provisioning") Signed-off-by: Lin Ma Cc: stable@vger.kernel.org --- drivers/vdpa/vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 965e32529eb8..3ad355a2208a 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -1249,6 +1249,7 @@ static const struct nla_policy vdpa_nl_policy[VDPA_AT= TR_MAX + 1] =3D { [VDPA_ATTR_DEV_NET_CFG_MACADDR] =3D NLA_POLICY_ETH_ADDR, /* virtio spec 1.1 section 5.1.4.1 for valid MTU range */ [VDPA_ATTR_DEV_NET_CFG_MTU] =3D NLA_POLICY_MIN(NLA_U16, 68), + [VDPA_ATTR_DEV_FEATURES] =3D { .type =3D NLA_U64 }, }; =20 static const struct genl_ops vdpa_nl_ops[] =3D { --=20 2.41.0 From nobody Sat Feb 7 17:40:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5613CC0015E for ; Thu, 27 Jul 2023 17:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231693AbjG0R6n (ORCPT ); Thu, 27 Jul 2023 13:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231414AbjG0R6l (ORCPT ); Thu, 27 Jul 2023 13:58:41 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1234358A for ; Thu, 27 Jul 2023 10:58:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiThJ1vRvDMeHmVlw0DeuwOgbZKieItlOTegxbaCuK5h8yggj0xmoBnmzuN9bRDk5WgSxj5qwNtySOt5lBjV9iJfBOJ5wMoPtIDz/1anWKE7vdDyJdUr2NtIwEwy25JlSQKnEkS4BfcnL+dWky8UQ46mgYGXTRpEQAayd4vFV0XaMeMVCJsQk/oxflPRVRZ2NyhaEG7hrV8MwlXH48RQ6CFgCQzfvQ4in3BZdQx/ROcLW1A2mge3ANfVzqtucFyDOCemS5ONQVWDC4Dkon0ZoINhXF9ifAJiiSgGVSbppOUctDGWtZREhfy4e+oYuKnOoCc8DMC2J1ZcAZHmFhLefw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a8UMif7Br05o4sgfEuqtA2qO+wkMcJ6NxdPG1E1yAJo=; b=c7T5h/KvOz1wZ6kkcHMcV+714FWjL4LWxn3FoATA4F0iZAvVk3F8cxUDsCME0VD3FDEjm+tPz4aKeh2Xww2oBmjT54dOlCXXwADQWou2j9XChtiYlCNsdGlost6wQTK/NFHXSAvnRm67gf0Y4l/8zOfYUQiTeV9GzaU56KA7Hbr4M/uXi1YnE1Egcu4zs1dyd+MZqccK7kaCDR1ruItCwR/bGYkKjJMsvzqbiPtbxCwPJKtmkYKQsY64i5R2tAmWuEGx7f0OJkd2/xfFxigNAIEpDzstQ/obXJWFcpE47rssIV97jlq1iNnzfJJFIdKp5Jl41s5vdzp2+B8Cu/b3Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a8UMif7Br05o4sgfEuqtA2qO+wkMcJ6NxdPG1E1yAJo=; b=K4XML+kPm1OYYXRpa28eCCJCVw8+pYucKEzuWd16YPv8rD7im8+o0qMgB2DAZP2LSpTCCUWaYKb40Q4xxERkut++JA3sGtX+s4QiumHhDY6B2Whcs4z2bywD1bWbfeMGzAFVRqCbZCkYY9Ky8G1ltaaAWsmcptMCkjKI5lTGzdNFCNZdPLily4/G4VhTDdmAMislnwSdN3pfZDe59cOLljCa7LTamKOF3eglMCibcyx1wfLtf8KJ6AZ4RRvX8RxgYV1gfmBcEC40PwLZ8u6pvQ3vFGy08MWYPNDjTSPjxAdmd+vEdYllzIPreG924HF2+zBI2fVIvwwhNRWRXZ6KuA== Received: from DS7PR03CA0211.namprd03.prod.outlook.com (2603:10b6:5:3ba::6) by SJ1PR12MB6027.namprd12.prod.outlook.com (2603:10b6:a03:48a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 17:58:33 +0000 Received: from DM6NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ba:cafe::6b) by DS7PR03CA0211.outlook.office365.com (2603:10b6:5:3ba::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DM6NAM11FT042.mail.protection.outlook.com (10.13.173.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:33 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 27 Jul 2023 10:58:22 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 27 Jul 2023 10:58:22 -0700 Received: from c-237-113-220-225.mtl.labs.mlnx (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 27 Jul 2023 10:58:20 -0700 From: Dragos Tatulea To: "Michael S . Tsirkin" , Lin Ma , "Jason Wang" , Xuan Zhuo , "Parav Pandit" CC: , , Subject: [PATCH 2/4] vdpa: Add queue index attr to vdpa_nl_policy for nlattr length check Date: Thu, 27 Jul 2023 20:57:50 +0300 Message-ID: <20230727175757.73988-5-dtatulea@nvidia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230727175757.73988-1-dtatulea@nvidia.com> References: <20230727175757.73988-1-dtatulea@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT042:EE_|SJ1PR12MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: d9616b4d-734c-4920-5bfb-08db8ecb17d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hlp644XSkCNUaICQJ1K/cpwc1e4ysjXHlhQ/dkuuvK7JgRjeaYLpfTIKO3N9R4G4aVN5izwrDIAGh1aGRpEO0QsPNaFlBJ5UyHSzHqLoHHu4wwluod75tw6j7Gk2SYr3gWXByVquVeb3vZukvBc3Np9ipSt/4z1L+7NxDQqSLw0dG3AlTusUYYr/vkGXPQN6pQaFnSPdkDbiudB5Va4mXDO7FVI7nyT84qBx1o63md98IHngLuwPXA1nPCTR40C9rg1OG7y9/PnCKeZhnBehGmduNeddim69r2fRfmagCw1k3y6yrfMItmw69kQkC6UrmafJrMOStv37j4iX7Qgo6fLmPC5TObWNBEIgLXNzg4fcWo0WeWim92Z0ApIGIs2/ahM5c4f31YpR/fD6IA+D0nNVIGSMvzNc+XEVof3GWY2+Khrp/WXLpM/dypHzS390HKR03VES5Yu1SKK35r/bHSUDeIXwVAMFBg4qJVL0Wj7wTDvs3KHR5xKSpkH/jf+8AloVy++YqJ9KhhRxm3mYgzZZwcp9Dm4OlvtSRD49uPiTCcTKlu7swEj5nW9QUa1/vy/XVpBL4wDTxZb12H5rmIVRDXUpPlRQiaiV40qGxbziXKUS9oe3ERyQ6xls2N2+7cvU47fD5J3HTErbIz9kKBrRfLhZsm0xvRhdRzBqoRln/Kzb/FhQA/e4x0SkRzPOGGnv5bXt9XkrVBxs8luczKGrVwlRysSVmx5zSRavDReVd149ZOjrMQ07+1iC2qWH X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199021)(82310400008)(46966006)(36840700001)(40470700004)(47076005)(478600001)(110136005)(54906003)(86362001)(70586007)(6636002)(4326008)(1076003)(316002)(70206006)(356005)(7636003)(40480700001)(186003)(6666004)(8676002)(336012)(26005)(82740400003)(40460700003)(8936002)(2906002)(426003)(41300700001)(5660300002)(2616005)(36756003)(83380400001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 17:58:33.0949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9616b4d-734c-4920-5bfb-08db8ecb17d4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Lin Ma The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in vdpa_nl_policy may lead to illegal nlattr after parsing, which could lead to OOB read just like CVE-2023-3773. This patch adds the missing nla_policy for vdpa queue index attr to avoid such bugs. Fixes: 13b00b135665 ("vdpa: Add support for querying vendor statistics") Signed-off-by: Lin Ma Cc: stable@vger.kernelorg --- drivers/vdpa/vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 3ad355a2208a..75f1df2b9d2a 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -1249,6 +1249,7 @@ static const struct nla_policy vdpa_nl_policy[VDPA_AT= TR_MAX + 1] =3D { [VDPA_ATTR_DEV_NET_CFG_MACADDR] =3D NLA_POLICY_ETH_ADDR, /* virtio spec 1.1 section 5.1.4.1 for valid MTU range */ [VDPA_ATTR_DEV_NET_CFG_MTU] =3D NLA_POLICY_MIN(NLA_U16, 68), + [VDPA_ATTR_DEV_QUEUE_INDEX] =3D { .type =3D NLA_U32 }, [VDPA_ATTR_DEV_FEATURES] =3D { .type =3D NLA_U64 }, }; =20 --=20 2.41.0 From nobody Sat Feb 7 17:40:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF16C04A94 for ; Thu, 27 Jul 2023 17:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231926AbjG0R64 (ORCPT ); Thu, 27 Jul 2023 13:58:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231547AbjG0R6x (ORCPT ); Thu, 27 Jul 2023 13:58:53 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AE27359A; Thu, 27 Jul 2023 10:58:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhFpAlpceAqnHbX27Eb4cDdbqsvEtqSDpgANc05Y3P1cBOJEobhIidBiqAQczqR2WEV9fNCvWnPplzkLOEJI6TH15EsJxcRpJwMH3lRxAGYjVu30KCVko6tYkdUTWfNWi6nyquOLl7r6+zhA5yrBHNF69vgn06cNj7z7T5CzvZ4gKbaiw9Kh1mmcPKnKV3vaalZ8ll7pjKAyhFhxSKuJNB/5wJg37gekI4ZCK6qfzarVuZnHvWMwlCSZIig9g10++rVcwnKT0GmCgA8JkCqR6mqoxo3KPJpxp8SXJ8LhRTkMy+5QHFkUkYwoHpGIAO+I7mULPIGMvX/tA9GgBhSlwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X/3tFs4v94Tz6IrklufFaCOyoSSG3RlgQP34HXOjVRQ=; b=DmdcFrK4HLVzii2Xr2d+rV3RZMfzUjULfJwkK3gdJMbjYptJK+8oSTak2td5lqGyZvB+MqNKRh2Wh8XAoj3b6CQ+ely+1EXwhcEzPp1jFPhmZOV89DlwiOfhQAzZvXzobLpTYhrb6pIbi5MfNc1TBOrfoNVPeeCWAU7eNMMi1eB5UJaMLCH5R+8TIykZrMeXJs/iCO+NDXcvsseBakZVKvFmz6hgyi4/gVdjvDSjr3Z1iXYwhCefU2NHfT1OJTfv5w3n6mAHrM7xokuT5IhJNCXf8e2drvfDY4YWbswxyA1aS2e1+ehGufqnGLO7sSALw0C/eCcc0Uz9DO3iDIViTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/3tFs4v94Tz6IrklufFaCOyoSSG3RlgQP34HXOjVRQ=; b=Yfv940Upl4uvVhVA+5k2iWq9RMne+xXyYYCUF1CwZmD2eiwafK5v2sGg71oI7wQq+LZsAOiq27WFkthjP9TB6Uaq1oDJICgcQ6ph7dOAyBL9wveQbO/EUDr0il10I+PnSQtFtBah0WHDBuFsz9wo4U5bGKJeez99iZubbUW+p2VSW7YIyP7q8gr0J7/ot1LAp7pueCPNVacmFqDuJz3R+grGqUiHbbsXX9yQZQ97TMR61hu8WUxDxJG2bYBh4qejMjJQT5CrvsbIlWwtCwlLaYQUOUYFsDSTvM8BbJwsu/uFY5WONORQ+BHWmRUbctpHA8VwsbfWzBWl4H7NTZmzDg== Received: from BY3PR03CA0030.namprd03.prod.outlook.com (2603:10b6:a03:39a::35) by LV3PR12MB9260.namprd12.prod.outlook.com (2603:10b6:408:1b4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 17:58:43 +0000 Received: from DM6NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:39a:cafe::d9) by BY3PR03CA0030.outlook.office365.com (2603:10b6:a03:39a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DM6NAM11FT101.mail.protection.outlook.com (10.13.172.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:42 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 27 Jul 2023 10:58:29 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 27 Jul 2023 10:58:29 -0700 Received: from c-237-113-220-225.mtl.labs.mlnx (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 27 Jul 2023 10:58:27 -0700 From: Dragos Tatulea To: "Michael S . Tsirkin" , Lin Ma , "Jason Wang" , Xuan Zhuo , "Parav Pandit" CC: , , Subject: [PATCH 3/4] vdpa: Add max vqp attr to vdpa_nl_policy for nlattr length check Date: Thu, 27 Jul 2023 20:57:52 +0300 Message-ID: <20230727175757.73988-7-dtatulea@nvidia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230727175757.73988-1-dtatulea@nvidia.com> References: <20230727175757.73988-1-dtatulea@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT101:EE_|LV3PR12MB9260:EE_ X-MS-Office365-Filtering-Correlation-Id: eed779e9-cd5a-4f53-5ffe-08db8ecb1dab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OxZDZPfx73XLpNIXAhMUUQhAaBuDBwihAxVvBMXSyBmgZCdzYqpclttsfzEVF8bkPkyr+j1+jx9yIiSzZtwmhtvPPxnm7TYdZp8MCgCLtEbJnPpX9k1EuJIvG11MJFHGCds8Gz+5+l/Zl3zygw2S7j5/4YWNwbVxSO0HA9JeJ/kefffLiFena0wakVfw95ny4AjhuVXcGAUygU/c7htHaDx6gNmp+nSUNjmUG26uOfNcNVCYWXptQuJztx29sf6DfY1i+b9/qnUpqax/OWM6oOPjM7i1nTciELzNkjAcK0DTpD6reAzSk9x4KQppPt8gRKXEh/j7L9nRu/B1eKNZRmy+zpn51Jnt6SQ/Cq9rngLinVHDb1VoJTBYDFxFs/R965Ho2ct70vKrdIHFnShuYLEqCb3ZTI/DROKXxaHkn8ahXrf6TNRhh0FfiITK4pn+aRFT3IUE7R5sULh+PGEzgskTF7IF4eWzXfsSSvewNfbBBLSqY+rq9TOEJOLyF1cifBKXl4ETSxcUIKt1Jt0msvX98uJEeQzDOP45opFKYkhDPadxT8B+XcE9tPIj8z7UgjT0BMnpXlodfDT+prESPzhp7NLUdBfkaQdVeSez3UZrSsJcJBaRXoRyizI6fvjsgi/uOB+oSDvCds2ds0nZWrupG1lk2H7jM2uHvz+7P53IO7iJE9JrDXkkE18qapkYDRvXy9rP1DSVoQKwDEb2v65WNWXmXlmFOIY0+zNOIDpmwhUcRpOvhUDJ24Mhf7vh X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(82310400008)(451199021)(46966006)(36840700001)(40470700004)(86362001)(7636003)(356005)(36756003)(40460700003)(40480700001)(2906002)(110136005)(478600001)(54906003)(82740400003)(36860700001)(336012)(26005)(1076003)(186003)(426003)(2616005)(47076005)(41300700001)(6636002)(6666004)(316002)(8676002)(83380400001)(4326008)(70206006)(70586007)(5660300002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 17:58:42.8926 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eed779e9-cd5a-4f53-5ffe-08db8ecb1dab X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9260 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Lin Ma The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in vdpa_nl_policy may lead to illegal nlattr after parsing, which could lead to OOB read just like CVE-2023-3773. This patch adds the missing nla_policy for vdpa max vqp attr to avoid such bugs. Fixes: ad69dd0bf26b ("vdpa: Introduce query of device config layout") Signed-off-by: Lin Ma Cc: stable@vger.kernel.org --- drivers/vdpa/vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 75f1df2b9d2a..f2f654fd84e5 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -1247,6 +1247,7 @@ static const struct nla_policy vdpa_nl_policy[VDPA_AT= TR_MAX + 1] =3D { [VDPA_ATTR_MGMTDEV_DEV_NAME] =3D { .type =3D NLA_STRING }, [VDPA_ATTR_DEV_NAME] =3D { .type =3D NLA_STRING }, [VDPA_ATTR_DEV_NET_CFG_MACADDR] =3D NLA_POLICY_ETH_ADDR, + [VDPA_ATTR_DEV_NET_CFG_MAX_VQP] =3D { .type =3D NLA_U16 }, /* virtio spec 1.1 section 5.1.4.1 for valid MTU range */ [VDPA_ATTR_DEV_NET_CFG_MTU] =3D NLA_POLICY_MIN(NLA_U16, 68), [VDPA_ATTR_DEV_QUEUE_INDEX] =3D { .type =3D NLA_U32 }, --=20 2.41.0 From nobody Sat Feb 7 17:40:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B67AC00528 for ; Thu, 27 Jul 2023 17:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231739AbjG0R7Q (ORCPT ); Thu, 27 Jul 2023 13:59:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbjG0R7N (ORCPT ); Thu, 27 Jul 2023 13:59:13 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061.outbound.protection.outlook.com [40.107.223.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 312F935AB; Thu, 27 Jul 2023 10:59:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLBHt4hPKbCinSugMWxH95Cy41Mzg+gc041xHc2BPc6DpUiBgCN24p7atMrrfRDnDVBNqNJKMEqxcvPvGd0Id4qtQNipw8KFWUiC3NVnLAm6mLqzzK9cldID+ZNiOJ2Z/obWKdO3nxYUxL/qpGEuEE6ZUoYrhxWs/maXGqtfjPcIyTHCh2ARVjIynhoGaJ1eB7fh8bBr9eHm69kjE58Z4pEA5t2p0gfVaYvcOJzgq5TlK98hBKRy7CX0OqEnBFs7NH5kjsw/MG5vEWo5qo5DQnCf8oXvdgk5oFtNgTRGe1dbMK4fd2ITk4vilLpcA9s2LI8lHMMldq/A14qL0HpPAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lWZ4yQYXvfaU6H77EQjQMAfKQF5C9n/gZM5EhbTLcqc=; b=GmHjzlLJBqVV7LzeznmMyAwqI96bnafTX17cbbAQnxjbsY7XtZs0+mrVGTznrmi73htFekNIMfd+ykjYqflljRXkee/8eZCcbxlVQHWfk8aSKoZhWlEVbUHdQbr8mxonchMHFMz8iQg4HUyTUMlxUbbAetHYHTxDanU7XPwEGq4BrxbzwOzJVvlkIGaCO/7AROb/JqN8SwgLX9wwKvrrfe8yfrjsFy0u6lhAV9NUQSDxcwRHrtsHoOB+hA86dDz1E3xyyxLFo1jEa5WdA2vXcmCFhtnK4HrgXHZpjGdYg9qSFCsxk7iFX1AMLEuCZx/LSbMHEXV7Vh65R0aloZlkNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lWZ4yQYXvfaU6H77EQjQMAfKQF5C9n/gZM5EhbTLcqc=; b=D2mACUu93L9Qnx/6UXi8Pnmj/hO+ZSzaM0JkZJX4x0J+zCXISXFdVyJ6AaNuZ1bZB9jA/ttDS6UnDQUbuG+0ZfXGXEctlYIyjR22/VUW8Os9uzQBI8sfZa8JjxJ6pWRdkbdlH+dUIU0S9iAGi6fdwIEEakQHrWDcRV8xdWVgLh64i8E32XnJirhn1rJUMPcGsTfmmDLs3cVfz4Fbg1yH4OnMgskEbUb9+u4EE9JnpJUgTfJ/NSR4jB7sCMKhAbdtu/RHYq8k886rfZS9wi69xCr8rbYbFC8L7WDJHfhdFsExKtdT0y4Z+rJQ0jRdOTMjfS80JwksQ1dJ3rNDfFqfoQ== Received: from DS7PR06CA0034.namprd06.prod.outlook.com (2603:10b6:8:54::18) by DM6PR12MB4315.namprd12.prod.outlook.com (2603:10b6:5:223::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 17:58:58 +0000 Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:8:54:cafe::c3) by DS7PR06CA0034.outlook.office365.com (2603:10b6:8:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Thu, 27 Jul 2023 17:58:57 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 27 Jul 2023 10:58:43 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 27 Jul 2023 10:58:43 -0700 Received: from c-237-113-220-225.mtl.labs.mlnx (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 27 Jul 2023 10:58:40 -0700 From: Dragos Tatulea To: "Michael S . Tsirkin" , Lin Ma , "Jason Wang" , Xuan Zhuo , "Parav Pandit" CC: , , Dragos Tatulea , Subject: [PATCH 4/4] vdpa: Enable strict validation for netlinks ops Date: Thu, 27 Jul 2023 20:57:54 +0300 Message-ID: <20230727175757.73988-9-dtatulea@nvidia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230727175757.73988-1-dtatulea@nvidia.com> References: <20230727175757.73988-1-dtatulea@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|DM6PR12MB4315:EE_ X-MS-Office365-Filtering-Correlation-Id: 8538c0bd-97b6-4a3e-103e-08db8ecb269c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LBrs3yQ3ouZULM0fesYh6lwNEi2hqv5uXSP1pbGSWJ2VIKGU+rNKSqBdDD9TZLc1D1HgOKzYTu22jTHObw8Ucqxkl9pfJTD++ofIRtKDjgRNGUwNzLO9OUzC20plowtqr+/D1+1wC0bFiDfdoKQtJMkb140ToEjlRf1CZxGJ4AAdZOaJ6HUv5KMXp8YpuUUBNlyyBMh6n/f9eKfYH9M+RmN9LCKUulCCKgoa9+WtRcP7DSqJVa2cp80CptRTc5itIHDyXqV3Zn/ulgrtZEkJFLoX2xPHmX5R8KDd3olLY043sEf/8N18ZZ9i99FH11/Xg3M+pAjHvMccwEDGMFcLlzchWK1C9WE73zv0OtqA6N+O6RDj9cim6ju0PZRZXVruKlGLbQKMJuw2rXSfghGT5EnQyAUyTbRg1r7sPaBs9nppbIQct8GOCOwgbvPeIP4WNnkiwb7qTjrQmp46F8YeJYDg1V9LQgDiGFbtcYzxb927dJptO5PWmeIRgDWoFwBTwtXTFzTfVSV0XEF/z/YvI/MeRbW7PsTN+Yqf8vTjcH8apb4eUQ9bXWFrsh2kSi9u0oeuJoriK0jEC9z6T8hkguNKJlE5DMXXC9KsN9XSnGwNIxcSEKul14qlKSVF8JnEYaKkuAzSfYUwz0SnfKEXxTexr2CjXKj5B/CO5bHA0GYPVCNR1F+0VqybzvkWjNJidw3+/tv7lKfxZdLGWwu2ypgjVzVrXRVib0DGcqpEsRM7avHnClsJfdQ/F5oxjVUn X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(82310400008)(451199021)(36840700001)(46966006)(40470700004)(54906003)(110136005)(6666004)(2906002)(7636003)(40460700003)(478600001)(82740400003)(316002)(8936002)(5660300002)(8676002)(41300700001)(36756003)(356005)(40480700001)(4326008)(70206006)(6636002)(70586007)(336012)(1076003)(186003)(86362001)(26005)(36860700001)(2616005)(47076005)(426003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 17:58:57.8449 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8538c0bd-97b6-4a3e-103e-08db8ecb269c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4315 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The previous patches added the missing nla policies that were required for validation to work. Now strict validation on netlink ops can be enabled. This patch does it. Signed-off-by: Dragos Tatulea Cc: stable@vger.kernel.org --- drivers/vdpa/vdpa.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index f2f654fd84e5..a7612e0783b3 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -1257,37 +1257,31 @@ static const struct nla_policy vdpa_nl_policy[VDPA_= ATTR_MAX + 1] =3D { static const struct genl_ops vdpa_nl_ops[] =3D { { .cmd =3D VDPA_CMD_MGMTDEV_GET, - .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit =3D vdpa_nl_cmd_mgmtdev_get_doit, .dumpit =3D vdpa_nl_cmd_mgmtdev_get_dumpit, }, { .cmd =3D VDPA_CMD_DEV_NEW, - .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit =3D vdpa_nl_cmd_dev_add_set_doit, .flags =3D GENL_ADMIN_PERM, }, { .cmd =3D VDPA_CMD_DEV_DEL, - .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit =3D vdpa_nl_cmd_dev_del_set_doit, .flags =3D GENL_ADMIN_PERM, }, { .cmd =3D VDPA_CMD_DEV_GET, - .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit =3D vdpa_nl_cmd_dev_get_doit, .dumpit =3D vdpa_nl_cmd_dev_get_dumpit, }, { .cmd =3D VDPA_CMD_DEV_CONFIG_GET, - .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit =3D vdpa_nl_cmd_dev_config_get_doit, .dumpit =3D vdpa_nl_cmd_dev_config_get_dumpit, }, { .cmd =3D VDPA_CMD_DEV_VSTATS_GET, - .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit =3D vdpa_nl_cmd_dev_stats_get_doit, .flags =3D GENL_ADMIN_PERM, }, --=20 2.41.0