From nobody Mon Feb 9 11:26:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F93C0015E for ; Thu, 27 Jul 2023 12:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231157AbjG0M0D (ORCPT ); Thu, 27 Jul 2023 08:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234122AbjG0MZm (ORCPT ); Thu, 27 Jul 2023 08:25:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708AC4213 for ; Thu, 27 Jul 2023 05:24:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5120361E6C for ; Thu, 27 Jul 2023 12:24:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE583C433C7; Thu, 27 Jul 2023 12:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690460692; bh=DY00colqkK3gBCSjern+mAjAl2tFAKCXSE4uSH6JQ7I=; h=From:To:Cc:Subject:Date:From; b=WD+zHprzGffs66c97X6dMroL1XP2wNSq4L5QstSYLzptHJqgI8QX/Cfmlyso5Ohsa PHR2Zz7OnecACe/lBu51sO6GwOFqzmIWNUt8A5ncY4BSvqmn8wX0PJyOv/v6veR4/L 5QAzjcHnkaJ5LaLTsNwINjQqnigoyQwMjkwRNv72AyCWkcBitWv6q+A0idFjhj5d4Z JAUCmZ1J67K0LIHVoE7i9eF3WtVIDCZ/vHc1YmJ909RWpyveb28vWoxWJf9aD7XUvP +qN3FOAaK5DYt4rqqBttXIMFZYl5M2FN+pOkzjvpA5mX514c00HOvGcLG26jq3Lzc+ SRmnxeLssz/gQ== From: Arnd Bergmann To: Sudip Mukherjee Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] [v2] parport: mfc3: avoid empty-body warning Date: Thu, 27 Jul 2023 14:24:44 +0200 Message-Id: <20230727122448.2479942-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann on m68k builds, the mfc3 driver causes a warning about an empty if() block: drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3': drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around empty= body in an 'if' statement [-Wempty-body] Remove it in favor of a simpler comment. Signed-off-by: Arnd Bergmann Acked-by: Sudip Mukherjee --- v2: fix typo --- drivers/parport/parport_mfc3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/parport/parport_mfc3.c b/drivers/parport/parport_mfc3.c index f4d0da741e856..bb1817218d7b2 100644 --- a/drivers/parport/parport_mfc3.c +++ b/drivers/parport/parport_mfc3.c @@ -102,8 +102,7 @@ static unsigned char control_pc_to_mfc3(unsigned char c= ontrol) ret |=3D 128; if (control & PARPORT_CONTROL_AUTOFD) /* AUTOLF */ ret &=3D ~64; - if (control & PARPORT_CONTROL_STROBE) /* Strobe */ - /* Handled directly by hardware */; + /* PARPORT_CONTROL_STROBE handled directly by hardware */ return ret; } =20 --=20 2.39.2