From nobody Sun Feb 8 05:08:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D20C001E0 for ; Thu, 27 Jul 2023 07:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232955AbjG0HuR (ORCPT ); Thu, 27 Jul 2023 03:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232432AbjG0Ht4 (ORCPT ); Thu, 27 Jul 2023 03:49:56 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 859D3659F for ; Thu, 27 Jul 2023 00:43:14 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0VoJlfUx_1690443778; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VoJlfUx_1690443778) by smtp.aliyun-inc.com; Thu, 27 Jul 2023 15:43:09 +0800 From: Jiapeng Chong To: rostedt@goodmis.org Cc: mhiramat@kernel.org, karolherbst@gmail.com, ppaalanen@gmail.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] x86/mm/kmmio: return -ENOMEM when kzalloc failed Date: Thu, 27 Jul 2023 15:42:56 +0800 Message-Id: <20230727074256.118672-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. arch/x86/mm/kmmio.c:392 add_kmmio_fault_page() warn: returning -1 instead o= f -ENOMEM is sloppy. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D6002 Signed-off-by: Jiapeng Chong --- arch/x86/mm/kmmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c index 9f82019179e1..9aa5bcf5a836 100644 --- a/arch/x86/mm/kmmio.c +++ b/arch/x86/mm/kmmio.c @@ -389,14 +389,14 @@ static int add_kmmio_fault_page(unsigned long addr) =20 f =3D kzalloc(sizeof(*f), GFP_ATOMIC); if (!f) - return -1; + return -ENOMEM; =20 f->count =3D 1; f->addr =3D addr; =20 if (arm_kmmio_fault_page(f)) { kfree(f); - return -1; + return -ENOMEM; } =20 list_add_rcu(&f->list, kmmio_page_list(f->addr)); --=20 2.20.1.7.g153144c