From nobody Fri Sep 20 15:29:10 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A90C001E0 for ; Wed, 26 Jul 2023 08:33:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231757AbjGZIdd (ORCPT ); Wed, 26 Jul 2023 04:33:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233182AbjGZIcd (ORCPT ); Wed, 26 Jul 2023 04:32:33 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E0576E8B for ; Wed, 26 Jul 2023 01:22:57 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9EAE1660711A; Wed, 26 Jul 2023 09:22:55 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690359776; bh=p6gmZfJJo8EhnnnFpNEwiof9/9yla+KEGH6T0UfImeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TFzM3ofVtCf3lqUx6TyEtDxvrDjQcrVvPw3NPZzcI7jzYrcyucGXQElJit6uImsM+ fSNPAXzX7C8V4mWzssLCkHbOI/Ag7x6v5C931ccXJWeMGMvq4ge9pWTDEZ8dYAp1m6 0BVIeXg5mCOiG0xZfLmYvb1tVHN4w/EId0TdwEkj+DUcxWzd5Gwlw2xcxSxyioInz6 f6vdN41NhZQnlXvjf+yGps0jMonwEVMEbYn9LGUesIgzPmNg4OrTIhf2mnbRJY3He8 BPQ4sFnl3DYSLkAI/9rWp+QaHB8YouQ0Uw12lOnhbUxt4OkWp/2TGNzvmgJxe1gEue aMa4E8uBw+p9A== From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, fshao@chromium.org, CK Hu Subject: [PATCH v3 2/6] drm/mediatek: mtk_dpi: Simplify with dev_err_probe() Date: Wed, 26 Jul 2023 10:22:41 +0200 Message-ID: <20230726082245.550929-3-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230726082245.550929-1-angelogioacchino.delregno@collabora.com> References: <20230726082245.550929-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use dev_err_probe() across the entire probe function of this driver to shrink the size. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 44 ++++++++++-------------------- 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/= mtk_dpi.c index e4ee0d02893a..fdd5b7126e27 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -1039,38 +1039,24 @@ static int mtk_dpi_probe(struct platform_device *pd= ev) } mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); dpi->regs =3D devm_ioremap_resource(dev, mem); - if (IS_ERR(dpi->regs)) { - ret =3D PTR_ERR(dpi->regs); - dev_err(dev, "Failed to ioremap mem resource: %d\n", ret); - return ret; - } + if (IS_ERR(dpi->regs)) + return dev_err_probe(dev, PTR_ERR(dpi->regs), + "Failed to ioremap mem resource\n"); =20 dpi->engine_clk =3D devm_clk_get(dev, "engine"); - if (IS_ERR(dpi->engine_clk)) { - ret =3D PTR_ERR(dpi->engine_clk); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "Failed to get engine clock: %d\n", ret); - - return ret; - } + if (IS_ERR(dpi->engine_clk)) + return dev_err_probe(dev, PTR_ERR(dpi->engine_clk), + "Failed to get engine clock\n"); =20 dpi->pixel_clk =3D devm_clk_get(dev, "pixel"); - if (IS_ERR(dpi->pixel_clk)) { - ret =3D PTR_ERR(dpi->pixel_clk); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "Failed to get pixel clock: %d\n", ret); - - return ret; - } + if (IS_ERR(dpi->pixel_clk)) + return dev_err_probe(dev, PTR_ERR(dpi->pixel_clk), + "Failed to get pixel clock\n"); =20 dpi->tvd_clk =3D devm_clk_get(dev, "pll"); - if (IS_ERR(dpi->tvd_clk)) { - ret =3D PTR_ERR(dpi->tvd_clk); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "Failed to get tvdpll clock: %d\n", ret); - - return ret; - } + if (IS_ERR(dpi->tvd_clk)) + return dev_err_probe(dev, PTR_ERR(dpi->tvd_clk), + "Failed to get tvdpll clock\n"); =20 dpi->irq =3D platform_get_irq(pdev, 0); if (dpi->irq <=3D 0) @@ -1094,10 +1080,8 @@ static int mtk_dpi_probe(struct platform_device *pde= v) return ret; =20 ret =3D component_add(dev, &mtk_dpi_component_ops); - if (ret) { - dev_err(dev, "Failed to add component: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to add component.\n"); =20 return 0; } --=20 2.41.0