From nobody Sat Feb 7 16:43:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F7AC0015E for ; Mon, 24 Jul 2023 17:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230458AbjGXRt5 (ORCPT ); Mon, 24 Jul 2023 13:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231880AbjGXRta (ORCPT ); Mon, 24 Jul 2023 13:49:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 732DF4686 for ; Mon, 24 Jul 2023 10:46:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 529366132A for ; Mon, 24 Jul 2023 17:45:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 808FAC433C8; Mon, 24 Jul 2023 17:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690220723; bh=F0EIIGsmfIB+Y7QbLwduV6cHaLIhokS7WljeV8e+XkQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nT369RIaytZKoua0dAoPD1E3ysYvjzoA7UIVRcXqwLuM2p29Xx48/D7VyYYKhumdy k7BNjmgz3bmm1pcPYlKPB8dnI1+ADa9nAw2A22dv8TrStw6hi2GMp7LjhPHQ7xKd77 wlWeQgvB+Cwv35BEJXNdXF6loAJBFGtCQRNHM1oVqyHn6b0cQZOfea5DX8jsJnJkG1 QH18n5Fpu3ILSCclHpkqgMTAeuIwTLVK0/4DLxverZTT9Rmaf3yLLvCrdsq2Xd9/Uc gwbEnL7i4xzLxdznfyc70BcTJiwRgJB6s6AYTtcnvDxIgjU88HFv74nYB5NbS/7pi7 7SiuRtg09vjLQ== From: Will Deacon To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Will Deacon , Josh Poimboeuf , John Stultz Subject: [PATCH 1/2] scripts/faddr2line: Ignore non-function symbols in readelf output Date: Mon, 24 Jul 2023 18:45:16 +0100 Message-Id: <20230724174517.15736-2-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230724174517.15736-1-will@kernel.org> References: <20230724174517.15736-1-will@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Non-function symbols emitted in the readelf output can confuse the 'faddr2line' symbol size calculation, resulting in the erroneous rejection of valid offsets. This is especially prevalent when building an arm64 kernel with CONFIG_CFI_CLANG=3Dy, where most functions are prefixed with a 32-bit data value in a '$d.n' section. For example: 447538: ffff800080014b80 548 FUNC GLOBAL DEFAULT 2 do_one_initcall 104: ffff800080014c74 0 NOTYPE LOCAL DEFAULT 2 $x.73 106: ffff800080014d30 0 NOTYPE LOCAL DEFAULT 2 $x.75 111: ffff800080014da4 0 NOTYPE LOCAL DEFAULT 2 $d.78 112: ffff800080014da8 0 NOTYPE LOCAL DEFAULT 2 $x.79 36: ffff800080014de0 200 FUNC LOCAL DEFAULT 2 run_init_process Adding a warning to do_one_initcall() results in: | WARNING: CPU: 0 PID: 1 at init/main.c:1236 do_one_initcall+0xf4/0x260 Which 'faddr2line' refuses to accept: $ ./scripts/faddr2line vmlinux do_one_initcall+0xf4/0x260 skipping do_one_initcall address at 0xffff800080014c74 due to size mismatch= (0x260 !=3D 0x224) no match for do_one_initcall+0xf4/0x260 Filter out entries from readelf that are not "FUNC" type, so that the size of a symbol is calculated as a delta to the next function address. Cc: Josh Poimboeuf Cc: John Stultz Signed-off-by: Will Deacon --- scripts/faddr2line | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/faddr2line b/scripts/faddr2line index 0e73aca4f908..60368a1cdaed 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -179,7 +179,7 @@ __faddr2line() { found=3D2 break fi - done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK= } -v sec=3D$sym_sec '$7 =3D=3D sec' | sort --key=3D2) + done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK= } -v sec=3D$sym_sec '$4 =3D=3D "FUNC" && $7 =3D=3D sec' | sort --key=3D2) =20 if [[ $found =3D 0 ]]; then warn "can't find symbol: sym_name: $sym_name sym_sec: $sym_sec sym_addr= : $sym_addr sym_elf_size: $sym_elf_size" --=20 2.41.0.487.g6d72f3e995-goog From nobody Sat Feb 7 16:43:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495CBC0015E for ; Mon, 24 Jul 2023 17:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbjGXRtI (ORCPT ); Mon, 24 Jul 2023 13:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231869AbjGXRsc (ORCPT ); Mon, 24 Jul 2023 13:48:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2145D4203 for ; Mon, 24 Jul 2023 10:45:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDE4F61312 for ; Mon, 24 Jul 2023 17:45:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04EDAC433C7; Mon, 24 Jul 2023 17:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690220725; bh=i/3ARKu2v/GvD5MJ/ESSUDjGzezlHuJEXEcQosWyGxw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=giw/2Q3xI3BJd+qXlnT5waP43ZXAgYm5VhgjSj8yRAByRpbbHrtlZsqiolfmNQk0i 9HJLQz5NPiV08MPYrJ6x7nH2ect7N6NvRMGZghRrPOgaRLIrlqOZf5EJOYlc9RzX/4 5ngKvNYTRf4aUYODIPD7qPFn7Y4ZiMkWyCYXtnWpN3tqYtZtSn0epwmlsWWRxu5lAo kjX90gJ3/G07/dWqJg69QhS8+ZXaP3V7B4jfPrg/32i814sfzCN5TmHSsTTxhaqp/O obRFovv3/hPnlQlKKgkUK8vWusSRcFQ6PvhrSzwDXAMRjFCIhMGBKd7xf9v391UjHE d8CHYroZ1sJNg== From: Will Deacon To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Will Deacon , Josh Poimboeuf , John Stultz Subject: [PATCH 2/2] scripts/faddr2line: Use LLVM addr2line and readelf if LLVM=1 Date: Mon, 24 Jul 2023 18:45:17 +0100 Message-Id: <20230724174517.15736-3-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230724174517.15736-1-will@kernel.org> References: <20230724174517.15736-1-will@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" GNU utilities cannot necessarily parse objects built by LLVM, which can result in confusing errors when using 'faddr2line': $ CROSS_COMPILE=3Daarch64-linux-gnu- ./scripts/faddr2line vmlinux do_one_in= itcall+0xf4/0x260 aarch64-linux-gnu-addr2line: vmlinux: unknown type [0x13] section `.relr.dy= n' aarch64-linux-gnu-addr2line: DWARF error: invalid or unhandled FORM value: = 0x25 do_one_initcall+0xf4/0x260: aarch64-linux-gnu-addr2line: vmlinux: unknown type [0x13] section `.relr.dy= n' aarch64-linux-gnu-addr2line: DWARF error: invalid or unhandled FORM value: = 0x25 $x.73 at main.c:? Although this can be worked around by setting CROSS_COMPILE to "llvm=3D-", it's cleaner to follow the same syntax as the top-level Makefile and accept LLVM=3D1 as an indication to use the llvm- tools. Cc: Josh Poimboeuf Cc: John Stultz Signed-off-by: Will Deacon --- scripts/faddr2line | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/faddr2line b/scripts/faddr2line index 60368a1cdaed..24845267efb2 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -58,8 +58,14 @@ die() { exit 1 } =20 -READELF=3D"${CROSS_COMPILE:-}readelf" -ADDR2LINE=3D"${CROSS_COMPILE:-}addr2line" +if [ "${LLVM:-}" =3D=3D "1" ]; then + UTIL_PREFIX=3Dllvm- +else + UTIL_PREFIX=3D${CROSS_COMPILE:-} +fi + +READELF=3D"${UTIL_PREFIX}readelf" +ADDR2LINE=3D"${UTIL_PREFIX}addr2line" AWK=3D"awk" GREP=3D"grep" =20 --=20 2.41.0.487.g6d72f3e995-goog