From nobody Fri Dec 19 07:47:27 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EFBC0015E for ; Mon, 24 Jul 2023 13:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231853AbjGXNi5 (ORCPT ); Mon, 24 Jul 2023 09:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbjGXNiZ (ORCPT ); Mon, 24 Jul 2023 09:38:25 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ADE93C10 for ; Mon, 24 Jul 2023 06:36:47 -0700 (PDT) Message-ID: <20230724132047.780772553@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690205718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=O0XTJMurd8agT9XR8N/9h35QD+xMCyVQhi7/zAo436M=; b=ZWXoG6IobDx6riWyjqKv9qh46qsw9PmprJtJxi4cys5MjKFTsvisDgmmRYUsv+el8SE71+ KXGU+c97azP3w1HyMNrA3DQs+oh+YqGjJiymvTiUP0QxmnEYO3Mlp+lhxR1X1IcQPyG8nX P9dx2m+we7FjI8tMuwYh14bjeIaUp2jhqes9xOzIVU14C3OjlP4XFcMk3biwaxEbgBrY52 Z5LI1bs0PmVBhwbbadTB01QVmLhMncMo1ROmsMXQSaMIWG5r6vHe2wxjPzofoHS/YRkETT 33PvP6hUv45T2UDOBZUPEhgf9sRgPyBSxsxut+X2/33WJQF3HjDIl8Zt/h3rkg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690205718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=O0XTJMurd8agT9XR8N/9h35QD+xMCyVQhi7/zAo436M=; b=bi4hxsCuLFaqNkJLJd0Of7FbqVBIiWHA7kyC7kZlN4qP2gWFrXinMDkuM/ShQlOGiW1Ghl nFxs6eylWxcHPgCQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross , Michael Kelley , Peter Keresztes Schmidt , "Peter Zijlstra (Intel)" Subject: [patch V2 54/58] x86/xen/apic: Mark apic __ro_after_init References: <20230724131206.500814398@linutronix.de> MIME-Version: 1.0 Date: Mon, 24 Jul 2023 15:35:17 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Nothing can change it post init. Remove the 32bit callbacks and comments as XENPV is strictly 64bit. While at it mop up the whitespace damage which causes eyebleed due to an editor which is highlighting it. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) Cc: Juergen Gross --- arch/x86/xen/apic.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) --- a/arch/x86/xen/apic.c +++ b/arch/x86/xen/apic.c @@ -123,39 +123,37 @@ static int xen_cpu_present_to_apicid(int return BAD_APICID; } =20 -static struct apic xen_pv_apic =3D { - .name =3D "Xen PV", - .probe =3D xen_apic_probe_pv, +static struct apic xen_pv_apic __ro_after_init =3D { + .name =3D "Xen PV", + .probe =3D xen_apic_probe_pv, .acpi_madt_oem_check =3D xen_madt_oem_check, =20 /* .delivery_mode and .dest_mode_logical not used by XENPV */ =20 .disable_esr =3D 0, =20 - .check_apicid_used =3D default_check_apicid_used, /* Used on 32-bit */ - .ioapic_phys_id_map =3D default_ioapic_phys_id_map, /* Used on 32-bit */ .cpu_present_to_apicid =3D xen_cpu_present_to_apicid, .phys_pkg_id =3D xen_phys_pkg_id, /* detect_ht */ =20 .max_apic_id =3D UINT_MAX, - .get_apic_id =3D xen_get_apic_id, - .set_apic_id =3D xen_set_apic_id, /* Can be NULL on 32-bit. */ + .get_apic_id =3D xen_get_apic_id, + .set_apic_id =3D xen_set_apic_id, =20 .calc_dest_apicid =3D apic_flat_calc_apicid, =20 #ifdef CONFIG_SMP - .send_IPI_mask =3D xen_send_IPI_mask, - .send_IPI_mask_allbutself =3D xen_send_IPI_mask_allbutself, - .send_IPI_allbutself =3D xen_send_IPI_allbutself, - .send_IPI_all =3D xen_send_IPI_all, - .send_IPI_self =3D xen_send_IPI_self, + .send_IPI_mask =3D xen_send_IPI_mask, + .send_IPI_mask_allbutself =3D xen_send_IPI_mask_allbutself, + .send_IPI_allbutself =3D xen_send_IPI_allbutself, + .send_IPI_all =3D xen_send_IPI_all, + .send_IPI_self =3D xen_send_IPI_self, #endif .read =3D xen_apic_read, .write =3D xen_apic_write, .eoi =3D xen_apic_eoi, =20 - .icr_read =3D xen_apic_icr_read, - .icr_write =3D xen_apic_icr_write, + .icr_read =3D xen_apic_icr_read, + .icr_write =3D xen_apic_icr_write, }; =20 static void __init xen_apic_check(void)