From nobody Sun Feb 8 21:12:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CE0C001B0 for ; Mon, 24 Jul 2023 02:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230257AbjGXCa3 (ORCPT ); Sun, 23 Jul 2023 22:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbjGXCaY (ORCPT ); Sun, 23 Jul 2023 22:30:24 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF313BF for ; Sun, 23 Jul 2023 19:30:12 -0700 (PDT) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R8PGv5HsHzVjXK; Mon, 24 Jul 2023 10:28:39 +0800 (CST) Received: from huawei.com (10.90.53.73) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 24 Jul 2023 10:30:10 +0800 From: Zhang Jianhua To: , , , , , CC: , , Subject: [PATCH -next] arm64: fix -Wundef warning for PUD_SHIFT Date: Mon, 24 Jul 2023 10:30:55 +0000 Message-ID: <20230724103055.2379274-1-chris.zjh@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building with W=3D1, the following warning occurs. arch/arm64/include/asm/kernel-pgtable.h:129:41: error: "PUD_SHIFT" is not d= efined, evaluates to 0 [-Werror=3Dundef] 129 | #define ARM64_MEMSTART_SHIFT PUD_SHIFT | ^~~~~~~~~ arch/arm64/include/asm/kernel-pgtable.h:142:5: note: in expansion of macro = =E2=80=98ARM64_MEMSTART_SHIFT=E2=80=99 142 | #if ARM64_MEMSTART_SHIFT < SECTION_SIZE_BITS | ^~~~~~~~~~~~~~~~~~~~ The reason is that PUD_SHIFT isn't defined if CONFIG_PGTABLE_LEVELS =3D=3D 3, and at this time PUD_SHIFT is equal to PGDIR_SHIFT, so define it. Fixes: 06e9bf2fd9b3 ("arm64: choose memstart_addr based on minimum sparseme= m section alignment") Signed-off-by: Zhang Jianhua --- v2: Define PUD_SHIFT before use it instead of judgement --- --- arch/arm64/include/asm/kernel-pgtable.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/include/asm/kernel-pgtable.h b/arch/arm64/include/a= sm/kernel-pgtable.h index 577773870b66..996a144e2929 100644 --- a/arch/arm64/include/asm/kernel-pgtable.h +++ b/arch/arm64/include/asm/kernel-pgtable.h @@ -59,6 +59,10 @@ #define EARLY_KASLR (0) #endif =20 +#ifndef PUD_SHIFT +#define PUD_SHIFT PGDIR_SHIFT +#endif + #define SPAN_NR_ENTRIES(vstart, vend, shift) \ ((((vend) - 1) >> (shift)) - ((vstart) >> (shift)) + 1) =20 --=20 2.34.1