From nobody Tue Feb 10 00:57:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2695C001DC for ; Sat, 22 Jul 2023 21:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbjGVV7l (ORCPT ); Sat, 22 Jul 2023 17:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjGVV7j (ORCPT ); Sat, 22 Jul 2023 17:59:39 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37305213B for ; Sat, 22 Jul 2023 14:59:19 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-345a8a78bcfso15125355ab.2 for ; Sat, 22 Jul 2023 14:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063158; x=1690667958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ICetZO3eJiINHtdQ5D1OIXxRMuzgneIba8TDtaF3d6E=; b=igpp763ye/MqzfrVlap+d88m97CjjDSbCeJm4qM2yOg4Dwtmx5u8AdHOLXLkJCzkm8 7DFM7SaC1F7H2GPAx7glIjuGmgq2JeKs7f69g/V6g0rvoEbaOEi1JCRFARaKnmXtkqSp /GEmm47vUybvNxMw7uWIabGvVXajEPZ4Oma8UGOpARHi8Ao3xQqlkan4d6Vl9KL0c961 CQttcuwVX6BIQIOfZridUj9pUtxJNdoOi7osLW2fmsWIwCXNPofhHotnemBNKK1CdjoD yuyRm5bGtpnFUrDebwjZ4pVCHjdfJn5FWSFeBb47MSeKu7Sfr40eiyeNbny9j1kPMYtb MWaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063158; x=1690667958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ICetZO3eJiINHtdQ5D1OIXxRMuzgneIba8TDtaF3d6E=; b=lrCBnn3rm583vH3OSZ9is/uYI5lZ7/uaiJqQZi429U7KMn1JxV/xK3pIfSGJsIaIv4 iYW3BZfMbgeCZXEogQfu2n0rxq57gAzn9t6DPfVUh0l85u4kDnQO/bpJwRfJiu6M6teD xpNRpnT7abvNyEp2fEKN0kN410m6cSeeL5dJuZNWjl5xRzoRSMd8ztpZOtXPMPhtn1VZ y6883maU+5wBwhJNj1zsEsCXJh7KiIzI7GKRG5sRpeYWe7vJVXK3+frBku+DIofc7D2e 5OUuDIOZzu8Q5LJKpa5ei7qhe9R1UEUi0N1ocMTPL0Das4Swa/0uAenJMaIMv/cnKwB8 ZhNg== X-Gm-Message-State: ABy/qLZI32JzK1dkHLbOVhvTaKbZwNkV3m3dY5TZtPuj+x8PfhomudXJ srLCF8VHY5thUekccyOKmpY= X-Google-Smtp-Source: APBJJlHXV0jmg/1doLTbZ3FFNTvdBkhrS+Ce1zxiK5mVCmupiC8T+9vMTzdib9n7CCIgyNTl0x1CRw== X-Received: by 2002:a05:6602:2993:b0:787:8fc:307d with SMTP id o19-20020a056602299300b0078708fc307dmr4086777ior.5.1690063158515; Sat, 22 Jul 2023 14:59:18 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id t18-20020a02ccb2000000b0042af069eeefsm1869614jap.50.2023.07.22.14.59.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:59:18 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 8/9] staging: rtl8723bs: ioctl_linux: Add preferred spaces Date: Sat, 22 Jul 2023 23:59:16 +0200 Message-Id: <20230722215916.4413-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issues: - CHECK: spaces preferred around that '+' (ctx:VxV) - CHECK: spaces preferred around that '&' (ctx:VxV) - CHECK: spaces preferred around that '|' (ctx:VxV) - CHECK: spaces required around that ':' (ctx:VxV) Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 88f560353df7..2896d64e13be 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -13,7 +13,7 @@ #include #include =20 -#define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30) +#define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV + 30) =20 static int wpa_set_auth_algs(struct net_device *dev, u32 value) { @@ -315,18 +315,18 @@ static int rtw_set_wpa_ie(struct adapter *padapter, c= har *pie, unsigned short ie while (cnt < ielen) { eid =3D buf[cnt]; =20 - if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&buf[cnt+2], wps= _oui, 4))) { - padapter->securitypriv.wps_ie_len =3D ((buf[cnt+1]+2) < MAX_WPS_IE_LE= N) ? (buf[cnt+1]+2):MAX_WPS_IE_LEN; + if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&buf[cnt + 2], w= ps_oui, 4))) { + padapter->securitypriv.wps_ie_len =3D ((buf[cnt + 1] + 2) < MAX_WPS_I= E_LEN) ? (buf[cnt + 1] + 2) : MAX_WPS_IE_LEN; =20 memcpy(padapter->securitypriv.wps_ie, &buf[cnt], padapter->securitypr= iv.wps_ie_len); =20 set_fwstate(&padapter->mlmepriv, WIFI_UNDER_WPS); =20 - cnt +=3D buf[cnt+1]+2; + cnt +=3D buf[cnt + 1] + 2; =20 break; } else { - cnt +=3D buf[cnt+1]+2; /* goto next */ + cnt +=3D buf[cnt + 1] + 2; /* goto next */ } } } @@ -359,7 +359,7 @@ static int wpa_set_param(struct net_device *dev, u8 nam= e, u32 value) =20 /* ret =3D ieee80211_wpa_enable(ieee, value); */ =20 - switch ((value)&0xff) { + switch ((value) & 0xff) { case 1: /* WPA */ padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; /* WP= A_PSK */ padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption2Enabl= ed; @@ -758,7 +758,7 @@ static int rtw_set_beacon(struct net_device *dev, struc= t ieee_param *param, int if ((pstapriv->max_num_sta > NUM_STA) || (pstapriv->max_num_sta <=3D 0)) pstapriv->max_num_sta =3D NUM_STA; =20 - if (rtw_check_beacon_data(padapter, pbuf, (len-12-2)) =3D=3D _SUCCESS)/*= 12 =3D param header, 2:no packed */ + if (rtw_check_beacon_data(padapter, pbuf, (len - 12 - 2)) =3D=3D _SUCCES= S)/* 12 =3D param header, 2:no packed */ ret =3D 0; else ret =3D -EINVAL; @@ -787,7 +787,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && @@ -815,7 +815,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) memcpy(psta->bssrateset, param->u.add_sta.tx_supp_rates, 16); =20 /* check wmm cap. */ - if (WLAN_STA_WME&flags) + if (WLAN_STA_WME & flags) psta->qos_option =3D 1; else psta->qos_option =3D 0; @@ -824,7 +824,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) psta->qos_option =3D 0; =20 /* chec 802.11n ht cap. */ - if (WLAN_STA_HT&flags) { + if (WLAN_STA_HT & flags) { psta->htpriv.ht_option =3D true; psta->qos_option =3D 1; memcpy((void *)&psta->htpriv.ht_cap, (void *)¶m->u.add_sta.ht_cap, = sizeof(struct ieee80211_ht_cap)); @@ -852,7 +852,7 @@ static int rtw_del_sta(struct net_device *dev, struct i= eee_param *param) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && @@ -891,7 +891,7 @@ static int rtw_ioctl_get_sta_data(struct net_device *de= v, struct ieee_param *par struct ieee_param_ex *param_ex =3D (struct ieee_param_ex *)param; struct sta_data *psta_data =3D (struct sta_data *)param_ex->data; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param_ex->sta_addr[0] =3D=3D 0xff && param_ex->sta_addr[1] =3D=3D 0xf= f && @@ -948,7 +948,7 @@ static int rtw_get_sta_wpaie(struct net_device *dev, st= ruct ieee_param *param) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && @@ -965,7 +965,7 @@ static int rtw_get_sta_wpaie(struct net_device *dev, st= ruct ieee_param *param) =20 wpa_ie_len =3D psta->wpa_ie[1]; =20 - copy_len =3D ((wpa_ie_len+2) > sizeof(psta->wpa_ie)) ? (sizeof(psta->wp= a_ie)):(wpa_ie_len+2); + copy_len =3D ((wpa_ie_len + 2) > sizeof(psta->wpa_ie)) ? (sizeof(psta->= wpa_ie)) : (wpa_ie_len + 2); =20 param->u.wpa_ie.len =3D copy_len; =20 @@ -990,7 +990,7 @@ static int rtw_set_wps_beacon(struct net_device *dev, s= truct ieee_param *param, if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ =20 kfree(pmlmepriv->wps_beacon_ie); pmlmepriv->wps_beacon_ie =3D NULL; @@ -1021,7 +1021,7 @@ static int rtw_set_wps_probe_resp(struct net_device *= dev, struct ieee_param *par if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ =20 kfree(pmlmepriv->wps_probe_resp_ie); pmlmepriv->wps_probe_resp_ie =3D NULL; @@ -1048,7 +1048,7 @@ static int rtw_set_wps_assoc_resp(struct net_device *= dev, struct ieee_param *par if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ =20 kfree(pmlmepriv->wps_assoc_resp_ie); pmlmepriv->wps_assoc_resp_ie =3D NULL; @@ -1086,14 +1086,14 @@ static int rtw_set_hidden_ssid(struct net_device *d= ev, struct ieee_param *param, =20 mlmeinfo->hidden_ssid_mode =3D ignore_broadcast_ssid =3D param->u.bcn_ie.= reserved[1]; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ ssid_ie =3D rtw_get_ie(param->u.bcn_ie.buf, WLAN_EID_SSID, &ssid_len, ie= _len); =20 if (ssid_ie && ssid_len > 0 && ssid_len <=3D NDIS_802_11_LENGTH_SSID) { struct wlan_bssid_ex *pbss_network =3D &mlmepriv->cur_network.network; struct wlan_bssid_ex *pbss_network_ext =3D &mlmeinfo->network; =20 - memcpy(ssid, ssid_ie+2, ssid_len); + memcpy(ssid, ssid_ie + 2, ssid_len); ssid[ssid_len] =3D 0x0; =20 memcpy(pbss_network->ssid.ssid, (void *)ssid, ssid_len); --=20 2.39.2 (Apple Git-143)