From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A5EC0015E for ; Sat, 22 Jul 2023 21:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbjGVV5u (ORCPT ); Sat, 22 Jul 2023 17:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjGVV5s (ORCPT ); Sat, 22 Jul 2023 17:57:48 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 869F51737 for ; Sat, 22 Jul 2023 14:57:47 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-348c62db335so3080975ab.0 for ; Sat, 22 Jul 2023 14:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063067; x=1690667867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NiYt7Tw0QK7f0nlz4SKEHhaEGnGqAWTc0j4eEPb3kRI=; b=ZJmJmCWE6gO0q9V9V7FLGpi9A4sxOAgfALRUjFO1sPEb0pIScMYl62jlC6Pn9DLgCW lh8vILEeXCl1UJGK+2mB/w/LPHM9XBX979nhfs3fTb02+J69Gu+SDKdFSnt24EJ5eE3G XhUlBC6wvB7Kd8NeiBh5szHXZgPJMko0q1bt+84LLMMLcZuh33lg9bqJWhLHAkE/aVT1 T9G+LJcn6Ey3U8dDNr6jcNjklx73XESyrjmfRSFNjOBkU8oj/wtq+17sxR8gyoIPSAD5 vNYvuxEZh/5PIJqoUViaPdihnIEYn+Df+rz4QuubdqxvFKYgjNzk36UXP+4nz834jw0F Gtvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063067; x=1690667867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NiYt7Tw0QK7f0nlz4SKEHhaEGnGqAWTc0j4eEPb3kRI=; b=kQa7fqFF3wCNzdgu3amSOQiOCCpN1BQAv/Q1sEV9TeVY9+/vBi/ayYMvkBlbCkqvRK R20O94y4oKvjpxQ5U6OkTx3+xZmUvgrDOwwNvlm+k5kXnCmLrCPoxUwUL0jfZKniOB56 q6hQRejCS7mODUX7TtAPXzM/3mxgugQINI8Pk6BGvlQRu3U1nL+/6gDMRntRQLZmmUw5 kmdlcLWOa8AdTUEsVI3SQI388KpvzIDAG/xUmIUChRjJYo7YB/l10qoFb+9qd7ab1jpq QZ2MzW13ugufG+1Ya0PFjrjucs/agyG3OIN0nyi1uZmJQkDbqhCWIlSfCZytHJGCEM3v yolA== X-Gm-Message-State: ABy/qLZZ5KU61b7w9q/ql8EkrGBUhzzBBr/MMr4Lg+v06pFJpP1P/yIk D/OVAd5NCOqiRPFM3V4RRCc= X-Google-Smtp-Source: APBJJlHn9jzE35Il7Hl7iVud49hHzAOTyod5n63H74V9XLwnE7acIsYFtMK2mdecTsPOx2PVVYZ71w== X-Received: by 2002:a92:d943:0:b0:348:8050:d7a with SMTP id l3-20020a92d943000000b0034880500d7amr3536447ilq.30.1690063066913; Sat, 22 Jul 2023 14:57:46 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id dp21-20020a0566381c9500b0042b1061c6a8sm1966166jab.84.2023.07.22.14.57.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:57:46 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 1/9] staging: rtl8723bs: ioctl_linux: Fix else on next line Date: Sat, 22 Jul 2023 23:57:36 +0200 Message-Id: <20230722215736.4183-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - ERROR: else should follow close brace '}' Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 40a3157fb735..b8595b28bceb 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -654,8 +654,7 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, =20 psecuritypriv->busetkipkey =3D true; =20 - } - else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { + } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _AES_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68705C001DC for ; Sat, 22 Jul 2023 21:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbjGVV6H (ORCPT ); Sat, 22 Jul 2023 17:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjGVV6E (ORCPT ); Sat, 22 Jul 2023 17:58:04 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADBE3171F for ; Sat, 22 Jul 2023 14:58:00 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-785d738d3feso77617739f.0 for ; Sat, 22 Jul 2023 14:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063080; x=1690667880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9NwbewUwtQOX42wr9LwdKvivKXFOaLGQh9L6giyMZRg=; b=HEp/1maRsFLWMNQhtS2UwRdOszuhv+sqOFeVsCUn7Ofs9yGRMzSw6v8kdd447LsBed ZgEk1WR7oKw0l2Rmbf0bWGusM3JQFMsOgXnJG8dWKCHjBa378DdBf2DXhxXBvZwb1mcT Q6EmAnwywYZhJ7kJp/jdDlpz9Dl25l+pPx9TqJAkcR1I73kLduUmlVYI6HsppG5HZ23o 98xXPrFjsE1N+gGSAtYfsmla/1cykphCieTiXHP7rMTeZxQADaxMJZ/JU1h7/w9SvFUe DdYBu3fV6RGYWwvWiq+B02N9YBHfNE7hZN7BS9dHxo/fm+MnJVoLLJPbbVxNkvdZ3G9d yGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063080; x=1690667880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9NwbewUwtQOX42wr9LwdKvivKXFOaLGQh9L6giyMZRg=; b=Fi93laTKslj+30kqq3kea9FR6M/9Kez8lO+zBt8IwJ6oQAX/Q3XIsHecMtoHAMcdQn 4WEJei/hcK0b5/MGe7fTz/ILMW63udZeNOzBlQ4dnY3i8qalWCgp8jzPBWOtvqjBuFk+ SYMkz82j9k76tGGYsN8oPxccOAHR64gC7bOhJ7wvWvHtmM+xGRpBWThE7LSt5PP1Rrv1 kz7qMyCvPs1jlyCpKZSl+50Qnf8lHxqTwCfVmp0rAZ9Get039n14xTrFKn443SFkDxpA sDd84cPuL++sYUUjeUNpB57b+Bl2ULh92Cz/jELIMjcQDRa+uoSFACnbLaYxZeV/VA5+ iDFA== X-Gm-Message-State: ABy/qLZW7sZpr4gBe0+Xplj236/QaeNQnjggnt3EzToDusuX9fSBRat5 JG7y6Z3JHIpiQdpoTlp5eZo= X-Google-Smtp-Source: APBJJlFjqqOWMP2pfQkY9d8/m0nxsrzn9e9tCzjf9GN1nqn6HNu0IYM3J3IRyzRBdreEsnet4wRqPA== X-Received: by 2002:a05:6602:3404:b0:783:6aa0:9816 with SMTP id n4-20020a056602340400b007836aa09816mr2716255ioz.7.1690063079959; Sat, 22 Jul 2023 14:57:59 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id j17-20020a02a691000000b0042b4b1246cbsm1921783jam.148.2023.07.22.14.57.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:57:59 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 2/9] staging: rtl8723bs: ioctl_linux: Fix code indent Date: Sat, 22 Jul 2023 23:57:57 +0200 Message-Id: <20230722215757.4214-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - WARNING: suspect code indent for conditional statements Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index b8595b28bceb..20c296d88c8d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -640,7 +640,7 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, =20 psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; if (param->u.crypt.key_len =3D=3D 13) - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; =20 } else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _TKIP_; --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8F9C001DC for ; Sat, 22 Jul 2023 21:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbjGVV6U (ORCPT ); Sat, 22 Jul 2023 17:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjGVV6P (ORCPT ); Sat, 22 Jul 2023 17:58:15 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45D082690 for ; Sat, 22 Jul 2023 14:58:12 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-785cbc5bfd2so162238639f.2 for ; Sat, 22 Jul 2023 14:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063091; x=1690667891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oPT/AaCv1OdblmY1sVuziMvUrHf6Fzs9xst1BQLTFpI=; b=gLDIOy0ohXK9vHvraqSrnUynmZTIZUhN13Q1jXSlL9o9+gqiPYDRq8Th/tnKe+eKSr y26Y+SLlCCOi3yT6/hzl7oVlUn3VlKC1I3LURBAXMh3alueBoROpiQydgomkdefEbaAg BqiF72KG8tCfKTQHV1GJu1DR5cQPrbD39eWEp6RhNC94WNp494vyNmucf2hvDpDHyuGK fdHq9foANdxDy3nFRxj9J6d8xXvfbZDd3Hqv45xD7KMjgQQjdgsO9g22b57RCXq9TsOW i1bAjp0mmhd/sFBbjpB3sgSxEAKy7zlgZ+MAwBY4hxYuGttf4twoX+moE0E+Pcdzg8Q3 OW7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063091; x=1690667891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPT/AaCv1OdblmY1sVuziMvUrHf6Fzs9xst1BQLTFpI=; b=d1BmQ8xS4MixE/sS3p0qY+L2g0iZPsfKDoqi8ET+pKuUDPjZaWLMdsfXfdgBXvF68W Ear61WURxg53AxsFJKPAlb3st2zMnTptRba20tMrA/HDhPGks1C3uxKe9K2DC2qhAvUZ GZEyq49x0VC7U/PD9iRZfsfa/Zc0rhYWpncFwSqp+KPaIRM09qH/r4IgqWj41eH1wAhv vs834zqByWPJGxrSyQTDqJOBDn2Nf7MEzvvwxBgp1A6DDvlWaUBdmnQhi+DdVP/GXtP9 KjnpqpQ3qiAGVeoss095FGIGYIMDzDOXTTYxQpivcSJQ5PggrIewqjaGnifYQK+EUfdT gTHQ== X-Gm-Message-State: ABy/qLZMV6k4WgE4TI/0h+8UfOS4CmasMhbK70wWlsfvWJwP3cfVIG0f M19N8Un8IllZWf/cA9nZsxI= X-Google-Smtp-Source: APBJJlFt3oHdVC28SHz3N2Mh7uQSWrDQ0BdAogp9lEEEWYgXszD5grDUOkI8fc6+R95dvQYp36wHFg== X-Received: by 2002:a5d:9c95:0:b0:78b:b892:e334 with SMTP id p21-20020a5d9c95000000b0078bb892e334mr150927iop.11.1690063091537; Sat, 22 Jul 2023 14:58:11 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id z25-20020a02ceb9000000b0042b3e86dfd8sm1932511jaq.141.2023.07.22.14.58.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:58:11 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 3/9] staging: rtl8723bs: ioctl_linux: Fix block comment alignment Date: Sat, 22 Jul 2023 23:58:08 +0200 Message-Id: <20230722215808.4246-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - WARNING: Block comments should align the * on each line Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 20c296d88c8d..088d29b9ea03 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -1204,9 +1204,9 @@ static int rtw_hostapd_ioctl(struct net_device *dev, = struct iw_point *p) struct adapter *padapter =3D rtw_netdev_priv(dev); =20 /* - * this function is expect to call in master mode, which allows no power s= aving - * so, we just check hw_init_completed - */ + * this function is expect to call in master mode, which allows no power = saving + * so, we just check hw_init_completed + */ =20 if (!padapter->hw_init_completed) return -EPERM; --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58578C0015E for ; Sat, 22 Jul 2023 21:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229713AbjGVV6g (ORCPT ); Sat, 22 Jul 2023 17:58:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbjGVV6e (ORCPT ); Sat, 22 Jul 2023 17:58:34 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD10F2111 for ; Sat, 22 Jul 2023 14:58:27 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-783549ef058so158104139f.2 for ; Sat, 22 Jul 2023 14:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063107; x=1690667907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YL49790jkqNe6T1q+uxDrJ1BBK7ge7fgG7lO4/q27+I=; b=PZtNr9l6RAhiNNeUbXlGFAjaE+gFxLCzOMfO+2PTjUnGqkWJvajWMqyA5GVI/tVESz o6MTpzIfvjeLZLHvJCn/B1BsAtSmfPTMcJizWSKsYvUNnmqhSAnp08dpfTcf4Wh1rgfH Q3ZaGcE7M41gXic90j3MrKlmxdF1k7057S+gObt3JuRELWMqJjKmHw0wTx34x51iMYC3 BOae6sdQJ+57pcW7w+RcziVGBA7YgdHCiizsrzeBh14XamRnK04QIcgtkE7s44zVP5j9 5zluux9xw87GmyM3IrhTfAgWqwv9s7ODgni5qeF4H56L89M3WlHOjxDOe2j6vIZtuJLt m2EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063107; x=1690667907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YL49790jkqNe6T1q+uxDrJ1BBK7ge7fgG7lO4/q27+I=; b=Dmr5U+7+WQNJovzyokXid59ui6E7PhVrvOEQ/aoXJZAwLoGGTGzVEXrVHri25kvKoB Ef9iWvlh1uuoE2NWmmwFuORmNgLbAX2ihXL/1kZcNPVpm1WJzwJQ0RQgsOoHFlVDJLSn rP9L+EKETizuD8yp0RmqBSL0aOp6y91PDPeF4Jtd+DdNFr6+qnGG31h/JC2Dv+JnGWtt djm4hDlzsnCt5PYea/wxn/7cDhstFf2DOH18IrnGw882ou8EB7DM/pLMPGlOH71WygdO ZOYhJx9xdyhEw7z4kFoJhujvfv2i3LBJC4fRcVebU7hF/k5No0aSXTerMRdcqpdQuR0h B97A== X-Gm-Message-State: ABy/qLYUmJB0gqoEZB1E8c/OqLbQRp8RGqf7KErv/g7nlVLTB+RSQyCr fKFxrq0YAahbHJIFYO7sDP0= X-Google-Smtp-Source: APBJJlG8iU0E+aXVtjwVob0J199siBx8CwKifG84WgH8SDXd7hE1tOsWU+ORXndrcuLNomQTs8TKOA== X-Received: by 2002:a05:6e02:1d86:b0:345:af82:dc3a with SMTP id h6-20020a056e021d8600b00345af82dc3amr4795337ila.14.1690063106811; Sat, 22 Jul 2023 14:58:26 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id f16-20020a02cad0000000b0042b2d9fbbecsm1874165jap.119.2023.07.22.14.58.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:58:26 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 4/9] staging: rtl8723bs: ioctl_linux: Remove multiple blank lines Date: Sat, 22 Jul 2023 23:58:24 +0200 Message-Id: <20230722215824.4281-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - CHECK: Please don't use multiple blank lines Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 088d29b9ea03..16ff55d75687 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -426,11 +426,8 @@ static int wpa_set_param(struct net_device *dev, u8 na= me, u32 value) =20 default: =20 - - ret =3D -EOPNOTSUPP; =20 - break; =20 } @@ -570,7 +567,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, goto exit; } =20 - if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0 && !psta) { wep_key_idx =3D param->u.crypt.idx; wep_key_len =3D param->u.crypt.key_len; @@ -580,7 +576,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, goto exit; } =20 - if (wep_key_len > 0) { wep_key_len =3D wep_key_len <=3D 5 ? 5 : 13; wep_total_len =3D wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, ke= y_material); @@ -609,7 +604,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; } =20 - psecuritypriv->dot11PrivacyKeyIndex =3D wep_key_idx; =20 memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_ma= terial, pwep->key_length); @@ -632,7 +626,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, =20 } =20 - if (!psta && check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* group key */ if (param->u.crypt.set_tx =3D=3D 1) { if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { @@ -778,13 +771,11 @@ static int rtw_set_beacon(struct net_device *dev, str= uct ieee_param *param, int if ((pstapriv->max_num_sta > NUM_STA) || (pstapriv->max_num_sta <=3D 0)) pstapriv->max_num_sta =3D NUM_STA; =20 - if (rtw_check_beacon_data(padapter, pbuf, (len-12-2)) =3D=3D _SUCCESS)/*= 12 =3D param header, 2:no packed */ ret =3D 0; else ret =3D -EINVAL; =20 - return ret; =20 } @@ -837,7 +828,6 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) =20 memcpy(psta->bssrateset, param->u.add_sta.tx_supp_rates, 16); =20 - /* check wmm cap. */ if (WLAN_STA_WME&flags) psta->qos_option =3D 1; @@ -861,7 +851,6 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) =20 update_sta_info_apmode(padapter, psta); =20 - } else { ret =3D -ENOMEM; } @@ -962,7 +951,6 @@ static int rtw_ioctl_get_sta_data(struct net_device *de= v, struct ieee_param *par psta_data->tx_bytes =3D psta->sta_stats.tx_bytes; psta_data->tx_drops =3D psta->sta_stats.tx_drops; =20 - } else { ret =3D -1; } @@ -1024,7 +1012,6 @@ static int rtw_set_wps_beacon(struct net_device *dev,= struct ieee_param *param, =20 ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ =20 - kfree(pmlmepriv->wps_beacon_ie); pmlmepriv->wps_beacon_ie =3D NULL; =20 @@ -1041,7 +1028,6 @@ static int rtw_set_wps_beacon(struct net_device *dev,= struct ieee_param *param, pmlmeext->bstart_bss =3D true; } =20 - return ret; =20 } @@ -1058,7 +1044,6 @@ static int rtw_set_wps_probe_resp(struct net_device *= dev, struct ieee_param *par =20 ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ =20 - kfree(pmlmepriv->wps_probe_resp_ie); pmlmepriv->wps_probe_resp_ie =3D NULL; =20 @@ -1071,7 +1056,6 @@ static int rtw_set_wps_probe_resp(struct net_device *= dev, struct ieee_param *par memcpy(pmlmepriv->wps_probe_resp_ie, param->u.bcn_ie.buf, ie_len); } =20 - return ret; =20 } @@ -1088,7 +1072,6 @@ static int rtw_set_wps_assoc_resp(struct net_device *= dev, struct ieee_param *par =20 ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ =20 - kfree(pmlmepriv->wps_assoc_resp_ie); pmlmepriv->wps_assoc_resp_ie =3D NULL; =20 @@ -1101,7 +1084,6 @@ static int rtw_set_wps_assoc_resp(struct net_device *= dev, struct ieee_param *par memcpy(pmlmepriv->wps_assoc_resp_ie, param->u.bcn_ie.buf, ie_len); } =20 - return ret; =20 } --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1004EC001DC for ; Sat, 22 Jul 2023 21:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbjGVV6v (ORCPT ); Sat, 22 Jul 2023 17:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbjGVV6s (ORCPT ); Sat, 22 Jul 2023 17:58:48 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF045269A for ; Sat, 22 Jul 2023 14:58:42 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3466725f0beso17729045ab.1 for ; Sat, 22 Jul 2023 14:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063122; x=1690667922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SQTls//O2JbbV17qPpJETi4oaKteU3qRCqIMmnS37Jk=; b=aMv1PRqcY/jg9COHkd6El94rMTQ5QhXFtV7Y0YnSaUpZuBEuTB6uPZ/EMeE6+GGYXm rXiznG5q5Ooqm5OFEVNF6cJKBMp+si2Bj+DAStv1u1NqKn7CmiP+p8MSUc/0dNORGuwz eQ8z6oEB8iyMBuhyQvQ3He9e5tjO3oY5U4MK/+miimYpiq3b4rtoQmj+/jw4jYryIjxd /fe/DAo8UT9ger+lpDhMjm0m3oXOj6Grv+vIgJZ3eTSEExYdcP5NFoOUAoTARDSiM5dx qA43JoZ5taunpD6JsgZGjdhfd3rnAU8WxC4XH8R5MOuEwKWB0YIegi1YAs08MlEFVJWP Ekag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063122; x=1690667922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SQTls//O2JbbV17qPpJETi4oaKteU3qRCqIMmnS37Jk=; b=ioNX8bUlfVMTmXYV1uZmjqgPQtHzdVxuMTBjTjHK8gTTZU1c93E6xEXRMU8TXHxC7N yq+DEZBsQ5dp24vjOrFBsdDa9g5ONIXxcE6URPWY6K0tZCVa437xcxT9FvMt4aCsydB7 SpkZ0bEm3ajzy9mvVOUzsPt3d7qi05NPPVOv3vIdybS1n5P1IjRwqaGMLsn4HITy63/f kTh780+Pxp3097i6Ee6ZMh8+HQy5uOXw2jyN1M7BTetiogyi7OaGsmnV1ordgcBlpyAD QkmTXmrUTrTD3Q7qywU74mSIVjgFj696NBiV62jg+ekg8EXTNQQy0KHr6tIo8temZbti PWsQ== X-Gm-Message-State: ABy/qLbNvFERBlmdfdxQ2+1QBIN9yXJSNoOFblHqiqeemgwTkkZl2kZ5 21y7h5S/7oCEw4ZH2/6CQ24= X-Google-Smtp-Source: APBJJlEKpsqcqDHLPWl1bfVv7gwOvVfdJeCwqkQoN4M8KHFx+7ASnFDEOXhlnWjjQ6FBHi8//k+1CQ== X-Received: by 2002:a05:6e02:1cae:b0:346:77f4:e22d with SMTP id x14-20020a056e021cae00b0034677f4e22dmr4151199ill.6.1690063122039; Sat, 22 Jul 2023 14:58:42 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id 17-20020a0566380a5100b0042b61a5087csm1878723jap.132.2023.07.22.14.58.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:58:41 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 5/9] staging: rtl8723bs: ioctl_linux: Remove unnecessary blank lines Date: Sat, 22 Jul 2023 23:58:40 +0200 Message-Id: <20230722215840.4323-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issues: - CHECK: Blank lines aren't necessary before a close brace '}' - CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 16ff55d75687..cde2c5d1e92c 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -40,7 +40,6 @@ static int wpa_set_auth_algs(struct net_device *dev, u32 = value) } =20 return ret; - } =20 static int wpa_set_encryption(struct net_device *dev, struct ieee_param *p= aram, u32 param_len) @@ -80,7 +79,6 @@ static int wpa_set_encryption(struct net_device *dev, str= uct ieee_param *param, } =20 if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { - padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enable= d; padapter->securitypriv.dot11PrivacyAlgrthm =3D _WEP40_; padapter->securitypriv.dot118021XGrpPrivacy =3D _WEP40_; @@ -392,7 +390,6 @@ static int wpa_set_param(struct net_device *dev, u8 nam= e, u32 value) * be set. */ break; - } case IEEE_PARAM_PRIVACY_INVOKED: =20 @@ -429,11 +426,9 @@ static int wpa_set_param(struct net_device *dev, u8 na= me, u32 value) ret =3D -EOPNOTSUPP; =20 break; - } =20 return ret; - } =20 static int wpa_mlme(struct net_device *dev, u32 command, u32 reason) @@ -462,7 +457,6 @@ static int wpa_mlme(struct net_device *dev, u32 command= , u32 reason) } =20 return ret; - } =20 static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p) @@ -485,7 +479,6 @@ static int wpa_supplicant_ioctl(struct net_device *dev,= struct iw_point *p) } =20 switch (param->cmd) { - case IEEE_CMD_SET_WPA_PARAM: ret =3D wpa_set_param(dev, param->u.wpa_param.name, param->u.wpa_param.v= alue); break; @@ -506,7 +499,6 @@ static int wpa_supplicant_ioctl(struct net_device *dev,= struct iw_point *p) default: ret =3D -EOPNOTSUPP; break; - } =20 if (ret =3D=3D 0 && copy_to_user(p->pointer, param, p->length)) @@ -586,7 +578,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, =20 pwep->key_length =3D wep_key_len; pwep->length =3D wep_total_len; - } =20 pwep->key_index =3D wep_key_idx; @@ -623,7 +614,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, } =20 goto exit; - } =20 if (!psta && check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* group key */ @@ -671,7 +661,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, } =20 goto exit; - } =20 if (psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X && psta= ) { /* psk/802_1x */ @@ -694,7 +683,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, psecuritypriv->busetkipkey =3D true; =20 } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { - psta->dot118021XPrivacy =3D _AES_; } else { psta->dot118021XPrivacy =3D _NO_PRIVACY_; @@ -752,7 +740,6 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, kfree(pwep); =20 return ret; - } =20 static int rtw_set_beacon(struct net_device *dev, struct ieee_param *param= , int len) @@ -777,7 +764,6 @@ static int rtw_set_beacon(struct net_device *dev, struc= t ieee_param *param, int ret =3D -EINVAL; =20 return ret; - } =20 static void rtw_hostapd_sta_flush(struct net_device *dev) @@ -856,7 +842,6 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) } =20 return ret; - } =20 static int rtw_del_sta(struct net_device *dev, struct ieee_param *param) @@ -885,18 +870,15 @@ static int rtw_del_sta(struct net_device *dev, struct= ieee_param *param) list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; updated =3D ap_free_sta(padapter, psta, true, WLAN_REASON_DEAUTH_LEAVIN= G); - } spin_unlock_bh(&pstapriv->asoc_list_lock); =20 associated_clients_update(padapter, updated); =20 psta =3D NULL; - } =20 return ret; - } =20 static int rtw_ioctl_get_sta_data(struct net_device *dev, struct ieee_para= m *param, int len) @@ -956,7 +938,6 @@ static int rtw_ioctl_get_sta_data(struct net_device *de= v, struct ieee_param *par } =20 return ret; - } =20 static int rtw_get_sta_wpaie(struct net_device *dev, struct ieee_param *pa= ram) @@ -995,7 +976,6 @@ static int rtw_get_sta_wpaie(struct net_device *dev, st= ruct ieee_param *param) } =20 return ret; - } =20 static int rtw_set_wps_beacon(struct net_device *dev, struct ieee_param *p= aram, int len) @@ -1029,7 +1009,6 @@ static int rtw_set_wps_beacon(struct net_device *dev,= struct ieee_param *param, } =20 return ret; - } =20 static int rtw_set_wps_probe_resp(struct net_device *dev, struct ieee_para= m *param, int len) @@ -1057,7 +1036,6 @@ static int rtw_set_wps_probe_resp(struct net_device *= dev, struct ieee_param *par } =20 return ret; - } =20 static int rtw_set_wps_assoc_resp(struct net_device *dev, struct ieee_para= m *param, int len) @@ -1085,7 +1063,6 @@ static int rtw_set_wps_assoc_resp(struct net_device *= dev, struct ieee_param *par } =20 return ret; - } =20 static int rtw_set_hidden_ssid(struct net_device *dev, struct ieee_param *= param, int len) @@ -1144,7 +1121,6 @@ static int rtw_ioctl_acl_remove_sta(struct net_device= *dev, struct ieee_param *p =20 rtw_acl_remove_sta(padapter, param->sta_addr); return 0; - } =20 static int rtw_ioctl_acl_add_sta(struct net_device *dev, struct ieee_param= *param, int len) @@ -1162,7 +1138,6 @@ static int rtw_ioctl_acl_add_sta(struct net_device *d= ev, struct ieee_param *para } =20 return rtw_acl_add_sta(padapter, param->sta_addr); - } =20 static int rtw_ioctl_set_macaddr_acl(struct net_device *dev, struct ieee_p= aram *param, int len) @@ -1293,7 +1268,6 @@ static int rtw_hostapd_ioctl(struct net_device *dev, = struct iw_point *p) default: ret =3D -EOPNOTSUPP; break; - } =20 if (ret =3D=3D 0 && copy_to_user(p->pointer, param, p->length)) --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F309C0015E for ; Sat, 22 Jul 2023 21:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbjGVV7C (ORCPT ); Sat, 22 Jul 2023 17:59:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjGVV67 (ORCPT ); Sat, 22 Jul 2023 17:58:59 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96C852680 for ; Sat, 22 Jul 2023 14:58:53 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-34574eb05f4so15172825ab.0 for ; Sat, 22 Jul 2023 14:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063133; x=1690667933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f4RHWRuMZ9AdFIutMNVpmAc8uN14s1z4APTsWvUfDsw=; b=Gn1HLbMzKGVIpgfqyhOYsXSMrI+w4YT0mngPqwmVOD4RIzqJ2+zdjLh1dfhup1Vqs/ IDSOZNcwZYG7feS9Cn+vrLmUblGthennt2TsiI5e/H7UnZO10DyLMClUhZu3b3dKBJKz CJcrXirEWPqJcpFGAH0RnAJz0RW95pYJ9AzHrc9AZzPYS3NDAAFqXOZdYYxjJmDH+SnI gZ1qGnsenXuVn8CLlQnTLLwrqUS1ms1s/uGffna4n8Afs4XVJ6LjNW/7kpdTqsbTeOFL gBOCBPXEgZGN+6d2diP7mbPsloa42xh7Lsjn1eAnKsljt73Xak6sjuuGUzqYBJMdGFRg TclQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063133; x=1690667933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f4RHWRuMZ9AdFIutMNVpmAc8uN14s1z4APTsWvUfDsw=; b=JQGGRMnQgs/dwuo8fejcTjBYFvxpuGdbQ0t2h+cNPdOaQxL9EHq60jTqaEXMIUY22J Qz+yZmq1xs6fhJlR9wX6GXQFFc3r3uAkd4ISg1+m0amDgDU0stcHWFBgD2VTnMoxIoXQ IU1mP6DyqIkbnc8r6QRXKLE3EZ1ysETexpJ7gcbKxQTVZVcJcGS6157afvQ0/1ZcNKww iok0nhqiipltG36nF5QJQDglA5B+bQnJsq2g+xJvD8DbTRI+A0m2mZVGCm20t79JVUfu r3zglSu2V/2zGgfdQ0xrVn0oGg4YtvSQuRKx6ECqx5Z7kx/S5NXpU8T0Eh28J5PUMEmS zCNA== X-Gm-Message-State: ABy/qLZOgwuuAyviI2ssbGzsQ8GIgWZnClGdYz22kWhDKhI6FM96T+kG WPORTJxJbOXpsqh4NDLY/NM= X-Google-Smtp-Source: APBJJlHFyYkKrYJ+OO3xzWGaiRJzncDksKg4hvsFaaQYlSCYhpMjI09oYOIs6a1x9HHHn/LB4zs4Gg== X-Received: by 2002:a92:c7d0:0:b0:345:e1be:1567 with SMTP id g16-20020a92c7d0000000b00345e1be1567mr2903362ilk.25.1690063132889; Sat, 22 Jul 2023 14:58:52 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id f19-20020a02b793000000b0042673ad37b1sm1892965jam.52.2023.07.22.14.58.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:58:52 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 6/9] staging: rtl8723bs: ioctl_linux: Remove unnecessary parentheses Date: Sat, 22 Jul 2023 23:58:50 +0200 Message-Id: <20230722215850.4353-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - CHECK: Unnecessary parentheses around ... Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index cde2c5d1e92c..e4c5e249df98 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -125,7 +125,7 @@ static int wpa_set_encryption(struct net_device *dev, s= truct ieee_param *param, goto exit; } - memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_ma= terial, pwep->key_length); + memcpy(&psecuritypriv->dot11DefKey[wep_key_idx].skey[0], pwep->key_mate= rial, pwep->key_length); psecuritypriv->dot11DefKeylen[wep_key_idx] =3D pwep->key_length; rtw_set_key(padapter, psecuritypriv, wep_key_idx, 0, true); } @@ -156,8 +156,8 @@ static int wpa_set_encryption(struct net_device *dev, s= truct ieee_param *param, if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { /* set mic key */ /* DEBUG_ERR(("\nset key length :param->u.crypt.key_len =3D%d\n", pa= ram->u.crypt.key_len)); */ - memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8); - memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8); + memcpy(psta->dot11tkiptxmickey.skey, ¶m->u.crypt.key[16], 8); + memcpy(psta->dot11tkiprxmickey.skey, ¶m->u.crypt.key[24], 8); padapter->securitypriv.busetkipkey =3D false; /* _set_timer(&padapter->securitypriv.tkip_timer, 50); */ @@ -169,8 +169,8 @@ static int wpa_set_encryption(struct net_device *dev, s= truct ieee_param *param, memcpy(padapter->securitypriv.dot118021XGrpKey[param->u.crypt.idx].s= key, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt= .key_len)); /* only TKIP group key need to install this */ if (param->u.crypt.key_len > 16) { - memcpy(padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.= idx].skey, &(param->u.crypt.key[16]), 8); - memcpy(padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.= idx].skey, &(param->u.crypt.key[24]), 8); + memcpy(padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.= idx].skey, ¶m->u.crypt.key[16], 8); + memcpy(padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.= idx].skey, ¶m->u.crypt.key[24], 8); } padapter->securitypriv.binstallGrpkey =3D true; @@ -518,7 +518,7 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, struct sta_info *psta =3D NULL, *pbcmc_sta =3D NULL; struct adapter *padapter =3D rtw_netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct security_priv *psecuritypriv =3D &(padapter->securitypriv); + struct security_priv *psecuritypriv =3D &padapter->securitypriv; struct sta_priv *pstapriv =3D &padapter->stapriv; char *txkey =3D padapter->securitypriv.dot118021XGrptxmickey[param->u.cry= pt.idx].skey; char *rxkey =3D padapter->securitypriv.dot118021XGrprxmickey[param->u.cry= pt.idx].skey; @@ -597,7 +597,7 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, psecuritypriv->dot11PrivacyKeyIndex =3D wep_key_idx; - memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_ma= terial, pwep->key_length); + memcpy(&psecuritypriv->dot11DefKey[wep_key_idx].skey[0], pwep->key_mate= rial, pwep->key_length); psecuritypriv->dot11DefKeylen[wep_key_idx] =3D pwep->key_length; @@ -606,7 +606,7 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, /* don't update "psecuritypriv->dot11PrivacyAlgrthm" and */ /* psecuritypriv->dot11PrivacyKeyIndex =3Dkeyid", but can rtw_set_key t= o cam */ - memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), pwep->key_ma= terial, pwep->key_length); + memcpy(&psecuritypriv->dot11DefKey[wep_key_idx].skey[0], pwep->key_mate= rial, pwep->key_length); psecuritypriv->dot11DefKeylen[wep_key_idx] =3D pwep->key_length; @@ -632,8 +632,8 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, /* DEBUG_ERR("set key length :param->u.crypt.key_len =3D%d\n", param->= u.crypt.key_len); */ /* set mic key */ - memcpy(txkey, &(param->u.crypt.key[16]), 8); - memcpy(psecuritypriv->dot118021XGrprxmickey[param->u.crypt.idx].skey, = &(param->u.crypt.key[24]), 8); + memcpy(txkey, ¶m->u.crypt.key[16], 8); + memcpy(psecuritypriv->dot118021XGrprxmickey[param->u.crypt.idx].skey, = ¶m->u.crypt.key[24], 8); psecuritypriv->busetkipkey =3D true; @@ -677,8 +677,8 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, /* DEBUG_ERR("set key length :param->u.crypt.key_len =3D%d\n", param-= >u.crypt.key_len); */ /* set mic key */ - memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8); - memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8); + memcpy(psta->dot11tkiptxmickey.skey, ¶m->u.crypt.key[16], 8); + memcpy(psta->dot11tkiprxmickey.skey, ¶m->u.crypt.key[24], 8); psecuritypriv->busetkipkey =3D true; @@ -706,8 +706,8 @@ static int rtw_set_encryption(struct net_device *dev, s= truct ieee_param *param, /* DEBUG_ERR("set key length :param->u.crypt.key_len =3D%d\n", param-= >u.crypt.key_len); */ /* set mic key */ - memcpy(txkey, &(param->u.crypt.key[16]), 8); - memcpy(rxkey, &(param->u.crypt.key[24]), 8); + memcpy(txkey, ¶m->u.crypt.key[16], 8); + memcpy(rxkey, ¶m->u.crypt.key[24], 8); psecuritypriv->busetkipkey =3D true; @@ -746,7 +746,7 @@ static int rtw_set_beacon(struct net_device *dev, struc= t ieee_param *param, int { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; unsigned char *pbuf =3D param->u.bcn_ie.buf; @@ -784,7 +784,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) int ret =3D 0; struct sta_info *psta =3D NULL; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) @@ -849,7 +849,7 @@ static int rtw_del_sta(struct net_device *dev, struct i= eee_param *param) int ret =3D 0; struct sta_info *psta =3D NULL; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) @@ -886,7 +886,7 @@ static int rtw_ioctl_get_sta_data(struct net_device *de= v, struct ieee_param *par int ret =3D 0; struct sta_info *psta =3D NULL; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; struct ieee_param_ex *param_ex =3D (struct ieee_param_ex *)param; struct sta_data *psta_data =3D (struct sta_data *)param_ex->data; @@ -945,7 +945,7 @@ static int rtw_get_sta_wpaie(struct net_device *dev, st= ruct ieee_param *param) int ret =3D 0; struct sta_info *psta =3D NULL; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) @@ -983,8 +983,8 @@ static int rtw_set_wps_beacon(struct net_device *dev, s= truct ieee_param *param, int ret =3D 0; unsigned char wps_oui[4] =3D {0x0, 0x50, 0xf2, 0x04}; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); - struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; int ie_len; if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) @@ -1015,7 +1015,7 @@ static int rtw_set_wps_probe_resp(struct net_device *= dev, struct ieee_param *par { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; int ie_len; if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) @@ -1042,7 +1042,7 @@ static int rtw_set_wps_assoc_resp(struct net_device *= dev, struct ieee_param *par { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; int ie_len; if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) @@ -1069,9 +1069,9 @@ static int rtw_set_hidden_ssid(struct net_device *dev= , struct ieee_param *param, { int ret =3D 0; struct adapter *adapter =3D rtw_netdev_priv(dev); - struct mlme_priv *mlmepriv =3D &(adapter->mlmepriv); - struct mlme_ext_priv *mlmeext =3D &(adapter->mlmeextpriv); - struct mlme_ext_info *mlmeinfo =3D &(mlmeext->mlmext_info); + struct mlme_priv *mlmepriv =3D &adapter->mlmepriv; + struct mlme_ext_priv *mlmeext =3D &adapter->mlmeextpriv; + struct mlme_ext_info *mlmeinfo =3D &mlmeext->mlmext_info; int ie_len; u8 *ssid_ie; char ssid[NDIS_802_11_LENGTH_SSID + 1]; @@ -1108,7 +1108,7 @@ static int rtw_set_hidden_ssid(struct net_device *dev= , struct ieee_param *param, static int rtw_ioctl_acl_remove_sta(struct net_device *dev, struct ieee_pa= ram *param, int len) { struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; @@ -1126,7 +1126,7 @@ static int rtw_ioctl_acl_remove_sta(struct net_device= *dev, struct ieee_param *p static int rtw_ioctl_acl_add_sta(struct net_device *dev, struct ieee_param= *param, int len) { struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; @@ -1144,7 +1144,7 @@ static int rtw_ioctl_set_macaddr_acl(struct net_devic= e *dev, struct ieee_param * { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(dev); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; -- 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF242C001DC for ; Sat, 22 Jul 2023 21:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbjGVV7X (ORCPT ); Sat, 22 Jul 2023 17:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjGVV7V (ORCPT ); Sat, 22 Jul 2023 17:59:21 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AE981FDC for ; Sat, 22 Jul 2023 14:59:08 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-3461053677eso7673605ab.0 for ; Sat, 22 Jul 2023 14:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063147; x=1690667947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lauvryu8+RbX4F+Ht5xLHh2lskvh455ipXTKcGMOp/A=; b=WQJSAZS/QFZogRrUnNVVA4Z9HR/apIXr9heJJY8reym+lUluCZjVpVTvYFki2M9QAJ KJFn3q7jYm12JP5F8xFP+SP0DrbS97Me4lmKeQw2NhrifvGQFOdgUE264B6wWNfAF4Ee Zqrd16xQ28G+Jvavb+4GKMdfw4OWH8L9TYiRsrq9+ZnsLk+bLCSKPln6d5Uy2ZyPOGiN jwTwwyRthVmLWoiwCGK1YxHw5VbfmVF7HT56i8iSpTEv+oC5m+Grc4pYDPzeOArPEQfg 87mZCVaI0+woAWOgdznYRYIhPDp85q0sJMIljnBM2/JZi3Oc4KNenR/wwLuD19d4ERKW o5Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063147; x=1690667947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lauvryu8+RbX4F+Ht5xLHh2lskvh455ipXTKcGMOp/A=; b=MeBS4y1vApuL8FGqyLffpdQpRkqX0rK7vpsLK3AHMa7JQdVoadTAkmi3C6h2BopoTQ /PRkaTjedeIKG/uBkynjVgFTDRS0s7PvJ+ifItbfgRfVwNkIDhV+qkjdIVZI5mWnZdnn sN2LvlMjaFWhAOzu9wzNSDCS2NXnYzSs7KNJUw5Skhgc7ksjy1soY7EYivSK4ymcgfqe npCIvBsFpCnE8njqdolwUHqm0z1QyGpFt55mIo3Pv48tPEb/W+Os/cld7QGOUpANzkEE HdwbI6kuhNzVJSNn1tLy0NAjzOZHJZbKhTv7LikQ3xI3pJG2dQ9gV/AYitv/Q1FZ85lv DQ/w== X-Gm-Message-State: ABy/qLZycEUma0ILHArAh2f6UjUxB3/jUcjAmfAo1b8uRVc1D1SxGEh/ z2WGfaMxFoLjNTGj0Oe3Ihc= X-Google-Smtp-Source: APBJJlFY8mNC3x+dU1aVMbXuCuG6KD3ZhpnnpHXe/AP6NEOc3uvjMGtemh9v0CoGKhXWBfFPaYPYLg== X-Received: by 2002:a05:6e02:1242:b0:348:9dd1:7963 with SMTP id j2-20020a056e02124200b003489dd17963mr1893489ilq.7.1690063147698; Sat, 22 Jul 2023 14:59:07 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id g15-20020a926b0f000000b0034285721db5sm1923590ilc.4.2023.07.22.14.59.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:59:07 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 7/9] staging: rtl8723bs: ioctl_linux: Fix alignment on open parenthesis Date: Sat, 22 Jul 2023 23:59:05 +0200 Message-Id: <20230722215905.4383-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - CHECK: Alignment should match open parenthesis Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index e4c5e249df98..88f560353df7 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -147,7 +147,7 @@ static int wpa_set_encryption(struct net_device *dev, s= truct ieee_param *param, psta->ieee8021x_blocked =3D false; =20 if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrth= m; } =20 @@ -200,7 +200,7 @@ static int wpa_set_encryption(struct net_device *dev, s= truct ieee_param *param, pbcmc_sta->ieee8021x_blocked =3D false; =20 if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { pbcmc_sta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyA= lgrthm; } } @@ -334,8 +334,8 @@ static int rtw_set_wpa_ie(struct adapter *padapter, cha= r *pie, unsigned short ie =20 /* TKIP and AES disallow multicast packets until installing group key */ if (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _TKIP_ || - padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _TKIP_WTMIC_ || - padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) + padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _TKIP_WTMIC_ || + padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) /* WPS open need to enable multicast */ /* check_fwstate(&padapter->mlmepriv, WIFI_UNDER_WPS) =3D=3D true) */ rtw_hal_set_hwreg(padapter, HW_VAR_OFF_RCR_AM, null_addr); --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2695C001DC for ; Sat, 22 Jul 2023 21:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbjGVV7l (ORCPT ); Sat, 22 Jul 2023 17:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjGVV7j (ORCPT ); Sat, 22 Jul 2023 17:59:39 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37305213B for ; Sat, 22 Jul 2023 14:59:19 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-345a8a78bcfso15125355ab.2 for ; Sat, 22 Jul 2023 14:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063158; x=1690667958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ICetZO3eJiINHtdQ5D1OIXxRMuzgneIba8TDtaF3d6E=; b=igpp763ye/MqzfrVlap+d88m97CjjDSbCeJm4qM2yOg4Dwtmx5u8AdHOLXLkJCzkm8 7DFM7SaC1F7H2GPAx7glIjuGmgq2JeKs7f69g/V6g0rvoEbaOEi1JCRFARaKnmXtkqSp /GEmm47vUybvNxMw7uWIabGvVXajEPZ4Oma8UGOpARHi8Ao3xQqlkan4d6Vl9KL0c961 CQttcuwVX6BIQIOfZridUj9pUtxJNdoOi7osLW2fmsWIwCXNPofhHotnemBNKK1CdjoD yuyRm5bGtpnFUrDebwjZ4pVCHjdfJn5FWSFeBb47MSeKu7Sfr40eiyeNbny9j1kPMYtb MWaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063158; x=1690667958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ICetZO3eJiINHtdQ5D1OIXxRMuzgneIba8TDtaF3d6E=; b=lrCBnn3rm583vH3OSZ9is/uYI5lZ7/uaiJqQZi429U7KMn1JxV/xK3pIfSGJsIaIv4 iYW3BZfMbgeCZXEogQfu2n0rxq57gAzn9t6DPfVUh0l85u4kDnQO/bpJwRfJiu6M6teD xpNRpnT7abvNyEp2fEKN0kN410m6cSeeL5dJuZNWjl5xRzoRSMd8ztpZOtXPMPhtn1VZ y6883maU+5wBwhJNj1zsEsCXJh7KiIzI7GKRG5sRpeYWe7vJVXK3+frBku+DIofc7D2e 5OUuDIOZzu8Q5LJKpa5ei7qhe9R1UEUi0N1ocMTPL0Das4Swa/0uAenJMaIMv/cnKwB8 ZhNg== X-Gm-Message-State: ABy/qLZI32JzK1dkHLbOVhvTaKbZwNkV3m3dY5TZtPuj+x8PfhomudXJ srLCF8VHY5thUekccyOKmpY= X-Google-Smtp-Source: APBJJlHXV0jmg/1doLTbZ3FFNTvdBkhrS+Ce1zxiK5mVCmupiC8T+9vMTzdib9n7CCIgyNTl0x1CRw== X-Received: by 2002:a05:6602:2993:b0:787:8fc:307d with SMTP id o19-20020a056602299300b0078708fc307dmr4086777ior.5.1690063158515; Sat, 22 Jul 2023 14:59:18 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id t18-20020a02ccb2000000b0042af069eeefsm1869614jap.50.2023.07.22.14.59.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:59:18 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 8/9] staging: rtl8723bs: ioctl_linux: Add preferred spaces Date: Sat, 22 Jul 2023 23:59:16 +0200 Message-Id: <20230722215916.4413-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issues: - CHECK: spaces preferred around that '+' (ctx:VxV) - CHECK: spaces preferred around that '&' (ctx:VxV) - CHECK: spaces preferred around that '|' (ctx:VxV) - CHECK: spaces required around that ':' (ctx:VxV) Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 88f560353df7..2896d64e13be 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -13,7 +13,7 @@ #include #include =20 -#define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30) +#define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV + 30) =20 static int wpa_set_auth_algs(struct net_device *dev, u32 value) { @@ -315,18 +315,18 @@ static int rtw_set_wpa_ie(struct adapter *padapter, c= har *pie, unsigned short ie while (cnt < ielen) { eid =3D buf[cnt]; =20 - if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&buf[cnt+2], wps= _oui, 4))) { - padapter->securitypriv.wps_ie_len =3D ((buf[cnt+1]+2) < MAX_WPS_IE_LE= N) ? (buf[cnt+1]+2):MAX_WPS_IE_LEN; + if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&buf[cnt + 2], w= ps_oui, 4))) { + padapter->securitypriv.wps_ie_len =3D ((buf[cnt + 1] + 2) < MAX_WPS_I= E_LEN) ? (buf[cnt + 1] + 2) : MAX_WPS_IE_LEN; =20 memcpy(padapter->securitypriv.wps_ie, &buf[cnt], padapter->securitypr= iv.wps_ie_len); =20 set_fwstate(&padapter->mlmepriv, WIFI_UNDER_WPS); =20 - cnt +=3D buf[cnt+1]+2; + cnt +=3D buf[cnt + 1] + 2; =20 break; } else { - cnt +=3D buf[cnt+1]+2; /* goto next */ + cnt +=3D buf[cnt + 1] + 2; /* goto next */ } } } @@ -359,7 +359,7 @@ static int wpa_set_param(struct net_device *dev, u8 nam= e, u32 value) =20 /* ret =3D ieee80211_wpa_enable(ieee, value); */ =20 - switch ((value)&0xff) { + switch ((value) & 0xff) { case 1: /* WPA */ padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; /* WP= A_PSK */ padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption2Enabl= ed; @@ -758,7 +758,7 @@ static int rtw_set_beacon(struct net_device *dev, struc= t ieee_param *param, int if ((pstapriv->max_num_sta > NUM_STA) || (pstapriv->max_num_sta <=3D 0)) pstapriv->max_num_sta =3D NUM_STA; =20 - if (rtw_check_beacon_data(padapter, pbuf, (len-12-2)) =3D=3D _SUCCESS)/*= 12 =3D param header, 2:no packed */ + if (rtw_check_beacon_data(padapter, pbuf, (len - 12 - 2)) =3D=3D _SUCCES= S)/* 12 =3D param header, 2:no packed */ ret =3D 0; else ret =3D -EINVAL; @@ -787,7 +787,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && @@ -815,7 +815,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) memcpy(psta->bssrateset, param->u.add_sta.tx_supp_rates, 16); =20 /* check wmm cap. */ - if (WLAN_STA_WME&flags) + if (WLAN_STA_WME & flags) psta->qos_option =3D 1; else psta->qos_option =3D 0; @@ -824,7 +824,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) psta->qos_option =3D 0; =20 /* chec 802.11n ht cap. */ - if (WLAN_STA_HT&flags) { + if (WLAN_STA_HT & flags) { psta->htpriv.ht_option =3D true; psta->qos_option =3D 1; memcpy((void *)&psta->htpriv.ht_cap, (void *)¶m->u.add_sta.ht_cap, = sizeof(struct ieee80211_ht_cap)); @@ -852,7 +852,7 @@ static int rtw_del_sta(struct net_device *dev, struct i= eee_param *param) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && @@ -891,7 +891,7 @@ static int rtw_ioctl_get_sta_data(struct net_device *de= v, struct ieee_param *par struct ieee_param_ex *param_ex =3D (struct ieee_param_ex *)param; struct sta_data *psta_data =3D (struct sta_data *)param_ex->data; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param_ex->sta_addr[0] =3D=3D 0xff && param_ex->sta_addr[1] =3D=3D 0xf= f && @@ -948,7 +948,7 @@ static int rtw_get_sta_wpaie(struct net_device *dev, st= ruct ieee_param *param) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) !=3D true) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE)) !=3D true) return -EINVAL; =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && @@ -965,7 +965,7 @@ static int rtw_get_sta_wpaie(struct net_device *dev, st= ruct ieee_param *param) =20 wpa_ie_len =3D psta->wpa_ie[1]; =20 - copy_len =3D ((wpa_ie_len+2) > sizeof(psta->wpa_ie)) ? (sizeof(psta->wp= a_ie)):(wpa_ie_len+2); + copy_len =3D ((wpa_ie_len + 2) > sizeof(psta->wpa_ie)) ? (sizeof(psta->= wpa_ie)) : (wpa_ie_len + 2); =20 param->u.wpa_ie.len =3D copy_len; =20 @@ -990,7 +990,7 @@ static int rtw_set_wps_beacon(struct net_device *dev, s= truct ieee_param *param, if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ =20 kfree(pmlmepriv->wps_beacon_ie); pmlmepriv->wps_beacon_ie =3D NULL; @@ -1021,7 +1021,7 @@ static int rtw_set_wps_probe_resp(struct net_device *= dev, struct ieee_param *par if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ =20 kfree(pmlmepriv->wps_probe_resp_ie); pmlmepriv->wps_probe_resp_ie =3D NULL; @@ -1048,7 +1048,7 @@ static int rtw_set_wps_assoc_resp(struct net_device *= dev, struct ieee_param *par if (check_fwstate(pmlmepriv, WIFI_AP_STATE) !=3D true) return -EINVAL; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ =20 kfree(pmlmepriv->wps_assoc_resp_ie); pmlmepriv->wps_assoc_resp_ie =3D NULL; @@ -1086,14 +1086,14 @@ static int rtw_set_hidden_ssid(struct net_device *d= ev, struct ieee_param *param, =20 mlmeinfo->hidden_ssid_mode =3D ignore_broadcast_ssid =3D param->u.bcn_ie.= reserved[1]; =20 - ie_len =3D len-12-2;/* 12 =3D param header, 2:no packed */ + ie_len =3D len - 12 - 2;/* 12 =3D param header, 2:no packed */ ssid_ie =3D rtw_get_ie(param->u.bcn_ie.buf, WLAN_EID_SSID, &ssid_len, ie= _len); =20 if (ssid_ie && ssid_len > 0 && ssid_len <=3D NDIS_802_11_LENGTH_SSID) { struct wlan_bssid_ex *pbss_network =3D &mlmepriv->cur_network.network; struct wlan_bssid_ex *pbss_network_ext =3D &mlmeinfo->network; =20 - memcpy(ssid, ssid_ie+2, ssid_len); + memcpy(ssid, ssid_ie + 2, ssid_len); ssid[ssid_len] =3D 0x0; =20 memcpy(pbss_network->ssid.ssid, (void *)ssid, ssid_len); --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 19:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98393C0015E for ; Sat, 22 Jul 2023 21:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbjGVV7p (ORCPT ); Sat, 22 Jul 2023 17:59:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjGVV7m (ORCPT ); Sat, 22 Jul 2023 17:59:42 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3516A2123 for ; Sat, 22 Jul 2023 14:59:30 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7835c92c373so97179939f.0 for ; Sat, 22 Jul 2023 14:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1690063169; x=1690667969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g4tY2GuOM7XF3DCI8b76kqr55OfGzK0tioQlStQn52s=; b=ApX7fxDyQFSjWFbkswQ6ONJQ/2B6R3/UfF2kiS4kQSEjPBgoURIyeVVhk0ZNjz3O/q kkic6sftOpZF8YydDQQK4oxPm0p7zYliaN64hSqHMh6py6xZhLmt9tXChoRT9PP/O9jU a74cxDd74UqISD/VCzSerGY9P/peTnIUpnC1KstK0Mz7v8WQWY+iTQr5+nTrxERcH6DY qXDEPSROzETCGQJSpP1eCFHkc2H6Zh+oz4cjPEYfO6bKyC3anzcN5wWfqQGomHALCbZI hsHyG8Tzu3i+siD07SeSPSlrrtkBxofZBbDOE1AonoUUZwE/NJwTOXXiJR3T5Ow80AEF NN/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690063169; x=1690667969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g4tY2GuOM7XF3DCI8b76kqr55OfGzK0tioQlStQn52s=; b=i73MdzdUYEDZyrAbnF7+SXS8AS7PgdiRCFjgiUOXJdYELsT1uKW76zepiIj30uXxNf ltoBQzOXtS2AME5dXhS41Ga4aTU48i1oEnQGS+R7zaxD0uwf49l0FhCdr9f6sIWpYCQO 6gqnnpebh8fq/g+z1Jud/s4DHf/TsCwHYrWWdoCrKszTIYBOsSOMQ1tI9EKqbgrnI7Li /GZ9pHrCR62w4zWja/uWefVL5ozbSaVdeb/K8Tz69Qe7oKIRT0leeZ64rXkjxwqSectj qSEaVmVWkUMV3vPMsqw05s1bVM2imUKKEcjYOOoAqzhzpSMBdhpVgmFGSKQFBp+fqbAi EEuA== X-Gm-Message-State: ABy/qLZ/82nZKoHSR7cB/jtuiW8JVZdmSeACxECcG4Z/FYfUaHgxYllt 6aRLmKO5WHQAkvmJiQCtSe6J4JnnB5NvvQ== X-Google-Smtp-Source: APBJJlGnr1TRBYjUKRbs+sLex/dT9A4Zmt3haniB2O7BLMdIRO2kLi4QWtG8xWGe31MexKYl4QdSSg== X-Received: by 2002:a05:6e02:1ba5:b0:345:fe2d:56f with SMTP id n5-20020a056e021ba500b00345fe2d056fmr2181422ili.14.1690063169593; Sat, 22 Jul 2023 14:59:29 -0700 (PDT) Received: from localhost.localdomain ([161.97.244.155]) by smtp.gmail.com with ESMTPSA id f16-20020a02cad0000000b0042b2d9fbbecsm1874673jap.119.2023.07.22.14.59.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Jul 2023 14:59:29 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 9/9] staging: rtl8723bs: ioctl_linux: Fix comparison to false Date: Sat, 22 Jul 2023 23:59:27 +0200 Message-Id: <20230722215927.4443-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230722215330.4114-1-franziska.naepelt@googlemail.com> References: <20230722215330.4114-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issue: - CHECK: Using comparison to false is error prone Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8723bs/os_dep/ioctl_linux.c index 2896d64e13be..54a2998e837d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -832,7 +832,7 @@ static int rtw_add_sta(struct net_device *dev, struct i= eee_param *param) psta->htpriv.ht_option =3D false; } =20 - if (pmlmepriv->htpriv.ht_option =3D=3D false) + if (!pmlmepriv->htpriv.ht_option) psta->htpriv.ht_option =3D false; =20 update_sta_info_apmode(padapter, psta); --=20 2.39.2 (Apple Git-143)