From nobody Sun Feb 8 12:13:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5954CEB64DC for ; Fri, 21 Jul 2023 07:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbjGUHJn (ORCPT ); Fri, 21 Jul 2023 03:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbjGUHJc (ORCPT ); Fri, 21 Jul 2023 03:09:32 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA7C62735 for ; Fri, 21 Jul 2023 00:09:30 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4R6gdN0nMlz18MCF; Fri, 21 Jul 2023 15:08:40 +0800 (CST) Received: from huawei.com (10.175.101.6) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 15:09:25 +0800 From: Kemeng Shi To: , , , CC: Subject: [PATCH v2 1/2] mm/compaction: correct comment of candidate pfn in fast_isolate_freepages Date: Fri, 21 Jul 2023 23:09:56 +0800 Message-ID: <20230721150957.2058634-2-shikemeng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230721150957.2058634-1-shikemeng@huawei.com> References: <20230721150957.2058634-1-shikemeng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If no preferred one was not found, we will use candidate page with maximum pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum candidate" in comment. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index eb1d3d9a422c..c0d8d08fc163 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_con= trol *cc) break; } =20 - /* Use a minimum pfn if a preferred one was not found */ + /* Use a maximum candidate pfn if a preferred one was not found */ if (!page && high_pfn) { page =3D pfn_to_page(high_pfn); =20 --=20 2.30.0 From nobody Sun Feb 8 12:13:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2887EB64DC for ; Fri, 21 Jul 2023 07:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230008AbjGUHJh (ORCPT ); Fri, 21 Jul 2023 03:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjGUHJb (ORCPT ); Fri, 21 Jul 2023 03:09:31 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D4E2710 for ; Fri, 21 Jul 2023 00:09:28 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R6gZf0J1PztRTg; Fri, 21 Jul 2023 15:06:18 +0800 (CST) Received: from huawei.com (10.175.101.6) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 15:09:26 +0800 From: Kemeng Shi To: , , , CC: Subject: [PATCH v2 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set Date: Fri, 21 Jul 2023 23:09:57 +0800 Message-ID: <20230721150957.2058634-3-shikemeng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230721150957.2058634-1-shikemeng@huawei.com> References: <20230721150957.2058634-1-shikemeng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded pageblock_end_pfn if no_set_skip_hint is set. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang Reviewed-by: David Hildenbrand --- mm/compaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index c0d8d08fc163..9b7a0a69e19f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_cont= rol *cc, unsigned long pfn) { struct zone *zone =3D cc->zone; =20 - pfn =3D pageblock_end_pfn(pfn); - /* Set for isolation rather than compaction */ if (cc->no_set_skip_hint) return; =20 + pfn =3D pageblock_end_pfn(pfn); + if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] =3D pfn; if (cc->mode !=3D MIGRATE_ASYNC && --=20 2.30.0