From nobody Tue Sep 9 01:21:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D025EB64DC for ; Fri, 21 Jul 2023 06:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbjGUGAq (ORCPT ); Fri, 21 Jul 2023 02:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbjGUGAm (ORCPT ); Fri, 21 Jul 2023 02:00:42 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38CDDE62; Thu, 20 Jul 2023 23:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1689919241; x=1721455241; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1ypgipcrK/g6JVBXnq3hemafU0QzkXU5hISGsnvZ/lw=; b=kBqdkSsGFIuj8nV2OOKS3jvpNZmUjOGuDTyunLF83Sp8rjWKsaGrCkLb ODFCyz7zNUYZHGCN43BoNcxhixLKpAJSLg2zlI63pzhiPybzk2IBhBz6h VyGWh6GvDY8MC8VwbJOJK3BJffcylVnkmdllC/ZT4agTzhmXMcabt4xKQ o6kWdV6J3sS6cg+xMmgUnrOr9yPx4RmcvvEVMZl/R+4lidgIoboHcgLHi fL7Bq7PCgl/5GaK9YD/ASzYXXVIvKxRBYc6vAG4nllrSMItsT35x/RTe4 54V8GeVixXVmFC/J0WMsXTz5s+VMt7XZaFGOm6jeo8au0AzdYv9M5Z1xb w==; X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="225102694" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Jul 2023 23:00:39 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 20 Jul 2023 23:00:37 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 20 Jul 2023 23:00:34 -0700 From: Raju Lakkaraju To: CC: , , , , , , Subject: [PATCH net-next 1/7] net: lan743x: Create separate PCS power reset function Date: Fri, 21 Jul 2023 11:30:13 +0530 Message-ID: <20230721060019.2737-2-Raju.Lakkaraju@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230721060019.2737-1-Raju.Lakkaraju@microchip.com> References: <20230721060019.2737-1-Raju.Lakkaraju@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Create separate PCS power reset function from lan743x_sgmii_config () to use as subroutine. Signed-off-by: Raju Lakkaraju --- drivers/net/ethernet/microchip/lan743x_main.c | 54 ++++++++++--------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index a36f6369f132..dba5576a933b 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1145,6 +1145,34 @@ static int lan743x_pcs_seq_state(struct lan743x_adap= ter *adapter, u8 state) return 0; } =20 +static int lan743x_pcs_power_reset(struct lan743x_adapter *adapter) +{ + int mii_ctl; + int ret; + + /* SGMII/1000/2500BASE-X PCS power down */ + mii_ctl =3D lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR); + if (mii_ctl < 0) + return mii_ctl; + + mii_ctl |=3D BMCR_PDOWN; + ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); + if (ret < 0) + return ret; + + ret =3D lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_DOWN); + if (ret < 0) + return ret; + + /* SGMII/1000/2500BASE-X PCS power up */ + mii_ctl &=3D ~BMCR_PDOWN; + ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); + if (ret < 0) + return ret; + + return lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_UP); +} + static int lan743x_sgmii_config(struct lan743x_adapter *adapter) { struct net_device *netdev =3D adapter->netdev; @@ -1207,31 +1235,7 @@ static int lan743x_sgmii_config(struct lan743x_adapt= er *adapter) netif_dbg(adapter, drv, adapter->netdev, "SGMII 1G mode enable\n"); =20 - /* SGMII/1000/2500BASE-X PCS power down */ - mii_ctl =3D lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR); - if (mii_ctl < 0) - return mii_ctl; - - mii_ctl |=3D BMCR_PDOWN; - ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); - if (ret < 0) - return ret; - - ret =3D lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_DOWN); - if (ret < 0) - return ret; - - /* SGMII/1000/2500BASE-X PCS power up */ - mii_ctl &=3D ~BMCR_PDOWN; - ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); - if (ret < 0) - return ret; - - ret =3D lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_UP); - if (ret < 0) - return ret; - - return 0; + return lan743x_pcs_power_reset(adapter); } =20 static void lan743x_mac_set_address(struct lan743x_adapter *adapter, --=20 2.25.1