From nobody Mon Feb 9 05:53:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B55C001DC for ; Wed, 19 Jul 2023 11:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbjGSLl2 (ORCPT ); Wed, 19 Jul 2023 07:41:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbjGSLl0 (ORCPT ); Wed, 19 Jul 2023 07:41:26 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C500125 for ; Wed, 19 Jul 2023 04:41:11 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fbef8ad9bbso67965835e9.0 for ; Wed, 19 Jul 2023 04:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1689766869; x=1690371669; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=omclyAfkGRQWS2BiKQCx7pDx212Hyui8qaS7KiVV4jA=; b=asvioqTlybWzOybciqN1ksH9D2IA4G3XyJNfKHI6nskJTHwCNROLCkZIv6WQMghL9d F/UumjmxH8VAADIo11xP6AFf7qgsbZqunQA6bzET8dmqqL4IdflaAbHMIxy5ZGR+ZFZt 81SGf3Fv6zhzOH9/ijWOwxmkAyvP+ov8dIoq/RbiHcORZfKlGc66mrGJyAYTLVDV9eML 7+wmoaQaKrBOeWdfBBzAJeRdmlltzIIB8wgEbKcMVpjXbth6hTgn0oXCpNiRDSmRrex+ wZnQT1z7EgtJtThH8crfTbBehz8pgAzYk5CERU/uHQkvthyrWInzdJQhyfi6Oc14te0m ZXOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689766869; x=1690371669; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=omclyAfkGRQWS2BiKQCx7pDx212Hyui8qaS7KiVV4jA=; b=MtrW6dXSgdePHHFTwQDDKxrxbed3AQSObk7PrI42uVflF6iu81+P6JzvdHoczlyoo4 VIVpKMcQnrOAN3u5E/847VDuPnTmn6LoywBRjP0Ett+cvk+2FqxEipjvMdT0nqs68QN1 F5oUbN7Kr4Q1S0+DVL17f8EjqkWWZ6fhUAyeD1m47rVyOV5Y0kTBx1/J2Yqnh0rR8iP2 R+zhFPUdjzJk6YfgW8Oxg1SumgW+/l09ZZX8/F5wuzEbKOrGb0KNiWaWteYBxT7pcREY Cu7rKsSawoWXarSR1pguZnWTUtnRGDmeiJrM+cmiBj6YMGwtKhRnLJaXlEIByqOJMMt1 e1Xg== X-Gm-Message-State: ABy/qLazjv3rygn8nAJuRHYKrZBLOW3p5p8dbQjmlMH+UiWYl2+PuTsa DcOb+9hAWTIsR+lqSXtpCgad4Q== X-Google-Smtp-Source: APBJJlEhQJz3wV0yQP9Hu5jxBZIFMZNrna3knuUJntAfNSU7Rc9Nko0UhR7OKF14/DD3JJO7/HJ80w== X-Received: by 2002:a7b:ce16:0:b0:3fa:9e61:19ed with SMTP id m22-20020a7bce16000000b003fa9e6119edmr1874710wmc.23.1689766869358; Wed, 19 Jul 2023 04:41:09 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:f884:f48d:2867:5c1d]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fbb346279dsm1485644wmc.38.2023.07.19.04.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 04:41:08 -0700 (PDT) From: Bartosz Golaszewski To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Linus Walleij , Andy Shevchenko Cc: linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] gpio: mvebu: fix irq domain leak Date: Wed, 19 Jul 2023 13:41:01 +0200 Message-Id: <20230719114101.55051-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Uwe Kleine-K=C3=B6nig pointed out we still have one resource leak in the mv= ebu driver triggered on driver detach. Let's address it with a custom devm action. Fixes: 812d47889a8e ("gpio/mvebu: Use irq_domain_add_linear") Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Uwe Kleine-K=C3=B6nig --- drivers/gpio/gpio-mvebu.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index a35958e7adf6..67497116ce27 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1112,6 +1112,13 @@ static int mvebu_gpio_probe_syscon(struct platform_d= evice *pdev, return 0; } =20 +static void mvebu_gpio_remove_irq_domain(void *data) +{ + struct irq_domain *domain =3D data; + + irq_domain_remove(domain); +} + static int mvebu_gpio_probe(struct platform_device *pdev) { struct mvebu_gpio_chip *mvchip; @@ -1246,13 +1253,18 @@ static int mvebu_gpio_probe(struct platform_device = *pdev) return -ENODEV; } =20 + err =3D devm_add_action_or_reset(&pdev->dev, mvebu_gpio_remove_irq_domain, + mvchip->domain); + if (err) + return err; + err =3D irq_alloc_domain_generic_chips( mvchip->domain, ngpios, 2, np->name, handle_level_irq, IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_LEVEL, 0, 0); if (err) { dev_err(&pdev->dev, "couldn't allocate irq chips %s (DT).\n", mvchip->chip.label); - goto err_domain; + return err; } =20 /* @@ -1292,10 +1304,6 @@ static int mvebu_gpio_probe(struct platform_device *= pdev) } =20 return 0; - -err_domain: - irq_domain_remove(mvchip->domain); - return err; } =20 static struct platform_driver mvebu_gpio_driver =3D { --=20 2.39.2