From nobody Mon Feb 9 13:18:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9812AEB64DD for ; Tue, 18 Jul 2023 18:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbjGRSj1 (ORCPT ); Tue, 18 Jul 2023 14:39:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230249AbjGRSjY (ORCPT ); Tue, 18 Jul 2023 14:39:24 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74C9AF0 for ; Tue, 18 Jul 2023 11:39:23 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51cff235226so10907a12.0 for ; Tue, 18 Jul 2023 11:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689705562; x=1692297562; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Jkb55HhAbN5nQxp124JO5CgyYp5FwsBzn/8eguMNO/I=; b=vo5NZKlbXQn4Jl6b8UAEOHnqb04wgASw6MkQZM+pF3hTs01Y0VzlGrVz8NYsDNXcPB smn7BGtYuxNMkXvFUouYasWjGuNLoRZjcMnan244Wbya7Mzsfc8ItrplIUBL9Mhkspac 9Oo1r54niZZC+ITU302GiMZGUvwaQbse/RPw4WsdMWIqh0Ke2HBBkygdlSZ33ijXXcBk OBiDSbdTvbmiQJpm56qq778Q6ijwlCTqPeTqJo8SkVFZzP+x3UdrAOL3UkAHgsKyYmVx CKo9yr9BEhDiUQVXbOmQrphU1dat7sTEJ5uf+Uqe4hldnVEj+0c+moHnjXglHo7uUeSF oYMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689705562; x=1692297562; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jkb55HhAbN5nQxp124JO5CgyYp5FwsBzn/8eguMNO/I=; b=G9HOeENiYDUH8UPcJcmWG2w+/avjnk24Y9se+tRH0JK1WQfg7VJaODb69J8WPz4syG tH2kWIBSQkg+ttwdOMrObVAxDdZ4ASokZhJmEWHFIU/0oxO51zmwTywzIbycr4ngl9bK P5bbgh4aO0UDGI5uPu3HqB3dZ1CkxXVBEYX0kRnZMlP4gVvZaoPk+grZWdFPZJQ7RiTC t91sCzQ/cqhJZsvodfzyB8HcRbhSkznERnQYMZ/pu9xdIOQmQx8ST9CqTXTl7PVxRGGv oR0bV01/OC0siXvpiazVB+2hUN32ITyT/VnARfnG69W/3Qij1q2KB+gcvwMLTX7K1Eqz Hv2g== X-Gm-Message-State: ABy/qLbf1Gm1rQtFv+eO/SlDBs0ihxZ4Xs1q8CaXGKQlDsxAqMHzYoJQ jtNrzXfbBwBNqz1dcQg87KtPig== X-Google-Smtp-Source: APBJJlELhwGyjrv7JKi503vZ44u3uhfj4GPWlLn4zkwX+p1EKl4j1+y/9UEV5+hm++H5sG8LkZHJ7w== X-Received: by 2002:a05:6402:40c5:b0:51e:588b:20ca with SMTP id z5-20020a05640240c500b0051e588b20camr1010538edb.8.1689705561993; Tue, 18 Jul 2023 11:39:21 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c993000000b0051e1a4454b2sm1564460edt.67.2023.07.18.11.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 11:39:21 -0700 (PDT) From: Krzysztof Kozlowski To: Sudeep Holla , Cristian Marussi , Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] firmware: arm_scmi: drop OF node reference in smc_chan_setup Date: Tue, 18 Jul 2023 20:39:16 +0200 Message-Id: <20230718183916.44439-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The OF node reference obtained from of_parse_phandle() should be dropped if node is not compatible with arm,scmi-shmem. Fixes: 507cd4d2c5eb ("firmware: arm_scmi: Add compatibility checks for shme= m node") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/firmware/arm_scmi/smc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/sm= c.c index 621c37efe3ec..2d8c510fbf52 100644 --- a/drivers/firmware/arm_scmi/smc.c +++ b/drivers/firmware/arm_scmi/smc.c @@ -137,8 +137,10 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo= , struct device *dev, return -ENOMEM; =20 np =3D of_parse_phandle(cdev->of_node, "shmem", 0); - if (!of_device_is_compatible(np, "arm,scmi-shmem")) + if (!of_device_is_compatible(np, "arm,scmi-shmem")) { + of_node_put(np); return -ENXIO; + } =20 ret =3D of_address_to_resource(np, 0, &res); of_node_put(np); --=20 2.34.1