From nobody Sun Feb 8 04:23:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C6BC001B0 for ; Mon, 17 Jul 2023 15:09:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230293AbjGQPJ6 (ORCPT ); Mon, 17 Jul 2023 11:09:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230474AbjGQPJ4 (ORCPT ); Mon, 17 Jul 2023 11:09:56 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0881410C0; Mon, 17 Jul 2023 08:09:53 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B335C15; Mon, 17 Jul 2023 08:10:36 -0700 (PDT) Received: from e126415.cambridge.arm.com (e126415.arm.com [10.1.25.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2986D3F738; Mon, 17 Jul 2023 08:09:50 -0700 (PDT) From: Aditya Deshpande To: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Shuah Khan , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino Subject: [PATCH] selftests: vDSO: fix Makefile so that it uses lib.mk correctly Date: Mon, 17 Jul 2023 16:09:42 +0100 Message-Id: <20230717150942.37448-1-aditya.deshpande@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" kselftest.rst states that flags must be specified before including lib.mk, but the vDSO selftest Makefile does not follow this order. As a result, changes made by lib.mk to flags and other variables are overwritten by the Makefile. For example, it is impossible to pass CFLAGS to the compiler via make. Rectify this by including lib.mk after assigning flag values. Also change the paths of the generated programs from absolute to relative paths as lib.mk will now correctly prepend the output directory path to the program name as intended. Cc: Shuah Khan Cc: Andy Lutomirski Cc: Thomas Gleixner Cc: Vincenzo Frascino Signed-off-by: Aditya Deshpande Reviewed-by: Vincenzo Frascino --- tools/testing/selftests/vDSO/Makefile | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/vDSO/Makefile b/tools/testing/selftest= s/vDSO/Makefile index d53a4d8008f9..19145210d044 100644 --- a/tools/testing/selftests/vDSO/Makefile +++ b/tools/testing/selftests/vDSO/Makefile @@ -1,16 +1,15 @@ # SPDX-License-Identifier: GPL-2.0 -include ../lib.mk - uname_M :=3D $(shell uname -m 2>/dev/null || echo not) ARCH ?=3D $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) =20 -TEST_GEN_PROGS :=3D $(OUTPUT)/vdso_test_gettimeofday $(OUTPUT)/vdso_test_g= etcpu -TEST_GEN_PROGS +=3D $(OUTPUT)/vdso_test_abi -TEST_GEN_PROGS +=3D $(OUTPUT)/vdso_test_clock_getres +TEST_GEN_PROGS :=3D vdso_test_gettimeofday +TEST_GEN_PROGS +=3D vdso_test_getcpu +TEST_GEN_PROGS +=3D vdso_test_abi +TEST_GEN_PROGS +=3D vdso_test_clock_getres ifeq ($(ARCH),$(filter $(ARCH),x86 x86_64)) -TEST_GEN_PROGS +=3D $(OUTPUT)/vdso_standalone_test_x86 +TEST_GEN_PROGS +=3D vdso_standalone_test_x86 endif -TEST_GEN_PROGS +=3D $(OUTPUT)/vdso_test_correctness +TEST_GEN_PROGS +=3D vdso_test_correctness =20 CFLAGS :=3D -std=3Dgnu99 CFLAGS_vdso_standalone_test_x86 :=3D -nostdlib -fno-asynchronous-unwind-ta= bles -fno-stack-protector @@ -19,7 +18,8 @@ ifeq ($(CONFIG_X86_32),y) LDLIBS +=3D -lgcc_s endif =20 -all: $(TEST_GEN_PROGS) +include ../lib.mk + $(OUTPUT)/vdso_test_gettimeofday: parse_vdso.c vdso_test_gettimeofday.c $(OUTPUT)/vdso_test_getcpu: parse_vdso.c vdso_test_getcpu.c $(OUTPUT)/vdso_test_abi: parse_vdso.c vdso_test_abi.c --=20 2.25.1