From nobody Sun Feb 8 09:11:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499E3EB64DC for ; Mon, 17 Jul 2023 09:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjGQJeF (ORCPT ); Mon, 17 Jul 2023 05:34:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbjGQJdy (ORCPT ); Mon, 17 Jul 2023 05:33:54 -0400 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A691410E6; Mon, 17 Jul 2023 02:33:52 -0700 (PDT) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36H8V0Yj026383; Mon, 17 Jul 2023 02:33:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=jcnoKj+3A+kq+bkfNVHg92JPmySG7/OrLEHs8Pz541M=; b=CqoPUGZwmczqG9syZZklqsvBj97G83izY2BaZlvGJbShgS1rcwtSQwFMebfhG+KGwDjv Olgqd8micGgc0tgIdnUBdksS4TFttcY987AHKx8ltIu7jw5EN+YBaWeb5Nk6JD2kbeni zf73sGnAfyMhgxP7fQ0WUUT44IaoUbrMjc/Pg5EyA/ERhi8izJos091S3NZKlY3PL2xo W+UHNKQEXxg2gmv8Fs7xShptul9hGcX8HiPv0JKOGLgQeVaClszl59CbodBMv4XiFxqb 1zgFKhR7qLJRMQ+URjVgYdm6SsSyI2KHs0H18XTsoDepCUAf/v60BGd2TNagfiYSh/ep rA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3rutyguygk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 02:33:34 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 17 Jul 2023 02:33:32 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Mon, 17 Jul 2023 02:33:32 -0700 Received: from hyd1soter3.marvell.com (unknown [10.29.37.134]) by maili.marvell.com (Postfix) with ESMTP id B7BD43F70A5; Mon, 17 Jul 2023 02:33:26 -0700 (PDT) From: Hariprasad Kelam To: , CC: , , , , , , , , , , , , , , , , , , Subject: [net-next Patch v3 1/4] octeontx2-pf: implement transmit schedular allocation algorithm Date: Mon, 17 Jul 2023 15:03:16 +0530 Message-ID: <20230717093319.26618-2-hkelam@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230717093319.26618-1-hkelam@marvell.com> References: <20230717093319.26618-1-hkelam@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: Mb_iFGsNSMT102kUtFSJpwVXrxO2FVbH X-Proofpoint-ORIG-GUID: Mb_iFGsNSMT102kUtFSJpwVXrxO2FVbH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_07,2023-07-13_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Naveen Mamindlapalli unlike strict priority, where number of classes are limited to max 8, there is no restriction on the number of dwrr child nodes unless the count increases the max number of child nodes supported. Hardware expects strict priority transmit schedular indexes mapped to their priority. This patch adds defines transmit schedular allocation algorithm such that the above requirement is honored. Signed-off-by: Naveen Mamindlapalli Signed-off-by: Hariprasad Kelam --- .../net/ethernet/marvell/octeontx2/nic/qos.c | 136 +++++++++++++++++- .../net/ethernet/marvell/octeontx2/nic/qos.h | 6 + 2 files changed, 136 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c b/drivers/net= /ethernet/marvell/octeontx2/nic/qos.c index d3a76c5ccda8..919cd01b7f02 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.c @@ -19,6 +19,7 @@ #define OTX2_QOS_CLASS_NONE 0 #define OTX2_QOS_DEFAULT_PRIO 0xF #define OTX2_QOS_INVALID_SQ 0xFFFF +#define OTX2_QOS_INVALID_TXSCHQ_IDX 0xFFFF =20 static void otx2_qos_update_tx_netdev_queues(struct otx2_nic *pfvf) { @@ -315,9 +316,14 @@ static void otx2_qos_fill_cfg_tl(struct otx2_qos_node = *parent, =20 list_for_each_entry(node, &parent->child_list, list) { otx2_qos_fill_cfg_tl(node, cfg); - cfg->schq_contig[node->level]++; otx2_qos_fill_cfg_schq(node, cfg); } + + /* Assign the required number of transmit schedular queues under the + * given class + */ + cfg->schq_contig[parent->level - 1] +=3D parent->child_dwrr_cnt + + parent->max_static_prio + 1; } =20 static void otx2_qos_prepare_txschq_cfg(struct otx2_nic *pfvf, @@ -401,9 +407,13 @@ static int otx2_qos_add_child_node(struct otx2_qos_nod= e *parent, struct otx2_qos_node *tmp_node; struct list_head *tmp; =20 + if (node->prio > parent->max_static_prio) + parent->max_static_prio =3D node->prio; + for (tmp =3D head->next; tmp !=3D head; tmp =3D tmp->next) { tmp_node =3D list_entry(tmp, struct otx2_qos_node, list); - if (tmp_node->prio =3D=3D node->prio) + if (tmp_node->prio =3D=3D node->prio && + tmp_node->is_static) return -EEXIST; if (tmp_node->prio > node->prio) { list_add_tail(&node->list, tmp); @@ -476,6 +486,7 @@ otx2_qos_sw_create_leaf_node(struct otx2_nic *pfvf, node->rate =3D otx2_convert_rate(rate); node->ceil =3D otx2_convert_rate(ceil); node->prio =3D prio; + node->is_static =3D true; =20 __set_bit(qid, pfvf->qos.qos_sq_bmap); =20 @@ -628,6 +639,21 @@ static int otx2_qos_txschq_alloc(struct otx2_nic *pfvf, return rc; } =20 +static void otx2_qos_free_unused_txschq(struct otx2_nic *pfvf, + struct otx2_qos_cfg *cfg) +{ + int lvl, idx, schq; + + for (lvl =3D 0; lvl < NIX_TXSCH_LVL_CNT; lvl++) { + for (idx =3D 0; idx < cfg->schq_contig[lvl]; idx++) { + if (!cfg->schq_index_used[lvl][idx]) { + schq =3D cfg->schq_contig_list[lvl][idx]; + otx2_txschq_free_one(pfvf, lvl, schq); + } + } + } +} + static void otx2_qos_txschq_fill_cfg_schq(struct otx2_nic *pfvf, struct otx2_qos_node *node, struct otx2_qos_cfg *cfg) @@ -652,9 +678,11 @@ static void otx2_qos_txschq_fill_cfg_tl(struct otx2_ni= c *pfvf, list_for_each_entry(tmp, &node->child_list, list) { otx2_qos_txschq_fill_cfg_tl(pfvf, tmp, cfg); cnt =3D cfg->static_node_pos[tmp->level]; - tmp->schq =3D cfg->schq_contig_list[tmp->level][cnt]; + tmp->schq =3D cfg->schq_contig_list[tmp->level][tmp->txschq_idx]; + cfg->schq_index_used[tmp->level][tmp->txschq_idx] =3D true; if (cnt =3D=3D 0) - node->prio_anchor =3D tmp->schq; + node->prio_anchor =3D + cfg->schq_contig_list[tmp->level][0]; cfg->static_node_pos[tmp->level]++; otx2_qos_txschq_fill_cfg_schq(pfvf, tmp, cfg); } @@ -667,9 +695,87 @@ static void otx2_qos_txschq_fill_cfg(struct otx2_nic *= pfvf, mutex_lock(&pfvf->qos.qos_lock); otx2_qos_txschq_fill_cfg_tl(pfvf, node, cfg); otx2_qos_txschq_fill_cfg_schq(pfvf, node, cfg); + otx2_qos_free_unused_txschq(pfvf, cfg); mutex_unlock(&pfvf->qos.qos_lock); } =20 +static void __otx2_qos_assign_base_idx_tl(struct otx2_nic *pfvf, + struct otx2_qos_node *tmp, + unsigned long *child_idx_bmap, + int child_cnt) +{ + int idx; + + if (tmp->txschq_idx !=3D OTX2_QOS_INVALID_TXSCHQ_IDX) + return; + + /* assign static nodes 1:1 prio mapping first, then remaining nodes */ + for (idx =3D 0; idx < child_cnt; idx++) { + if (tmp->is_static && tmp->prio =3D=3D idx && + !test_bit(idx, child_idx_bmap)) { + tmp->txschq_idx =3D idx; + set_bit(idx, child_idx_bmap); + return; + } else if (!tmp->is_static && idx >=3D tmp->prio && + !test_bit(idx, child_idx_bmap)) { + tmp->txschq_idx =3D idx; + set_bit(idx, child_idx_bmap); + return; + } + } +} + +static int otx2_qos_assign_base_idx_tl(struct otx2_nic *pfvf, + struct otx2_qos_node *node) +{ + unsigned long *child_idx_bmap; + struct otx2_qos_node *tmp; + int child_cnt; + + list_for_each_entry(tmp, &node->child_list, list) + tmp->txschq_idx =3D OTX2_QOS_INVALID_TXSCHQ_IDX; + + /* allocate child index array */ + child_cnt =3D node->child_dwrr_cnt + node->max_static_prio + 1; + child_idx_bmap =3D kcalloc(BITS_TO_LONGS(child_cnt), + sizeof(unsigned long), + GFP_KERNEL); + if (!child_idx_bmap) + return -ENOMEM; + + list_for_each_entry(tmp, &node->child_list, list) + otx2_qos_assign_base_idx_tl(pfvf, tmp); + + /* assign base index of static priority children first */ + list_for_each_entry(tmp, &node->child_list, list) { + if (!tmp->is_static) + continue; + __otx2_qos_assign_base_idx_tl(pfvf, tmp, child_idx_bmap, + child_cnt); + } + + /* assign base index of dwrr priority children */ + list_for_each_entry(tmp, &node->child_list, list) + __otx2_qos_assign_base_idx_tl(pfvf, tmp, child_idx_bmap, + child_cnt); + + kfree(child_idx_bmap); + + return 0; +} + +static int otx2_qos_assign_base_idx(struct otx2_nic *pfvf, + struct otx2_qos_node *node) +{ + int ret =3D 0; + + mutex_lock(&pfvf->qos.qos_lock); + ret =3D otx2_qos_assign_base_idx_tl(pfvf, node); + mutex_unlock(&pfvf->qos.qos_lock); + + return ret; +} + static int otx2_qos_txschq_push_cfg_schq(struct otx2_nic *pfvf, struct otx2_qos_node *node, struct otx2_qos_cfg *cfg) @@ -761,8 +867,10 @@ static void otx2_qos_free_cfg(struct otx2_nic *pfvf, s= truct otx2_qos_cfg *cfg) =20 for (lvl =3D 0; lvl < NIX_TXSCH_LVL_CNT; lvl++) { for (idx =3D 0; idx < cfg->schq_contig[lvl]; idx++) { - schq =3D cfg->schq_contig_list[lvl][idx]; - otx2_txschq_free_one(pfvf, lvl, schq); + if (cfg->schq_index_used[lvl][idx]) { + schq =3D cfg->schq_contig_list[lvl][idx]; + otx2_txschq_free_one(pfvf, lvl, schq); + } } } } @@ -838,6 +946,10 @@ static int otx2_qos_push_txschq_cfg(struct otx2_nic *p= fvf, if (ret) return -ENOSPC; =20 + ret =3D otx2_qos_assign_base_idx(pfvf, node); + if (ret) + return -ENOMEM; + if (!(pfvf->netdev->flags & IFF_UP)) { otx2_qos_txschq_fill_cfg(pfvf, node, cfg); return 0; @@ -995,6 +1107,7 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_nic *= pfvf, u16 classid, if (ret) goto out; =20 + parent->child_static_cnt++; set_bit(prio, parent->prio_bmap); =20 /* read current txschq configuration */ @@ -1067,6 +1180,7 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_nic = *pfvf, u16 classid, free_old_cfg: kfree(old_cfg); reset_prio: + parent->child_static_cnt--; clear_bit(prio, parent->prio_bmap); out: return ret; @@ -1105,6 +1219,7 @@ static int otx2_qos_leaf_to_inner(struct otx2_nic *pf= vf, u16 classid, goto out; } =20 + node->child_static_cnt++; set_bit(prio, node->prio_bmap); =20 /* store the qid to assign to leaf node */ @@ -1178,6 +1293,7 @@ static int otx2_qos_leaf_to_inner(struct otx2_nic *pf= vf, u16 classid, free_old_cfg: kfree(old_cfg); reset_prio: + node->child_static_cnt--; clear_bit(prio, node->prio_bmap); out: return ret; @@ -1207,6 +1323,10 @@ static int otx2_qos_leaf_del(struct otx2_nic *pfvf, = u16 *classid, otx2_qos_destroy_node(pfvf, node); pfvf->qos.qid_to_sqmap[qid] =3D OTX2_QOS_INVALID_SQ; =20 + parent->child_static_cnt--; + if (!parent->child_static_cnt) + parent->max_static_prio =3D 0; + clear_bit(prio, parent->prio_bmap); =20 return 0; @@ -1245,6 +1365,10 @@ static int otx2_qos_leaf_del_last(struct otx2_nic *p= fvf, u16 classid, bool force otx2_qos_destroy_node(pfvf, node); pfvf->qos.qid_to_sqmap[qid] =3D OTX2_QOS_INVALID_SQ; =20 + parent->child_static_cnt--; + if (!parent->child_static_cnt) + parent->max_static_prio =3D 0; + clear_bit(prio, parent->prio_bmap); =20 /* create downstream txschq entries to parent */ diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h b/drivers/net= /ethernet/marvell/octeontx2/nic/qos.h index 19773284be27..faa7c24675d1 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h @@ -35,6 +35,7 @@ struct otx2_qos_cfg { int dwrr_node_pos[NIX_TXSCH_LVL_CNT]; u16 schq_contig_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC]; u16 schq_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC]; + bool schq_index_used[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC]; }; =20 struct otx2_qos { @@ -62,7 +63,12 @@ struct otx2_qos_node { u16 schq; /* hw txschq */ u16 qid; u16 prio_anchor; + u16 max_static_prio; + u16 child_dwrr_cnt; + u16 child_static_cnt; + u16 txschq_idx; /* txschq allocation index */ u8 level; + bool is_static; }; =20 =20 --=20 2.17.1 From nobody Sun Feb 8 09:11:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467CEC001DE for ; Mon, 17 Jul 2023 09:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbjGQJd5 (ORCPT ); Mon, 17 Jul 2023 05:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbjGQJdx (ORCPT ); Mon, 17 Jul 2023 05:33:53 -0400 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 773EAE47; Mon, 17 Jul 2023 02:33:51 -0700 (PDT) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36H5TrO3020470; Mon, 17 Jul 2023 02:33:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=Rder2OAzgtZd3D78Lyy1oE9ERfYSQk2vWQvPHgIJsIA=; b=UC2RTGw9iAOqju32zC15e1cjjvSl/39yEv5OG6ZdhFN2vj21dPx0H02kgIqFDkYZKvwM 4Fas8Q/MmIp0arOQnUkrWnc29TqmeK4/M00Sb77HlhVexe8V8/MlVakKouMAJC6YDuWx QMtLyfnxgX/K4ccNNwnmJ0ELZIdwpkd7FznfVQXgRGG6z3Bm6ReGruVI2sp7gHVW6l77 WwiI0vQY7uxiW4jvf1g8k1oTR+BfPsr18VeggntCzZ41cGtYLPTz7QvgtiMT/YW1Ca4E UxgXSP+u+Og74J30c543xk4nK4YH5Z/J0R8CybRp1HRfE0iaAl+oDI2qjwOZY0i7IvVz DA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3rvyhx0p2t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 02:33:40 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 17 Jul 2023 02:33:38 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Mon, 17 Jul 2023 02:33:38 -0700 Received: from hyd1soter3.marvell.com (unknown [10.29.37.134]) by maili.marvell.com (Postfix) with ESMTP id 02DFC3F70A4; Mon, 17 Jul 2023 02:33:32 -0700 (PDT) From: Hariprasad Kelam To: , CC: , , , , , , , , , , , , , , , , , , Subject: [net-next Patch v3 2/4] sch_htb: Allow HTB quantum parameter in offload mode Date: Mon, 17 Jul 2023 15:03:17 +0530 Message-ID: <20230717093319.26618-3-hkelam@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230717093319.26618-1-hkelam@marvell.com> References: <20230717093319.26618-1-hkelam@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: 9bNqpZraSwjnHvYJ62TyVIOdHGWfFcS_ X-Proofpoint-ORIG-GUID: 9bNqpZraSwjnHvYJ62TyVIOdHGWfFcS_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_07,2023-07-13_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Naveen Mamindlapalli The current implementation of HTB offload returns the EINVAL error for quantum parameter. This patch removes the error returning checks for 'quantum' parameter and populates its value to tc_htb_qopt_offload structure such that driver can use the same. Add quantum parameter check in mlx5 driver, as mlx5 devices are not capable of supporting the quantum parameter when htb offload is used. Report error if quantum parameter is set to a non-default value. Signed-off-by: Naveen Mamindlapalli Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/mellanox/mlx5/core/en/qos.c | 4 ++-- include/net/pkt_cls.h | 1 + net/sched/sch_htb.c | 7 +++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c b/drivers/net= /ethernet/mellanox/mlx5/core/en/qos.c index 1874c2f0587f..244bc15a42ab 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c @@ -379,9 +379,9 @@ int mlx5e_htb_setup_tc(struct mlx5e_priv *priv, struct = tc_htb_qopt_offload *htb_ if (!htb && htb_qopt->command !=3D TC_HTB_CREATE) return -EINVAL; =20 - if (htb_qopt->prio) { + if (htb_qopt->prio || htb_qopt->quantum) { NL_SET_ERR_MSG_MOD(htb_qopt->extack, - "prio parameter is not supported by device with HTB offload enabled= ."); + "prio and quantum parameters are not supported by device with HTB o= ffload enabled."); return -EOPNOTSUPP; } =20 diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index a2ea45c7b53e..139cd09828af 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -866,6 +866,7 @@ struct tc_htb_qopt_offload { u32 parent_classid; u16 classid; u16 qid; + u32 quantum; u64 rate; u64 ceil; u8 prio; diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index 325c29041c7d..333800a7d4eb 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c @@ -1810,10 +1810,6 @@ static int htb_change_class(struct Qdisc *sch, u32 c= lassid, NL_SET_ERR_MSG(extack, "HTB offload doesn't support the mpu parameter"); goto failure; } - if (hopt->quantum) { - NL_SET_ERR_MSG(extack, "HTB offload doesn't support the quantum paramet= er"); - goto failure; - } } =20 /* Keeping backward compatible with rate_table based iproute2 tc */ @@ -1910,6 +1906,7 @@ static int htb_change_class(struct Qdisc *sch, u32 cl= assid, .rate =3D max_t(u64, hopt->rate.rate, rate64), .ceil =3D max_t(u64, hopt->ceil.rate, ceil64), .prio =3D hopt->prio, + .quantum =3D hopt->quantum, .extack =3D extack, }; err =3D htb_offload(dev, &offload_opt); @@ -1931,6 +1928,7 @@ static int htb_change_class(struct Qdisc *sch, u32 cl= assid, .rate =3D max_t(u64, hopt->rate.rate, rate64), .ceil =3D max_t(u64, hopt->ceil.rate, ceil64), .prio =3D hopt->prio, + .quantum =3D hopt->quantum, .extack =3D extack, }; err =3D htb_offload(dev, &offload_opt); @@ -2017,6 +2015,7 @@ static int htb_change_class(struct Qdisc *sch, u32 cl= assid, .rate =3D max_t(u64, hopt->rate.rate, rate64), .ceil =3D max_t(u64, hopt->ceil.rate, ceil64), .prio =3D hopt->prio, + .quantum =3D hopt->quantum, .extack =3D extack, }; err =3D htb_offload(dev, &offload_opt); --=20 2.17.1 From nobody Sun Feb 8 09:11:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 532AAEB64DC for ; Mon, 17 Jul 2023 09:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbjGQJeS (ORCPT ); Mon, 17 Jul 2023 05:34:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230372AbjGQJeC (ORCPT ); Mon, 17 Jul 2023 05:34:02 -0400 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E6313D; Mon, 17 Jul 2023 02:33:56 -0700 (PDT) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36H8Uxe7026343; Mon, 17 Jul 2023 02:33:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=nL8fpG9iocxNyRSI2y8KFYKeGEYWNd9e7mV45V49b7w=; b=ePPAW91UvD12RjtzmcPINGDkHC90GW6uD3vsXXUv9oTKyWFC3//c5ClRBDHcwQbEId3n DxtmuNuMTBiQxPm6Ly+/jwCwqZtpbiKzUIWXFVCNo1HQlk//WjYkBt/AU2eaXv64S8Zc 3kQ1YZ9yrGZXi1Sjzzo+aFxYyrG3nhHpcPj0cXxCqhlD92skmDQTP1LPxhY7vdFVoQ7r 2f3lS5JUa+I+lfzAn+eIbJ6aYSry+vFx4A8pQErHELfk38suVg5D8J7y26poD3bXoPcI yBW97yqrqcgtngEtNpL5th3noUerTLREnEN7NFrD2BL5M/Wm5g8hN+6OgrE26g6Xk+6f 3A== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3rutyguygq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 02:33:47 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 17 Jul 2023 02:33:44 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Mon, 17 Jul 2023 02:33:44 -0700 Received: from hyd1soter3.marvell.com (unknown [10.29.37.134]) by maili.marvell.com (Postfix) with ESMTP id 429583F70A5; Mon, 17 Jul 2023 02:33:39 -0700 (PDT) From: Hariprasad Kelam To: , CC: , , , , , , , , , , , , , , , , , , Subject: [net-next Patch v3 3/4] octeontx2-pf: htb offload support for Round Robin scheduling Date: Mon, 17 Jul 2023 15:03:18 +0530 Message-ID: <20230717093319.26618-4-hkelam@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230717093319.26618-1-hkelam@marvell.com> References: <20230717093319.26618-1-hkelam@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: Jl65TqQzJ-E02ITIUK_mUWjyyRBCvm0B X-Proofpoint-ORIG-GUID: Jl65TqQzJ-E02ITIUK_mUWjyyRBCvm0B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_07,2023-07-13_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Naveen Mamindlapalli When multiple traffic flows reach Transmit level with the same priority, with Round robin scheduling traffic flow with the highest quantum value is picked. With this support, the user can add multiple classes with the same priority and different quantum. This patch does necessary changes to support the same. Signed-off-by: Naveen Mamindlapalli Signed-off-by: Hariprasad Kelam --- .../marvell/octeontx2/nic/otx2_common.c | 1 + .../marvell/octeontx2/nic/otx2_common.h | 1 + .../net/ethernet/marvell/octeontx2/nic/qos.c | 280 +++++++++++++++--- .../net/ethernet/marvell/octeontx2/nic/qos.h | 5 +- 4 files changed, 247 insertions(+), 40 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/dri= vers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index 77c8f650f7ac..8cdd92dd9762 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -774,6 +774,7 @@ int otx2_txsch_alloc(struct otx2_nic *pfvf) rsp->schq_list[lvl][schq]; =20 pfvf->hw.txschq_link_cfg_lvl =3D rsp->link_cfg_lvl; + pfvf->hw.txschq_aggr_lvl_rr_prio =3D rsp->aggr_lvl_rr_prio; =20 return 0; } diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/dri= vers/net/ethernet/marvell/octeontx2/nic/otx2_common.h index ba8091131ec0..37d792f18809 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h @@ -224,6 +224,7 @@ struct otx2_hw { =20 /* NIX */ u8 txschq_link_cfg_lvl; + u8 txschq_aggr_lvl_rr_prio; u16 txschq_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC]; u16 matchall_ipolicer; u32 dwrr_mtu; diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c b/drivers/net= /ethernet/marvell/octeontx2/nic/qos.c index 919cd01b7f02..1e77bbf5d22a 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.c @@ -20,6 +20,8 @@ #define OTX2_QOS_DEFAULT_PRIO 0xF #define OTX2_QOS_INVALID_SQ 0xFFFF #define OTX2_QOS_INVALID_TXSCHQ_IDX 0xFFFF +#define CN10K_MAX_RR_WEIGHT GENMASK_ULL(13, 0) +#define OTX2_MAX_RR_QUANTUM GENMASK_ULL(23, 0) =20 static void otx2_qos_update_tx_netdev_queues(struct otx2_nic *pfvf) { @@ -66,11 +68,24 @@ static void otx2_qos_get_regaddr(struct otx2_qos_node *= node, } } =20 +static int otx2_qos_quantum_to_dwrr_weight(struct otx2_nic *pfvf, u32 quan= tum) +{ + u32 weight; + + weight =3D quantum / pfvf->hw.dwrr_mtu; + if (quantum % pfvf->hw.dwrr_mtu) + weight +=3D 1; + + return weight; +} + static void otx2_config_sched_shaping(struct otx2_nic *pfvf, struct otx2_qos_node *node, struct nix_txschq_config *cfg, int *num_regs) { + u32 rr_weight; + u32 quantum; u64 maxrate; =20 otx2_qos_get_regaddr(node, cfg, *num_regs); @@ -87,8 +102,17 @@ static void otx2_config_sched_shaping(struct otx2_nic *= pfvf, return; } =20 - /* configure priority */ - cfg->regval[*num_regs] =3D (node->schq - node->parent->prio_anchor) << 24; + /* configure priority/quantum */ + if (node->is_static) { + cfg->regval[*num_regs] =3D + (node->schq - node->parent->prio_anchor) << 24; + } else { + quantum =3D node->quantum ? + node->quantum : pfvf->tx_max_pktlen; + rr_weight =3D otx2_qos_quantum_to_dwrr_weight(pfvf, quantum); + cfg->regval[*num_regs] =3D node->parent->child_dwrr_prio << 24 | + rr_weight; + } (*num_regs)++; =20 /* configure PIR */ @@ -196,9 +220,8 @@ static int otx2_qos_txschq_set_parent_topology(struct o= tx2_nic *pfvf, cfg->reg[0] =3D NIX_AF_TL1X_TOPOLOGY(parent->schq); =20 cfg->regval[0] =3D (u64)parent->prio_anchor << 32; - if (parent->level =3D=3D NIX_TXSCH_LVL_TL1) - cfg->regval[0] |=3D (u64)TXSCH_TL1_DFLT_RR_PRIO << 1; - + cfg->regval[0] |=3D ((parent->child_dwrr_prio !=3D OTX2_QOS_DEFAULT_PRIO)= ? + parent->child_dwrr_prio : 0) << 1; cfg->num_regs++; =20 rc =3D otx2_sync_mbox_msg(&pfvf->mbox); @@ -384,10 +407,12 @@ otx2_qos_alloc_root(struct otx2_nic *pfvf) return ERR_PTR(-ENOMEM); =20 node->parent =3D NULL; - if (!is_otx2_vf(pfvf->pcifunc)) + if (!is_otx2_vf(pfvf->pcifunc)) { node->level =3D NIX_TXSCH_LVL_TL1; - else + } else { node->level =3D NIX_TXSCH_LVL_TL2; + node->child_dwrr_prio =3D OTX2_QOS_DEFAULT_PRIO; + } =20 WRITE_ONCE(node->qid, OTX2_QOS_QID_INNER); node->classid =3D OTX2_QOS_ROOT_CLASSID; @@ -444,6 +469,10 @@ static int otx2_qos_alloc_txschq_node(struct otx2_nic = *pfvf, txschq_node->rate =3D 0; txschq_node->ceil =3D 0; txschq_node->prio =3D 0; + txschq_node->quantum =3D 0; + txschq_node->is_static =3D true; + txschq_node->child_dwrr_prio =3D OTX2_QOS_DEFAULT_PRIO; + txschq_node->txschq_idx =3D OTX2_QOS_INVALID_TXSCHQ_IDX; =20 mutex_lock(&pfvf->qos.qos_lock); list_add_tail(&txschq_node->list, &node->child_schq_list); @@ -469,7 +498,7 @@ static struct otx2_qos_node * otx2_qos_sw_create_leaf_node(struct otx2_nic *pfvf, struct otx2_qos_node *parent, u16 classid, u32 prio, u64 rate, u64 ceil, - u16 qid) + u32 quantum, u16 qid, bool static_cfg) { struct otx2_qos_node *node; int err; @@ -486,7 +515,10 @@ otx2_qos_sw_create_leaf_node(struct otx2_nic *pfvf, node->rate =3D otx2_convert_rate(rate); node->ceil =3D otx2_convert_rate(ceil); node->prio =3D prio; - node->is_static =3D true; + node->quantum =3D quantum; + node->is_static =3D static_cfg; + node->child_dwrr_prio =3D OTX2_QOS_DEFAULT_PRIO; + node->txschq_idx =3D OTX2_QOS_INVALID_TXSCHQ_IDX; =20 __set_bit(qid, pfvf->qos.qos_sq_bmap); =20 @@ -633,6 +665,7 @@ static int otx2_qos_txschq_alloc(struct otx2_nic *pfvf, } =20 pfvf->qos.link_cfg_lvl =3D rsp->link_cfg_lvl; + pfvf->hw.txschq_aggr_lvl_rr_prio =3D rsp->aggr_lvl_rr_prio; =20 out: mutex_unlock(&mbox->lock); @@ -1006,6 +1039,13 @@ static int otx2_qos_root_add(struct otx2_nic *pfvf, = u16 htb_maj_id, u16 htb_defc goto free_root_node; } =20 + /* Update TL1 RR PRIO */ + if (root->level =3D=3D NIX_TXSCH_LVL_TL1) { + root->child_dwrr_prio =3D pfvf->hw.txschq_aggr_lvl_rr_prio; + netdev_dbg(pfvf->netdev, + "TL1 DWRR Priority %d\n", root->child_dwrr_prio); + } + if (!(pfvf->netdev->flags & IFF_UP) || root->level =3D=3D NIX_TXSCH_LVL_TL1) { root->schq =3D new_cfg->schq_list[root->level][0]; @@ -1052,37 +1092,126 @@ static int otx2_qos_root_destroy(struct otx2_nic *= pfvf) return 0; } =20 +static int otx2_qos_validate_quantum(struct otx2_nic *pfvf, u32 quantum) +{ + u32 rr_weight =3D otx2_qos_quantum_to_dwrr_weight(pfvf, quantum); + int err =3D 0; + + /* Max Round robin weight supported by octeontx2 and CN10K + * is different. Validate accordingly + */ + if (is_dev_otx2(pfvf->pdev)) + err =3D (rr_weight > OTX2_MAX_RR_QUANTUM) ? -EINVAL : 0; + else if (rr_weight > CN10K_MAX_RR_WEIGHT) + err =3D -EINVAL; + + return err; +} + +static int otx2_qos_validate_dwrr_cfg(struct otx2_qos_node *parent, + struct netlink_ext_ack *extack, + struct otx2_nic *pfvf, + u64 prio, u64 quantum) +{ + int err; + + err =3D otx2_qos_validate_quantum(pfvf, quantum); + if (err) { + NL_SET_ERR_MSG_MOD(extack, "Unsupported quantum value"); + return err; + } + + if (parent->child_dwrr_prio =3D=3D OTX2_QOS_DEFAULT_PRIO) { + parent->child_dwrr_prio =3D prio; + } else if (prio !=3D parent->child_dwrr_prio) { + NL_SET_ERR_MSG_MOD(extack, "Only one DWRR group is allowed"); + return -EOPNOTSUPP; + } + + return 0; +} + static int otx2_qos_validate_configuration(struct otx2_qos_node *parent, struct netlink_ext_ack *extack, struct otx2_nic *pfvf, - u64 prio) + u64 prio, bool static_cfg) { - if (test_bit(prio, parent->prio_bmap)) { - NL_SET_ERR_MSG_MOD(extack, - "Static priority child with same priority exists"); + if (prio =3D=3D parent->child_dwrr_prio && static_cfg) { + NL_SET_ERR_MSG_MOD(extack, "DWRR child group with same priority exists"); return -EEXIST; } =20 - if (prio =3D=3D TXSCH_TL1_DFLT_RR_PRIO) { + if (static_cfg && test_bit(prio, parent->prio_bmap)) { NL_SET_ERR_MSG_MOD(extack, - "Priority is reserved for Round Robin"); - return -EINVAL; + "Static priority child with same priority exists"); + return -EEXIST; } =20 return 0; } =20 +static void otx2_reset_dwrr_prio(struct otx2_qos_node *parent, u64 prio) +{ + /* For PF, root node dwrr priority is static */ + if (parent->level =3D=3D NIX_TXSCH_LVL_TL1) + return; + + if (parent->child_dwrr_prio !=3D OTX2_QOS_DEFAULT_PRIO) { + parent->child_dwrr_prio =3D OTX2_QOS_DEFAULT_PRIO; + clear_bit(prio, parent->prio_bmap); + } +} + +static bool is_qos_node_dwrr(struct otx2_qos_node *parent, + struct otx2_nic *pfvf, + u64 prio) +{ + struct otx2_qos_node *node; + bool ret =3D false; + + if (parent->child_dwrr_prio =3D=3D prio) + return true; + + mutex_lock(&pfvf->qos.qos_lock); + list_for_each_entry(node, &parent->child_list, list) { + if (prio =3D=3D node->prio) { + if (parent->child_dwrr_prio !=3D OTX2_QOS_DEFAULT_PRIO && + parent->child_dwrr_prio !=3D prio) + continue; + + if (otx2_qos_validate_quantum(pfvf, node->quantum)) { + netdev_err(pfvf->netdev, + "Unsupported quantum value for existing classid=3D0x%x quantum=3D%= d prio=3D%d", + node->classid, node->quantum, + node->prio); + break; + } + /* mark old node as dwrr */ + node->is_static =3D false; + parent->child_dwrr_cnt++; + parent->child_static_cnt--; + ret =3D true; + break; + } + } + mutex_unlock(&pfvf->qos.qos_lock); + + return ret; +} + static int otx2_qos_leaf_alloc_queue(struct otx2_nic *pfvf, u16 classid, u32 parent_classid, u64 rate, u64 ceil, - u64 prio, struct netlink_ext_ack *extack) + u64 prio, u32 quantum, + struct netlink_ext_ack *extack) { struct otx2_qos_cfg *old_cfg, *new_cfg; struct otx2_qos_node *node, *parent; int qid, ret, err; + bool static_cfg; =20 netdev_dbg(pfvf->netdev, - "TC_HTB_LEAF_ALLOC_QUEUE: classid=3D0x%x parent_classid=3D0x%x rate= =3D%lld ceil=3D%lld prio=3D%lld\n", - classid, parent_classid, rate, ceil, prio); + "TC_HTB_LEAF_ALLOC_QUEUE: classid=3D0x%x parent_classid=3D0x%x rate= =3D%lld ceil=3D%lld prio=3D%lld quantum=3D%d\n", + classid, parent_classid, rate, ceil, prio, quantum); =20 if (prio > OTX2_QOS_MAX_PRIO) { NL_SET_ERR_MSG_MOD(extack, "Valid priority range 0 to 7"); @@ -1090,6 +1219,12 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_nic= *pfvf, u16 classid, goto out; } =20 + if (!quantum || quantum > INT_MAX) { + NL_SET_ERR_MSG_MOD(extack, "Invalid quantum, range 1 - 2147483647 bytes"= ); + ret =3D -EOPNOTSUPP; + goto out; + } + /* get parent node */ parent =3D otx2_sw_node_find(pfvf, parent_classid); if (!parent) { @@ -1103,11 +1238,24 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_ni= c *pfvf, u16 classid, goto out; } =20 - ret =3D otx2_qos_validate_configuration(parent, extack, pfvf, prio); + static_cfg =3D !is_qos_node_dwrr(parent, pfvf, prio); + ret =3D otx2_qos_validate_configuration(parent, extack, pfvf, prio, + static_cfg); if (ret) goto out; =20 - parent->child_static_cnt++; + if (!static_cfg) { + ret =3D otx2_qos_validate_dwrr_cfg(parent, extack, pfvf, prio, + quantum); + if (ret) + goto out; + } + + if (static_cfg) + parent->child_static_cnt++; + else + parent->child_dwrr_cnt++; + set_bit(prio, parent->prio_bmap); =20 /* read current txschq configuration */ @@ -1132,7 +1280,7 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_nic = *pfvf, u16 classid, =20 /* allocate and initialize a new child node */ node =3D otx2_qos_sw_create_leaf_node(pfvf, parent, classid, prio, rate, - ceil, qid); + ceil, quantum, qid, static_cfg); if (IS_ERR(node)) { NL_SET_ERR_MSG_MOD(extack, "Unable to allocate leaf node"); ret =3D PTR_ERR(node); @@ -1180,7 +1328,11 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_nic= *pfvf, u16 classid, free_old_cfg: kfree(old_cfg); reset_prio: - parent->child_static_cnt--; + if (static_cfg) + parent->child_static_cnt--; + else + parent->child_dwrr_cnt--; + clear_bit(prio, parent->prio_bmap); out: return ret; @@ -1188,10 +1340,11 @@ static int otx2_qos_leaf_alloc_queue(struct otx2_ni= c *pfvf, u16 classid, =20 static int otx2_qos_leaf_to_inner(struct otx2_nic *pfvf, u16 classid, u16 child_classid, u64 rate, u64 ceil, u64 prio, - struct netlink_ext_ack *extack) + u32 quantum, struct netlink_ext_ack *extack) { struct otx2_qos_cfg *old_cfg, *new_cfg; struct otx2_qos_node *node, *child; + bool static_cfg; int ret, err; u16 qid; =20 @@ -1205,6 +1358,12 @@ static int otx2_qos_leaf_to_inner(struct otx2_nic *p= fvf, u16 classid, goto out; } =20 + if (!quantum || quantum > INT_MAX) { + NL_SET_ERR_MSG_MOD(extack, "Invalid quantum, range 1 - 2147483647 bytes"= ); + ret =3D -EOPNOTSUPP; + goto out; + } + /* find node related to classid */ node =3D otx2_sw_node_find(pfvf, classid); if (!node) { @@ -1219,7 +1378,19 @@ static int otx2_qos_leaf_to_inner(struct otx2_nic *p= fvf, u16 classid, goto out; } =20 - node->child_static_cnt++; + static_cfg =3D !is_qos_node_dwrr(node, pfvf, prio); + if (!static_cfg) { + ret =3D otx2_qos_validate_dwrr_cfg(node, extack, pfvf, prio, + quantum); + if (ret) + goto out; + } + + if (static_cfg) + node->child_static_cnt++; + else + node->child_dwrr_cnt++; + set_bit(prio, node->prio_bmap); =20 /* store the qid to assign to leaf node */ @@ -1242,7 +1413,8 @@ static int otx2_qos_leaf_to_inner(struct otx2_nic *pf= vf, u16 classid, =20 /* allocate and initialize a new child node */ child =3D otx2_qos_sw_create_leaf_node(pfvf, node, child_classid, - prio, rate, ceil, qid); + prio, rate, ceil, quantum, + qid, static_cfg); if (IS_ERR(child)) { NL_SET_ERR_MSG_MOD(extack, "Unable to allocate leaf node"); ret =3D PTR_ERR(child); @@ -1293,7 +1465,10 @@ static int otx2_qos_leaf_to_inner(struct otx2_nic *p= fvf, u16 classid, free_old_cfg: kfree(old_cfg); reset_prio: - node->child_static_cnt--; + if (static_cfg) + node->child_static_cnt--; + else + node->child_dwrr_cnt--; clear_bit(prio, node->prio_bmap); out: return ret; @@ -1303,6 +1478,7 @@ static int otx2_qos_leaf_del(struct otx2_nic *pfvf, u= 16 *classid, struct netlink_ext_ack *extack) { struct otx2_qos_node *node, *parent; + int dwrr_del_node =3D false; u64 prio; u16 qid; =20 @@ -1318,17 +1494,28 @@ static int otx2_qos_leaf_del(struct otx2_nic *pfvf,= u16 *classid, prio =3D node->prio; qid =3D node->qid; =20 + if (!node->is_static) + dwrr_del_node =3D true; + otx2_qos_disable_sq(pfvf, node->qid); =20 otx2_qos_destroy_node(pfvf, node); pfvf->qos.qid_to_sqmap[qid] =3D OTX2_QOS_INVALID_SQ; =20 - parent->child_static_cnt--; + if (dwrr_del_node) { + parent->child_dwrr_cnt--; + } else { + parent->child_static_cnt--; + clear_bit(prio, parent->prio_bmap); + } + + /* Reset DWRR priority if all dwrr nodes are deleted */ + if (!parent->child_dwrr_cnt) + otx2_reset_dwrr_prio(parent, prio); + if (!parent->child_static_cnt) parent->max_static_prio =3D 0; =20 - clear_bit(prio, parent->prio_bmap); - return 0; } =20 @@ -1337,6 +1524,7 @@ static int otx2_qos_leaf_del_last(struct otx2_nic *pf= vf, u16 classid, bool force { struct otx2_qos_node *node, *parent; struct otx2_qos_cfg *new_cfg; + int dwrr_del_node =3D false; u64 prio; int err; u16 qid; @@ -1361,16 +1549,27 @@ static int otx2_qos_leaf_del_last(struct otx2_nic *= pfvf, u16 classid, bool force return -ENOENT; } =20 + if (!node->is_static) + dwrr_del_node =3D true; + /* destroy the leaf node */ otx2_qos_destroy_node(pfvf, node); pfvf->qos.qid_to_sqmap[qid] =3D OTX2_QOS_INVALID_SQ; =20 - parent->child_static_cnt--; + if (dwrr_del_node) { + parent->child_dwrr_cnt--; + } else { + parent->child_static_cnt--; + clear_bit(prio, parent->prio_bmap); + } + + /* Reset DWRR priority if all dwrr nodes are deleted */ + if (!parent->child_dwrr_cnt) + otx2_reset_dwrr_prio(parent, prio); + if (!parent->child_static_cnt) parent->max_static_prio =3D 0; =20 - clear_bit(prio, parent->prio_bmap); - /* create downstream txschq entries to parent */ err =3D otx2_qos_alloc_txschq_node(pfvf, parent); if (err) { @@ -1422,10 +1621,12 @@ void otx2_qos_config_txschq(struct otx2_nic *pfvf) if (!root) return; =20 - err =3D otx2_qos_txschq_config(pfvf, root); - if (err) { - netdev_err(pfvf->netdev, "Error update txschq configuration\n"); - goto root_destroy; + if (root->level !=3D NIX_TXSCH_LVL_TL1) { + err =3D otx2_qos_txschq_config(pfvf, root); + if (err) { + netdev_err(pfvf->netdev, "Error update txschq configuration\n"); + goto root_destroy; + } } =20 err =3D otx2_qos_txschq_push_cfg_tl(pfvf, root, NULL); @@ -1458,7 +1659,8 @@ int otx2_setup_tc_htb(struct net_device *ndev, struct= tc_htb_qopt_offload *htb) res =3D otx2_qos_leaf_alloc_queue(pfvf, htb->classid, htb->parent_classid, htb->rate, htb->ceil, - htb->prio, htb->extack); + htb->prio, htb->quantum, + htb->extack); if (res < 0) return res; htb->qid =3D res; @@ -1467,7 +1669,7 @@ int otx2_setup_tc_htb(struct net_device *ndev, struct= tc_htb_qopt_offload *htb) return otx2_qos_leaf_to_inner(pfvf, htb->parent_classid, htb->classid, htb->rate, htb->ceil, htb->prio, - htb->extack); + htb->quantum, htb->extack); case TC_HTB_LEAF_DEL: return otx2_qos_leaf_del(pfvf, &htb->classid, htb->extack); case TC_HTB_LEAF_DEL_LAST: diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h b/drivers/net= /ethernet/marvell/octeontx2/nic/qos.h index faa7c24675d1..221bd0438f60 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h @@ -60,12 +60,15 @@ struct otx2_qos_node { u64 ceil; u32 classid; u32 prio; - u16 schq; /* hw txschq */ + u32 quantum; + /* hw txschq */ + u16 schq; u16 qid; u16 prio_anchor; u16 max_static_prio; u16 child_dwrr_cnt; u16 child_static_cnt; + u16 child_dwrr_prio; u16 txschq_idx; /* txschq allocation index */ u8 level; bool is_static; --=20 2.17.1 From nobody Sun Feb 8 09:11:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A548EB64DC for ; Mon, 17 Jul 2023 09:34:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbjGQJei (ORCPT ); Mon, 17 Jul 2023 05:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230439AbjGQJeR (ORCPT ); Mon, 17 Jul 2023 05:34:17 -0400 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C47E1725; Mon, 17 Jul 2023 02:34:04 -0700 (PDT) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36H5TrO8020470; Mon, 17 Jul 2023 02:33:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=A6vb4AfiZvBPM3VMzeFbHqzbdNwya3XR1SiGD5k6Gnk=; b=UCxuh6ood5GryilNTUmftnSpyu2p3oR8PtnPRkXxw63/y5j/QxkxbxbD7fV07FSMJBcn QNP1xtj886of9YNAEw0RtfAWHa2n4lP2Eiw8cKTXcVkFLcZKOqdj9Bj9RrnOZoe0NrP+ OLViurmeYKDwYCDJz4lNmdO5KNF+m1wJ9w0wWQfc9+exZykA1diyngxtjBCuUujecMNp mvUPUbWzKfjT9QnQ9Gx5k5qFQ82N6LsxakE5m92LMm2c2xmA688jZW2eIRb+DkT6w7Xa BAJD6Un9isVu7+c0F8g4YNzm+J95bsIW2OZiZHiGeT4eFeVAU8sjvqwN+9c9D2TktgVB mw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3rvyhx0p41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 02:33:53 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 17 Jul 2023 02:33:51 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Mon, 17 Jul 2023 02:33:51 -0700 Received: from hyd1soter3.marvell.com (unknown [10.29.37.134]) by maili.marvell.com (Postfix) with ESMTP id 87F5F3F70A4; Mon, 17 Jul 2023 02:33:45 -0700 (PDT) From: Hariprasad Kelam To: , CC: , , , , , , , , , , , , , , , , , , Subject: [net-next Patch v3 4/4] docs: octeontx2: extend documentation for Round Robin scheduling Date: Mon, 17 Jul 2023 15:03:19 +0530 Message-ID: <20230717093319.26618-5-hkelam@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230717093319.26618-1-hkelam@marvell.com> References: <20230717093319.26618-1-hkelam@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: zmcuVvw3xrV44UQ9PWInUeQ82PT9qnUP X-Proofpoint-ORIG-GUID: zmcuVvw3xrV44UQ9PWInUeQ82PT9qnUP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_07,2023-07-13_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add example tc-htb commands for Round robin scheduling Signed-off-by: Hariprasad Kelam --- .../device_drivers/ethernet/marvell/octeontx2.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/networking/device_drivers/ethernet/marvell/octeo= ntx2.rst b/Documentation/networking/device_drivers/ethernet/marvell/octeont= x2.rst index bfd233cfac35..3523e101cb53 100644 --- a/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst +++ b/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst @@ -332,3 +332,11 @@ Setup HTB offload # tc class add dev parent 1: classid 1:1 htb rate 10Gb= it prio 1 =20 # tc class add dev parent 1: classid 1:2 htb rate 10Gb= it prio 7 + +4. Create tc classes with same priorities and different quantum:: + + # tc class add dev parent 1: classid 1:1 htb rate 10Gb= it prio 2 quantum 409600 + + # tc class add dev parent 1: classid 1:2 htb rate 10Gb= it prio 2 quantum 188416 + + # tc class add dev parent 1: classid 1:2 htb rate 10Gb= it prio 2 quantum 32768 --=20 2.17.1