From nobody Mon Feb 9 19:30:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5321EC001DF for ; Thu, 13 Jul 2023 04:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233839AbjGMEV1 (ORCPT ); Thu, 13 Jul 2023 00:21:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233813AbjGMEVJ (ORCPT ); Thu, 13 Jul 2023 00:21:09 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 653512683 for ; Wed, 12 Jul 2023 21:21:06 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3a425ef874dso297862b6e.0 for ; Wed, 12 Jul 2023 21:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689222065; x=1691814065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jcE2YmIW31bFO7IyE1TbOouyqUx4815Ufga9qggKlmE=; b=mYhOCoF5+AgtodxdPh9hQADQfzcGGFdPKxTugVcu2Qs0e1yVg+0UkvCcRf/X3w/74s Kyz6ifXK6zTs2BFM00E8ADWIYlLRhhPSNmHbMUUZlBj8VJNziwCjHk5q1W5JoGbozIkM qI8cO56rtKm63AxeFVfIB07C8I5KBI7+H5+WeFGDdYzbEUHEYPgAoPksrpjWn3Ox9zJz BMPH5pv3QTN4UVgD9QNi87H5RnXLR/nsxOoAuPs2SRz6Ey0ejYmkLYeUBccuiFTR0Oqh q7//HZplNbzxfarT1/+PAPdpS1Cq6urRz8/Ed7OiPdOVBDo5/1Ub5DlQn/PxPVvuBZ4M +pKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689222065; x=1691814065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jcE2YmIW31bFO7IyE1TbOouyqUx4815Ufga9qggKlmE=; b=HPJfEIsoD4pf9fW+JwjfBNB5tzd/b0JqD8/MGXEEn5ozwNcb9fEKasdaNyogN58CZh 45qOqWCGjsvvbN92+o/79KwNLYrtPfaCGyLwdKy+IUYP2V7MSq9N1Fmn3jcKYVXMVKSD 9Yzj1k60MnAAAQ+TafM/6AAT51+XY9mRdgypfU0U5CtiyJOJMJ7URbSUvWDtI9M+yIlI /YwHhageQnP6IX4nEwm7atGz7XeTose3LF/EPWfgt3Tanuj6wp6UWfgv4R9CwMmDppF+ +eMyh4EPkdXT4Xt6NZ4fps5w9eg674VhvOA/gNTIXq3zlTASVLO9YlhQ83RFcXET7R+h D3sQ== X-Gm-Message-State: ABy/qLYubrYZ9r8l7nLeBLBBe8+E/rjYN0OJoQgYnFjALpId1P2kQsBc S1qgs0c7IKAcHuuqUfqDm/4= X-Google-Smtp-Source: APBJJlHn+GjEfwkeFf3et/qnGrOvXvkqgNMp79oM2A97NPAz4SPID9PPqYp6PTsedEbPVJXbuLD/Bg== X-Received: by 2002:a05:6808:1286:b0:3a3:baf8:5b8a with SMTP id a6-20020a056808128600b003a3baf85b8amr908456oiw.13.1689222065353; Wed, 12 Jul 2023 21:21:05 -0700 (PDT) Received: from fedora.. ([1.245.179.104]) by smtp.gmail.com with ESMTPSA id u18-20020aa78392000000b006827c26f147sm4346601pfm.138.2023.07.12.21.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 21:21:04 -0700 (PDT) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Minchan Kim , Sergey Senozhatsky Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Mike Rapoport , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [RFC PATCH v2 04/21] mm/zsmalloc: add alternatives of frequently used helper functions Date: Thu, 13 Jul 2023 13:20:19 +0900 Message-ID: <20230713042037.980211-5-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713042037.980211-1-42.hyeyoo@gmail.com> References: <20230713042037.980211-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" get_first_page(), get_next_page(), is_first_page() are frequently used throughout zsmalloc code. As replacing them all at once would be hard to review, add alternative helpers and gradually replace its users to use new functions. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/zsmalloc.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 8f7d9b79d849..f44a2d8a36b5 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -498,6 +498,11 @@ static __maybe_unused int is_first_page(struct page *p= age) return PagePrivate(page); } =20 +static __maybe_unused int is_first_zsdesc(struct zsdesc *zsdesc) +{ + return PagePrivate(zsdesc_page(zsdesc)); +} + /* Protected by pool->lock */ static inline int get_zspage_inuse(struct zspage *zspage) { @@ -510,7 +515,7 @@ static inline void mod_zspage_inuse(struct zspage *zspa= ge, int val) zspage->inuse +=3D val; } =20 -static inline struct page *get_first_page(struct zspage *zspage) +static __maybe_unused inline struct page *get_first_page(struct zspage *zs= page) { struct page *first_page =3D zsdesc_page(zspage->first_zsdesc); =20 @@ -518,6 +523,14 @@ static inline struct page *get_first_page(struct zspag= e *zspage) return first_page; } =20 +static __maybe_unused struct zsdesc *get_first_zsdesc(struct zspage *zspag= e) +{ + struct zsdesc *first_zsdesc =3D zspage->first_zsdesc; + + VM_BUG_ON_PAGE(!is_first_zsdesc(first_zsdesc), zsdesc_page(first_zsdesc)); + return first_zsdesc; +} + static inline unsigned int get_first_obj_offset(struct page *page) { return page->page_type; @@ -806,7 +819,7 @@ static struct zspage *get_zspage(struct page *page) return zspage; } =20 -static struct page *get_next_page(struct page *page) +static __maybe_unused struct page *get_next_page(struct page *page) { struct zspage *zspage =3D get_zspage(page); =20 @@ -816,6 +829,16 @@ static struct page *get_next_page(struct page *page) return (struct page *)page->index; } =20 +static __maybe_unused struct zsdesc *get_next_zsdesc(struct zsdesc *zsdesc) +{ + struct zspage *zspage =3D get_zspage(zsdesc_page(zsdesc)); + + if (unlikely(ZsHugePage(zspage))) + return NULL; + + return zsdesc->next; +} + /** * obj_to_location - get (, ) from encoded object value * @obj: the encoded object value --=20 2.41.0