From nobody Mon Feb 9 15:45:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5ADEB64D9 for ; Wed, 12 Jul 2023 11:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232102AbjGLLig (ORCPT ); Wed, 12 Jul 2023 07:38:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231782AbjGLLia (ORCPT ); Wed, 12 Jul 2023 07:38:30 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B163F1FF9 for ; Wed, 12 Jul 2023 04:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Lc4sa5FGc2Zv9bQCMcvCzN5cn0oZy93aSUCyZIixchQ=; b=deDZfe L+hfRpQ10A/KrZQcnU9x20j9gg9dZhwrbPZIAvEM7abQq38875+JoRulHgVP6dd7 kxJchhDFJFIzHNRm2AlTkJ0RCBAkAjmDUOokXWR2F5kFeHLAdBr3CZA62XyL526u dWRQ+Jz3D4UTDIvv5N68Ww2stMmEV0+OTa8LnFBwADBQ7dZ9RaPbbgGYhvY4XLU3 d2Kadb1gr5dJkUumElSHhlUPdSyM1Voia3jMYJkaqBBhhToKmUqwabzFZw8SEezo HfckxB7OSX1Y93HIlZL8P87p7VN1Rz5kLCJjk0/4G4Q1EurPMjQ6qc8yotZTTYYs EhPSTB9nY307YYpw== Received: (qmail 1596861 invoked from network); 12 Jul 2023 13:37:45 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jul 2023 13:37:45 +0200 X-UD-Smtp-Session: l3s3148p1@Ubf3pEgAXqUujnvL From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang , Johan Hovold , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] gnss: ubx: add support for the reset gpio Date: Wed, 12 Jul 2023 13:37:31 +0200 Message-Id: <20230712113731.3306-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> References: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Tested with a Renesas KingFisher board. Because my GNSS device is hooked up via UART and I2C simultaneously, I could verify functionality by opening/closing the GNSS device using UART and see if the corresponding I2C device was visible on the bus. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index 9b76b101ba5e..cb0612100644 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -18,6 +19,7 @@ =20 struct ubx_data { struct regulator *vcc; + struct gpio_desc *reset_gpio; }; =20 static int ubx_set_active(struct gnss_serial *gserial) @@ -29,6 +31,8 @@ static int ubx_set_active(struct gnss_serial *gserial) if (ret) return ret; =20 + gpiod_set_value_cansleep(data->reset_gpio, 0); + return 0; } =20 @@ -41,6 +45,8 @@ static int ubx_set_standby(struct gnss_serial *gserial) if (ret) return ret; =20 + gpiod_set_value_cansleep(data->reset_gpio, 1); + return 0; } =20 @@ -90,6 +96,13 @@ static int ubx_probe(struct serdev_device *serdev) if (ret < 0 && ret !=3D -ENODEV) goto err_free_gserial; =20 + /* Start with reset asserted (GPIO must be active low!) */ + data->reset_gpio =3D devm_gpiod_get_optional(&serdev->dev, "reset", GPIOD= _OUT_HIGH); + if (IS_ERR(data->reset_gpio)) { + ret =3D PTR_ERR(data->reset_gpio); + goto err_free_gserial; + } + ret =3D gnss_serial_register(gserial); if (ret) goto err_free_gserial; --=20 2.30.2