From nobody Sat Feb 7 08:55:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 907FFC001DD for ; Wed, 12 Jul 2023 11:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjGLLib (ORCPT ); Wed, 12 Jul 2023 07:38:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbjGLLi3 (ORCPT ); Wed, 12 Jul 2023 07:38:29 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB0141FF5 for ; Wed, 12 Jul 2023 04:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=IaSSkUShHNsHf6Hcd7JI1DA9Dk1NQz4OjpXmmsS2XZs=; b=kjseum Cm5xuq2vtQdu7bornhxj0aQLSbuFsmfDHBzjhV/woyt0WBkCvugSYZtRFw8IgTgx 5hpD29dAeiAGGOX0NpRYC1gOMk4nPcfK/121tn89n7kOVluD+5BZOGwKblTqxBQs AKq2MDpEg145H1bKyhrUnyIFxu41BbmhvollbBh91eTmJBnZLCDH8Bw2YGKy8xKe fjmMQc0hdLrNprQQuVVJIm3N1uDfAWtLPP6n8jlH73VrBMf9gYhety5LpaKXq7s9 IbLFOoeZJaxOMWjF0+rOYwINANyP7uxZVQKZsP+uIBne9wj06lPDY/qycaMnnl/w oEDcA9mRcBkY5M2g== Received: (qmail 1596777 invoked from network); 12 Jul 2023 13:37:44 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jul 2023 13:37:44 +0200 X-UD-Smtp-Session: l3s3148p1@AgjkpEgATqUujnvL From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang , Johan Hovold , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] gnss: ubx: use new helper to remove open coded regulator handling Date: Wed, 12 Jul 2023 13:37:29 +0200 Message-Id: <20230712113731.3306-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> References: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" v_bckp shall always be enabled as long as the device exists. We now have a regulator helper for that, use it. Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven --- drivers/gnss/ubx.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c951be202ca2..9b76b101ba5e 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -17,7 +17,6 @@ #include "serial.h" =20 struct ubx_data { - struct regulator *v_bckp; struct regulator *vcc; }; =20 @@ -87,30 +86,16 @@ static int ubx_probe(struct serdev_device *serdev) goto err_free_gserial; } =20 - data->v_bckp =3D devm_regulator_get_optional(&serdev->dev, "v-bckp"); - if (IS_ERR(data->v_bckp)) { - ret =3D PTR_ERR(data->v_bckp); - if (ret =3D=3D -ENODEV) - data->v_bckp =3D NULL; - else - goto err_free_gserial; - } - - if (data->v_bckp) { - ret =3D regulator_enable(data->v_bckp); - if (ret) - goto err_free_gserial; - } + ret =3D devm_regulator_get_enable_optional(&serdev->dev, "v-bckp"); + if (ret < 0 && ret !=3D -ENODEV) + goto err_free_gserial; =20 ret =3D gnss_serial_register(gserial); if (ret) - goto err_disable_v_bckp; + goto err_free_gserial; =20 return 0; =20 -err_disable_v_bckp: - if (data->v_bckp) - regulator_disable(data->v_bckp); err_free_gserial: gnss_serial_free(gserial); =20 @@ -120,11 +105,8 @@ static int ubx_probe(struct serdev_device *serdev) static void ubx_remove(struct serdev_device *serdev) { struct gnss_serial *gserial =3D serdev_device_get_drvdata(serdev); - struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); =20 gnss_serial_deregister(gserial); - if (data->v_bckp) - regulator_disable(data->v_bckp); gnss_serial_free(gserial); } =20 --=20 2.30.2 From nobody Sat Feb 7 08:55:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDBCEB64D9 for ; Wed, 12 Jul 2023 11:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231767AbjGLLij (ORCPT ); Wed, 12 Jul 2023 07:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbjGLLi3 (ORCPT ); Wed, 12 Jul 2023 07:38:29 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D961994 for ; Wed, 12 Jul 2023 04:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=ilnQAzhkzQbHlzdI76gswcqDlW6Rxu0S5Cd2vxmIpbY=; b=F2UijB 020gDZg0aQdUbhqDiFJbrOXtXLrgwaqr+1aQ/phqgDQcveY9q5C/zH45ra9P9YWv 33HOfZJ8RGHw1dmaZMtXvEco5AzsWUg5bq50e6Y+eM6cJegEpahKp1+I42wR9zvC VIa/y3DSQlSAN0CM4jreD9mEch6wiEOsst2mKzv69KEgtBgv4uHG93eEzWMAaYMX 73cKJo5sR8n7PNVQ7iItn48f7lN7TmPsUP4D9HMoTRujyeVd7TnRQnOr89uXpwBS u19i3hq+Sq1jutTzC1l+iCc1FedqgVPmYW3K/f0asARqnJBoogvsgtX1dLjeObol E/BU/BfYFdZOFT5g== Received: (qmail 1596815 invoked from network); 12 Jul 2023 13:37:45 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jul 2023 13:37:45 +0200 X-UD-Smtp-Session: l3s3148p1@NN/tpEgAVqUujnvL From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang , Johan Hovold , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Date: Wed, 12 Jul 2023 13:37:30 +0200 Message-Id: <20230712113731.3306-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> References: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Needed to enable this chip on a Renesas KingFisher board. Description copied over from the Mediatek driver which already supports it. Signed-off-by: Wolfram Sang --- Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Do= cumentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml index 4835a280b3bf..8f6992b97ca6 100644 --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml @@ -41,6 +41,12 @@ properties: description: > Backup voltage regulator =20 + reset-gpios: + maxItems: 1 + description: > + An optional reset line, with names such as RESET or NRESET. + If the line is active low it should be flagged with GPIO_ACTIVE_LOW. + required: - compatible - vcc-supply @@ -54,5 +60,6 @@ examples: compatible =3D "u-blox,neo-8"; v-bckp-supply =3D <&gnss_v_bckp_reg>; vcc-supply =3D <&gnss_vcc_reg>; + reset-gpios =3D <&gpio 1 GPIO_ACTIVE_LOW>; }; }; --=20 2.30.2 From nobody Sat Feb 7 08:55:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5ADEB64D9 for ; Wed, 12 Jul 2023 11:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232102AbjGLLig (ORCPT ); Wed, 12 Jul 2023 07:38:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231782AbjGLLia (ORCPT ); Wed, 12 Jul 2023 07:38:30 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B163F1FF9 for ; Wed, 12 Jul 2023 04:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Lc4sa5FGc2Zv9bQCMcvCzN5cn0oZy93aSUCyZIixchQ=; b=deDZfe L+hfRpQ10A/KrZQcnU9x20j9gg9dZhwrbPZIAvEM7abQq38875+JoRulHgVP6dd7 kxJchhDFJFIzHNRm2AlTkJ0RCBAkAjmDUOokXWR2F5kFeHLAdBr3CZA62XyL526u dWRQ+Jz3D4UTDIvv5N68Ww2stMmEV0+OTa8LnFBwADBQ7dZ9RaPbbgGYhvY4XLU3 d2Kadb1gr5dJkUumElSHhlUPdSyM1Voia3jMYJkaqBBhhToKmUqwabzFZw8SEezo HfckxB7OSX1Y93HIlZL8P87p7VN1Rz5kLCJjk0/4G4Q1EurPMjQ6qc8yotZTTYYs EhPSTB9nY307YYpw== Received: (qmail 1596861 invoked from network); 12 Jul 2023 13:37:45 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jul 2023 13:37:45 +0200 X-UD-Smtp-Session: l3s3148p1@Ubf3pEgAXqUujnvL From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang , Johan Hovold , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] gnss: ubx: add support for the reset gpio Date: Wed, 12 Jul 2023 13:37:31 +0200 Message-Id: <20230712113731.3306-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> References: <20230712113731.3306-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Tested with a Renesas KingFisher board. Because my GNSS device is hooked up via UART and I2C simultaneously, I could verify functionality by opening/closing the GNSS device using UART and see if the corresponding I2C device was visible on the bus. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index 9b76b101ba5e..cb0612100644 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -18,6 +19,7 @@ =20 struct ubx_data { struct regulator *vcc; + struct gpio_desc *reset_gpio; }; =20 static int ubx_set_active(struct gnss_serial *gserial) @@ -29,6 +31,8 @@ static int ubx_set_active(struct gnss_serial *gserial) if (ret) return ret; =20 + gpiod_set_value_cansleep(data->reset_gpio, 0); + return 0; } =20 @@ -41,6 +45,8 @@ static int ubx_set_standby(struct gnss_serial *gserial) if (ret) return ret; =20 + gpiod_set_value_cansleep(data->reset_gpio, 1); + return 0; } =20 @@ -90,6 +96,13 @@ static int ubx_probe(struct serdev_device *serdev) if (ret < 0 && ret !=3D -ENODEV) goto err_free_gserial; =20 + /* Start with reset asserted (GPIO must be active low!) */ + data->reset_gpio =3D devm_gpiod_get_optional(&serdev->dev, "reset", GPIOD= _OUT_HIGH); + if (IS_ERR(data->reset_gpio)) { + ret =3D PTR_ERR(data->reset_gpio); + goto err_free_gserial; + } + ret =3D gnss_serial_register(gserial); if (ret) goto err_free_gserial; --=20 2.30.2