From nobody Wed Feb 11 00:55:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669E4C001DD for ; Tue, 11 Jul 2023 12:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231731AbjGKMUb (ORCPT ); Tue, 11 Jul 2023 08:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231857AbjGKMTx (ORCPT ); Tue, 11 Jul 2023 08:19:53 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A90271BEE for ; Tue, 11 Jul 2023 05:19:06 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b702319893so89294201fa.3 for ; Tue, 11 Jul 2023 05:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689077935; x=1691669935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GmM1SbjU7EsG3x868ftGBwF3Sx0onSUF7y0rst5GVmk=; b=plwZoSoPJbs8qjoxscUxgQbGiP+UHsQcjAV50k4jG19V2z2Wsvtort2aBJM7r4VJmY fv8SPk1i0duQrQ3BKnNVobCgfRgjedwELJGkh0vA57S7fMMhEGFTmcrGDaKo2/5Ry5ey +nxJsn1+re5r6HxsWq9ktFNl+PbZ/mUKDzbXOfbxDYabazC4Vsg3CApgqydyexzxHV4b RYpaTkY7efLvYAyB/V3NAP1jXqhvDT7QwxJ53D7h2he4dgHI6KYeAxkeB7bRVeBDZDkO brWQQYZCJcSYdQYXGSFl7sn1J6OrS8rDxbkO/4rEmOhDgK45neFWbETYHFDfe5c7eYHe AnUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689077935; x=1691669935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmM1SbjU7EsG3x868ftGBwF3Sx0onSUF7y0rst5GVmk=; b=E0N69jgt6Oeyd/fRPztBmnOkvJfRQ4j1rLie34AhYT+9zv0oG7hHesgZr/qidezm8W pkOa9kswFfaWGO+DWRuH1dpi+vY+/X+1790BMN4ljnERX+8eeGuR7RmIq4FXhljlKx73 oma//IOhIs+JIIG86/AWPIkyRYdZyHuDaLKPAAmTC0CDdKYRgTpIh9lo61HDwCanaxZR 1qQ/tXuMeP+pLTDNp+a5Cfqmw+lFS985PNJAFSpsq1WJx7Wbja/yVs2QNC0kBkM8IJIK eGU9PWB4LrlCRxY9Jc4cIqazJl7CDZoc+ZxGOIgGyfBohQDlRE7WasexNGie/UzWluXL C8Uw== X-Gm-Message-State: ABy/qLbPqtwZzqyfE/+e+UlMF9fwv4o8zJbo6BShukh8MzLp4tRCuIuT V5l+5kiPN7FJd6fahI3X0Pr8Wg== X-Google-Smtp-Source: APBJJlGh1bf6Dlfv7+5YmGoZEQ4uJLOFRiB2sN966EQGlCJm5PJge2ZAOxwnqk841iFClcvOwuTwDQ== X-Received: by 2002:a2e:8085:0:b0:2b6:e283:32cb with SMTP id i5-20020a2e8085000000b002b6e28332cbmr12705279ljg.23.1689077935036; Tue, 11 Jul 2023 05:18:55 -0700 (PDT) Received: from [192.168.1.101] (abyl96.neoplus.adsl.tpnet.pl. [83.9.31.96]) by smtp.gmail.com with ESMTPSA id d18-20020a2e96d2000000b002b708450951sm435563ljj.88.2023.07.11.05.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 05:18:54 -0700 (PDT) From: Konrad Dybcio Date: Tue, 11 Jul 2023 14:18:20 +0200 Subject: [PATCH 21/53] interconnect: qcom: sm6350: Retire DEFINE_QBCM MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230708-topic-rpmh_icc_rsc-v1-21-b223bd2ac8dd@linaro.org> References: <20230708-topic-rpmh_icc_rsc-v1-0-b223bd2ac8dd@linaro.org> In-Reply-To: <20230708-topic-rpmh_icc_rsc-v1-0-b223bd2ac8dd@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1689077904; l=8416; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=SrAfEu7z7LDi+swPnqPTMHcA8pMC5/hLxqI6ZqZhaf0=; b=7WlneqnlYUMwfgEWnegCIMJfixgMc1PsRYVSsNGX2DEtr9WcXugI3RsfzMQZKXEXxhT053I17 5WznrJl7egfC0ejss8NmYrjEn1JX6/Cc84u1ixD848BDyOfR/6GCl1m X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The struct definition macros are hard to read and comapre, expand them. Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/sm6350.c | 276 +++++++++++++++++++++++++++++++++= ---- 1 file changed, 251 insertions(+), 25 deletions(-) diff --git a/drivers/interconnect/qcom/sm6350.c b/drivers/interconnect/qcom= /sm6350.c index 7421eb4cd520..845d888f7634 100644 --- a/drivers/interconnect/qcom/sm6350.c +++ b/drivers/interconnect/qcom/sm6350.c @@ -1161,31 +1161,257 @@ static struct qcom_icc_node xs_sys_tcu_cfg =3D { .buswidth =3D 8, }; =20 -DEFINE_QBCM(bcm_acv, "ACV", false, &ebi); -DEFINE_QBCM(bcm_ce0, "CE0", false, &qxm_crypto); -DEFINE_QBCM(bcm_cn0, "CN0", true, &qnm_snoc, &xm_qdss_dap, &qhs_a1_noc_cfg= , &qhs_a2_noc_cfg, &qhs_ahb2phy0, &qhs_aoss, &qhs_boot_rom, &qhs_camera_cfg= , &qhs_camera_nrt_thrott_cfg, &qhs_camera_rt_throttle_cfg, &qhs_clk_ctl, &q= hs_cpr_cx, &qhs_cpr_mx, &qhs_crypto0_cfg, &qhs_dcc_cfg, &qhs_ddrss_cfg, &qh= s_display_cfg, &qhs_display_throttle_cfg, &qhs_glm, &qhs_gpuss_cfg, &qhs_im= em_cfg, &qhs_ipa, &qhs_mnoc_cfg, &qhs_mss_cfg, &qhs_npu_cfg, &qhs_pimem_cfg= , &qhs_prng, &qhs_qdss_cfg, &qhs_qm_cfg, &qhs_qm_mpu_cfg, &qhs_qup0, &qhs_q= up1, &qhs_security, &qhs_snoc_cfg, &qhs_tcsr, &qhs_ufs_mem_cfg, &qhs_usb3_0= , &qhs_venus_cfg, &qhs_venus_throttle_cfg, &qhs_vsense_ctrl_cfg, &srvc_cnoc= ); -DEFINE_QBCM(bcm_cn1, "CN1", false, &xm_emmc, &xm_sdc2, &qhs_ahb2phy2, &qhs= _emmc_cfg, &qhs_pdm, &qhs_sdc2); -DEFINE_QBCM(bcm_co0, "CO0", false, &qns_cdsp_gemnoc); -DEFINE_QBCM(bcm_co2, "CO2", false, &qnm_npu); -DEFINE_QBCM(bcm_co3, "CO3", false, &qxm_npu_dsp); -DEFINE_QBCM(bcm_mc0, "MC0", true, &ebi); -DEFINE_QBCM(bcm_mm0, "MM0", true, &qns_mem_noc_hf); -DEFINE_QBCM(bcm_mm1, "MM1", true, &qxm_camnoc_hf0_uncomp, &qxm_camnoc_icp_= uncomp, &qxm_camnoc_sf_uncomp, &qxm_camnoc_hf, &qxm_mdp0); -DEFINE_QBCM(bcm_mm2, "MM2", false, &qns_mem_noc_sf); -DEFINE_QBCM(bcm_mm3, "MM3", false, &qhm_mnoc_cfg, &qnm_video0, &qnm_video_= cvp, &qxm_camnoc_sf); -DEFINE_QBCM(bcm_qup0, "QUP0", false, &qup0_core_master, &qup1_core_master,= &qup0_core_slave, &qup1_core_slave); -DEFINE_QBCM(bcm_sh0, "SH0", true, &qns_llcc); -DEFINE_QBCM(bcm_sh2, "SH2", false, &acm_sys_tcu); -DEFINE_QBCM(bcm_sh3, "SH3", false, &qnm_cmpnoc); -DEFINE_QBCM(bcm_sh4, "SH4", false, &acm_apps); -DEFINE_QBCM(bcm_sn0, "SN0", true, &qns_gemnoc_sf); -DEFINE_QBCM(bcm_sn1, "SN1", false, &qxs_imem); -DEFINE_QBCM(bcm_sn2, "SN2", false, &qns_gemnoc_gc); -DEFINE_QBCM(bcm_sn3, "SN3", false, &qxs_pimem); -DEFINE_QBCM(bcm_sn4, "SN4", false, &xs_qdss_stm); -DEFINE_QBCM(bcm_sn5, "SN5", false, &qnm_aggre1_noc); -DEFINE_QBCM(bcm_sn6, "SN6", false, &qnm_aggre2_noc); -DEFINE_QBCM(bcm_sn10, "SN10", false, &qnm_gemnoc); +static struct qcom_icc_bcm bcm_acv =3D { + .name =3D "ACV", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &ebi }, +}; + +static struct qcom_icc_bcm bcm_ce0 =3D { + .name =3D "CE0", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qxm_crypto }, +}; + +static struct qcom_icc_bcm bcm_cn0 =3D { + .name =3D "CN0", + .keepalive =3D true, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 41, + .nodes =3D { &qnm_snoc, + &xm_qdss_dap, + &qhs_a1_noc_cfg, + &qhs_a2_noc_cfg, + &qhs_ahb2phy0, + &qhs_aoss, + &qhs_boot_rom, + &qhs_camera_cfg, + &qhs_camera_nrt_thrott_cfg, + &qhs_camera_rt_throttle_cfg, + &qhs_clk_ctl, + &qhs_cpr_cx, + &qhs_cpr_mx, + &qhs_crypto0_cfg, + &qhs_dcc_cfg, + &qhs_ddrss_cfg, + &qhs_display_cfg, + &qhs_display_throttle_cfg, + &qhs_glm, + &qhs_gpuss_cfg, + &qhs_imem_cfg, + &qhs_ipa, + &qhs_mnoc_cfg, + &qhs_mss_cfg, + &qhs_npu_cfg, + &qhs_pimem_cfg, + &qhs_prng, + &qhs_qdss_cfg, + &qhs_qm_cfg, + &qhs_qm_mpu_cfg, + &qhs_qup0, + &qhs_qup1, + &qhs_security, + &qhs_snoc_cfg, + &qhs_tcsr, + &qhs_ufs_mem_cfg, + &qhs_usb3_0, + &qhs_venus_cfg, + &qhs_venus_throttle_cfg, + &qhs_vsense_ctrl_cfg, + &srvc_cnoc + }, +}; + +static struct qcom_icc_bcm bcm_cn1 =3D { + .name =3D "CN1", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 6, + .nodes =3D { &xm_emmc, + &xm_sdc2, + &qhs_ahb2phy2, + &qhs_emmc_cfg, + &qhs_pdm, + &qhs_sdc2 + }, +}; + +static struct qcom_icc_bcm bcm_co0 =3D { + .name =3D "CO0", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qns_cdsp_gemnoc }, +}; + +static struct qcom_icc_bcm bcm_co2 =3D { + .name =3D "CO2", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qnm_npu }, +}; + +static struct qcom_icc_bcm bcm_co3 =3D { + .name =3D "CO3", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qxm_npu_dsp }, +}; + +static struct qcom_icc_bcm bcm_mc0 =3D { + .name =3D "MC0", + .keepalive =3D true, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &ebi }, +}; + +static struct qcom_icc_bcm bcm_mm0 =3D { + .name =3D "MM0", + .keepalive =3D true, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qns_mem_noc_hf }, +}; + +static struct qcom_icc_bcm bcm_mm1 =3D { + .name =3D "MM1", + .keepalive =3D true, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 5, + .nodes =3D { &qxm_camnoc_hf0_uncomp, + &qxm_camnoc_icp_uncomp, + &qxm_camnoc_sf_uncomp, + &qxm_camnoc_hf, + &qxm_mdp0 + }, +}; + +static struct qcom_icc_bcm bcm_mm2 =3D { + .name =3D "MM2", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qns_mem_noc_sf }, +}; + +static struct qcom_icc_bcm bcm_mm3 =3D { + .name =3D "MM3", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 4, + .nodes =3D { &qhm_mnoc_cfg, &qnm_video0, &qnm_video_cvp, &qxm_camnoc_sf }, +}; + +static struct qcom_icc_bcm bcm_qup0 =3D { + .name =3D "QUP0", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 4, + .nodes =3D { &qup0_core_master, &qup1_core_master, &qup0_core_slave, &qup= 1_core_slave }, +}; + +static struct qcom_icc_bcm bcm_sh0 =3D { + .name =3D "SH0", + .keepalive =3D true, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qns_llcc }, +}; + +static struct qcom_icc_bcm bcm_sh2 =3D { + .name =3D "SH2", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &acm_sys_tcu }, +}; + +static struct qcom_icc_bcm bcm_sh3 =3D { + .name =3D "SH3", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qnm_cmpnoc }, +}; + +static struct qcom_icc_bcm bcm_sh4 =3D { + .name =3D "SH4", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &acm_apps }, +}; + +static struct qcom_icc_bcm bcm_sn0 =3D { + .name =3D "SN0", + .keepalive =3D true, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qns_gemnoc_sf }, +}; + +static struct qcom_icc_bcm bcm_sn1 =3D { + .name =3D "SN1", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qxs_imem }, +}; + +static struct qcom_icc_bcm bcm_sn2 =3D { + .name =3D "SN2", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qns_gemnoc_gc }, +}; + +static struct qcom_icc_bcm bcm_sn3 =3D { + .name =3D "SN3", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qxs_pimem }, +}; + +static struct qcom_icc_bcm bcm_sn4 =3D { + .name =3D "SN4", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &xs_qdss_stm }, +}; + +static struct qcom_icc_bcm bcm_sn5 =3D { + .name =3D "SN5", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qnm_aggre1_noc }, +}; + +static struct qcom_icc_bcm bcm_sn6 =3D { + .name =3D "SN6", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qnm_aggre2_noc }, +}; + +static struct qcom_icc_bcm bcm_sn10 =3D { + .name =3D "SN10", + .keepalive =3D false, + .voter_idx =3D ICC_BCM_VOTER_APPS, + .num_nodes =3D 1, + .nodes =3D { &qnm_gemnoc }, +}; =20 static struct qcom_icc_bcm * const aggre1_noc_bcms[] =3D { &bcm_cn1, --=20 2.41.0