From nobody Fri Sep 20 16:50:06 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5D6EB64DD for ; Tue, 4 Jul 2023 11:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjGDL4z (ORCPT ); Tue, 4 Jul 2023 07:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbjGDL4t (ORCPT ); Tue, 4 Jul 2023 07:56:49 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A297810D7 for ; Tue, 4 Jul 2023 04:56:47 -0700 (PDT) X-UUID: d74e09ba1a6111ee9cb5633481061a41-20230704 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=kDmDXnjKdjFDPlrVeD7IKJ7Ywmn7ZI+Wx6K1yIaJQEA=; b=U0+UN2ctIVNOINxIiOMPfSIuBl9lpsKl3hpCqX2xCsIMfbTzI2JtgIzMmHlH32EW0guaNVhvSxsdT5RSbJvHG1jn7l1ZJJfUu+9sWpYab0HzshDV+rndfjcVLuu5HU4PwxMG17a7dLAManHQTMvKBTZ4Fd69VqImXhPHDAtSP5Q=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:7f2d32be-69d2-4369-b8b1-e91250455b05,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:100,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:95 X-CID-INFO: VERSION:1.1.27,REQID:7f2d32be-69d2-4369-b8b1-e91250455b05,IP:0,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:100,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTI ON:quarantine,TS:95 X-CID-META: VersionHash:01c9525,CLOUDID:14558d0d-26a8-467f-b838-f99719a9c083,B ulkID:230704195642DL3I3ZRD,BulkQuantity:1,Recheck:0,SF:28|17|19|48|38|29,T C:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_SNR,TF_CID_SPAM_SDM, TF_CID_SPAM_ASC X-UUID: d74e09ba1a6111ee9cb5633481061a41-20230704 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 853156001; Tue, 04 Jul 2023 19:56:42 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 4 Jul 2023 19:56:40 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 4 Jul 2023 19:56:40 +0800 From: Yong Wu To: Joerg Roedel , Matthias Brugger CC: Will Deacon , Robin Murphy , AngeloGioacchino Del Regno , Yong Wu , , , , Subject: [PATCH] iommu/mediatek: Remove a unnecessary checking for larbid Date: Tue, 4 Jul 2023 19:56:34 +0800 Message-ID: <20230704115634.7727-1-yong.wu@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix a coverity issue: >>assignment: Assigning: larbid =3D (fwspec->ids[0] >> 5) & 0x1fU. larbid =3D MTK_M4U_TO_LARB(fwspec->ids[0]); >>between: At condition larbid >=3D 32U, the value of larbid must be between >>0 and 31. >>dead_error_condition: The condition larbid >=3D 32U cannot be true. if (larbid >=3D MTK_LARB_NR_MAX) >>CID 11306470 (#1 of 1): Logically dead code (DEADCODE) >>dead_error_line: Execution cannot reach this statement: >>return ERR_PTR(-22L); return ERR_PTR(-EINVAL); The checking "if (larbid >=3D MTK_LARB_NR_MAX)" is unnecessary. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Robin Murphy --- Rebase on v6.4-rc1. --- drivers/iommu/mtk_iommu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index aecc7d154f28..67caa90b481b 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -838,9 +838,6 @@ static struct iommu_device *mtk_iommu_probe_device(stru= ct device *dev) * All the ports in each a device should be in the same larbs. */ larbid =3D MTK_M4U_TO_LARB(fwspec->ids[0]); - if (larbid >=3D MTK_LARB_NR_MAX) - return ERR_PTR(-EINVAL); - for (i =3D 1; i < fwspec->num_ids; i++) { larbidx =3D MTK_M4U_TO_LARB(fwspec->ids[i]); if (larbid !=3D larbidx) { --=20 2.25.1