From nobody Sun Feb 8 07:07:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4FDEB64D9 for ; Sun, 2 Jul 2023 19:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbjGBTQi (ORCPT ); Sun, 2 Jul 2023 15:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbjGBTQe (ORCPT ); Sun, 2 Jul 2023 15:16:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB049C2 for ; Sun, 2 Jul 2023 12:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688325346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JDcEAV6QwSsPTLZL87iLrwMThHt45oSghNV/E5+yNmU=; b=bt93jACT9sz4hZfiEOe+oBmltfKCjExU0UW9xoHTBEai2BP6/92jdlX8DKC1bksUUflJW0 UlN5uBffHJ4NpVlL3G4CfptRZwbiZ8KxuRBcKgmaL5MDnw6KX8O+IfszBOEVk7h7Wb4Kte CJd6YrspfUw2Iaf382mWXW0gjZpdMbE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-HmTHNCLPOImiiRU9P5r4iQ-1; Sun, 02 Jul 2023 15:15:44 -0400 X-MC-Unique: HmTHNCLPOImiiRU9P5r4iQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-313f2430134so1703983f8f.3 for ; Sun, 02 Jul 2023 12:15:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688325343; x=1690917343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JDcEAV6QwSsPTLZL87iLrwMThHt45oSghNV/E5+yNmU=; b=d+U8nbV1O9DZPSs2Zmpny0eQuVe6IhuP/nzynURg2h1xHHsQfEKeL+vAqXraqo55aL Uqdpm39LMG8rvuxiyMXwsRWfLRQtvJ56zZ/6kv0Hx8y7GiPYhVXaLTNraE0SrUE52EMw SNVqHfGZYayJTLdHVRouGHw8CVlD3KAWFytpsvq041SVkOJPR8L4jdwWJgiIlu3W0mSe 5RW9uJ1oBY1VWI0S84akQSDXKTdMnsJMiKwQwWWNsS5Y9izaZkdA/xWLAWM8AQHI9uEt de2B0keMDfigyeqooFGYi0+n9WmmfN9JWd0Z/CzO3YAF8cuqD3z3Sz8qokqsPvsaeb76 2MgQ== X-Gm-Message-State: ABy/qLa+m8avV4Hkfd6XBLkNQ9sOEDzxllsQLivVn3gZSNwSyh46bQKJ lZnBQ641unI3lYxbrz/mzPg8g7PUAqFMm2oAZVNLB781roelHm5+aIkCor8UD1asOQthy4oh1wu zPlWCQwElV5ovYhHloKAFCR3ABdkYTiMHZEJlZfM5cSsE7Et1+46lq5Sn+ejcfZqxNTy0oVFk0s cOeFfIxrY= X-Received: by 2002:adf:dd0a:0:b0:314:1a98:ebc0 with SMTP id a10-20020adfdd0a000000b003141a98ebc0mr6619312wrm.26.1688325343477; Sun, 02 Jul 2023 12:15:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEDpCbRzZteK5K4atZLapgedVl0F/kvFEX2HZm5FHmLp8U7TVJXppcUN0K6Sz/ypkNYMZhM6Q== X-Received: by 2002:adf:dd0a:0:b0:314:1a98:ebc0 with SMTP id a10-20020adfdd0a000000b003141a98ebc0mr6619298wrm.26.1688325343187; Sun, 02 Jul 2023 12:15:43 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm14144231wmk.48.2023.07.02.12.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 12:15:42 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Thomas Zimmermann , Arnd Bergmann , Javier Martinez Canillas , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org Subject: [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts Date: Sun, 2 Jul 2023 21:15:18 +0200 Message-ID: <20230702191529.768248-2-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702191529.768248-1-javierm@redhat.com> References: <20230702191529.768248-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The current text were not changed since the original Linux-2.6.12-rc2 git import. Let's improve it and make that more aligned with the DRM/KMS docs. Suggested-by: Geert Uytterhoeven Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/Kconfig | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index afb3b2f5f425..373f85e174c2 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -3,10 +3,11 @@ # Drm device configuration # # This driver provides support for the -# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +# Direct Rendering Infrastructure (DRI) that is composed of the Direct +# Rendering Manager (DRM) and Kernel Mode Settings (KMS) subsystems. # menuconfig DRM - tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" + tristate "Direct Rendering Manager (DRM) and Kernel Mode Settings (KMS)" depends on (AGP || AGP=3Dn) && !EMULATED_CMPXCHG && HAS_DMA select DRM_PANEL_ORIENTATION_QUIRKS select HDMI @@ -19,13 +20,16 @@ menuconfig DRM select VIDEO_CMDLINE select VIDEO_NOMODESET help - Kernel-level support for the Direct Rendering Infrastructure (DRI) - introduced in XFree86 4.0. If you say Y here, you need to select - the module that's right for your graphics card from the list below. - These modules provide support for synchronization, security, and - DMA transfers. Please see for more - details. You should also select and configure AGP - (/dev/agpgart) support if it is available for your platform. + Kernel-level support for the Direct Rendering Infrastructure (DRI), + that is composed of the Direct Rendering Manager (DRM) and Kernel + Mode Settings (KMS) subsystems. + + If you say Y here, you need to select the module that's right for + your graphics card from the list below. These modules provide support + for synchronization, security, and DMA transfers. + + Please see + for more details about the Linux DRM and KMS subsystems. =20 config DRM_MIPI_DBI tristate --=20 2.41.0 From nobody Sun Feb 8 07:07:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40BFEB64D9 for ; Sun, 2 Jul 2023 19:17:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjGBTRW (ORCPT ); Sun, 2 Jul 2023 15:17:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjGBTRS (ORCPT ); Sun, 2 Jul 2023 15:17:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8226E60 for ; Sun, 2 Jul 2023 12:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688325351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+OpQ8FhWL4vINUgdpBq2jtly/gGBeEwyQXrGSBuzmI=; b=I3Ogo4PyXiYi6OHNmOtkRmlzhEAKZaLJ7GjwOwE4/kcMvGqBVNKYmA3me5fQQH5Sl3Ke7o calEarX4RRrj0WE7JNO3Zuitrn4+CBSP3C2Av6KSwu8C7LlorOwIPd+glqhavFvf95/SdF V/JO4ZLRmBgxPNYZwlh7rxKWSieEK7A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-fKvKT9IbNhCcW-vNhGMt1w-1; Sun, 02 Jul 2023 15:15:49 -0400 X-MC-Unique: fKvKT9IbNhCcW-vNhGMt1w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fbcefecda0so9699465e9.1 for ; Sun, 02 Jul 2023 12:15:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688325348; x=1690917348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+OpQ8FhWL4vINUgdpBq2jtly/gGBeEwyQXrGSBuzmI=; b=eHY50czvUZlmYjMzyTfjKNNbpm1GOOx7lmouDsbqSI4GHNxBz2JuDdgCTDw5xdyav9 gkKbijRH0BllY8X/QRYTYxRfJqxbWgb9o9u4Q5kR/fEaqduXnP82eqpP1cJ/P6n4w/J/ JSihPvq2FkRzcw/MuxC6OkYV0cRZ/moaQWRnyEm+jEePQ9/zbT7WT3t56J8i+hu/bKKE ChMf6INmDo8wKVkygdagUDzlzgFjrQX4Ii87sbBPCe7TK0Hs+eV8QP7Ei9Y92b8mabYY QZVXPK9B7b0EvpJphNs9vHgdJavI+KFcqkKdfioYad8ZzMdBg3hRPxE1hX7kf4Uqg5J4 YAlw== X-Gm-Message-State: AC+VfDw+13/xrqbkTiPnc69744/9++8aqj6SCJxXpEgqQ8BLqwaC2HdX iXH8ErlkUVuGyvf53w9+yYtYynHmBckQkiqBB8Ff2ph6GxQxRicaa4JY+i1VRU57/tSPzMAseNq Q67f9s0Jez17Ofpag5o/FIKMv/ps5bOHNGT4Zu9RapGVey1YSCrYeeTZ6zGcUPkyxDiOBLzUCWF 3IdTCvpZI= X-Received: by 2002:a1c:ed19:0:b0:3fb:407e:9b30 with SMTP id l25-20020a1ced19000000b003fb407e9b30mr6973023wmh.13.1688325347872; Sun, 02 Jul 2023 12:15:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6TEDx7mZMSKS0zMb7cTutew+fp0z6fzjfQL6TR1HiUxmFFKyKRmLqu7ujS36y1E7Z5uUniDA== X-Received: by 2002:a1c:ed19:0:b0:3fb:407e:9b30 with SMTP id l25-20020a1ced19000000b003fb407e9b30mr6972988wmh.13.1688325347442; Sun, 02 Jul 2023 12:15:47 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm14144231wmk.48.2023.07.02.12.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 12:15:47 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Thomas Zimmermann , Arnd Bergmann , Javier Martinez Canillas , Andy Shevchenko , Borislav Petkov , Daniel Vetter , Dave Hansen , Greg Kroah-Hartman , "H. Peter Anvin" , Helge Deller , Ingo Molnar , Randy Dunlap , Robert Jarzmik , Sam Ravnborg , Thomas Gleixner , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, x86@kernel.org Subject: [PATCH v3 2/3] fbdev: Split frame buffer support in FB and FB_CORE symbols Date: Sun, 2 Jul 2023 21:15:19 +0200 Message-ID: <20230702191529.768248-3-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702191529.768248-1-javierm@redhat.com> References: <20230702191529.768248-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles). The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well. That means fbdev drivers have to be explicitly disabled if users want to enable CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer. This patch introduces a non-visible CONFIG_FB_CORE symbol that could be enabled just to have core support needed for CONFIG_DRM_FBDEV_EMULATION, allowing CONFIG_FB to be disabled (and automatically disabling all the fbdev drivers). Nothing from fb_backlight.o and fbmon.o is used by the DRM fbdev emulation layer so these two objects can be compiled out when CONFIG_FB is disabled. Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Really make a hidden symbol by removing the prompt (Arnd Bergmann). - Change FB_CORE to config instead of menuconfig (Arnd Bergmann). - Keep "depends on FB" for FIRMWARE_EDID (Arnd Bergmann). - Compile out fb_backlight.o and fbmon.o that are only needed for FB (Arnd Bergmann). - Make FB_DEVICE to depend on FB_CORE instead of selecting it. Changes in v2: - Keep "depends on FB" for FB_DDC, FB_HECUBA, FB_SVGALIB, FB_MACMODES, FB_BACKLIGHT, FB_MODE_HELPERS and FB_TILEBLITTING (Arnd Bergmann). - Don't change the fb.o object name (Arnd Bergmann). - Make FB_CORE a non-visible Kconfig symbol instead (Thomas Zimmermann). arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 40 +++++++++++++++++++------------ drivers/video/fbdev/core/Makefile | 8 +++---- 5 files changed, 32 insertions(+), 22 deletions(-) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index b39975977c03..89a02e69be5f 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -259,7 +259,7 @@ drivers-$(CONFIG_PCI) +=3D arch/x86/pci/ # suspend and hibernation support drivers-$(CONFIG_PM) +=3D arch/x86/power/ =20 -drivers-$(CONFIG_FB) +=3D arch/x86/video/ +drivers-$(CONFIG_FB_CORE) +=3D arch/x86/video/ =20 #### # boot loader support. Several targets are kept for legacy purposes diff --git a/arch/x86/video/Makefile b/arch/x86/video/Makefile index 11640c116115..5ebe48752ffc 100644 --- a/arch/x86/video/Makefile +++ b/arch/x86/video/Makefile @@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_FB) +=3D fbdev.o +obj-$(CONFIG_FB_CORE) +=3D fbdev.o diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index a2a88d42edf0..1b5a319971ed 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -72,7 +72,7 @@ config DUMMY_CONSOLE_ROWS =20 config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" - depends on FB && !UML + depends on FB_CORE && !UML select VT_HW_CONSOLE_BINDING select CRC32 select FONT_SUPPORT diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index cecf15418632..d436a4fd6f0a 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -6,10 +6,14 @@ config FB_NOTIFY bool =20 +config FB_CORE + select VIDEO_CMDLINE + tristate + menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers" + select FB_CORE select FB_NOTIFY - select VIDEO_CMDLINE help The frame buffer device provides an abstraction for the graphics hardware. It represents the frame buffer of some video hardware and @@ -33,6 +37,12 @@ menuconfig FB for m= ore information. =20 + This enables support for native frame buffer device (fbdev) drivers. + + The DRM subsystem provides support for emulated frame buffer devices + on top of KMS drivers, but this option allows legacy fbdev drivers to + be enabled as well. + Say Y here and to the driver for your graphics board below if you are compiling a kernel for a non-x86 architecture. =20 @@ -59,7 +69,7 @@ config FIRMWARE_EDID =20 config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + depends on FB_CORE default y help Say Y here if you want the legacy /dev/fb* device file and @@ -75,7 +85,7 @@ config FB_DDC =20 config FB_CFB_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the cfb_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own @@ -83,7 +93,7 @@ config FB_CFB_FILLRECT =20 config FB_CFB_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the cfb_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated) @@ -91,7 +101,7 @@ config FB_CFB_COPYAREA =20 config FB_CFB_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the cfb_imageblit function for generic software image blitting. This is used by drivers that don't provide their own @@ -99,7 +109,7 @@ config FB_CFB_IMAGEBLIT =20 config FB_CFB_REV_PIXELS_IN_BYTE bool - depends on FB + depends on FB_CORE help Allow generic frame-buffer functions to work on displays with 1, 2 and 4 bits per pixel depths which has opposite order of pixels in @@ -107,7 +117,7 @@ config FB_CFB_REV_PIXELS_IN_BYTE =20 config FB_SYS_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the sys_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own @@ -115,7 +125,7 @@ config FB_SYS_FILLRECT =20 config FB_SYS_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the sys_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated) @@ -123,7 +133,7 @@ config FB_SYS_COPYAREA =20 config FB_SYS_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the sys_imageblit function for generic software image blitting. This is used by drivers that don't provide their own @@ -162,22 +172,22 @@ endchoice =20 config FB_SYS_FOPS tristate - depends on FB + depends on FB_CORE =20 config FB_DEFERRED_IO bool - depends on FB + depends on FB_CORE =20 config FB_IO_HELPERS bool - depends on FB + depends on FB_CORE select FB_CFB_COPYAREA select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT =20 config FB_SYS_HELPERS bool - depends on FB + depends on FB_CORE select FB_SYS_COPYAREA select FB_SYS_FILLRECT select FB_SYS_FOPS @@ -185,7 +195,7 @@ config FB_SYS_HELPERS =20 config FB_SYS_HELPERS_DEFERRED bool - depends on FB + depends on FB_CORE select FB_DEFERRED_IO select FB_SYS_HELPERS =20 diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/M= akefile index 9150bafd9e89..2cd213716c12 100644 --- a/drivers/video/fbdev/core/Makefile +++ b/drivers/video/fbdev/core/Makefile @@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) +=3D fb_notify.o -obj-$(CONFIG_FB) +=3D fb.o -fb-y :=3D fb_backlight.o \ - fb_info.o \ - fbmem.o fbmon.o fbcmap.o \ +obj-$(CONFIG_FB_CORE) +=3D fb.o +fb-y :=3D fb_info.o \ + fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.o fb_io_f= ops.o +fb-$(CONFIG_FB) +=3D fb_backlight.o fbmon.o fb-$(CONFIG_FB_DEFERRED_IO) +=3D fb_defio.o fb-$(CONFIG_FB_DEVICE) +=3D fb_chrdev.o \ fb_procfs.o \ --=20 2.41.0 From nobody Sun Feb 8 07:07:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54849EB64DD for ; Sun, 2 Jul 2023 19:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbjGBTQo (ORCPT ); Sun, 2 Jul 2023 15:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230325AbjGBTQg (ORCPT ); Sun, 2 Jul 2023 15:16:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B301AB for ; Sun, 2 Jul 2023 12:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688325351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BtebbbtsycpwEyNSye/8z5gGh26uqgxI4WhcsSrx/V0=; b=E8j3CgK+3dldu3/aQbeZfNDGsAfvDYAqm/zmmKN0wLX6hTKf3n7b/U7fAJ8nVVQ9L7TS/+ +pl4isgcAoQxwObXp+vjfOG+hUzSntCbUBNUMk26o2Hdf0BKvKHxqTTa56aZL/+YLywdjW 5kJjiiilntrjyKPyDulQep7X/d2WPRY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-az7lY1qUMuSKhyJ0tXx-Kg-1; Sun, 02 Jul 2023 15:15:50 -0400 X-MC-Unique: az7lY1qUMuSKhyJ0tXx-Kg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31286355338so2119643f8f.0 for ; Sun, 02 Jul 2023 12:15:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688325349; x=1690917349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BtebbbtsycpwEyNSye/8z5gGh26uqgxI4WhcsSrx/V0=; b=XtzwCoEFiB72N9wGnS2xgv9boO1hrvVbs5H1S+zvBkqAIppuPqHkrQnGbtGo1fnekD DZ0jhI7Wiicsa1KyYxRBbbG6kYraVgAQGNd0MEUa+OP+CP3y79Z1ksblP9fkjjG/vho1 6q3LTVklj5f6hvWgeYV5PHKstfSfH2dv1iG+hExf1brpjbwNaystPb48w0jWVL/muc0q rmHI+/YOUDsP2+f9GdLgy3v90bdr6vWVctO7n1Wn6oyDMXW3Rgjs3BLckxDLhH7CJ2d/ mq4ZxIPjXiSdyIjI4TidGzIuXlCqFaJZVUFusmRY+ySRGafXAaIwOo+M8wTEEEqdu2pa y+/g== X-Gm-Message-State: ABy/qLaocMzVRCBtTJCXM9jFaNj+3ncwfnmeDiMKS7Ph5d5YqcOLdRJL teaySZ5zm0AIN7TISCr8HqQMJtOCNpe0X3wOHabZVLtkM3+AgBhZ5VDx3fjxruREv6iqr0PAO3A qKTJDm6V6F+zMqNKbv1of4d+YaFLK/BxH+rGgMgBxdWgLCys7gOU1g6dScET9zogQYRwZwwVchN AVZCrQSoI= X-Received: by 2002:adf:df03:0:b0:314:f88:4fea with SMTP id y3-20020adfdf03000000b003140f884feamr7089533wrl.8.1688325348987; Sun, 02 Jul 2023 12:15:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlEyklTA8x1D+VHvsQUZVf1gre+qa/Wgc/bQ4CPKiC6Ihq07p7WS1Q0iaaxUngWXac/drZSALQ== X-Received: by 2002:adf:df03:0:b0:314:f88:4fea with SMTP id y3-20020adfdf03000000b003140f884feamr7089512wrl.8.1688325348614; Sun, 02 Jul 2023 12:15:48 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm14144231wmk.48.2023.07.02.12.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 12:15:48 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Thomas Zimmermann , Arnd Bergmann , Javier Martinez Canillas , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org Subject: [PATCH v3 3/3] drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled Date: Sun, 2 Jul 2023 21:15:20 +0200 Message-ID: <20230702191529.768248-4-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702191529.768248-1-javierm@redhat.com> References: <20230702191529.768248-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Now that fbdev core has been split in FB_CORE and FB, make the DRM symbol to select the FB_CORE option if the DRM fbdev emulation layer is enabled. This allows to disable the CONFIG_FB option if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers. Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Make the DRM symbol to select FB_CORE if DRM_FBDEV_EMULATION is enabled (Arnd Bergmann). - Also make DRM select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION - Make DRM_FBDEV_EMULATION to depend on DRM instead of DRM_KMS_HELPER. Changes in v2: - Make CONFIG_DRM_FBDEV_EMULATION to select FB_CORE (Thomas Zimmermann). drivers/gpu/drm/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 373f85e174c2..07077708efd8 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -10,6 +10,9 @@ menuconfig DRM tristate "Direct Rendering Manager (DRM) and Kernel Mode Settings (KMS)" depends on (AGP || AGP=3Dn) && !EMULATED_CMPXCHG && HAS_DMA select DRM_PANEL_ORIENTATION_QUIRKS + select DRM_KMS_HELPER if DRM_FBDEV_EMULATION + select FB_CORE if DRM_FBDEV_EMULATION + select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION select HDMI select I2C select DMA_SHARED_BUFFER @@ -99,7 +102,6 @@ config DRM_KUNIT_TEST config DRM_KMS_HELPER tristate depends on DRM - select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION help CRTC helpers for KMS drivers. =20 @@ -135,8 +137,7 @@ config DRM_DEBUG_MODESET_LOCK =20 config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" - depends on DRM_KMS_HELPER - depends on FB=3Dy || FB=3DDRM_KMS_HELPER + depends on DRM select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y --=20 2.41.0