From nobody Sun Feb 8 18:24:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCA6EB64DC for ; Sat, 1 Jul 2023 10:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbjGAKZs (ORCPT ); Sat, 1 Jul 2023 06:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjGAKZp (ORCPT ); Sat, 1 Jul 2023 06:25:45 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9C11FCB for ; Sat, 1 Jul 2023 03:25:43 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b6afc1ceffso45367251fa.0 for ; Sat, 01 Jul 2023 03:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1688207142; x=1690799142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=clI9fiq1iEcRtB6iNCIk8JBKBujqSi3c+gmf90kUWRE=; b=r9o+mc5F8h0HyZ3CfSL4FrLY4tFSnT7SlSEywz/LsmCaQtyEnuBFAksRQvlKdeZt4M KYhUoQRbNX+SXPQKXQgq9SJHnHZy6arPPFkyyQted1yZBeiUBNVn3NfkrvYjP/u5v1Da rIUR3LSuX3lM51wu+jH37kekb/Y0eWzJ9UB01zmkjBuy98dCtMODYlI2GZtcPJqrcxru PgpvZu9v1fmtx++GiFR14uAyYElMwVSTOyp1vemxLFL+TvxqRzrxXUTbqd+n/mlUqw7e PxLDbVGQD5g0x8cxbDoaInXc+5GZ1xHG79XNGrBTj74Lw5qHpz6QqAvlxuPZDxLo66FZ aHHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688207142; x=1690799142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=clI9fiq1iEcRtB6iNCIk8JBKBujqSi3c+gmf90kUWRE=; b=lZ8w7NW15VnnQ3iritHw/GAYpTFO7ET1QCmbzdEtgonozeSL7JZ5rC8Az5GylUT1oD RGPyUYrEwnqAc5AwQ0JXm7Q1OnOq8wZL3+HADpXAoJ6q1020/saAHo17o11rKDRJKmqW 1o3kAh1fRAeQCizJC915z62yaZ+NvJ1eWrxOrGJEvYPUbdST4mjlbK2Vqlzq3v+MUXoK WW9y8Uqr9lOqNcpMWDb3bHhy9yVmKq/b8qFfFrALXtBSwaGueo2SLdvF9pmbL2ercksh QDHifqi+5z7y8yBNPDQefDqCL+qDf3RrStVXiHEb8GCUVha+KLVaosFuuCArwpInRgli FEEQ== X-Gm-Message-State: ABy/qLbMcNKGlehFVkn3GjL6VrBWjXNtboDalJGsdRqyb3PBEMaqVzTG Bha/iOVb5DUla8zAnBzk15Y= X-Google-Smtp-Source: APBJJlE1XByDiG2QhYXA7oPbgM9U6jwxP0GkFu53zwp/PfmOdp3LAXegd8nc1+o6okVO+tlrmocMeg== X-Received: by 2002:a2e:7214:0:b0:2b6:cecb:2f0f with SMTP id n20-20020a2e7214000000b002b6cecb2f0fmr3708508ljc.2.1688207141632; Sat, 01 Jul 2023 03:25:41 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:185:3db5:c5f0:49bb]) by smtp.gmail.com with ESMTPSA id i7-20020aa7c9c7000000b0051a3334f873sm7597535edt.89.2023.07.01.03.25.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 01 Jul 2023 03:25:41 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: dan.carpenter@linaro.org, eperi1024@gmail.com, gregkh@linuxfoundation.org, guozihua@huawei.com, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH v4 1/3] staging: rtl8723bs: Fix space issues Date: Sat, 1 Jul 2023 12:25:38 +0200 Message-Id: <20230701102538.5359-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230701102223.5308-1-franziska.naepelt@googlemail.com> References: <20230701102223.5308-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch space issues: - CHECK: spaces preferred around that '*' (ctx:VxV) - CHECK: spaces preferred around that '+' (ctx:VxV) - CHECK: spaces preferred around that '-' (ctx:VxV) - CHECK: spaces preferred around that '|' (ctx:VxV) - CHECK: No space is necessary after a cast - WARNING: please, no spaces at the start of a line Signed-off-by: Franziska Naepelt --- v4: Fix sign-off email address --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 76 +++++++++---------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 2ae7843abdf7..7a651952f77c 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] =3D= { static void rtw_2g_channels_init(struct ieee80211_channel *channels) { memcpy((void *)channels, (void *)rtw_2ghz_channels, - sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM + sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM ); } static void rtw_2g_rates_init(struct ieee80211_rate *rates) { memcpy(rates, rtw_g_rates, - sizeof(struct ieee80211_rate)*RTW_G_RATES_NUM + sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM ); } @@ -126,8 +126,8 @@ static struct ieee80211_supported_band *rtw_spt_band_al= loc( if (!spt_band) goto exit; - spt_band->channels =3D (struct ieee80211_channel *)(((u8 *)spt_band)+size= of(struct ieee80211_supported_band)); - spt_band->bitrates =3D (struct ieee80211_rate *)(((u8 *)spt_band->channel= s)+sizeof(struct ieee80211_channel)*n_channels); + spt_band->channels =3D (struct ieee80211_channel *)(((u8 *)spt_band) + si= zeof(struct ieee80211_supported_band)); + spt_band->bitrates =3D (struct ieee80211_rate *)(((u8 *)spt_band->channel= s) + sizeof(struct ieee80211_channel) * n_channels); spt_band->band =3D band; spt_band->n_channels =3D n_channels; spt_band->n_bitrates =3D n_bitrates; @@ -247,10 +247,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl u32 wpsielen =3D 0; u8 *wpsie =3D NULL; - wpsie =3D rtw_get_wps_ie(pnetwork->network.ies+_FIXED_IE_LENGTH_, pnetwo= rk->network.ie_length-_FIXED_IE_LENGTH_, NULL, &wpsielen); + wpsie =3D rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnet= work->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen); if (wpsie && wpsielen > 0) - psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_RE= GISTRAR, (u8 *)(&sr), NULL); + psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_REG= ISTRAR, (u8 *)(&sr), NULL); if (sr !=3D 0) { /* it means under processing WPS */ @@ -277,9 +277,9 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0))= { - notify_signal =3D 100*translate_percentage_to_dbm(padapter->recvpriv.sig= nal_strength);/* dbm */ + notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { - notify_signal =3D 100*translate_percentage_to_dbm(pnetwork->network.phy_= info.signal_strength);/* dbm */ + notify_signal =3D 100 * translate_percentage_to_dbm(pnetwork->network.ph= y_info.signal_strength);/* dbm */ } buf =3D kzalloc(MAX_BSSINFO_LEN, GFP_ATOMIC); @@ -449,20 +449,20 @@ void rtw_cfg80211_indicate_connect(struct adapter *pa= dapter) roam_info.links[0].channel =3D notify_channel; roam_info.links[0].bssid =3D cur_network->network.mac_address; roam_info.req_ie =3D - pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2; + pmlmepriv->assoc_req + sizeof(struct ieee80211_hdr_3addr) + 2; roam_info.req_ie_len =3D - pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2; + pmlmepriv->assoc_req_len - sizeof(struct ieee80211_hdr_3addr) - 2; roam_info.resp_ie =3D - pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6; + pmlmepriv->assoc_rsp + sizeof(struct ieee80211_hdr_3addr) + 6; roam_info.resp_ie_len =3D - pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6; + pmlmepriv->assoc_rsp_len - sizeof(struct ieee80211_hdr_3addr) - 6; cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC); } else { cfg80211_connect_result(padapter->pnetdev, cur_network->network.mac_addr= ess - , pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2 - , pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2 - , pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6 - , pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6 + , pmlmepriv->assoc_req + sizeof(struct ieee80211_hdr_3addr) + 2 + , pmlmepriv->assoc_req_len - sizeof(struct ieee80211_hdr_3addr) - 2 + , pmlmepriv->assoc_rsp + sizeof(struct ieee80211_hdr_3addr) + 6 + , pmlmepriv->assoc_rsp_len - sizeof(struct ieee80211_hdr_3addr) - 6 , WLAN_STATUS_SUCCESS, GFP_ATOMIC); } } @@ -708,7 +708,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param param->u.crypt.err =3D 0; param->u.crypt.alg[IEEE_CRYPT_ALG_NAME_LEN - 1] =3D '\0'; - if (param_len < (u32) ((u8 *) param->u.crypt.key - (u8 *) param) + param-= >u.crypt.key_len) { + if (param_len < (u32)((u8 *)param->u.crypt.key - (u8 *)param) + param->u.= crypt.key_len) { ret =3D -EINVAL; goto exit; } @@ -1019,10 +1019,10 @@ static int cfg80211_rtw_get_station(struct wiphy *w= iphy, } /* for Ad-Hoc/AP mode */ - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) - || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) - || check_fwstate(pmlmepriv, WIFI_AP_STATE)) - && check_fwstate(pmlmepriv, _FW_LINKED)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_AP_STATE)) && + check_fwstate(pmlmepriv, _FW_LINKED)) { /* TODO: should acquire station info... */ } @@ -1219,7 +1219,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy spin_unlock_bh(&pwdev_priv->scan_req_lock); if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { - if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS|_FW_UNDER_SURVEY|_FW_UNDER_L= INKING) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS | _FW_UNDER_SURVEY | _FW_UND= ER_LINKING) =3D=3D true) { need_indicate_scan_done =3D true; goto check_need_indicate_scan_done; } @@ -1273,7 +1273,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } /* parsing channels, n_channels */ - memset(ch, 0, sizeof(struct rtw_ieee80211_channel)*RTW_CHANNEL_SCAN_AMOUN= T); + memset(ch, 0, sizeof(struct rtw_ieee80211_channel) * RTW_CHANNEL_SCAN_AMO= UNT); for (i =3D 0; i < request->n_channels && i < RTW_CHANNEL_SCAN_AMOUNT; i++= ) { ch[i].hw_value =3D request->channels[i]->hw_value; ch[i].flags =3D request->channels[i]->flags; @@ -1287,7 +1287,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } else if (request->n_channels <=3D 4) { for (j =3D request->n_channels - 1; j >=3D 0; j--) for (i =3D 0; i < survey_times; i++) - memcpy(&ch[j*survey_times+i], &ch[j], sizeof(struct rtw_ieee80211_chan= nel)); + memcpy(&ch[j * survey_times + i], &ch[j], sizeof(struct rtw_ieee80211_= channel)); _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, ch,= survey_times * request->n_channels); } else { _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, NUL= L, 0); @@ -1436,7 +1436,7 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *pa= dapter, u8 *pie, size_t iel goto exit; } - if (ielen > MAX_WPA_IE_LEN+MAX_WPS_IE_LEN+MAX_P2P_IE_LEN) { + if (ielen > MAX_WPA_IE_LEN + MAX_WPS_IE_LEN + MAX_P2P_IE_LEN) { ret =3D -EINVAL; goto exit; } @@ -1456,19 +1456,19 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *= padapter, u8 *pie, size_t iel pwpa =3D rtw_get_wpa_ie(buf, &wpa_ielen, ielen); if (pwpa && wpa_ielen > 0) { - if (rtw_parse_wpa_ie(pwpa, wpa_ielen+2, &group_cipher, &pairwise_cipher,= NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(pwpa, wpa_ielen + 2, &group_cipher, &pairwise_ciphe= r, NULL) =3D=3D _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; - memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen+2); + memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen + 2); } } pwpa2 =3D rtw_get_wpa2_ie(buf, &wpa2_ielen, ielen); if (pwpa2 && wpa2_ielen > 0) { - if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen+2, &group_cipher, &pairwise_ciph= er, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen + 2, &group_cipher, &pairwise_ci= pher, NULL) =3D=3D _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPA2PSK; - memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen+2); + memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen + 2); } } @@ -1863,7 +1863,7 @@ static int cfg80211_rtw_set_pmksa(struct wiphy *wiphy, if (!memcmp(psecuritypriv->PMKIDList[index].Bssid, (u8 *)pmksa->bssid, E= TH_ALEN)) { memcpy(psecuritypriv->PMKIDList[index].PMKID, (u8 *)pmksa->pmkid, WLAN_= PMKID_LEN); psecuritypriv->PMKIDList[index].bUsed =3D true; - psecuritypriv->PMKIDIndex =3D index+1; + psecuritypriv->PMKIDIndex =3D index + 1; blInserted =3D true; break; } @@ -2064,8 +2064,8 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry= (struct sk_buff *skb, struc _rtw_xmit_entry(skb, padapter->pnetdev); return NETDEV_TX_OK; - } else if ((frame_control & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE)) = =3D=3D - (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)) { + } else if ((frame_control & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)= ) =3D=3D + (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)) { /* only for action frames */ struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; @@ -2174,7 +2174,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter= *padapter, char *name, str goto out; *ndev =3D pwdev_priv->pmon_ndev =3D mon_ndev; - memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1); + memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ + 1); out: if (ret && mon_wdev) { @@ -2268,14 +2268,14 @@ static int rtw_add_beacon(struct adapter *adapter, = const u8 *head, size_t head_l if (head_len < 24) return -EINVAL; - pbuf =3D rtw_zmalloc(head_len+tail_len); + pbuf =3D rtw_zmalloc(head_len + tail_len); if (!pbuf) return -ENOMEM; - memcpy(pbuf, (void *)head+24, head_len-24);/* 24 =3Dbeacon header len. */ - memcpy(pbuf+head_len-24, (void *)tail, tail_len); + memcpy(pbuf, (void *)head + 24, head_len - 24);/* 24 =3Dbeacon header le= n. */ + memcpy(pbuf + head_len - 24, (void *)tail, tail_len); - len =3D head_len+tail_len-24; + len =3D head_len + tail_len - 24; /* check wps ie if inclued */ rtw_get_wps_ie(pbuf + _FIXED_IE_LENGTH_, len - _FIXED_IE_LENGTH_, NULL, &= wps_ielen); @@ -2558,7 +2558,7 @@ static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, pwdev_priv =3D adapter_wdev_data(padapter); /* cookie generation */ - *cookie =3D (unsigned long) buf; + *cookie =3D (unsigned long)buf; /* indicate ack before issue frame to avoid racing with rsp frame */ rtw_cfg80211_mgmt_tx_status(padapter, *cookie, buf, len, ack, GFP_KERNEL); -- 2.39.2 (Apple Git-143) From nobody Sun Feb 8 18:24:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A41EB64DD for ; Sat, 1 Jul 2023 10:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229885AbjGAK0H (ORCPT ); Sat, 1 Jul 2023 06:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjGAK0G (ORCPT ); Sat, 1 Jul 2023 06:26:06 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FD8F3ABD for ; Sat, 1 Jul 2023 03:26:01 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-98d34f1e54fso295258966b.2 for ; Sat, 01 Jul 2023 03:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1688207160; x=1690799160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7GZu65JhxFHkJXNbRjSzNPKPbKjdim0drHX3vhxmqLw=; b=G7bwbgPOZZ4AtLEKCrS9/WIuQNJms0y0q1gZhnrYDR3D0g9eNuyWDZ7WxqrjEAMZbB I7Avp1bkeWotBu7pOcXufgFMVeNkHXE5P+b4alodtmMedvHWnyLWxoIAPX2pudMlu2YI L1+L5ZEWPvf1/o417Ji7b/v3ttD6pexxGMQ8YBgzY3fb/eJ8BV1bOtivZB4SR5ud3cNB eumzgvxbY3yzecd9Qp0zTwJf/Y93fqayUOgeHu8O6qiR/9F3MvdlxhjnOvbEGnuUznDY Xt2NE5kIu9Jcv/Zdirm6B2UqOyFfsTzMH1qHd5gfxKaAr1ttUVFy85mPrrRbNO4YER/m /zhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688207160; x=1690799160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7GZu65JhxFHkJXNbRjSzNPKPbKjdim0drHX3vhxmqLw=; b=gDbp4bcNsyU4LlEW5s5Nuh/wI/8QMCcj177Tc/FjBD0PYf7WFaKjNM0RwDOonBBMra hN31l4TeQ3rZIIoPUd/MK9FqFuRb1A6mQv8K8lhNq56yn6eHOY+NvENYKa1l0il1OgKj WKIZWtopIh6btgcGnhifNqpe+7SAwb7jxnbczQtCo/AQSh2LtHyjQT773JEjUS9hqFeQ UXZ/0YqCofgGG2YU8xA4CtzToqq8CiCcNY89a7xviNAQNmW3RRL7mMNix1nmiRFdBiqo cqXlNVuLJmW1iMmzfnK+f+x4kW36cJ22fzhMAPEW8fsQshDpYxQKEu4p3ub3j8gYUYtV +1SA== X-Gm-Message-State: ABy/qLbp28A6yjzMlZUaw8CxcHosbk60hCQ+PhUr1nRNB4HH3akux6oy FEMK/gizPYciaP0vZxRWqEvy872t8PNnfg== X-Google-Smtp-Source: APBJJlE7NvtKVHZ3a/ABk4LTkGSQ+LbJXPCPZubIx16bKbKw+ui6gAWfGFC0JkNOz///4x41FvzhYQ== X-Received: by 2002:a17:906:5650:b0:982:82aa:86b1 with SMTP id v16-20020a170906565000b0098282aa86b1mr2700060ejr.43.1688207159678; Sat, 01 Jul 2023 03:25:59 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:185:3db5:c5f0:49bb]) by smtp.gmail.com with ESMTPSA id v4-20020a170906180400b009920e9a3a73sm5446274eje.115.2023.07.01.03.25.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 01 Jul 2023 03:25:59 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: dan.carpenter@linaro.org, eperi1024@gmail.com, gregkh@linuxfoundation.org, guozihua@huawei.com, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH v4 2/3] staging: rtl8723bs: Fix alignment open parenthesis Date: Sat, 1 Jul 2023 12:25:55 +0200 Message-Id: <20230701102555.5393-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230701102223.5308-1-franziska.naepelt@googlemail.com> References: <20230701102223.5308-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issues: - CHECK: Alignment should match open parenthesis Signed-off-by: Franziska Naepelt --- v4: Fix sign-off email address --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 91 ++++++++++--------- 1 file changed, 49 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 7a651952f77c..8f30098168f1 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] =3D= { static void rtw_2g_channels_init(struct ieee80211_channel *channels) { memcpy((void *)channels, (void *)rtw_2ghz_channels, - sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM + sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM ); } static void rtw_2g_rates_init(struct ieee80211_rate *rates) { memcpy(rates, rtw_g_rates, - sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM + sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM ); } @@ -276,7 +276,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && - is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0))= { + is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, = 0)) { notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { notify_signal =3D 100 * translate_percentage_to_dbm(pnetwork->network.ph= y_info.signal_strength);/* dbm */ @@ -314,7 +314,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl *((__le64 *)pbuf) =3D cpu_to_le64(notify_timestamp); bss =3D cfg80211_inform_bss_frame(wiphy, notify_channel, (struct ieee8021= 1_mgmt *)buf, - len, notify_signal, GFP_ATOMIC); + len, notify_signal, GFP_ATOMIC); if (unlikely(!bss)) goto exit; @@ -346,9 +346,9 @@ int rtw_cfg80211_check_bss(struct adapter *padapter) notify_channel =3D ieee80211_get_channel(padapter->rtw_wdev->wiphy, freq); bss =3D cfg80211_get_bss(padapter->rtw_wdev->wiphy, notify_channel, - pnetwork->mac_address, pnetwork->ssid.ssid, - pnetwork->ssid.ssid_length, - IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); + pnetwork->mac_address, pnetwork->ssid.ssid, + pnetwork->ssid.ssid_length, + IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); cfg80211_put_bss(padapter->rtw_wdev->wiphy, bss); @@ -487,7 +487,7 @@ void rtw_cfg80211_indicate_disconnect(struct adapter *p= adapter) NULL, 0, true, GFP_ATOMIC); } else { cfg80211_connect_result(padapter->pnetdev, NULL, NULL, 0, NULL, 0, - WLAN_STATUS_UNSPECIFIED_FAILURE, GFP_ATOMIC/*GFP_KERNEL*/); + WLAN_STATUS_UNSPECIFIED_FAILURE, GFP_ATOMIC/*GFP_KERNEL*/); } } } @@ -778,7 +778,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param psta->ieee8021x_blocked =3D false; if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrth= m; } @@ -827,7 +827,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param pbcmc_sta->ieee8021x_blocked =3D false; if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { pbcmc_sta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyA= lgrthm; } } @@ -945,9 +945,9 @@ static int cfg80211_rtw_del_key(struct wiphy *wiphy, st= ruct net_device *ndev, } static int cfg80211_rtw_set_default_key(struct wiphy *wiphy, - struct net_device *ndev, int link_id, u8 key_index - , bool unicast, bool multicast - ) + struct net_device *ndev, int link_id, + u8 key_index, bool unicast, + bool multicast) { struct adapter *padapter =3D rtw_netdev_priv(ndev); struct security_priv *psecuritypriv =3D &padapter->securitypriv; @@ -1122,9 +1122,10 @@ void rtw_cfg80211_unlink_bss(struct adapter *padapte= r, struct wlan_network *pnet struct wlan_bssid_ex *select_network =3D &pnetwork->network; bss =3D cfg80211_get_bss(wiphy, NULL/*notify_channel*/, - select_network->mac_address, select_network->ssid.ssid, - select_network->ssid.ssid_length, IEEE80211_BSS_TYPE_ANY, - IEEE80211_PRIVACY_ANY); + select_network->mac_address, + select_network->ssid.ssid, + select_network->ssid.ssid_length, + IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); if (bss) { cfg80211_unlink_bss(wiphy, bss); @@ -1329,7 +1330,7 @@ static int rtw_cfg80211_set_wpa_version(struct securi= ty_priv *psecuritypriv, u32 } static int rtw_cfg80211_set_auth_type(struct security_priv *psecuritypriv, - enum nl80211_auth_type sme_auth_type) + enum nl80211_auth_type sme_auth_type) { switch (sme_auth_type) { case NL80211_AUTHTYPE_AUTOMATIC: @@ -1634,7 +1635,7 @@ static int cfg80211_rtw_leave_ibss(struct wiphy *wiph= y, struct net_device *ndev) } static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *nd= ev, - struct cfg80211_connect_params *sme) + struct cfg80211_connect_params *sme) { int ret =3D 0; enum ndis_802_11_authentication_mode authmode; @@ -1709,7 +1710,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, /* For WEP Shared auth */ if ((psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Shared || - psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme-= >key) { + psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme= ->key) { u32 wep_key_idx, wep_key_len, wep_total_len; struct ndis_802_11_wep *pwep =3D NULL; @@ -1807,15 +1808,14 @@ static int cfg80211_rtw_disconnect(struct wiphy *wi= phy, struct net_device *ndev, } static int cfg80211_rtw_set_txpower(struct wiphy *wiphy, - struct wireless_dev *wdev, - enum nl80211_tx_power_setting type, int mbm) + struct wireless_dev *wdev, + enum nl80211_tx_power_setting type, int mbm) { return 0; } static int cfg80211_rtw_get_txpower(struct wiphy *wiphy, - struct wireless_dev *wdev, - int *dbm) + struct wireless_dev *wdev, int *dbm) { *dbm =3D (12); @@ -2228,7 +2228,7 @@ static struct wireless_dev * } static int cfg80211_rtw_del_virtual_intf(struct wiphy *wiphy, - struct wireless_dev *wdev + struct wireless_dev *wdev ) { struct net_device *ndev =3D wdev_to_ndev(wdev); @@ -2295,13 +2295,14 @@ static int rtw_add_beacon(struct adapter *adapter, = const u8 *head, size_t head_l } static int cfg80211_rtw_start_ap(struct wiphy *wiphy, struct net_device *n= dev, - struct cfg80211_ap_settings *settings) + struct cfg80211_ap_settings *settings) { int ret =3D 0; struct adapter *adapter =3D rtw_netdev_priv(ndev); - ret =3D rtw_add_beacon(adapter, settings->beacon.head, settings->beacon.h= ead_len, - settings->beacon.tail, settings->beacon.tail_len); + ret =3D rtw_add_beacon(adapter, settings->beacon.head, + settings->beacon.head_len, settings->beacon.tail, + settings->beacon.tail_len); adapter->mlmeextpriv.mlmext_info.hidden_ssid_mode =3D settings->hidden_ss= id; @@ -2318,8 +2319,9 @@ static int cfg80211_rtw_start_ap(struct wiphy *wiphy,= struct net_device *ndev, return ret; } -static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, struct net_devi= ce *ndev, - struct cfg80211_beacon_data *info) +static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, + struct net_device *ndev, + struct cfg80211_beacon_data *info) { struct adapter *adapter =3D rtw_netdev_priv(ndev); @@ -2332,9 +2334,10 @@ static int cfg80211_rtw_stop_ap(struct wiphy *wiphy,= struct net_device *ndev, return 0; } -static int cfg80211_rtw_add_station(struct wiphy *wiphy, struct net_device= *ndev, - const u8 *mac, - struct station_parameters *params) +static int cfg80211_rtw_add_station(struct wiphy *wiphy, + struct net_device *ndev, + const u8 *mac, + struct station_parameters *params) { return 0; } @@ -2396,8 +2399,10 @@ static int cfg80211_rtw_del_station(struct wiphy *wi= phy, struct net_device *ndev return ret; } -static int cfg80211_rtw_change_station(struct wiphy *wiphy, struct net_dev= ice *ndev, - const u8 *mac, struct station_parameters *params) +static int cfg80211_rtw_change_station(struct wiphy *wiphy, + struct net_device *ndev, + const u8 *mac, + struct station_parameters *params) { return 0; } @@ -2422,8 +2427,10 @@ static struct sta_info *rtw_sta_info_get_by_idx(cons= t int idx, struct sta_priv * return psta; } -static int cfg80211_rtw_dump_station(struct wiphy *wiphy, struct net_devic= e *ndev, - int idx, u8 *mac, struct station_info *sinfo) +static int cfg80211_rtw_dump_station(struct wiphy *wiphy, + struct net_device *ndev, + int idx, u8 *mac, + struct station_info *sinfo) { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(ndev); @@ -2445,8 +2452,9 @@ static int cfg80211_rtw_dump_station(struct wiphy *wi= phy, struct net_device *nde return ret; } -static int cfg80211_rtw_change_bss(struct wiphy *wiphy, struct net_device = *ndev, - struct bss_parameters *params) +static int cfg80211_rtw_change_bss(struct wiphy *wiphy, + struct net_device *ndev, + struct bss_parameters *params) { return 0; } @@ -2529,10 +2537,9 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *pad= apter, u8 tx_ch, const u8 *b return ret; } -static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, - struct wireless_dev *wdev, - struct cfg80211_mgmt_tx_params *params, - u64 *cookie) +static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *= wdev, + struct cfg80211_mgmt_tx_params *params, + u64 *cookie) { struct net_device *ndev =3D wdev_to_ndev(wdev); struct ieee80211_channel *chan =3D params->chan; -- 2.39.2 (Apple Git-143) From nobody Sun Feb 8 18:24:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB8D6EB64DD for ; Sat, 1 Jul 2023 10:26:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbjGAK0Z (ORCPT ); Sat, 1 Jul 2023 06:26:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbjGAK0V (ORCPT ); Sat, 1 Jul 2023 06:26:21 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EB9F3C2A for ; Sat, 1 Jul 2023 03:26:20 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51dfa0771cdso733485a12.2 for ; Sat, 01 Jul 2023 03:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1688207179; x=1690799179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eRU/4EgIG59FlYdUAQY/bxVUjSKGZZK/O/khm55mTyc=; b=Ui5ViJExRzULqY2c10lgXVJvlivZipx89e9cDYXQa6aFO/3yHYGLoOkPsq8ip03BV0 jXwFWbnz4Y/Wa4AbyZljXjV4n8V7BUm0ex5ROA3LHxnKTsH1o7bmYD9PYiPf7lL4Mw60 itfPn0WxcqM1+8LwCr68P7rYiQ9TGDd4jAvDHs5pfoe1jF6hBohgrTbo7Mngko8EJdum QFTn3E8tk1USWd47lA0Eee70JVPg5MYMu6ho3V1xLJ5Wt2WZ/r4HwBovwO9rMRcYOZhT CyGBC+h401EV7l/xHo8QyoTtokBczww9frocGE51YT1sySBK0PaOABst9nzNxLxumDqY 5ayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688207179; x=1690799179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eRU/4EgIG59FlYdUAQY/bxVUjSKGZZK/O/khm55mTyc=; b=H4c0MMlP36U77+wcoUVi7e86Ml860OZfUyRDQvjTDlwx9J5ILXNvCAPhwTts9eJqH6 ytopJPVzkvXT4aHXkVofiFu5oXCkgCL5L63NIECRftW39TyJcgAJAqPkF8jRAJIv3cI1 tz+cT23uvPbSpcb0bYKO78b8DDpci+kuDaByZ6WNoGCBWUiUgfLHP3+ufB5kjJcaiBDd Pm++wSUitZNhg9UrkbYc5ta0lJ2S1A+attLzLds+/muZ+8zvP4Lg74kcktgm3+YV1vc8 6P4Djo2hbzm6L/e8PAhL60vKN3Af0529Eh6vnMSyB95xHPxBfisQ0g12JBF0CDiJgCgM wshA== X-Gm-Message-State: ABy/qLZdwCRbdTsLphC9iX+tvMkPZVi/u/4kV0iGD1ke1zOHS367BGgd 6Zw8iNAP/6j9wzuWpF4ZL4Y= X-Google-Smtp-Source: APBJJlEOM2wyXiO811piYKKG/fldWxWfNc7UGh39pgsxm8pMfnhTINVSYue1eBWNQi8U0ef4m28PcQ== X-Received: by 2002:aa7:d31a:0:b0:51d:d30c:f1e3 with SMTP id p26-20020aa7d31a000000b0051dd30cf1e3mr3058659edq.16.1688207178949; Sat, 01 Jul 2023 03:26:18 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:185:3db5:c5f0:49bb]) by smtp.gmail.com with ESMTPSA id c19-20020a056402121300b0051dd19d6d6esm3385151edw.73.2023.07.01.03.26.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 01 Jul 2023 03:26:18 -0700 (PDT) From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: dan.carpenter@linaro.org, eperi1024@gmail.com, gregkh@linuxfoundation.org, guozihua@huawei.com, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH v4 3/3] staging: rtl8723bs: Fix remaining blank line issue Date: Sat, 1 Jul 2023 12:26:13 +0200 Message-Id: <20230701102613.5420-1-franziska.naepelt@googlemail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230701102223.5308-1-franziska.naepelt@googlemail.com> References: <20230701102223.5308-1-franziska.naepelt@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch blank line issue: - CHECK: Please don't use multiple blank lines Signed-off-by: Franziska Naepelt --- v4: Fix sign-off email address --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 8f30098168f1..292cba045023 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -266,7 +266,6 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl } /* spin_unlock_bh(&pwdev_priv->scan_req_lock); */ - channel =3D pnetwork->network.configuration.ds_config; freq =3D rtw_ieee80211_channel_to_frequency(channel, NL80211_BAND_2GHZ); -- 2.39.2 (Apple Git-143)