From nobody Sat Feb 7 15:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CA2EB64D7 for ; Fri, 30 Jun 2023 14:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232503AbjF3O1m (ORCPT ); Fri, 30 Jun 2023 10:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbjF3O1V (ORCPT ); Fri, 30 Jun 2023 10:27:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF5C93AAB for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67D3761767 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB990C433CC; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=NRFErKcwJ/XzcSK0nLh18CLPEbv6pza++M+LD175n/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rp+wfgt/fmfucldMXsQFVG5qrpdRwt2MhBa4hhvoo9tTSd9s8F6S09guVvviSPh/b bvOMCWwmWygIQDX8yK6ABQIriIUp8fSs+G96HhRVrxiNbzy/Jzjym4F4HEXRvJr38o gC1AOgAl0g1w86zqKQY7JJuc/k18l98/0N+CmP+cNX7oB5wTM7wwvtQEAtZD/9Ir5F mGDRP0qyjIWKfFkJ2vWj9TyXN7gTh5by1Z+O3tZKJQKV65lK9/L+Zc2tQgIUr1nrKA YXv08G+0rd0aWGx3sd2Nr0LQsBCE87E0E+qlvOnS2I9yA/SEKhID5PrCkmf02qkMXs Mrgz7snhumXqQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001O7-8o; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/5] ASoC: codecs: wcd938x: fix mbhc impedance loglevel Date: Fri, 30 Jun 2023 16:27:13 +0200 Message-Id: <20230630142717.5314-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Demote the MBHC impedance measurement printk, which is not an error message, from error to debug level. While at it, fix the capitalisation of "ohm" and add the missing space before the opening parenthesis. Fixes: bcee7ed09b8e ("ASoC: codecs: wcd938x: add Multi Button Headset Contr= ol support") Signed-off-by: Johan Hovold Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index e3ae4fb2c4db..b8a52a1a63d5 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2165,8 +2165,8 @@ static inline void wcd938x_mbhc_get_result_params(str= uct wcd938x_priv *wcd938x, else if (x1 < minCode_param[noff]) *zdet =3D WCD938X_ZDET_FLOATING_IMPEDANCE; =20 - pr_err("%s: d1=3D%d, c1=3D%d, x1=3D0x%x, z_val=3D%d(milliOhm)\n", - __func__, d1, c1, x1, *zdet); + pr_debug("%s: d1=3D%d, c1=3D%d, x1=3D0x%x, z_val=3D%d (milliohm)\n", + __func__, d1, c1, x1, *zdet); ramp_down: i =3D 0; while (x1) { --=20 2.39.3 From nobody Sat Feb 7 15:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F43EB64D7 for ; Fri, 30 Jun 2023 14:27:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbjF3O1b (ORCPT ); Fri, 30 Jun 2023 10:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjF3O1U (ORCPT ); Fri, 30 Jun 2023 10:27:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D43E135AF for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4BF5A61763 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB908C433CA; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=PQzafQPINWzNCKfU5qAbB7q39zv1fe5dtlRulHQmlWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EEH5d8nmZCFHaRW8Qfwvrw5eNUf+1b2fNeJWl2yEjsEaYvYJH0AzcfYcAfP2rHAe7 sBLFMDTvsOaXYOYCudL0iFFfRwKwwgEXgrlXqC4nG23beyJK+aJUOXQInbZy20Tle5 3YUWnL39h1Q68uJzcvO+S1WxjG+0y392YKXRo15u8y2hZOIFBW06lIlUlIb2LG2IQ9 W66LzIPVxrsK2xDEh2qvjNdaP89h+TF+u9CzC9JRo7aRyQS0XBnFMVTYed/WyuGWvY z+I1c8vDDYWSksfECI0r9E/HS6Sk+9WKQ4ZbhU2M8AVAK243u3Gkw4DgxlGC3YjOaz uQ4eGCn4tJXjw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OQ-BJ; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/5] ASoC: codecs: wcd938x: drop inline keywords Date: Fri, 30 Jun 2023 16:27:14 +0200 Message-Id: <20230630142717.5314-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The compiler is generally better at deciding what functions should be inlined than driver authors are. Drop the bogus inline keyword from two functions that were neither very small or used in a single place. Signed-off-by: Johan Hovold Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index b8a52a1a63d5..5ce15b622a91 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2124,7 +2124,7 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struc= t snd_soc_component *compon return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); } =20 -static inline void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd= 938x, +static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, s16 *d1_a, u16 noff, int32_t *zdet) { @@ -2231,8 +2231,8 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_com= ponent *component, *zr =3D zdet; } =20 -static inline void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *co= mponent, - int32_t *z_val, int flag_l_r) +static void wcd938x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, + int32_t *z_val, int flag_l_r) { s16 q1; int q1_cal; --=20 2.39.3 From nobody Sat Feb 7 15:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE90AEB64D7 for ; Fri, 30 Jun 2023 14:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbjF3O1q (ORCPT ); Fri, 30 Jun 2023 10:27:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbjF3O1Y (ORCPT ); Fri, 30 Jun 2023 10:27:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1114935AF for ; Fri, 30 Jun 2023 07:27:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D61B061771 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B36E4C433CD; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=P6YVdCFm2ZOkpCnCJ7xlyVk9dprYs6KAI7jlHUrVE5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D424TjQiXcZcj4i/3v89N3a4BuqKXQtLcEZgEl+wCzeh7iNUv9wFPGkfd+0jwWfcF p4pMrS4+tXjRGn/TwKglozLY4ew3h/f+zgCLPdyKpxacvKwkQA1ab0X9/DTvw15rGy 2SzNG29ZYSKYlrOtNDqgn3Y0WMNdqhEPRR3xPTg4Y9ZUzgjl1j7bPYSboYsYysFPHY +rMGkUb3Kg96Cul1BwADFXFtywQbLLUwaJUL0T0bS+qPNzIgEJz0lDRm/Sd5uu1olg 04l1NbsWscLKr++r95aPcKmkuLf90puLbVydfB0tcAUzmSQeKxeFhputmq4UrPxsrk qBS6Ed5P+q0tA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OS-Ds; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/5] ASoC: codecs: wcd938x: use dev_printk() for impedance logging Date: Fri, 30 Jun 2023 16:27:15 +0200 Message-Id: <20230630142717.5314-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Pass the component structure also to the wcd938x_mbhc_get_result_params() helper so that the component device can be used for logging consistently. Signed-off-by: Johan Hovold Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 5ce15b622a91..ddefe4af0b1e 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2124,10 +2124,11 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(str= uct snd_soc_component *compon return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); } =20 -static void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, +static void wcd938x_mbhc_get_result_params(struct snd_soc_component *compo= nent, s16 *d1_a, u16 noff, int32_t *zdet) { + struct wcd938x_priv *wcd938x =3D snd_soc_component_get_drvdata(component); int i; int val, val1; s16 c1; @@ -2154,8 +2155,8 @@ static void wcd938x_mbhc_get_result_params(struct wcd= 938x_priv *wcd938x, usleep_range(5000, 5050); =20 if (!c1 || !x1) { - pr_err("%s: Impedance detect ramp error, c1=3D%d, x1=3D0x%x\n", - __func__, c1, x1); + dev_err(component->dev, "Impedance detect ramp error, c1=3D%d, x1=3D0x%x= \n", + c1, x1); goto ramp_down; } d1 =3D d1_a[c1]; @@ -2165,8 +2166,8 @@ static void wcd938x_mbhc_get_result_params(struct wcd= 938x_priv *wcd938x, else if (x1 < minCode_param[noff]) *zdet =3D WCD938X_ZDET_FLOATING_IMPEDANCE; =20 - pr_debug("%s: d1=3D%d, c1=3D%d, x1=3D0x%x, z_val=3D%d (milliohm)\n", - __func__, d1, c1, x1, *zdet); + dev_dbg(component->dev, "%s: d1=3D%d, c1=3D%d, x1=3D0x%x, z_val=3D%d (mil= liohm)\n", + __func__, d1, c1, x1, *zdet); ramp_down: i =3D 0; while (x1) { @@ -2210,7 +2211,7 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_com= ponent *component, WCD938X_ANA_MBHC_ZDET, 0x80, 0x80); dev_dbg(component->dev, "%s: ramp for HPH_L, noff =3D %d\n", __func__, zdet_param->noff); - wcd938x_mbhc_get_result_params(wcd938x, d1_a, zdet_param->noff, &zdet); + wcd938x_mbhc_get_result_params(component, d1_a, zdet_param->noff, &zdet); regmap_update_bits(wcd938x->regmap, WCD938X_ANA_MBHC_ZDET, 0x80, 0x00); =20 @@ -2224,7 +2225,7 @@ static void wcd938x_mbhc_zdet_ramp(struct snd_soc_com= ponent *component, WCD938X_ANA_MBHC_ZDET, 0x40, 0x40); dev_dbg(component->dev, "%s: ramp for HPH_R, noff =3D %d\n", __func__, zdet_param->noff); - wcd938x_mbhc_get_result_params(wcd938x, d1_a, zdet_param->noff, &zdet); + wcd938x_mbhc_get_result_params(component, d1_a, zdet_param->noff, &zdet); regmap_update_bits(wcd938x->regmap, WCD938X_ANA_MBHC_ZDET, 0x40, 0x00); =20 --=20 2.39.3 From nobody Sat Feb 7 15:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A9CEB64D7 for ; Fri, 30 Jun 2023 14:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232348AbjF3O1g (ORCPT ); Fri, 30 Jun 2023 10:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjF3O1V (ORCPT ); Fri, 30 Jun 2023 10:27:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26B33AAD for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C44761769 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB857C433C8; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=d1TV3UMh6xoeemuKnST1bo2dXdckO3q+r8QUrL0X6V0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jcldJ0KIiGOHCLdh9VVbIIOMTDdsd6uLObALf9+N/4QXztMgUhpnzo07D6JSEprGM ysVwMdU2PImvgsB5pqYjIvXZMsmeeULwOILdMeIoJXSwnjfIErW6dM4eX1nbNAAJXY V9JcWcfAE4AfzWdwEc1M4M77rRKpZVqIQwUz3MiMlfa2v7hLL3SFBbvGoiSa+xN5H5 OfzWVaRpKNjExA124iP9Ph2a1ewcq91hqNWwCiKAMNmSwWeO7QJdoOU5wS78uBPvXy fzqKb+BQ2096laCMex5jcQuh3ulVn45f94C2JgpZgoQgM6iNWghg5jSYM2fyJqS3/W W3WQTNgRXUdWg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OU-GP; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/5] ASoC: codecs: wcd934x: demote impedance printk Date: Fri, 30 Jun 2023 16:27:16 +0200 Message-Id: <20230630142717.5314-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Demote the MBHC impedance measurement printk, which is only needed for development and debugging, to debug level. While at it, fix the capitalisation of "ohm" and add the missing space before the opening parenthesis. Signed-off-by: Johan Hovold Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd934x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index c0d1fa36d841..9d724b5710f7 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2683,7 +2683,7 @@ static inline void wcd934x_mbhc_get_result_params(str= uct wcd934x_codec *wcd934x, else if (x1 < minCode_param[noff]) *zdet =3D WCD934X_ZDET_FLOATING_IMPEDANCE; =20 - dev_info(wcd934x->dev, "%s: d1=3D%d, c1=3D%d, x1=3D0x%x, z_val=3D%d(milli= Ohm)\n", + dev_dbg(wcd934x->dev, "%s: d1=3D%d, c1=3D%d, x1=3D0x%x, z_val=3D%di (mill= iohm)\n", __func__, d1, c1, x1, *zdet); ramp_down: i =3D 0; --=20 2.39.3 From nobody Sat Feb 7 15:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D57EB64D7 for ; Fri, 30 Jun 2023 14:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232518AbjF3O1k (ORCPT ); Fri, 30 Jun 2023 10:27:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231245AbjF3O1V (ORCPT ); Fri, 30 Jun 2023 10:27:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F37593AAE for ; Fri, 30 Jun 2023 07:27:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60EC961764 for ; Fri, 30 Jun 2023 14:27:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB87AC433C9; Fri, 30 Jun 2023 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688135238; bh=lrVbd0JoMGVuCAGlTtBwHS0krlYpo5gW52m7Wo7fi6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eYqZFelz3wt7y/0/q3o7bAsYRDLYrKrsMemIk08HP9xdO/MwqGzw09bWbTrSyYu8c KNNrYRnbad1Z5fuRBL2+xKFmpTirqeRQeexighNf8Whe3vS0ogxc1O86yFCD1VWbbB Ft5KD1t8MCf3RnPvebkrKv3PXpfcc5ntWi158pa6b6T1CfuFviR4KsRLEWbCWPpwgg 8whZvA/RiPAuV1j9Vo+85OxGwWa1QrLo4K86BSDV1ZmFXEoQOYuzuoHH8vr46aA2aO Zt91COgZM3Fovf1l0SK8cZzoX/YsQQ6KQnEN2v230F4nPMlXMds6q3A0tdRc4Tkz9i Hwvsy/8BSTC5Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qFF5p-0001OY-Iu; Fri, 30 Jun 2023 16:27:25 +0200 From: Johan Hovold To: Mark Brown , Srinivas Kandagatla Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 5/5] ASoC: codecs: wcd934x: drop inline keywords Date: Fri, 30 Jun 2023 16:27:17 +0200 Message-Id: <20230630142717.5314-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230630142717.5314-1-johan+linaro@kernel.org> References: <20230630142717.5314-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The compiler is generally better at deciding what functions should be inlined than driver authors are. Drop the bogus inline keyword from two functions that were neither very small or used in a single place. Signed-off-by: Johan Hovold Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd934x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 9d724b5710f7..a17cd75b969b 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2642,7 +2642,7 @@ static int wcd934x_mbhc_micb_ctrl_threshold_mic(struc= t snd_soc_component *compon return rc; } =20 -static inline void wcd934x_mbhc_get_result_params(struct wcd934x_codec *wc= d934x, +static void wcd934x_mbhc_get_result_params(struct wcd934x_codec *wcd934x, s16 *d1_a, u16 noff, int32_t *zdet) { @@ -2740,8 +2740,8 @@ static void wcd934x_mbhc_zdet_ramp(struct snd_soc_com= ponent *component, *zr =3D zdet; } =20 -static inline void wcd934x_wcd_mbhc_qfuse_cal(struct snd_soc_component *co= mponent, - int32_t *z_val, int flag_l_r) +static void wcd934x_wcd_mbhc_qfuse_cal(struct snd_soc_component *component, + int32_t *z_val, int flag_l_r) { s16 q1; int q1_cal; --=20 2.39.3