From nobody Fri Sep 20 16:40:25 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040C9EB64DD for ; Thu, 29 Jun 2023 08:07:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbjF2IHf (ORCPT ); Thu, 29 Jun 2023 04:07:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232012AbjF2IHL (ORCPT ); Thu, 29 Jun 2023 04:07:11 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51904EC5 for ; Thu, 29 Jun 2023 00:59:21 -0700 (PDT) X-UUID: d7cc6962165211eeb20a276fd37b9834-20230629 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=DiiWsMcy5MZboP5al/aFt6kLyJc9jecmPV9qc6pE8+w=; b=YY7zdvpdoecyLAxPnBHUZLd5Rihhga+1Mv6mY6h2h8SJXx3ObJgwUMZJ9aqM0jczOhe3U93UkLwqC7m/OBo6RLAEI14iJ+iv0x3YUqcgjM8Uc/MRp2HoF2jTr/lNsRwwexdchIbEjBWkmUKX7uo7P8lC+/XJdHbgzbzpV+yu6W0=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:5c1cbac4-5a1f-4724-bae3-51f1bfb37881,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:01c9525,CLOUDID:0ec75e0d-26a8-467f-b838-f99719a9c083,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: d7cc6962165211eeb20a276fd37b9834-20230629 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 532892412; Thu, 29 Jun 2023 15:59:15 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 29 Jun 2023 15:59:15 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 29 Jun 2023 15:59:15 +0800 From: Trevor Wu To: , , , , , CC: , , , , Subject: [PATCH] ASoC: mediatek: mt8188: add constraints for PCM Date: Thu, 29 Jun 2023 15:59:10 +0800 Message-ID: <20230629075910.21982-1-trevor.wu@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For certain projects, only a limited number of parameters are necessary. Therefore, it may be beneficial to add constraints that restrict the capacity of the PCM. Signed-off-by: Trevor Wu --- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 145 +++++++++++++++++++++- 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c b/sound/soc/mediatek= /mt8188/mt8188-mt6359.c index ac69c23e0da1..0e4e1b8c99e2 100644 --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c @@ -30,6 +30,7 @@ #define TEST_MISO_DONE_2 BIT(29) =20 #define NAU8825_HS_PRESENT BIT(0) +#define DPCM_FE_CONSTRAINT BIT(16) =20 /* * Maxim MAX98390 @@ -452,6 +453,143 @@ enum { DAI_LINK_UL_SRC_BE, }; =20 +static int mt8188_playback_startup(struct snd_pcm_substream *substream) +{ + static const unsigned int rates[] =3D { + 48000 + }; + static const unsigned int channels[] =3D { + 2 + }; + static const struct snd_pcm_hw_constraint_list constraints_rates =3D { + .count =3D ARRAY_SIZE(rates), + .list =3D rates, + .mask =3D 0, + }; + static const struct snd_pcm_hw_constraint_list constraints_channels =3D { + .count =3D ARRAY_SIZE(channels), + .list =3D channels, + .mask =3D 0, + }; + + struct snd_soc_pcm_runtime *rtd =3D asoc_substream_to_rtd(substream); + struct snd_pcm_runtime *runtime =3D substream->runtime; + struct mt8188_mt6359_priv *priv =3D snd_soc_card_get_drvdata(rtd->card); + struct mt8188_card_data *data =3D (struct mt8188_card_data *)priv->privat= e_data; + int ret; + + if (!(data->quirk & DPCM_FE_CONSTRAINT)) + return 0; + + ret =3D snd_pcm_hw_constraint_list(runtime, 0, + SNDRV_PCM_HW_PARAM_RATE, + &constraints_rates); + if (ret < 0) { + dev_err(rtd->dev, "hw_constraint_list rate failed\n"); + return ret; + } + + ret =3D snd_pcm_hw_constraint_list(runtime, 0, + SNDRV_PCM_HW_PARAM_CHANNELS, + &constraints_channels); + if (ret < 0) { + dev_err(rtd->dev, "hw_constraint_list channel failed\n"); + return ret; + } + + return 0; +} + +static const struct snd_soc_ops mt8188_playback_ops =3D { + .startup =3D mt8188_playback_startup, +}; + +static int mt8188_capture_startup(struct snd_pcm_substream *substream) +{ + static const unsigned int rates[] =3D { + 48000 + }; + static const struct snd_pcm_hw_constraint_list constraints_rates =3D { + .count =3D ARRAY_SIZE(rates), + .list =3D rates, + .mask =3D 0, + }; + + struct snd_soc_pcm_runtime *rtd =3D asoc_substream_to_rtd(substream); + struct snd_pcm_runtime *runtime =3D substream->runtime; + struct mt8188_mt6359_priv *priv =3D snd_soc_card_get_drvdata(rtd->card); + struct mt8188_card_data *data =3D (struct mt8188_card_data *)priv->privat= e_data; + int ret; + + if (!(data->quirk & DPCM_FE_CONSTRAINT)) + return 0; + + ret =3D snd_pcm_hw_constraint_list(runtime, 0, + SNDRV_PCM_HW_PARAM_RATE, + &constraints_rates); + if (ret < 0) { + dev_err(rtd->dev, "hw_constraint_list rate failed\n"); + return ret; + } + + return 0; +} + +static const struct snd_soc_ops mt8188_capture_ops =3D { + .startup =3D mt8188_capture_startup, +}; + +static int mt8188_hdmi_dptx_startup(struct snd_pcm_substream *substream) +{ + static const unsigned int rates[] =3D { + 48000 + }; + static const unsigned int channels[] =3D { + 2, 4, 6, 8 + }; + static const struct snd_pcm_hw_constraint_list constraints_rates =3D { + .count =3D ARRAY_SIZE(rates), + .list =3D rates, + .mask =3D 0, + }; + static const struct snd_pcm_hw_constraint_list constraints_channels =3D { + .count =3D ARRAY_SIZE(channels), + .list =3D channels, + .mask =3D 0, + }; + + struct snd_soc_pcm_runtime *rtd =3D asoc_substream_to_rtd(substream); + struct snd_pcm_runtime *runtime =3D substream->runtime; + struct mt8188_mt6359_priv *priv =3D snd_soc_card_get_drvdata(rtd->card); + struct mt8188_card_data *data =3D (struct mt8188_card_data *)priv->privat= e_data; + int ret; + + if (!(data->quirk & DPCM_FE_CONSTRAINT)) + return 0; + + ret =3D snd_pcm_hw_constraint_list(runtime, 0, + SNDRV_PCM_HW_PARAM_RATE, + &constraints_rates); + if (ret < 0) { + dev_err(rtd->dev, "hw_constraint_list rate failed\n"); + return ret; + } + + ret =3D snd_pcm_hw_constraint_list(runtime, 0, + SNDRV_PCM_HW_PARAM_CHANNELS, + &constraints_channels); + if (ret < 0) { + dev_err(rtd->dev, "hw_constraint_list channel failed\n"); + return ret; + } + + return 0; +} + +static const struct snd_soc_ops mt8188_hdmi_dptx_playback_ops =3D { + .startup =3D mt8188_hdmi_dptx_startup, +}; + static int mt8188_dptx_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { @@ -723,6 +861,7 @@ static struct snd_soc_dai_link mt8188_mt6359_dai_links[= ] =3D { }, .dynamic =3D 1, .dpcm_playback =3D 1, + .ops =3D &mt8188_playback_ops, SND_SOC_DAILINK_REG(playback2), }, [DAI_LINK_DL3_FE] =3D { @@ -734,6 +873,7 @@ static struct snd_soc_dai_link mt8188_mt6359_dai_links[= ] =3D { }, .dynamic =3D 1, .dpcm_playback =3D 1, + .ops =3D &mt8188_playback_ops, SND_SOC_DAILINK_REG(playback3), }, [DAI_LINK_DL6_FE] =3D { @@ -778,6 +918,7 @@ static struct snd_soc_dai_link mt8188_mt6359_dai_links[= ] =3D { }, .dynamic =3D 1, .dpcm_playback =3D 1, + .ops =3D &mt8188_hdmi_dptx_playback_ops, SND_SOC_DAILINK_REG(playback10), }, [DAI_LINK_DL11_FE] =3D { @@ -833,6 +974,7 @@ static struct snd_soc_dai_link mt8188_mt6359_dai_links[= ] =3D { }, .dynamic =3D 1, .dpcm_capture =3D 1, + .ops =3D &mt8188_capture_ops, SND_SOC_DAILINK_REG(capture4), }, [DAI_LINK_UL5_FE] =3D { @@ -844,6 +986,7 @@ static struct snd_soc_dai_link mt8188_mt6359_dai_links[= ] =3D { }, .dynamic =3D 1, .dpcm_capture =3D 1, + .ops =3D &mt8188_capture_ops, SND_SOC_DAILINK_REG(capture5), }, [DAI_LINK_UL6_FE] =3D { @@ -1122,7 +1265,7 @@ static struct mt8188_card_data mt8188_evb_card =3D { =20 static struct mt8188_card_data mt8188_nau8825_card =3D { .name =3D "mt8188_nau8825", - .quirk =3D NAU8825_HS_PRESENT, + .quirk =3D NAU8825_HS_PRESENT | DPCM_FE_CONSTRAINT, }; =20 static const struct of_device_id mt8188_mt6359_dt_match[] =3D { --=20 2.18.0