From nobody Sat Feb 7 22:01:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32D0EB64DA for ; Thu, 29 Jun 2023 01:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231718AbjF2BmJ (ORCPT ); Wed, 28 Jun 2023 21:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbjF2BmA (ORCPT ); Wed, 28 Jun 2023 21:42:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 355CD2D56 for ; Wed, 28 Jun 2023 18:41:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 772E3614B3 for ; Thu, 29 Jun 2023 01:41:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C131CC433C8; Thu, 29 Jun 2023 01:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688002898; bh=L7S8mzMQYGKIhxRcHxSQJwBqPxvW57dJoZChkWhi8UQ=; h=From:To:Cc:Subject:Date:From; b=h30G/Ady3rTuj4pHc4oWRB3blePjJz5XFd/9KEEWRzUxfvNqyc9o1X8gYVmzQ35zY BXqPAVyMc1TT5LcjStHIFg42667UMOGHH4zP/90dwcpi3gYTKxdecpNdM8uVAQi90+ c0TEYq7vvUG88wqKf0unzA53ngGoVo6PtSw9iyNnln9emfTnZuXyhCnDWkK1bLLAkF O3H8upLiPGXvBgPtB8YK1+4MqvhzXG9Q56C/7rPDkYCbx9pNHfuMQSw/tI9chDB62h Oni7IlLkEPtbFaQhAn0vCri36+h72jw3QBkHHRNd1X4QLZBQDoBkq/EDhqk0QInEJN yppxRiS9wJroQ== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH] f2fs: fix compile warning in f2fs_destroy_node_manager() Date: Thu, 29 Jun 2023 09:41:34 +0800 Message-Id: <20230629014134.3058318-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fs/f2fs/node.c: In function =E2=80=98f2fs_destroy_node_manager=E2=80=99: fs/f2fs/node.c:3390:1: warning: the frame size of 1048 bytes is larger than= 1024 bytes [-Wframe-larger-than=3D] 3390 | } Merging below pointer arrays into common one, and reuse it by cast type. struct nat_entry *natvec[NATVEC_SIZE]; struct nat_entry_set *setvec[SETVEC_SIZE]; Signed-off-by: Chao Yu --- fs/f2fs/node.c | 14 ++++++++------ fs/f2fs/node.h | 3 +-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index dadea6b01888..3e1fa564db8f 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -3062,7 +3062,7 @@ int f2fs_flush_nat_entries(struct f2fs_sb_info *sbi, = struct cp_control *cpc) struct f2fs_nm_info *nm_i =3D NM_I(sbi); struct curseg_info *curseg =3D CURSEG_I(sbi, CURSEG_HOT_DATA); struct f2fs_journal *journal =3D curseg->journal; - struct nat_entry_set *setvec[SETVEC_SIZE]; + struct nat_entry_set *setvec[NAT_VEC_SIZE]; struct nat_entry_set *set, *tmp; unsigned int found; nid_t set_idx =3D 0; @@ -3095,7 +3095,7 @@ int f2fs_flush_nat_entries(struct f2fs_sb_info *sbi, = struct cp_control *cpc) remove_nats_in_journal(sbi); =20 while ((found =3D __gang_lookup_nat_set(nm_i, - set_idx, SETVEC_SIZE, setvec))) { + set_idx, NAT_VEC_SIZE, setvec))) { unsigned idx; =20 set_idx =3D setvec[found - 1]->set + 1; @@ -3316,8 +3316,9 @@ void f2fs_destroy_node_manager(struct f2fs_sb_info *s= bi) { struct f2fs_nm_info *nm_i =3D NM_I(sbi); struct free_nid *i, *next_i; - struct nat_entry *natvec[NATVEC_SIZE]; - struct nat_entry_set *setvec[SETVEC_SIZE]; + void *vec[NAT_VEC_SIZE]; + struct nat_entry **natvec =3D (struct nat_entry **)vec; + struct nat_entry_set **setvec =3D (struct nat_entry_set **)vec; nid_t nid =3D 0; unsigned int found; =20 @@ -3340,7 +3341,7 @@ void f2fs_destroy_node_manager(struct f2fs_sb_info *s= bi) /* destroy nat cache */ f2fs_down_write(&nm_i->nat_tree_lock); while ((found =3D __gang_lookup_nat_cache(nm_i, - nid, NATVEC_SIZE, natvec))) { + nid, NAT_VEC_SIZE, natvec))) { unsigned idx; =20 nid =3D nat_get_nid(natvec[found - 1]) + 1; @@ -3356,8 +3357,9 @@ void f2fs_destroy_node_manager(struct f2fs_sb_info *s= bi) =20 /* destroy nat set cache */ nid =3D 0; + memset(vec, 0, sizeof(void *) * NAT_VEC_SIZE); while ((found =3D __gang_lookup_nat_set(nm_i, - nid, SETVEC_SIZE, setvec))) { + nid, NAT_VEC_SIZE, setvec))) { unsigned idx; =20 nid =3D setvec[found - 1]->set + 1; diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h index 906fb67a99da..5bd16a95eef8 100644 --- a/fs/f2fs/node.h +++ b/fs/f2fs/node.h @@ -35,8 +35,7 @@ #define DEF_RF_NODE_BLOCKS 0 =20 /* vector size for gang look-up from nat cache that consists of radix tree= */ -#define NATVEC_SIZE 64 -#define SETVEC_SIZE 32 +#define NAT_VEC_SIZE 32 =20 /* return value for read_node_page */ #define LOCKED_PAGE 1 --=20 2.40.1